WordPress Coding Standard 2.0 removed the sniff
WordPress.Security.NonceVerification.NoNonceVerification:
```
The WordPress.Security.NonceVerification sniff used the same error code for both an error as well as a warning.
The old error code NoNonceVerification is no longer used.
The error now uses the Missing error code, while the warning now uses the Recommended error code.
```
(from
d45f5e5cf3/CHANGELOG.md (200-rc1---2018-12-31))
This commit updates WooCommerce code and replaces all instances where WordPress.Security.NonceVerification.NoNonceVerification verification was used with either WordPress.Security.NonceVerification.Missing or
WordPress.Security.NonceVerification.Recommended. In a few cases WordPress.Security.NonceVerification.NoNonceVerification was used but was not needed, so instead of replacing the sniff, the line was removed. In two other cases, I removed other unrelated sniffs that were not needed.
The nonce generated on the previous page was not being verified properly due to mismatched brackets (the second argument to wp_verify_nonce was not being passed).
* Check if current step matches event before firing
* Move step check to switch statement
* Track when the OBW has started
* Rename Jetpack activation tracking method
* Remove duplicate tracking optin check
* Track when option to track is udpated in OBW
* Check if tracking is actively being opted into in is_tracking_enabled()
* Move tracking start check into WC_Admin_Setup_Wizard_Tracking
* Clean up tracking opt-in check logic
* Setup wizard: avoid duplicate plugin installs.
* Setup wizard: use background flag to determine if Jetpack is being installed.
* Setup wizard: use wc_set_time_limit() instead of set_time_limit() to avoid potential warnings/errors.
* Wizard: Remove extra query arg in next step URL
Remove the activate_error query arg from
the URL for the next step.
* Wizard: Remove temp queued Jetpack install option
This is done so that the option does not remain
when going through the wizard again, or when going
back to previous pages.
It prevents an infinite loop from happening when
waiting for the Jetpack install and activation
to finish on the activate step.
* Wizard: Install and activate Jetpack if needed
Add function to install & activate Jetpack as needed.
Props to @jeffstieler for the idea, and the implementation/code:
https://github.com/Automattic/woocommerce-services/pull/1031#discussion_r122505316https://github.com/Automattic/jetpack/blob/master/3rd-party/woocommerce-services.php#L101
Add a list of errors and a function to get the correct error message.
After clicking the connect Jetpack button, make sure that
Jetpack is installed and activated.
On error, redirect to the activate page with a query arg.
* Wizard: Show Jetpack error message if it exists
Always check for an error message when displaying
the activate step. If the error
message exists, display it at the top of the page.
* Remove redundant "if" so the $title in the Activate step is always a valid string
* Tweaked the "Server is on a private network" Jetpack activation error message.
We need to know that Jetpack is active before moving to the next step. The previously logic fired off a synchronous installation that caused a race condition.
Old translation string:
* `If you like <strong>WooCommerce</strong> please leave us a %s rating. A huge thanks in advance!`
New translation string:
* `If you like %1$s please leave us a %2$s rating. A huge thanks in advance!`
* Helper: Improve messaging and CTAs
* Helper: Update copy on connect flow
* Helper: Improve messaging around plugins without a subscription
* removes toggle from extensions that cannot be activated
* Helper: Add new `WC_Helper_Compat` class for legacy helper compat
This new class removes some of the actions from the legacy helper
(updater) plugin, attempts to migrate an existing legacy connection
to a new one, attempts to deactivate the old helper plugin.
* Helper: Improve messaging around maxed out subscriptions
* Helper: Enable `WC_Tracker` when connected to WooCommerce.com
* Helper: adds styles for manual licence form row and other visual improvements
* Helper: removes disabled toggles
* Helper: adds styles for connection component
* Helper: redesigned connection module
* Helper: rotates the connection module chevron on mouse hover
* Helper: adds some fixes to the key form on mobile and other updates to meet coding standards
* Helper: Only mark action as primary if there's a CTA button.
* Helper: Better handling for woothemes_updater_notice
Remove the updater notice built into extensions and themes, even
if the legacy Helper plugin is deactivated.
* Helper: Navigate existing Helper users to the new place.
Adds a Dashboard menu item and direct users of the old helper
plugin to the new Extensions screen.
* Helper: Do not show the back-compat menu item for new users
* Helper: Avoid notice in API authentication if credentials are missing
* Helper: Hide the back-compat menu item when users see the new screen
Also sets the user_id for the connection if one was not previously set.
Claudio Sanches
xristos3490
Peter Fabian
Rodrigo Primo
Ron Rennick
Leon Aves
Kelly Dwan
Mike Jolley
Paul Sealock
Jeff Stieler
Joshua T Flowers
Konstantin Kovshenin
haszari
Kanishk
JeroenSormani
Chris Marslender
Valerie K
Shiva Poudel
Rami Yushuvaev
claudiulodro
Jaydeep Rami