b4507d3b92
Fix circular dependencies ( https://github.com/woocommerce/woocommerce-blocks/pull/3704 )
...
* fix circular dependency in text-input
* fix circular dependency in chip component
* fix circular dependencies in AddressForm component
* fix circular dependencies in product-list
* fix circular dependencies in hooks
* fix circular dependencies in context
* Fix circular dependencies in components/cart-checkout
* fix use-checkout-submit test
- can’t mock the hook alias anymore
- account for undefined object returned from `usePaymentMethods`
2021-01-19 10:55:44 -05:00
9115160c2f
Enable and fix all jsdoc rule violations ( https://github.com/woocommerce/woocommerce-blocks/pull/3168 )
...
* add param jsdocs to satisfy jsdoc require-param rule
* Fix jsdoc-checktypes rule violations
* fix jsdoc/require-param-type rule violations
* fix jsdoc/check-param-names violations
* fix jsdoc/require-property-description rule violations
* fix rule violations for jsdoc/valid-types rule
* fix rule violations for jsdoc/require-property rule
* fix jsdoc/no-undefined-types rule violations
* fix jsdoc/check-types rule violations
* fix jsdoc/require-returns-description rule violation
* enable jsdoc/require-returns-type rule
* fix jsdoc/newline-after-description rule violations
2020-09-20 19:54:08 -04:00
0f43c3af0f
Remove classes from dashicons ( https://github.com/woocommerce/woocommerce-blocks/pull/2848 )
2020-07-10 14:20:57 -04:00
8c06276b00
Unify Chip styles ( https://github.com/woocommerce/woocommerce-blocks/pull/2765 )
...
* Improve cross character used in dropdown selector
* Add is-open and has-checked classes to dropdown selector so we stop relying on complex pseudoselector combinations
* Update Chip component with new props
* Update Chip styles
* Update dropdown selector selected chip with the Chip component
* Update active filters chip with the Chip component
* Style fixes
* Update snapshots and add tests
* Change onRemove prop signature
* Fix wrong bottom margin
* Fix misaligned remove icon
* Update assets/js/base/components/chip/index.js
Co-authored-by: Darren Ethier <darren@roughsmootheng.in>
* Update assets/js/base/components/chip/index.js
Co-authored-by: Darren Ethier <darren@roughsmootheng.in>
* Add missing default prop
* Prettier
* Ensure showScreenReaderText is a bool
* Rename removeOnClick with removeOnAnyClick
* Update snapshots
* Fix Chip aria-label logic
* Split Chip and RemovableChip
* Replace chip close character with an icon
* Fix outdated comment
Co-authored-by: Darren Ethier <darren@roughsmootheng.in>
2020-07-10 11:09:49 +02:00
Darren Ethier
Albert Juhé Lluveras