Commit Graph

1615 Commits

Author SHA1 Message Date
Mike Jolley faa09deff1 Recalc taxes if address changes in API 2018-05-18 21:47:04 +01:00
Claudiu Lodromanean ccededa35c
Merge pull request #19971 from woocommerce/fix/19964
Fix: WC API should not try to create a product image if an empty image is passed
2018-05-07 10:48:10 -07:00
Rodrigo Primo c7a9550691 Fix: WC API should not try to create a product image if empty image is passed
Currently if you try to create a product variation passing an empty array as the value of the image key using WC API:

Endpoint: `wp-json/wc/v2/products/PRODUCT_ID/variations`
Payload: `{ "attributes" : [ { "id" : 1, "name" : "color", "option" : "Green" } ], "dscription" : "Green Tea Variety", "image" : {} }`

WC will return the following error:

```
{ "code": "woocommerce_product_invalid_image_id", "data": { "status": 400 }, "message": "#0 is an invalid image ID." }
```

This is happening because the code that handles image creation
(4e42b2cd30/includes/api/class-wc-rest-product-variations-controller.php (L292)) is not checking if `$request['image']` is empty before adding a new `position` key to it. To fix this problem, this commit simply adds a check to see if `$request['image']` is empty before proceeding.

Fixes #19964
2018-05-04 10:47:39 -03:00
Gerhard Potgieter 96d84b2813 Revert "Update the actual message and not just the test :)"
This reverts commit 9607fbcdd8.
2018-05-04 11:57:26 +02:00
Gerhard Potgieter 9607fbcdd8 Update the actual message and not just the test :) 2018-05-04 09:24:05 +02:00
Gerhard Potgieter e6e03858a0 Add call to tracking API when opting out to comply with GDPR erasure. 2018-05-04 09:10:18 +02:00
Mike Jolley d584ed72b9
Merge pull request #19930 from woocommerce/update/19925-api-order-refund-schema
Update refunds items schema to match actual response keys.
2018-05-02 18:06:30 +01:00
Gerhard Potgieter 5a2da43733 After talking with @mikejolley we decided it would be better to stick to the original schema, reason makes more sense. 2018-05-02 12:12:06 +02:00
Gerhard Potgieter 4a39d8b8cc Update refunds items schema to match actual response keys. 2018-05-02 10:13:51 +02:00
claudiulodro 4da458a9df Tool for cleaning up permissions table 2018-05-01 12:35:37 -07:00
Mike Jolley 17ad9dac06 Update docs 2018-05-01 10:15:51 +01:00
Mike Jolley eeaebc92a0
Merge pull request #19788 from rnaby/class-wc-rest-customers-controller-update_customer_meta_fields-doc-spelling-fix
Spelling fix
2018-04-20 11:40:22 +01:00
Khan M Rashedun-Naby b6cfc6f291 Removed unnecessary else condition. 2018-04-20 01:06:25 +06:00
Khan M Rashedun-Naby 1b7e14a4b6 Spelling fix 2018-04-19 21:10:36 +06:00
Khan M Rashedun-Naby 9aed8394cb Removed unnecessary else condition check. I think in this situation after early returning the else is redundant. 2018-04-19 11:04:44 +06:00
Claudio Sanches 81a699114c
Merge pull request #19667 from woocommerce/fix/19655
Load gateways before order is saved/email is triggered
2018-04-10 14:27:47 -03:00
Mike Jolley 903e3e8acd Fix featured filter 2018-04-10 14:58:06 +01:00
Mike Jolley f9cc65b586 Load gateways before order is saved/email is triggered
Fixes #19655
2018-04-10 12:15:14 +01:00
Mike Jolley 4e42b2cd30 Handle manage_stock mixed content for variations 2018-04-03 17:46:43 +01:00
Mike Jolley f98eb66f8c Webhooks do not need permission checks 2018-03-23 12:45:10 +00:00
Claudio Sanches b0617a13c4 Removed unnecessary ternary operators 2018-03-21 20:05:19 -03:00
Claudio Sanches 0660a50e07 Removed obvious boolean results 2018-03-21 19:57:10 -03:00
Mike Jolley 6539b7913e Merge branch 'master' 2018-03-19 18:05:36 +00:00
Claudio Sanches f0d37ff4f5 Fixed PHPCS violations on REST API 2018-03-06 15:04:58 -03:00
Claudio Sanches e8017e985b Fixed coding standards issues with PHPCBF 2018-03-05 17:53:06 -03:00
Mike Jolley f162fdb9d1 Merge branch 'master' into update/17795 2018-03-01 12:13:14 +00:00
Mike Jolley cceec55714 Fix error in unit tests due to missing object check 2018-02-27 16:32:59 +00:00
Claudio Sanches 69044423d2 [REST API] Do not allow updating parent ID from variations after created
Closes #18933
2018-02-22 16:22:42 -03:00
Claudio Sanches b64b2a8680 Fixed coding standards 2018-02-22 16:00:21 -03:00
Claudio Sanches f60cd7cca4 [REST API] Fixed products shipping_class_id type 2018-02-20 17:16:26 -03:00
Mike Jolley 5feed3e0cc Merge branch 'master' into update/add-ext-object-cache-to-system-status 2018-02-19 14:39:31 +00:00
Mike Jolley 68238938e4 Adds back get_item so you can get a single Webhook
Closes #19015
2018-02-19 11:56:57 +00:00
Mike Jolley d841cf3f27 Conditionally add messages in customiser 2018-02-14 17:25:52 +00:00
Mike Jolley 7ae0f6c274 Hide status button when disabled via filter 2018-02-14 17:00:43 +00:00
Mike Jolley 66e65cf7bf Disable image regen if photon is being used. 2018-02-14 11:38:18 +00:00
Gerhard Potgieter 1961076bf7 Update tools message for image reneneration. 2018-02-14 10:38:59 +02:00
Mike Jolley 52853e9c23 typo 2018-02-13 13:59:54 +00:00
Mike Jolley e39b6950a8 Notice when regeneration is happening 2018-02-13 12:02:24 +00:00
Mike Jolley 3c7262112e Merge branch 'fix/18842-external-images-fix' into update/3.3-image-handling 2018-02-13 11:18:43 +00:00
Gerhard Potgieter 794272a732 Do not auto generate images on setting changes or theme switches. Introduce a regenerate button under tools. Only resize images on the fly when using the customizer to preview changes. 2018-02-13 09:55:50 +02:00
Mike Jolley bdd4898946 Set status after order is created/updated. 2018-02-12 11:56:48 +00:00
Claudio Sanches 9c39dd34cc Merge branch 'feature/network-order-widget' of https://github.com/cmmarslender/woocommerce into cmmarslender-feature/network-order-widget 2018-02-02 14:46:51 -02:00
Claudio Sanches 0755038e8d
Merge pull request #18505 from liquidweb/feature/post-system-status-tool-hook
Add a hook after executing a REST system status tool
2018-02-02 14:19:03 -02:00
Mike Jolley a370a4c12a
Merge pull request #18693 from woocommerce/fix/18692
Webhooks API error checking
2018-01-31 14:53:49 +00:00
Rodrigo Primo 211ec9b896 phpcs fixes 2018-01-31 11:22:33 -02:00
Mike Jolley b230d6be4c Error checking 2018-01-31 10:40:06 +00:00
Gerhard Potgieter a0b89fdda3 PHPCS fixes 2018-01-31 08:07:27 +02:00
Gerhard Potgieter 6a7f00ce89 Fix grammer 2018-01-31 08:06:51 +02:00
Claudio Sanches e6597cd351 Fixed coding standards 2018-01-30 15:05:25 -02:00
Claudio Sanches 05a80e2d4f [REST API] Fixed typos on products schema 2018-01-30 15:03:01 -02:00