Commit Graph

31080 Commits

Author SHA1 Message Date
Renovate Bot d65355a115
Update dependency grunt-contrib-uglify to v4.0.1 2019-03-21 18:57:42 +00:00
Rodrigo Primo 6001b0177e Only install Chrome and Nginx in the build job that uses it
This commit changes Travis configuration to only install Chrome and Nginx in the e2e tests build job, which is the only one that requires those packages. This change should save a little bit of time in the Travis build as before Travis was installing Chrome and Nginx in all the jobs.
2019-03-21 15:44:02 -03:00
Rodrigo Primo d2c294af95 Merge branch 'master' into update/prevent-fatal-errors-when-extending-rest-api 2019-03-21 15:31:29 -03:00
Rodrigo Primo 38437e8f50
Merge pull request #23104 from rodrigoprimo/fix/phpcs-in-travis
Fix PHPCS in the Travis builds
2019-03-21 15:29:22 -03:00
Rodrigo Primo 61a096d871 Fix PHPCS in the Travis builds
PR https://github.com/woocommerce/woocommerce/pull/23082 made some changes to the Travis configuration and one of those changes broke the PHPCS when running inside Travis with the following error:

```
ERROR: Referenced sniff "WooCommerce-Core" does not exist
```

For example: https://travis-ci.org/woocommerce/woocommerce/jobs/509471213#L659

This problem went unnoticed during the PR review as no PHP file was modified in it and thus there was no file for PHPCS to check.

This commit fixes the error above by installing the Composer package `woocommerce/woocommerce-sniffs` which is the package that provides `WooCommerce-Core` sniffs and which installs `wp-coding-standards/wpcs` as one of its requirements. I couldn't find an easy way to make this work installing `woocommerce/woocommerce-sniffs` globally so that is why this commit also removes the `global` parameter when calling composer.
2019-03-21 15:23:42 -03:00
Mike Jolley 8ad8a4efa5 Deprecation functions should not output errors during REST requests. 2019-03-21 16:26:33 +00:00
Mike Jolley 3ff2c2f053 If someone tries to load WC_REST class to early, throw notice and include rest api classes 2019-03-21 15:38:29 +00:00
Mike Jolley aecb0fd4fc
Merge pull request #23082 from woocommerce/update/travis-config
Refactor Travis Config
2019-03-21 14:42:37 +00:00
Mike Jolley 44291f3215
Merge pull request #23068 from woocommerce/renovate/grunt-contrib-jshint-2.x
Update dependency grunt-contrib-jshint to v2.1.0
2019-03-21 14:15:53 +00:00
Mike Jolley 2665cfae7a
Merge pull request #23073 from woocommerce/renovate/eslint-5.x
Update dependency eslint to v5.15.3
2019-03-21 13:43:20 +00:00
Mike Jolley 308d08f97e Run grunt tasks
Fixes warnings from grunt so files are minified correctly. Copied fixes that went into release branch but not master earlier this week.
2019-03-20 20:08:52 +00:00
Rodrigo Primo b283a89847 Bump stable tag 2019-03-20 10:13:00 -03:00
Rodrigo Primo 952ed0c126 3.5.7 changelog 2019-03-20 10:10:11 -03:00
Mike Jolley 7c42ac0a29 Also remove hardcoding of attributes on frontend state fields 2019-03-19 16:59:22 +00:00
Mike Jolley f2ca110a46 Add default text using .text() 2019-03-19 16:59:16 +00:00
Mike Jolley 5bb58cc14b Add props via jquery, not direct 2019-03-19 16:59:08 +00:00
Gerhard 589f561c5e Restore cache 2019-03-19 15:46:24 +02:00
Gerhard e9e64dc30a Use vendor bin folder for calling phpunit 2019-03-19 15:41:43 +02:00
Gerhard 441c79ee41 Fix syntax error in shell script 2019-03-19 15:31:49 +02:00
Gerhard 0a1eb076ea Add PHPUnit call fallback for 5.2 specifically 2019-03-19 15:23:36 +02:00
Gerhard 506b1cec55 Restore Codecoverage to PHP 7.1 2019-03-19 15:17:11 +02:00
Gerhard 608579e987 Also update the include matrix with right version info for codecoverage 2019-03-19 15:05:14 +02:00
Gerhard 323935a1e8 Remove cache as it might cause issues with Scrutinizer 2019-03-19 14:57:19 +02:00
Gerhard 0824423752 Run Codecoverage using PHP 7.3 2019-03-19 14:48:45 +02:00
Gerhard a59969ca53 Do not try to run composer on PHP 5.2 and default to phpunit command instead of specifying path, travis will first try and look for in the composer dirs. 2019-03-19 14:30:54 +02:00
Gerhard cb6b43528a Add 5.3 to PHP versions 2019-03-19 14:20:28 +02:00
Gerhard 978b94c44f Move back to precise 2019-03-19 14:09:53 +02:00
Gerhard b06caa4fbf Workaround for PHP5.2 and Composer 2019-03-19 14:01:14 +02:00
Gerhard e2d68820a5 Use xenial instead of precise 2019-03-19 13:53:23 +02:00
Gerhard d391e87fc7 Update PHPUnit location 2019-03-19 13:47:26 +02:00
Gerhard dc99c30772 Move phpunit call after first params 2019-03-19 13:33:21 +02:00
Gerhard b105550b47 Changes to travis, globally install phpunit and wpcs when required, cache vendor and composer cache directories 2019-03-19 13:14:42 +02:00
Renovate Bot ebed7f4bd0
Update dependency eslint to v5.15.3 2019-03-18 16:24:54 +00:00
Mike Jolley 97f30e7f5c Variation stock status handling 2019-03-18 12:56:49 +00:00
Renovate Bot 3ba7571817
Update dependency grunt-contrib-jshint to v2.1.0 2019-03-18 12:20:00 +00:00
Mike Jolley 986375862e
Merge pull request #23057 from freer4/patch-1
Allow extension of WC_Breadcrumb class
2019-03-18 11:38:01 +00:00
Mike Jolley 81a4b81e7c
Merge pull request #23066 from woocommerce/fix/23055
preventDefault when dismissing store notices
2019-03-18 11:12:26 +00:00
Gerhard 2b90cf845e Pass event as parameter. 2019-03-18 13:09:38 +02:00
Mike Jolley 3070961783 Merge branch 'pr/23047' 2019-03-18 11:02:33 +00:00
Mike Jolley 5d22b3a2eb data check 2019-03-18 11:02:26 +00:00
Mike Jolley 4130f737fc Merge branch 'master' of https://github.com/woocommerce/woocommerce 2019-03-18 10:59:58 +00:00
Mike Jolley 4d975a6e62 Merge branch 'pr/23054' 2019-03-18 10:59:55 +00:00
Mike Jolley cbb92ef86c combine check 2019-03-18 10:59:43 +00:00
Mike Jolley 37bc893aba
Merge pull request #23039 from woocommerce/update/plugin-rating-notice-text
Update the rating request text in the footer to be friendlier for screen reader users
2019-03-18 10:38:53 +00:00
Mike Jolley 10b266439a
Merge pull request #23050 from JeroenSormani/checkout-input-fields
Recognize all input fields with ID for checkout fields
2019-03-18 09:50:43 +00:00
Mike Jolley 88009929b7
Merge pull request #23065 from woocommerce/fix/lookup-table-notice-typo
Fix typo in lookup table notice markup
2019-03-18 09:38:36 +00:00
Gerhard 63f8359491 preventDefault when dismissing store notice, this fixes jumping of page to top when clicking store notices at the bottom of the page. 2019-03-18 10:23:25 +02:00
Gerhard a7571c71c1 Fix typo in lookup table notice markup 2019-03-18 10:11:05 +02:00
freer4 701d92233c
Allow extension of WC_Breadcrumb class
Changing the private class methods to protected allows extending the class to work with the built-in functionality. 

The desired effect - removing the "Shop" crumb - was not possible with the few filters available interspersed in this class. 

After much hair-pulling over the simple task of excluding one breadcrumb and the stubborn refusal to copy-pasta the entire class into my theme, I choose to extend the WC_Breadcrumb class to override the already-public add_crumb method. Without access to the other methods on the class, this was futile. 

There are several asks around the web for removing or updating the breadcrumbs. The accepted answer to these appears to be to "just hide it with CSS" which is a poor workaround.
2019-03-17 02:43:00 -04:00
Silicon Forks 19a7bb82a0 Fix image regeneration check when image is not cropped
Resolves #21800.
2019-03-16 12:39:40 -03:00