Commit Graph

6 Commits

Author SHA1 Message Date
Manish Menaria aa5d9debbf
Modify PR template and document that tests are required (#49331)
* Update PULL_REQUEST_TEMPLATE.md to include a checklist item for adding/updating tests

Added a new checklist item to the pull request template for contributors to confirm they have added or updated relevant tests (E2E, Unit, Integration, etc.) to ensure their fix or feature works as intended. This helps maintain the quality and reliability of the codebase by encouraging thorough testing.

* Update workflow to request reviewers to check test coverage along with testing instructions

Modified the review-testing-instructions workflow to enhance the review process by asking reviewers to not only review the testing instructions but also verify that relevant tests (E2E, Unit, Integration, etc.) have been added or updated as needed. This change ensures a more thorough review process and helps maintain high code quality.

* Update action name

* Remove changes from Template
2024-07-17 18:04:12 +05:30
Adrian Moldovan a9e7acf04f
Use @octokit/action and @actions/core versions instead of latest workflows (#47348) 2024-05-10 10:10:41 -03:00
Christopher Allford 86c102a5ed
Fixed `review-testing-instructions.yml` Workflow Permissions (#38032) 2023-04-28 00:55:10 -07:00
rodelgc dfb23eaccc Add steps to setup dependencies 2023-04-19 15:51:11 +08:00
rodelgc f1d72977c1 Add if condition 2023-04-19 15:32:52 +08:00
Alejandro López Ariza c3994e6f9d
Add workflow to remind PR reviewers to also review the testing instructions. (#36918)
* Add workflow to remind PR reviewers to also review the testing instructions.

* Update review-testing-instructions GitHub Actions workflow to also mentioning teams in the comment.

* Update review-testing-instructions GitHub Actions workflow to find if the comment it posts was already posted and - in that case - update it instead of creating a new one.

* Pin find-comment and create-or-update-comment thirdparty GitHub Actions to full length commit SHA instead of tag for better security.
2023-03-22 12:50:36 +01:00