Commit Graph

260 Commits

Author SHA1 Message Date
Roy Ho 81febc4a57
Update includes/admin/meta-boxes/class-wc-meta-box-product-data.php
Co-authored-by: jonathansadowski <jonathansadowski@users.noreply.github.com>
2021-08-09 17:53:17 +01:00
roykho 3d37ac60bf
Fix variations menu order not applying correctly when manually set closes #29630 2021-08-04 09:03:35 -07:00
Peter Fabian 685be2a791 Connect the UI to the db to allow updates of the values. 2021-03-10 17:24:52 +01:00
Ron Rennick f07585dc93 phpcs fixes, on sale dates should be displayed in local time 2020-10-20 11:35:49 -03:00
Ron Rennick 894dceee95 Fixes needed for variable product E2E test
- Jest/Puppeteer sometimes will not find an element on page load when that element is outside the initial viewport
- There were duplicate .variation_tab classes which confused Jest/Puppeteer
- Add function for opening and verifying new product page
- Update test sequence for changes in flow in markup and Jest/Puppeteer
2020-10-20 11:25:36 -03:00
Claudio Sanches 3377c60c5e
Merge pull request #27433 from woocommerce/fix/remove-relative-include-paths
Change relative include paths to absolute include paths
2020-09-17 13:15:40 -03:00
Rodrigo Primo d50cd4389b Fix using tax classes with some non-ASCII characters
This commit fixes a bug that made it impossible to assign to a product a tax class that contained non-ASCII characters that are URL encoded by sanitize_title().

WooCommerce uses sanitize_title() to generate a slug when creating a tax class (d48f1d4e2e/includes/class-wc-tax.php (L808)). sanitize_title() converts some non-ASCII to ASCII equivalents (those handled by remove_accents()) and URL encodes others (like some Greek characters, for example).

The code was using wc_clean() to sanitize the tax class when the user edited a product. The problem is that wc_clean() removes URL encoded characters, changing the slug of some tax class, causing WooCommerce to use the standard tax class instead without any errors. To fix this issue, this commit replaces wc_clean() with sanitize_title(). This should be enough for security purposes and should not cause any issues with non-ASCII characters.
2020-09-08 16:00:56 -03:00
Romario 67a178f4f7 Replace 'DIRECTORY_SEPARATOR' with '/' 2020-08-26 15:50:34 -05:00
Romario 073c63c9c4 Replace dirname with __DIR__ and add DIRECTORY_SEPARATOR
Previously 'dirname(  __FILE__ )' was used to import files, however, the directory separator was missing.

This commit replaces 'dirname(  __FILE__ )' that was introduced in 5370d02484 with __DIR__  and added DIRECTORY_SEPARATOR
2020-08-21 15:16:26 -05:00
Romario 5370d02484 Change relative include paths to absolute include paths
Relative include paths in PHP can break whenever the server is running opcache.  As such, WordPress.com deploy system refuses to include WooCommerce because of that issue.

This commit changes the relative include paths to absolute include paths.

Relates to #27269
2020-08-20 15:32:04 -05:00
Claudio Sanches d48f1d4e2e Fixed package tag usage 2020-08-05 13:36:24 -03:00
Jonathan Sadowski 4d6aad4ecb Encode HTML entities in product attributes 2020-06-11 14:10:05 -05:00
Rodrigo Primo f06ad5d78a Replace removed WordPress.Security.NonceVerification.NoNonceVerification
WordPress Coding Standard 2.0 removed the sniff
WordPress.Security.NonceVerification.NoNonceVerification:

```
The WordPress.Security.NonceVerification sniff used the same error code for both an error as well as a warning.
The old error code NoNonceVerification is no longer used.
The error now uses the Missing error code, while the warning now uses the Recommended error code.
```

(from
d45f5e5cf3/CHANGELOG.md (200-rc1---2018-12-31))

This commit updates WooCommerce code and replaces all instances where WordPress.Security.NonceVerification.NoNonceVerification verification was used with either WordPress.Security.NonceVerification.Missing or
WordPress.Security.NonceVerification.Recommended. In a few cases WordPress.Security.NonceVerification.NoNonceVerification was used but was not needed, so instead of replacing the sniff, the line was removed. In two other cases, I removed other unrelated sniffs that were not needed.
2019-12-13 17:45:32 -03:00
Rodrigo Primo 9c4de8f5e7 Fix indentation 2019-12-13 16:48:17 -03:00
Rodrigo Primo d451b68488
Merge pull request #24929 from helgatheviking/feature/woocommerce_process_variation_object
Add woocommerce_admin_process_variation_object before $variation->save()
2019-12-13 16:46:22 -03:00
Claudio Sanches 8033d5751e Changed wc_get_product_classname function name to wc_get_product_object 2019-12-04 16:15:16 -03:00
Claudio Sanches ba0773d12e Apply wc_get_product_classname() in the current code base 2019-11-13 15:30:09 -03:00
Kathy Daring e55af6431c Add woocommerce_admin_process_variation_object before $variation->save() 2019-10-29 11:50:52 -06:00
Claudio Sanches d365497a66 Fixed coding standards 2019-03-14 19:48:47 -03:00
Mike Jolley bea53ebf4f Handle date offsets on save 2019-03-08 13:36:55 +00:00
Ron Rennick e9a98ce4ae fixes from review 2019-02-19 15:37:45 -04:00
Ron Rennick 4c7f61e123 phpcs except for ignore use of $_POST 2019-02-19 13:41:14 -04:00
Ron Rennick a2abe8783e check low_stock for empty string vs isset 2019-02-19 11:08:14 -04:00
Peter Fabian c1d82478a6 Added check for POST variable existance. 2019-02-07 13:39:47 +01:00
Mike Jolley a0aa663f29 Attribute post data needs stripslashes 2019-01-08 13:25:27 +00:00
David Marín bc86676b7e
Update class-wc-meta-box-product-data.php 2018-08-16 09:28:48 +02:00
David Marín 6b3ef46f4e
Complete filter call 2018-08-16 09:28:03 +02:00
David Marín 97eddce025
Admin: New filter to customize variations count
Adding new filter to customize variations count, so internal-use variations can be hidden by plugins.
2018-08-16 08:37:25 +02:00
Peter Fabian 1c2f51ee86 Unslashed the SKU for variation. 2018-08-09 12:13:23 +02:00
Joey Gilham 58cdd7dad2
Merge branch 'master' into master 2018-07-03 15:41:15 +01:00
Joey cd8416122f removed low stock options for variations, and addressed changes 2018-06-19 12:40:27 +01:00
Mike Jolley 01a3e359c3 Merge branch 'master' into feature/product-custom-tables-supporting-changes 2018-06-13 10:18:38 +01:00
Joey 98e44092e7 updating suggested changes 2018-06-07 14:37:06 +01:00
Joey b08b55a651 added changes for low stock notifications per product 2018-05-27 05:40:58 +01:00
Mike Jolley 81b65f1783 add missing wp_unslash calls to product data meta box 2018-05-25 12:15:59 +01:00
Rodrigo Primo bb553c88ae Merge branch 'master' into feature/product-custom-tables-supporting-changes 2018-03-29 12:05:55 -03:00
Rodrigo Primo 23b69eba53 Use phpcbf to fix coding standard violations in includes/admin
After using phpcbf to fix the coding standard violations, I did some manual adjustments to the changes, especially in poorly indented files.
2018-03-05 16:21:35 -03:00
Mike Jolley 672a31e7c6 Merge branch 'master' into feature/product-custom-tables-supporting-changes 2018-01-16 10:40:19 +00:00
Mike Jolley e1a82a4127 Add nonce to both panels. Closes #18333 2018-01-03 10:37:07 +00:00
Mike Jolley 698db6c131 When custom attributes are created, they are decoded. Make the values match.
When we create/link variations, the entities are decoded.

When the variation form is posted, the entities are encoded (esc_attr).
This decodes them so they match correctly. Fixes #17820
2017-11-20 20:51:32 +00:00
Mike Jolley 28d69c08e4 Filter attributes 2017-11-17 15:43:02 +00:00
Josh Smith 644ac674d7 [#12517] Replace download_id on customer download and product download with static UUID instead of filename based hash, to preserve download links, logs, and permissions across filename changes 2017-08-05 04:42:31 +00:00
Mike Jolley 916294b7d0 Use comment_status input name
Closes #16153
2017-07-19 15:18:33 +01:00
Mike Jolley beba2757ee feedback 2017-07-05 17:11:34 +01:00
Mike Jolley 1265633286 If stock changes between page load and editing, reject stock changes
Fixes #15818
2017-06-27 21:22:46 +01:00
Dixita Dusara fe4a4a7e83 Update issue Undefined index warning when saving variations with stock management disabled #15242 (#15271)
* Issue Undefined index warning when saving variations with stock management disabled #15242

* updated issue as per your suggestion for index warning when saving variations with stock management disabled #15242
2017-05-25 10:58:32 +01:00
Mike Jolley d3666738d8 Merge branch 'pr/15069' 2017-05-23 18:56:58 +01:00
Mike Jolley 89ece25a32 Fix stock/backorder notice when stock management is disabled
Fixes #15145
2017-05-18 15:28:38 +01:00
Rasmus Bengtsson 185934fad9 Fix phpdoc to include params and correct types 2017-05-15 13:50:52 +02:00
Mike Jolley 7c63c21eaf $post global is not required in meta box callback
Fixes #15047
2017-05-15 12:29:11 +01:00