56ffa3d2aa
Merge pull request #14706 from crodas/make_get_item_consistent
...
Make get item consistent
2017-05-31 11:10:09 +01:00
bf095190c4
Improved data unit tests
2017-05-29 12:51:12 -04:00
71e462469a
Problem in WC_Abstract_Order->get_items()
...
This only effects new items, which are given duplicate array keys, eg: `new:0`, `new:1` etc.
2017-05-04 19:12:19 +09:00
b5f182e14d
Problem in WC_Abstract_Order->get_items()
...
This test will fail.
If the order is created with different item types, eg: *line_item* and *fee*, they will both be given the key `new:0`. Items with duplicate keys are not combined in the `get_items` function ([line 703](https://github.com/woocommerce/woocommerce/blob/master/includes/abstracts/abstract-wc-order.php#L703 )).
2017-05-04 18:47:43 +09:00
38f379a7d7
Make get_item() consistent (like get_items())
...
Right now get_item() is loading an item from the database directly. It doesn't
take advantage of our cache and it doesn't check if the item is already loaded in memory.
There is also another bug (or feature?) that it will let you load any item, even if the item is not related to the current order. I believe this is a bug, if somebody really wants to load any item regardless of the order they should use `WC_Order_Factory::get_order_item`.
Another bug is that items loaded with get_item() are not related to the order object, therefore any calls to Order::save() won't persist the changes made to the item.
This commits makes sure the item returned by get_item is loaded similarly like get_items() does, taking advantage of the cache and the $items protected property (chances are the item is already in memory, ready to be used).
If a given item is not found false will be returned. If item exists but it is not related to the current object it will return false as well (If this behaviour is wanted, I can easily change it load the item anyways instead of returning false).
2017-04-26 02:54:14 -04:00
65b6ee58f7
Fix map URL unit test.
2017-04-17 12:10:38 +01:00
59c2849736
Changed version 2.7 to 3.0
2017-03-15 13:36:53 -03:00
d55653a408
Merge branch 'master' into fix-13498
...
# Conflicts:
# includes/class-wc-order.php
# tests/unit-tests/crud/data.php
2017-03-15 15:52:40 +00:00
6ec06ef0db
Update tests
2017-03-10 14:52:41 +00:00
b645fc5513
Docblocks
2017-03-08 12:02:14 -08:00
3b8eb75c93
Better handling of nested arrays in apply_changes
2017-03-08 11:51:38 -08:00
dda75c3d43
Unit tests
2017-03-08 16:52:21 +00:00
1eccb65d85
Fixed coding standards
2017-02-24 17:30:41 -03:00
252c08b943
Map legacy tax array keys to CRUD
2017-02-23 11:14:42 -08:00
b17932f4e3
Fix test due to invalid amount and caching
2017-02-09 12:04:44 +00:00
66914966fb
Adjust meta saving code throughout
...
#12885
2017-01-23 11:30:53 +00:00
4000ba6aea
Use strict `assertTrue` and `assertFalse` over `assertEquals( true|false )`
2016-12-20 23:33:35 +01:00
4ca49ba999
Fix tests
2016-11-23 16:27:18 +00:00
b20b3590c8
First pass at order items
2016-11-21 10:56:21 -08:00
5d9a9b4dec
Fix tests
2016-11-18 11:14:09 +00:00
1b2df3dd3b
Merge branch 'pr/11797'
...
# Conflicts:
# includes/admin/meta-boxes/class-wc-meta-box-coupon-data.php
# includes/api/class-wc-rest-coupons-controller.php
# includes/class-wc-coupon.php
# tests/unit-tests/api/coupons.php
# tests/unit-tests/coupon/crud.php
2016-09-01 11:46:05 +01:00
06280a7003
HTTPS for google maps
2016-08-31 14:18:55 -03:00
b063bcfe4c
last item in a multiline-array should end in a comma
2016-08-27 04:46:45 +03:00
077f57f139
Merge branch 'master' into WC_Data_Exception
2016-08-25 11:03:14 +01:00
90137f128b
Update unit test
2016-08-25 10:58:11 +01:00
d9798f7226
Set reading to prevent exceptions during DB load
2016-08-24 14:37:19 +01:00
b727acd96e
Implement get and set prop methods
2016-08-23 18:48:48 +01:00
a8e47992a6
Put back add_product for convenience. Fix unit tests.
2016-08-22 18:00:52 +01:00
c88984eb0e
Replace add methods
2016-08-22 16:48:19 +01:00
03110e755f
Unit tests
2016-08-18 17:24:44 +01:00
Mike Jolley
Cesar Rodas
Paul Kilmurray
Claudio Sanches
Claudiu Lodromanean
Jon Surrell
Justin Shreve
Claudio Sanches
Aristeides Stathopoulos