vedanshujain
6f2d64dcb4
Check for max discount to be -ve to prevent overwriting fee.
...
When we refund fee and some other line item whose value is more than fee in a single requst, value of line item will overwrite refund fee.
This is because where we check to make sure that we do not discount more than total possible value (to prevent negative total), we do not account for the fact that sometimes the cart could contain refund items. In those cases max_discount * -1 will always be larges then fees total.
This commit adds a check to make sure that max discount * -1 is indeed negative before overwriting fee total.
2019-09-03 20:45:33 +05:30
Claudio Sanches
1b2b9d528a
Fixed Netherlands postcode formatting ( #24284 )
...
* Fixed Netherlands postcode formatting
Trim all spaces, fixes issues when postcode is empty.
* Always trim spaces
* Updated unit test for test_wc_format_postcode()
2019-08-09 15:00:40 -03:00
Gerhard
9c7e1d43b0
Update unit tests for wc_string_to_bool to test for camel case as well as uppercase values.
2019-08-06 14:12:42 +02:00
Claudio Sanches
162c5dd8a2
Updated tests for wc_query_string_form_fields()
2019-08-01 17:30:39 -03:00
Rodrigo Primo
833c5016ea
Add unit tests for wc_get_endpoint_url()
2019-08-01 17:23:11 -03:00
Claudio Sanches
83c0e69637
Update wc_format_decimal() tests to check for multiple decimals points
2019-07-31 19:54:58 -03:00
Rodrigo Primo
a8f6a94cda
Remove methods assertIsWPError() and assertNotWPError() from WC_Unit_Test_Case
...
Those two methods are already declared in the class WP_UnitTestCase, so there is
no need to declare them again in the class WC_Unit_Test_Case. The only
caveat is that assertIsWPError() is called assertWPError() in
WP_UnitTestCase so it was necessary to update all of its usages.
2019-07-19 10:56:58 -03:00
Rodrigo Primo
16442956e8
Fix PHPCS errors
2019-07-19 10:19:23 -03:00
Claudio Sanches
5eb11ea77a
Remove exception for PHP 5.2
2019-07-18 23:02:30 -03:00
Claudio Sanches
16041d9247
Fixed failing tests
2019-07-18 22:42:31 -03:00
Gerhard Potgieter
52f1eb4060
Revert "Prevent negative prices on products"
2019-07-15 08:50:11 +02:00
Claudio Sanches
77191a97f8
Merge pull request #23705 from woocommerce/fix/23696
...
Prevent negative prices on products
2019-07-12 12:56:34 -03:00
Claudio Sanches
60c18ce544
Merge pull request #23067 from woocommerce/pr/23043
...
Allow matching of "any" attributes in find_matching_product_variation…
2019-07-12 12:40:53 -03:00
Gerhard
aad5b2863a
Add more tests to test more expected combinations as well as test the negatives.
2019-07-12 15:10:20 +02:00
Claudio Sanches
c63cd802aa
Merge pull request #23957 from woocommerce/feature/feature-plugin-packages
...
Include external feature plugins as packages
2019-07-10 15:47:48 -03:00
Gerhard Potgieter
49adf8169b
Merge pull request #23672 from woocommerce/fix/23366-2
...
Auto generate usernames when a username is blacklisted by WP
2019-07-10 15:44:44 +02:00
Mike Jolley
c928188831
Update from master
2019-07-10 12:57:02 +01:00
Gerhard
98c24b1090
Merge branch 'master' into pr/23043
2019-07-10 10:34:52 +02:00
Gerhard
22bb52f9be
Fix failing unit tests due to changes in #24111
2019-07-10 08:48:33 +02:00
Claudio Sanches
6e6ca196f9
Merge branch 'master' into fix/23340
2019-07-09 16:32:43 -03:00
Rodrigo Primo
34e5018137
Merge pull request #23262 from woocommerce/fix/23257
...
CSV Import - check if sku or id column exists when updating products from csv
2019-07-09 14:25:03 -03:00
Claudio Sanches
2fa5396cfc
Fixed coding standards
2019-07-09 12:43:03 -03:00
Claudio Sanches
32996d2fdd
Merge branch 'master' into pr/23043
2019-07-09 12:39:40 -03:00
Gerhard Potgieter
a7b6d7bfa4
Merge pull request #24024 from woocommerce/fix/23917/code
...
Round late when rounding at subtotal to reduce rounding error.
2019-07-09 11:05:40 +02:00
Claudio Sanches
a4b8184464
Merge pull request #23950 from parmarhardip/fix-23944
...
Currency changes applied for 'São Tomé and Príncipe dobra' and 'Mauritanian ouguiya'
2019-07-08 16:12:53 -03:00
Claudio Sanches
da99bc8ca0
Merge branch 'master' into feature/feature-plugin-packages
2019-07-08 14:33:21 -03:00
vedanshujain
8ab6cb2b5a
Round late when rounding at subtotal to reduce rounding error.
...
We were earlier rounding different tax rate values while they are merged, even if rounding at subtotal setting is enabled. This increases the rounding error, especially when prices are inclusive of taxes, and thus there is a chance that the total will be slightly different from when add the original values. For egs: https://github.com/woocommerce/woocommerce/issues/23917 .
This commit changes this behavior to round *after* we have summed all the precise unround values. Similar for items prices, we now round as late as possible, if rounding at subtotal is enabled.
2019-07-04 22:34:29 +05:30
Gerhard Potgieter
12fbfa5677
Merge pull request #22927 from woocommerce/update/22895
...
Allow "Thanks" wording in emails to be reworded by admin
2019-07-04 12:43:00 +02:00
Gerhard
29bb165aca
Apply unit tests
2019-07-04 11:50:33 +02:00
Gerhard
88442fea1e
Update unit tests to match new placeholder text
2019-07-04 11:36:12 +02:00
Rodrigo Primo
737f6af5e8
Introduce file type check for tax rate importer
2019-07-02 10:44:21 -03:00
Rodrigo Primo
7324e480e7
Fix phpcs violations
2019-07-02 10:43:52 -03:00
Mike Jolley
a0a58cfb15
update from master
2019-06-26 15:26:47 +01:00
Mike Jolley
9a8e8dacff
Add integration tests
2019-06-25 15:57:44 +01:00
Mike Jolley
de06195ae9
Remove API unit tests
2019-06-25 14:25:31 +01:00
Claudio Sanches
fe4dfea8eb
Merge pull request #23771 from woocommerce/fix/23756
...
Fix Top rated shortcode results
2019-06-24 12:18:57 -03:00
Claudio Sanches
606c0417a9
Merge pull request #23837 from woocommerce/fix/23834
...
Make NL postcode validation more flexible
2019-06-24 12:17:53 -03:00
MD0123-Hardip
9890ab4164
unit testing changes
2019-06-20 11:37:38 +05:30
Claudio Sanches
eedc871bea
Update unit tests for wc_format_phone_number()
2019-06-19 17:44:01 -03:00
Claudio Sanches
2f7ec9506f
New tests for is_postcode with NL postcodes
2019-05-28 20:55:51 -03:00
Gerhard Potgieter
b2ed079520
Manual orders coupon usage limits by email ( #23775 )
...
* Add functionality to wp-admin order to check for coupon usage based on email addresses, similar to how WC_Cart handles this seperately, included unit tests.
* Only do the coupon by email usage check if order is from a guest. Fix issue with unit test.
2019-05-27 11:45:29 -03:00
Gerhard
f6d9faa062
Introducde wc_load_cart to dynamically load the cart, this allows for functionality outside of frontend to initialise the cart.
2019-05-22 12:24:31 +02:00
Claudio Sanches
8af5117bf4
Fixed unit tests and coding standards
2019-05-20 17:27:25 -03:00
Gerhard Potgieter
afd7e72c03
Merge pull request #23690 from woocommerce/update/obw-stripe
...
Update OWB Payment Gateway structure
2019-05-16 18:26:29 +02:00
Gerhard
ddcef3b34c
Fix unit test for new scenarios
2019-05-16 16:26:34 +02:00
Gerhard Potgieter
30ce9ff6a3
Merge pull request #23689 from woocommerce/add/get_used_coupon_codes
...
Deprecate get_used_coupons in favor of get_coupon_codes
2019-05-15 15:34:40 +02:00
Rodrigo Primo
47188f05cb
Fix unit tests after changes in the default enabled payment gateways
2019-05-14 19:46:38 -03:00
Rodrigo Primo
c8b55ff62d
Improve WC_Admin_Setup_Wizard::get_wizard_in_cart_payment_gateways() tests
...
This commit moves two functions declared inside a test method to their
own protected methods inside the same test class to make it easier to
read the tests and it fixes the order of the parameters for the calls to
Assert::assertEquals(). The first parameter passed to this method should
be the expected value and the second parameter should be the actual
value and not the opposite.
2019-05-14 18:38:53 -03:00
Rodrigo Primo
ba792a6589
Fix PHPCS errors
2019-05-14 18:34:21 -03:00
Claudio Sanches
33249f3f3d
Updated unit tests for wc_format_decimal()
2019-05-14 13:21:42 -03:00
Gerhard Potgieter
b7facc0674
Merge pull request #23663 from danielbitzer/add_get_coupons_method
...
Add WC_Abstract_Order::get_coupons()
2019-05-14 11:35:21 +02:00
Gerhard
486321161c
Update usage of get_used_coupon_codes to get_coupon_codes
2019-05-14 11:21:27 +02:00
Daniel Bitzer
3024043bb4
Add unit test for WC_Abstract_Order::get_coupons()
2019-05-14 15:46:49 +09:30
Gerhard
31acfbcb4a
Deprecate WC_Abstract_Order::get_used_coupons in favor of WC_Abstract_Order::get_used_coupon_codes, this reflects the actual data being returned better.
2019-05-13 14:40:54 +02:00
Gerhard Potgieter
d2c7d8c86e
Merge pull request #23535 from woocommerce/fix/23518
...
Fix: parameter values should be converted back as well when building form fields
2019-05-10 10:43:28 +02:00
Claudio Sanches
4c028c13ba
Updated unit tests
2019-05-09 17:28:32 -03:00
Rodrigo Primo
18ee70918b
Fix PHPCS violations in tests/ using PHPCBF
...
This commit fixes all 1533 PHPCS errors that PHPCBF can fix automatically in the tests/ directory. Before this change there was a total of 3106 PHPCS errors in the WooCommerce repository and now there is 1573 errors.
2019-05-01 19:05:00 -03:00
Rodrigo Primo
45c2c78ea2
Fix: parameter values should be converted back as well when building form fields
...
PR #23196 added a workaround to `parse_str()` limitation when dealing with full-stops, pluses, and spaces in the parameter key. This workaround involved temporarily replacing those three characters with placeholders before calling `parse_str()` and then replacing back to the original form. This commit fixes a bug in this logic that was replacing back only parameters keys and not parameters values.
For example, if the query string is `?query.parameter=foo.bar`, the resulting <input> field contained `foo{dot}bar`, instead of the expected `foo.bar`.
2019-04-26 13:58:27 -03:00
Rodrigo Primo
e21430703c
Remove redundant calls to var_export() in test_wc_query_string_form_fields()
...
It is not necessary to use the $message parameter of assertEquals() to output the value of $actual_html, as PHPUnit already output this variable value in case of error.
2019-04-26 11:49:30 -03:00
Mike Jolley
9bf2081869
Merge pull request #23477 from woocommerce/fix/23466
...
Default category sorting order should be overwritten if defined by get_terms
2019-04-24 16:00:33 +01:00
Mike Jolley
8ffc4fca71
menu_order test
2019-04-24 10:45:33 +01:00
Mike Jolley
8fe68400be
name_num tests
2019-04-24 10:44:22 +01:00
Mike Jolley
3945aae94e
Test cases for sorting
2019-04-24 10:38:38 +01:00
Mike Jolley
a4ba20681e
added failing test
2019-04-23 11:48:24 +01:00
Mike Jolley
f306d3fc11
Merge pull request #23266 from woocommerce/fix/23234
...
Switch to subquery for sale product query
2019-04-18 12:36:22 +01:00
Mike Jolley
cafd81e6e5
Merge pull request #23329 from woocommerce/fix/23327
...
Non int value handling in wc_let_to_num
2019-04-18 11:30:57 +01:00
Mike Jolley
ceefe98bd0
Merge pull request #23297 from dkjensen/master
...
Remove tags from product titles when building PayPal request URL
2019-04-18 11:23:55 +01:00
Mike Jolley
b686150655
Merge pull request #23196 from woocommerce/fix/23195
...
Replace full stops before running through `parse_str`
2019-04-18 11:01:59 +01:00
Mike Jolley
630cae2483
phpcs for discounts class
2019-04-17 16:53:02 +01:00
Mike Jolley
29c3f63628
Failing test case for 23340
2019-04-17 16:41:04 +01:00
Gerhard
8ca0bd7b4d
Add logic to wc_let_to_num to handle non int values, added unit tests to cover these scenarios
2019-04-17 10:30:49 +02:00
Timmy Crawford
e12e4aaa25
Merge pull request #23304 from woocommerce/fix/link-all-variations
...
[3.6] Fix logic in link all variations
2019-04-15 11:16:22 -07:00
Timmy Crawford
438d22762e
Merge pull request #23246 from franticpsyx/issue-23245
...
Introduce IN and NOT IN clauses in `WC_Product_Data_Store_CPT::search_products
2019-04-15 11:08:32 -07:00
Rodrigo Primo
60a006d96a
Add unit test to cover WC_Tests_Product_CSV_Importer::import() when updating products
2019-04-15 12:00:49 -03:00
Rodrigo Primo
93f2050a2c
phpcs fixes
2019-04-15 11:59:55 -03:00
Mike Jolley
6c6785c844
Merge pull request #23269 from marcochiesi/patch-1
...
Added validation for Italian postcodes
2019-04-15 14:10:01 +01:00
Mike Jolley
1504f8af3e
Merge pull request #23011 from Tofandel/patch-2
...
Improve the speed of the admin dashboard by only updating transients once per class
2019-04-15 14:03:31 +01:00
Mike Jolley
d0c6c54989
Moved link/create code to data store with new unit test
...
This code was not testable within ajax code, so moved to the data stores.
2019-04-15 11:59:57 +01:00
David Jensen
23bda4503e
Add comment
2019-04-12 14:49:17 -07:00
David Jensen
ac6da3cb55
Unit test strip HTML from product title when building PayPal request URL
2019-04-12 14:44:38 -07:00
Marco Chiesi
92c356021c
Added missing parameter comments
2019-04-11 01:12:27 +02:00
Marco Chiesi
2a784a3003
Added missing doc comments (coding standards)
2019-04-11 01:03:48 +02:00
Marco Chiesi
cba442283c
Fixed wrong tests for Italian postcodes
2019-04-11 00:33:30 +02:00
Mike Jolley
d3e2d725e7
prevent test showing content
2019-04-10 13:50:42 +01:00
Manos Psychogyiopoulos
2fbb7bda5c
Check coding stds
2019-04-10 13:02:52 +03:00
Manos Psychogyiopoulos
c1b7c55768
Add exclude param tests
2019-04-10 12:47:31 +03:00
Manos Psychogyiopoulos
a9f86ef202
Add include param tests
2019-04-10 12:47:19 +03:00
Manos Psychogyiopoulos
e6f25b04d8
Add limit param tests
2019-04-10 12:47:06 +03:00
Timmy Crawford
ef4f0f0c0f
Merge pull request #23197 from woocommerce/fix/23182
...
[3.6] Fix backwards compatibility issues for wc_get_template function w/ tests
2019-04-08 10:19:16 -07:00
Mike Jolley
1cd2959087
unset rather than prevent the template being included.
2019-04-03 16:08:12 +01:00
Mike Jolley
7feae340f2
Add tests
2019-04-03 11:58:15 +01:00
Mike Jolley
2e9ce0a061
unit tests
2019-04-02 15:18:06 +01:00
Mike Jolley
c5b31cee3d
Unit test for counts
2019-04-02 11:45:58 +01:00
Mike Jolley
ad49085571
Append random number to reduce recusion
2019-03-27 12:22:15 +00:00
Mike Jolley
94466460ad
Tests
2019-03-26 11:09:30 +00:00
Claudio Sanches
a425e92672
Removed legacy "Orders index" tool
2019-03-15 11:34:32 +00:00
Adrien Foulon
8bae56d51a
Remove '_' prefix from function
2019-03-13 18:01:53 +01:00
Mike Jolley
e2e124f365
Merge pull request #22083 from woocommerce/feature/variation-search
...
Added storing attribute values as post_excerpt for variations.
2019-03-13 15:09:19 +00:00
Adrien Foulon
7099aa5d1a
Change function call to static
2019-03-13 13:48:39 +01:00
Peter Fabian
2b8d2cf3dd
PHPCS on test file.
2019-03-13 13:30:59 +01:00