Commit Graph

27332 Commits

Author SHA1 Message Date
Rodrigo Primo 7ce69dfca2 PHPCS fixes 2018-05-04 11:42:45 -03:00
Rodrigo Primo c7a9550691 Fix: WC API should not try to create a product image if empty image is passed
Currently if you try to create a product variation passing an empty array as the value of the image key using WC API:

Endpoint: `wp-json/wc/v2/products/PRODUCT_ID/variations`
Payload: `{ "attributes" : [ { "id" : 1, "name" : "color", "option" : "Green" } ], "dscription" : "Green Tea Variety", "image" : {} }`

WC will return the following error:

```
{ "code": "woocommerce_product_invalid_image_id", "data": { "status": 400 }, "message": "#0 is an invalid image ID." }
```

This is happening because the code that handles image creation
(4e42b2cd30/includes/api/class-wc-rest-product-variations-controller.php (L292)) is not checking if `$request['image']` is empty before adding a new `position` key to it. To fix this problem, this commit simply adds a check to see if `$request['image']` is empty before proceeding.

Fixes #19964
2018-05-04 10:47:39 -03:00
Gerhard Potgieter ccb39deca6 Revert "Add message to description about erasing personal data."
This reverts commit 245266f0d4.
2018-05-04 11:57:37 +02:00
Gerhard Potgieter 96d84b2813 Revert "Update the actual message and not just the test :)"
This reverts commit 9607fbcdd8.
2018-05-04 11:57:26 +02:00
Gerhard Potgieter 9607fbcdd8 Update the actual message and not just the test :) 2018-05-04 09:24:05 +02:00
Gerhard Potgieter 245266f0d4 Add message to description about erasing personal data. 2018-05-04 09:20:06 +02:00
Gerhard Potgieter e6e03858a0 Add call to tracking API when opting out to comply with GDPR erasure. 2018-05-04 09:10:18 +02:00
Gerhard Potgieter c2dbc0c887 Keep taxonomy_hierarchical test in place 2018-05-04 08:50:14 +02:00
claudiulodro eeb97510eb Recompile and prepare for beta 2 2018-05-03 09:46:40 -07:00
claudiulodro c8c2e977e6 Update changelog 2018-05-03 09:45:28 -07:00
Claudiu Lodromanean eaa6915c6b
Merge pull request #19958 from woocommerce/fix/default-asterisk
Required fields should be marked with *
2018-05-03 09:28:26 -07:00
Claudiu Lodromanean 8035ce7f9f
Update readme.txt 2018-05-03 09:25:20 -07:00
Claudiu Lodromanean 594641c32f
Merge pull request #19952 from woocommerce/add/obw-plugin-install-info-message
OBW: List all plugins to be installed upon continuing to next step
2018-05-03 09:23:45 -07:00
Mike Jolley 9e9949a742 This should be on by default 2018-05-03 16:50:26 +01:00
Claudiu Lodromanean 4357feef98
Merge pull request #19957 from woocommerce/fix/blank-state-cta
Fixes blank state call to action styling
2018-05-03 08:26:59 -07:00
Claudiu Lodromanean 87211d9f19
Merge pull request #19954 from woocommerce/update/19688
Disable zoom on touch devices
2018-05-03 08:22:43 -07:00
Claudiu Lodromanean 5dbe21012b
Update readme.txt 2018-05-03 08:22:26 -07:00
Claudiu Lodromanean 36fa5b27a3
Update readme.txt 2018-05-03 08:12:47 -07:00
Mike Jolley a3a2d234bb
Merge pull request #19946 from woocommerce/fix/19940
Actions should be filters
2018-05-03 16:11:47 +01:00
Mike Jolley 228b888ab6
Merge pull request #19947 from woocommerce/fix/19944
Page conditionals need to ensure the page exists/is set first
2018-05-03 16:11:23 +01:00
Mike Jolley 9069357a84 Fixes blank state call to action styling 2018-05-03 16:09:35 +01:00
Claudiu Lodromanean c82453c1db
Update readme.txt 2018-05-03 08:04:20 -07:00
Claudiu Lodromanean 305167efba
Merge pull request #19933 from franticpsyx/deprecate-woocommerce_ajax_added_order_items
[3.4] Deprecate woocommerce_ajax_added_order_items action
2018-05-03 08:03:55 -07:00
Claudiu Lodromanean 9dfd62dd67
Merge pull request #19938 from woocommerce/fix/update-obw-payfast-repo-slug
Updating repo slug for PayFast in the onboarding wizard
2018-05-03 08:01:17 -07:00
Claudiu Lodromanean fdb8cdb482
Merge pull request #19945 from woocommerce/update/gdpr-messages
Updates to GDPR wording
2018-05-03 08:00:05 -07:00
Mike Jolley d4e8ae093d
Merge pull request #19942 from woocommerce/tweak/gdpr-customer-tokens
Introduce GDPR export/erase for customer tokens
2018-05-03 15:36:56 +01:00
Mike Jolley c637d7d8c6
Merge pull request #19955 from woocommerce/update/translator-strings
Make some strings easier to translate for translators
2018-05-03 15:35:16 +01:00
Mike Jolley b6b4961108 min 2018-05-03 15:29:57 +01:00
Mike Jolley 2f8f30cd29 Make some strings easier to translate for translators 2018-05-03 14:50:39 +01:00
Paul Dechov 44cf10e8cc Fix phpcs issues 2018-05-03 09:35:09 -04:00
Mike Jolley 3a67c497d0 Update policy text 2018-05-03 13:19:50 +01:00
Peter Fabian 92180d2b42 Add scheme to widget id when caching objects.
This should prevent cache from serving mixed content when widget cache is preloaded with http version, then accessed via https.
2018-05-03 14:10:04 +02:00
Mike Jolley 982d9ec245 Disable zoom on touch devices 2018-05-03 12:28:25 +01:00
Paul Dechov 084510b11b Fix hiding plugin info message when no plugins will be installed 2018-05-03 06:03:25 -04:00
Boro Sitnikovski d3f3073f13 Merge branch 'master' into tweak/gdpr-customer-tokens 2018-05-03 12:02:12 +02:00
Boro Sitnikovski 868034886a Use display name for tokens 2018-05-03 12:00:07 +02:00
Paul Dechov 60b3b87f4f Adjust email field styling to fit inside container 2018-05-03 05:44:02 -04:00
Paul Dechov d4cd1e7413 Extend highlight around box 2018-05-03 05:43:32 -04:00
Mike Jolley f05f439c58 Page conditionals need to ensure the page exists/is set first 2018-05-03 10:23:36 +01:00
Paul Dechov 0fb1954af6 Only call plugin info function once on load
Also refactors this function for conciseness and avoiding frequent function definition.
2018-05-03 05:18:00 -04:00
Mike Jolley 3c905387dc Actions should be filters 2018-05-03 10:06:47 +01:00
Boro Sitnikovski 8782be0b02 Use payment tokens instead of tokens 2018-05-03 11:06:11 +02:00
Mike Jolley fde3eddccd Just updates wording 2018-05-03 10:05:13 +01:00
Mike Jolley 6b8123cdf8
Merge pull request #19943 from woocommerce/tweak/associative-array-gdpr-registration
Update GDPR abstract class to use associative arrays
2018-05-03 09:51:03 +01:00
Boro Sitnikovski 194dba40e2 Make sure devs pass their own unique ID and use localisation for constructor 2018-05-03 10:47:30 +02:00
Paul Dechov 099e4b9703 Refactor: move code around for more logical grouping 2018-05-03 04:45:01 -04:00
Boro Sitnikovski 1cfa6c6e4e Per discussion with Mike, use id when adding exporters/erasers 2018-05-03 10:36:11 +02:00
Boro Sitnikovski 0d981a000a Update abstract class to use associative arrays 2018-05-03 10:08:29 +02:00
Boro Sitnikovski d8d2f03a50 Introduce GDPR export/erase for customer tokens 2018-05-03 09:46:07 +02:00
Gerhard Potgieter a43ac9acae No need to do checks of parent, WordPress does all the checks when running wp_insert_term and wp_update_term 2018-05-03 08:19:16 +02:00