Commit Graph

120 Commits

Author SHA1 Message Date
claudiulodro 67d80c35d8 Update cache key to consistently work with all types of chars 2018-09-20 08:21:39 -07:00
Gerhard Potgieter f28002f257 Use wp_json_encode instead of esc_js. Hat tip @dtugend 2018-09-10 14:35:55 +02:00
Gerhard Potgieter 16b2abe8cd Remove charset, WP will load site charset by default. We need to do esc_js first before wp_specialchars_decode to avoid esc_js to encode double quotes again. 2018-09-10 11:58:39 +02:00
Gerhard Potgieter 6b3feb0417 Decode encoded special chars for Any string label used in the layered nav widget. 2018-09-10 10:49:25 +02:00
Rodrigo Primo 20fd569a55 Fix clearing filters in "Filter products by attribute" widget
This commit fixes an issue that was making it impossible to clear filters in the "Filter products by attribute" widget when the attribute name contained non-ASCII characters. The problem was caused by a call to sanitize_title() which doesn't seem necessary as it is sanitizing one of the widget parameters which is already sanitized in 679d719368/includes/widgets/class-wc-widget-layered-nav.php (L116). So this commit simply removes the sanitize_title() call. Even if we needed to sanitize the variable `$taxonomy`, it would be better to use sanitize_text_input_field() or wc_sanitize_taxonomy_name() as sanitize_title() will replace accented characters.

For more about the problem that is fixed by this commit see #21028
2018-08-14 11:45:57 -03:00
Mike Jolley 679d719368 Use correct escaping on placeholder
Use correct escaping on placeholder - this is not HTML, this is an attribute output within javascript code.

Closes #20360
2018-06-04 10:53:10 +01:00
Mike Jolley 06418f67e5
Merge pull request #19225 from roylindauer/17355-SplitAndFilter
Split layered nav transient per issue #17355
2018-03-14 12:50:54 +00:00
Roy Lindauer b151480e6b fix indentation issues 2018-03-13 15:34:47 -07:00
Claudio Sanches cbb1271b2c Fixed class-wc-widget-product-categories.php PHPCS violations 2018-03-09 17:28:08 -03:00
Claudio Sanches e87c309b01 Fixed class-wc-widget-layered-nav.php PHPCS violations 2018-03-09 17:10:03 -03:00
Roy Lindauer bb9afb29be
cached_counts would not be defined if cache is false 2018-03-06 07:32:12 -08:00
Roy Lindauer 4147038e93 Add filter to control caching of layered nav counts. Split cached layered nav counts by taxonomy 2018-03-02 22:14:20 -08:00
Boro Sitnikovski 080ece9588 Change method name 2017-12-14 15:37:42 +01:00
Boro Sitnikovski e1b753122e Deprecate the function as a whole 2017-12-14 10:23:51 +01:00
claudiulodro d60456cc73 Resolve conflicts and bring up to date with master 2017-12-04 13:56:59 -08:00
Mike Jolley 208b2d1b81 Slugs are encoded, so decode before outputting to the form
Fixes #17845
2017-11-21 16:50:33 +00:00
Mike Jolley 46775c2f7d standards 2017-11-20 12:14:05 +00:00
Alexandre GASNE 0018b4349e Fix: Apostrophe wrongly escaped for price nav filter and widget nav filters 2017-11-18 20:11:53 +01:00
Mike Jolley 1a7d7dd127 Widget base url 2017-11-09 11:24:29 +00:00
Mike Jolley 1b22d97be2 Combined get_page_base_url 2017-11-09 11:16:47 +00:00
Gerhard Potgieter 21377fe5a7 input to button for submit in class-wc-widget-layered-nav.php 2017-11-07 10:56:36 +02:00
Gerhard Potgieter 364d266def PHPCS fixes for class-wc-widget-layered-nav.php 2017-11-07 10:55:27 +02:00
Mike Jolley a6e5a684d0 Merge branch 'pr/17134' 2017-10-27 16:07:41 +01:00
Mike Jolley e5038e737e Standards 2017-10-27 16:07:30 +01:00
Mike Jolley 35f5140e1c Merge branch 'pr/17137' 2017-10-27 15:59:56 +01:00
Mike Jolley 47bb63733b Standards 2017-10-27 15:59:47 +01:00
Mike Jolley 2d021e3786 Merge pull request #17077 from grosssmutttr/patch-2
Update class-wc-widget-layered-nav.php - Avoid duplicate content
2017-10-27 15:19:48 +01:00
grosssmutttr 1ccec7d156 class-wc-widget-layered-nav.php - Crawling Budget
Additional optimization to save up crawling budget.
Added $link = str_replace('%2C', ',', $link); on line 513

https://mydomain.com/produkt-kategorie/my-category/?filter_filter-color=orange,black

If you add another filter it encodes the existing commas:
https://mydomain.com/produkt-kategorie/my-category/?filter_filter-color=orange%2Cblack&filter_manufacturer=adidas&filter_cut=men.children

So sometimes you have "," as seperator and sometimes you have encoded "%2C".

After implementing this pull-request the seperator stays ",":
https://mydomain.com/produkt-kategorie/my-category/?filter_filter-farbe=orange,black&filter_manufacturer=adidas&filter_cut=men.children

This pull request belongs to the optimization https://github.com/woocommerce/woocommerce/pull/17134 to save up crawling budget,
2017-10-11 14:47:00 +02:00
grosssmutttr d9f0bd5e92 Keep link structure - prevent duplicate content
Added asort($current_filter) so the urls always look the same and there are not millions of urls possibilities when adding multiple filters.

Current url example:
https://myurl.com/produkt-kategorie/mycategory/?filter_filter-color=yellow,brown,blue,red
https://myurl.com/produkt-kategorie/mycategory/?filter_filter-color=yellow,blue,red,brown
https://myurl.com/produkt-kategorie/mycategory/?filter_filter-color=blue,yellow,red,brown
...

With asort you only have this url:
https://myurl.com/produkt-kategorie/mycategory/?filter_filter-color=blue,brown,red,yellow

So it is independent on the sequence a user adds a filter
2017-10-11 08:33:46 +02:00
claudiulodro f1dac6f3ac Use esc_js instead of addslashes 2017-10-09 11:37:09 -07:00
claudiulodro 97d7ae7df8 Missing semicolon 2017-10-09 11:16:24 -07:00
claudiulodro 2ccd44afa7 Translate "no matches" message 2017-10-09 11:10:32 -07:00
Claudiu Lodromanean 2b49125b46 Enable clearing for attribute filter widget (#17093)
* Enable clearing for attribute filter widget

* Multiselect variant doesnt need clear button

* Make code less ugly
2017-10-09 11:21:21 +01:00
grosssmutttr 52beb782c6 Update class-wc-widget-layered-nav.php - Avoid duplicate content
Added rel="nofollow" to the filters to avoid duplicate content.
2017-10-05 19:55:10 +02:00
Mike Jolley ff5228e944 Standardise widget titles and descriptions
Follow the same pattern as core WP widgets, including title case.
Avoids terms like ‘layered nav’ which has no real meaning to new users.
2017-08-25 12:07:17 +01:00
Jaydeep Rami 3522857d23 Fix typo in WooCommerce plugin (#16135)
* Fixed typo

* Fixed more typo

* Fixed more typo

* Fix tyop

* Fix more typo

* Fix more typo

* Fix typo

* Fix typo

* Fix typo

* Fix typo datatime object

* Fix short name of compat

* Fix typo: update short name

* Fix typo "deactive" to "deactivate" and short BW - Compat

* Fix typo "Backwards compat"

* Fix typo 'parameters'

* Fix more typo 'pararmeters'

* Fix typo 'compund'

* FIx typo order

* Fix typo

* Fix typo 'incorrecly'

* Fix typo 'genarate'

* Fix typo 'reletive'

* Fix typo 'Handly'

* Fix typo 'rotatated'

* Fix typo

* Fix typo 'additonal'

* Fix typos
2017-07-17 11:10:52 +01:00
claudiulodro 4c4526424a Remove race condition 2017-07-11 13:21:42 -07:00
Mike Jolley 70420db6fd Spacing 2017-07-11 11:31:02 +01:00
Mike Jolley a527a9566b Add select2 to layered nav 2017-07-10 14:36:47 +01:00
Mike Jolley 0a3856c5cb Merge branch 'master' into feature-13189 2017-07-10 13:24:42 +01:00
Mike Jolley 67d13874ab Add transient caching to get_filtered_term_product_counts to reduce large queries 2017-06-16 13:35:31 +01:00
Rasmus Bengtsson 185934fad9 Fix phpdoc to include params and correct types 2017-05-15 13:50:52 +02:00
Caleb Burks c4805e41e1 Use Select2 for layered nav
WIP
2017-02-24 02:18:38 -06:00
Diego Zanella de02645544 Improved filter `woocommerce_layered_nav_link`
* Added term and taxonomy as additional parameters.
2017-01-09 19:27:01 +00:00
Mike Jolley e0e0c9e832 Replace rating filters with taxonomy 2016-12-09 15:43:25 +00:00
Mike Jolley 47fbae4d26 Product Visibility Taxonomies (#12527)
* Convert visibility and featured to taxonomy

* Comment

* Add missing tax_queries

* Only check SKU after read.

* Added visibility term for outofstock products to speed those queries up al

* wc_bool_to_string
2016-12-08 10:56:45 +00:00
opportus 4c8e694dce Layered Nav menu dropdown empty count fix 2016-11-22 19:48:39 +01:00
opportus 42bb48abf1 layered nav OR hide attributes applying to 0 product 2016-11-17 23:33:24 +01:00
Claudio Sanches 657c312cae Fix strings case (#12069)
* Fixed case for all _e, esc_attr_e and esc_html_e strings

* Fixed case for all _n_noop strings

* Fixed case for all _x strings

* Fixed case for all __, esc_html__ and esc_attr__ strings

* Fixed a few more strings

* Fixed strings in unit tests

* Fix PayPal Standard case.

* Save Order text
2016-10-12 11:16:30 +01:00
Mike Jolley 50544233f5 Wrap layered nav term in filter
Closes #11922
2016-10-11 18:23:25 +01:00