Commit Graph

35238 Commits

Author SHA1 Message Date
Nestor Soriano f0b0822c1c Fix code sniffer errors in CodeHacker and related classes. 2020-05-20 09:56:25 +02:00
Nestor Soriano 57845ef8b8 All code hacking files moved to src\Testing folder. 2020-05-20 09:56:25 +02:00
Nestor Soriano 1a68abbc28 Miscellaneous code hacking fixes:
- Fix how CodeHackerTestHook::executeBeforeTest parses the test name,
  to account for warnings and tests with data sets.

- CodeHackerTestHook now includes a executeAfterTest hook that
  disables the code hacker (needed to prevent it from inadvertently
  altering further tests). Also, clear_hacks is executed in
  executeBeforeTest for the same reason.

- CodeHacker gets restore, clear_hacks and is_enabled methods
  to support the changes in CodeHackerTestHook.

- FunctionsMockerHack fixed so that it doesn't modify strings
  that are class method definitions.

- Added the WC_Unit_Test_Case::file_copy method, it must be used
  instead of the PHP built-in "copy" in tests, otherwise tests
  that run with the code hacker active will fail.
  This is something to investigate.
2020-05-20 09:56:25 +02:00
Nestor Soriano 9a5b3b353d Add the @hack code annotation for tests.
Now @hack class and method annotations can be used to register
code hacks as an alternative to using before_ methods.
The syntax is /* @hack HackClassName param1 param2 */
where parameters will be passed to the class constructor.
If the class name ends with "Hack", then that suffix can be
omitted (e.g. "Foo" can be specified instead of "FooHack").
2020-05-20 09:56:25 +02:00
Nestor Soriano db58b51de3 Barebones implementation of a code hacker for unit tests.
The "code hacker" is a class that hooks on filesystem events
(using stream_wrapper_unregister) in order to allow for dynamically
modifying the content of PHP code files while they are loaded.
The code hacker class allows registering hacks, which are
functions that take source code as input and return the modified code.
A hack can be a standalone function or a class with a "hack" method.

A few hacks are provided off the shelf. One allows mocking standalone
PHP functions (WP, WOO or not), another one allows mocking static
methods, and there's the one that removes the "final" qualifier
from a class definition. This helps unit testing stuff that would
otherwise be quite hard to test.
2020-05-20 09:56:25 +02:00
Christopher Allford 326d8feb92 Updated the Jetpack Autoloader
Jetpack made a change that requires some extra ignore entries from the latest release of the autoloader, otherwise debug logging warnings are thrown.
2020-05-19 16:16:50 -07:00
David Stone 4486f06cda Use keepAlive for better user experience
keepAlive lets the user hover over the tooltip without closing it.
closes # 26555
2020-05-19 14:40:56 -06:00
David Stone 030c90e069 tweak keepAlive for better user experience
keepAlive will now close when leaving target element or tooltip box
2020-05-19 14:39:44 -06:00
Jeffrey Scott French 9faee1d909 Sets Select a country option element value attribute to default. 2020-05-19 15:07:27 -04:00
Viktor Szépe 90c34a26a0
Fix PHPDoc in WC_Notes_Run_Db_Update
and correct a newbie mistake
2020-05-19 19:21:57 +02:00
Christopher Allford 4750a2d567
Merge pull request #26550 from woocommerce/fix/update-wp-minimum
Adhere to WP support policy
2020-05-19 09:21:09 -07:00
Vedanshu Jain 12ff70fb14
Merge pull request #26549 from woocommerce/fix/26493-error-handling
Call callback on tracking script load error
2020-05-19 21:09:06 +05:30
Joshua Flowers b7bca44beb Call callback on tracking script load error 2020-05-19 18:19:19 +03:00
Christopher Allford df7db72855 Cleaned up our Travis config to suit the WP support policy 2020-05-19 07:00:32 -07:00
Christopher Allford 7db709957b Increased the WordPress minimum version to 5.2 as per our support policy 2020-05-19 06:59:52 -07:00
Vedanshu Jain 5adaa5667e
Merge pull request #26493 from woocommerce/fix/26466
Add function to allow client-side enabling of tracks
2020-05-19 16:30:45 +05:30
Vedanshu Jain 7fb1079137
Merge pull request #26399 from woocommerce/fix/uploads_htaccess
Disable directory listing for redirect download method
2020-05-19 15:56:37 +05:30
Damien Carbery 3132f14c77
Allow heading filter for cross sells component
Copying a similar change to templates/single-product/up-sells.php by @jacobarriola on 2020-02-10.
eea787e0e8 (diff-26fe493bd38552d971b507f64e87a879)
I do not have a use case for this but saw a blog post this morning that used 'gettext' filter to change this text (I suggested a custom PO file with just this string).
2020-05-19 10:51:51 +01:00
Boro Sitnikovski d1ac3731a5 Add actions before/after shipping calculation 2020-05-18 21:04:13 +02:00
Jeffrey Scott French a75c118c02 Sets Select a country option value as default on shipping-calculator country select input. 2020-05-18 13:48:21 -04:00
Joshua Flowers 07b1887c2b Use var instead of const 2020-05-18 19:11:29 +03:00
Ron Rennick 617a523057 fix merge conflicts 2020-05-18 12:34:03 -03:00
Claudio Sanches eea062f9fa
Merge pull request #26519 from woocommerce/fix/csv-import-special-columns
Fixed the case conversion for meta key column mapping in product CSV imports
2020-05-18 11:33:50 -03:00
Peter Fabian e3e72e0423
Merge pull request #26500 from woocommerce/fix/26443
Refresh db update nonce on the Thank you notice
2020-05-18 14:36:13 +02:00
Pan Seba d5952d3b00 Trigger removed_coupon_in_checkout event after coupon removal on checkout 2020-05-18 13:16:30 +02:00
Ron Rennick 07c6075dde use nonced logout link for store owner logout 2020-05-15 16:58:50 -03:00
Albert Juhé Lluveras 9a34c4fe75 Update WC shipping settings so no shipping zones banner appears when all are deactivated 2020-05-15 16:32:12 +02:00
Néstor Soriano 8b0d4ef050
Merge pull request #26386 from woocommerce/fix/26355
Set an error ID for each WP_Error entry
2020-05-15 12:09:14 +02:00
Boro Sitnikovski f34e73d402 Add a comment on @babel/preset-env 2020-05-15 11:28:21 +02:00
Albert Juhé Lluveras 973e50ab64 Add param to wc_get_shipping_method_count() 2020-05-15 11:22:28 +02:00
Boro Sitnikovski ad3b9fc861 Fix version mismatch error 2020-05-15 11:21:59 +02:00
Boro Sitnikovski b01f3aae93 Add some additional information and be specific about babel file 2020-05-15 11:21:34 +02:00
Albert Juhé Lluveras de7ca06b41 Set is_enabled=1 instead of is_enabled=true 2020-05-15 11:02:12 +02:00
Albert Juhé Lluveras 33b0bef8c5 Add is_enabled=true check in wc_get_shipping_method_count() 2020-05-15 11:02:12 +02:00
Néstor Soriano 3d2927f6e1
Merge pull request #26407 from woocommerce/feature/build-zip
Introduced script to generate a zip package
2020-05-15 10:59:04 +02:00
Néstor Soriano eab8920a07
Merge pull request #26314 from woocommerce/add/build-workflow
Build release workflow
2020-05-15 10:36:34 +02:00
Peter Fabian 0934f4a147 Merged should_show_notice and show_reminder and simplified logic.
Removed redundant calls to the same functions as this code runs on each admin pageload.
2020-05-15 10:24:30 +02:00
Néstor Soriano b9875a4fc1
Merge pull request #26445 from tsteur/issue_26414
Add hooks to "Add payment method form" to show additional fields and validate input
2020-05-15 10:16:53 +02:00
Peter Fabian 2f141eca77 PHPCS 2020-05-15 09:40:23 +02:00
Peter Fabian 50e386cbe8 Corrected the comment. 2020-05-15 09:26:17 +02:00
Kathy Daring cecfee4f57 to account for <select> fields not being present, make sure ajax doesn't fire if there are no found attributes 2020-05-14 22:28:39 -06:00
Kathy Daring d1672ff42e optionally accept a custom array of chosen attributes. This will make it easier for "Swatches" and "Radio" input plugins to interact with the variations script without replacing the entire thing. 2020-05-14 22:27:40 -06:00
Kathy Daring b93b9092ca Give plugins an entry point into the VariationForm object 2020-05-14 22:26:13 -06:00
Christopher Allford 7bf9c31f64 Adjusted the column name normalization to avoid squashing meta key case sensitivity
Since we were converting the field to lowercase we ended up inserting meta in all lowercase, regardless of what it was in the CSV file. We should only be using the normalized field name when looking at the default columns, and should instead rely on a case-insensitive regex for the special columns.

One thing to note is that we're still defaulting the $headers array to the normalized field, as we don't want to change what is being passed to the filter for unmapped columns.
2020-05-14 21:20:55 -07:00
Christopher Allford 63ba6f7ee0 Moved the PSR-4 namespaced test directory to the correct folder
I know this probably doesn't belong in this PR, but it has been thoroughly discussed and I don't think anyone will mind :)
2020-05-14 21:20:47 -07:00
Christopher Allford aa6a025526
Merge pull request #26517 from woocommerce/revert-25517-duplicated-custom-fields-after-import
Revert "Fix duplicated custom fields after import products from .csv file"
2020-05-14 14:32:09 -07:00
Thomas Steur 630b7f436d apply review feedback: better naming and coding style fix 2020-05-15 09:08:35 +12:00
Mat Lipe bf42110179
Fix set cache loop when no attributes exist
Test strictly for false to prevent an endless set cache loop when
you are not using attribute taxonomies or don't have any set.
Prevents `wc_get_attribute_taxonomies` function from calling `wp_cache_set` 
on every page load.
2020-05-14 12:37:29 -05:00
Claudio Sanches c09a269589
Revert "Fix duplicated custom fields after import products from .csv file" 2020-05-14 14:06:01 -03:00
koko 54db5f07c4
Fix error message in wc_get_template
If the filtered template does not exist the error should report the filtered template, not the original
2020-05-14 17:10:06 +02:00