Commit Graph

28260 Commits

Author SHA1 Message Date
Rodrigo Primo 3f82ecee8c Remove unnecessary uses of @codingStandardsIgnoreLine 2018-07-31 16:10:51 -03:00
Claudiu Lodromanean 3a6f14f380
Merge pull request #20905 from woocommerce/fix/20904
Fixes an issue with the 'woocommerce_grant_product_download_access' hook
2018-07-31 11:31:05 -07:00
Brent Shepherd ab78e65af9 Update WC_Queue_Interface::get_next()
To more closely align return value with other date APIs in WC, namely
WC_Data. Includes changing return value to:

1. a WC_DateTime instead of a timestamp when a scheduled occurrence is found
2. null instead of false, similar to the default of WC_Data::set_date_prop()
2018-07-31 12:29:15 +10:00
Brent Shepherd d9158a8c0e Add WC_Queue and WC()->queue() wrapper for accessing it
To take care of instantiating a canonical job queue for use across
all of WooCommerce, and by 3rd party code.

Also use this new API for enqueuing webhooks instead of raw Action
Scheduler APIs.
2018-07-31 12:21:07 +10:00
Brent Shepherd 0611ff7665 Add WC_Action_Queue
As a wrapper for Action Scheduler. This implements the WC_Queue_Interface
so it can be used as WC core's job queue. Implementing WC_Queue_Interface
also means this class has more generic and appropriate job queue nomenclature
than Action Scheduler itself. For exsample, it provides a method for
non-delayed jobs, i.e. WC_Queue_Interface::add(), unlike Action Scheduler,
which requires scheduling a job for now(), which while fairly simple, is not
intuitive or immediately obvious to new comers.

This makes it both more clear and convenient to use Action Scheduler
as a simple job queue instead of just a queue for delayed jobs.
2018-07-31 12:21:04 +10:00
Brent Shepherd 8e4466c9c8 Add WC_Queue_Interface
To provide an agreed set of public methods that need to be defined
for any class wanting to act as WooCommerce's queue handler.

The require APIs support both delay jobs, by providing APIs to
schedule an action/job/event for some time in the future, and a
non-delayed job API, to add an event to the queue to run as soon
as possible.
2018-07-31 12:20:30 +10:00
Rodrigo Primo b09bb3eee9 Fix: orderby and order parameters in WC_Customer_Download_Log_Data_Store::get_download_logs()
This commit fixes a bug in WC_Customer_Download_Log_Data_Store::get_download_logs() that made impossible to change the order in which the query returned the results. This method accepts the arguments order_by and order, but it was ignoring them and always using the default values ('download_log_id' and 'ASC' respectively).

It also introduces a very basic unit test to cover the method main functionality and to make sure that the parameters order and orderby are not ignored anymore.

It seems that the modified method was inspired in WC_Customer_Download_Data_Store::get_downloads() before the same bug was fixed in #18620.
2018-07-30 16:40:21 -03:00
Claudiu Lodromanean dc191b58a4
Merge pull request #20916 from woocommerce/fix/20906
Do not use array_merge for appending to tax classes
2018-07-30 11:46:13 -07:00
Claudiu Lodromanean 28f1aed9b0
Merge pull request #20913 from shoheitanaka/patch-15
If email @local include non alphabet
2018-07-30 11:43:10 -07:00
Shohei Tanaka d77990edde
Update it again
Thank you for the concrete method.
2018-07-29 09:17:39 +09:00
Claudiu Lodromanean 075cbd156e
Merge pull request #20915 from stromhalm/master
Merging plugin's tax_queries on REST endpoint, fixes #20914
2018-07-27 06:52:17 -07:00
Shohei Tanaka f4db4ecad7
Update it
Do you mean it?
2018-07-27 19:12:17 +09:00
Adrian Jagusch dc8d15356b
Ensure coding standards on #20914 2018-07-27 11:38:57 +02:00
Gerhard Potgieter 11832f937d Use + instead of array_merge for appending to tax classes since it rewrites numeric keys which we allow in tax class names. 2018-07-27 11:18:16 +02:00
Gerhard Potgieter 75e462c448 Do not use array_merge for appending parent to tax classes rather +, array_merge will rewrite numeric keys which we allow for tax class names. 2018-07-27 11:16:28 +02:00
Adrian Jagusch 7b7bccaf21
Ensure coding standards on #20914 2018-07-27 10:51:15 +02:00
Claudiu Lodromanean 30d34dcf8c
Merge pull request #20910 from woocommerce/fix/tax-rate-non-numeric
Cast tax rate to float so that it can be treated as number further on.
2018-07-26 10:44:56 -07:00
Claudiu Lodromanean bebd77c2b5
Merge pull request #20901 from woocommerce/fix/20895
Fixed reset password cookie when REQUEST_URI includes Cyrillic alphabet
2018-07-26 10:34:53 -07:00
Adrian Jagusch 2a2345acae
Fixes #20914 2018-07-26 17:32:08 +02:00
Shohei Tanaka fdc9d42dc4
If email @local include non alphabet
If I input infoおおお@test.com as billing email address, automatically change to info@test.com by sanitize_email function.

So at first check the email address by is_email function, after that we must use sanitize_email function.
2018-07-27 00:18:09 +09:00
Peter Fabian 4e7bc117e4 Update unit tests. 2018-07-26 15:11:24 +02:00
Peter Fabian 9bca5abb40 Cast tax rate to float so that it can be treated as number going forward.
In case no tax rate is specified for the default catch-all tax rate, the tax rate was an empty string which caused a PHP notice when it was later used in arithmetic operations.
2018-07-26 14:32:48 +02:00
Kanishk 4fc06834b6 Fix for #20904 2018-07-26 15:12:28 +05:30
Claudio Sanches 575575d280 Fixed reset password cookie when REQUEST_URI includes cyrillic alphabet
WordPress core doesn't try to satinize this either.
See: ae2b929294/wp-login.php (L646)

Closes #20895
2018-07-25 20:33:11 -03:00
Rodrigo Primo 424956c6f6 3.4.4 changelog 2018-07-25 15:16:46 -03:00
Claudiu Lodromanean b76667796a
Merge pull request #20886 from woocommerce/fix/20871
Re-add woocommerce_order_details_after_customer_details_filter
2018-07-25 08:39:43 -07:00
Claudiu Lodromanean a396312b85
Merge pull request #20889 from woocommerce/fix/20885
Do not hide coupon form when a coupon is applied
2018-07-25 08:08:55 -07:00
claudiulodro 737dbbf36a phpcs fixes 2018-07-25 08:05:01 -07:00
Gerhard Potgieter 71d52e401a
Merge pull request #20758 from woocommerce/update/core-function-unit-tests
Improve core functions test coverage
2018-07-25 14:23:48 +02:00
Gerhard Potgieter d050f6af50
Merge pull request #20801 from LuigiPulcini/LuigiPulcini-patch-1
Adding product data to `removed_from_cart` event
2018-07-25 14:14:14 +02:00
Gerhard Potgieter 73b80c9241 Remove extra asterisk 2018-07-25 14:09:04 +02:00
Gerhard Potgieter 5a0d3c8bf7 Fix indentation issues caused by github conflict tool 2018-07-25 14:07:57 +02:00
Gerhard Potgieter da82639ebc
Merge branch 'master' into update/core-function-unit-tests 2018-07-25 14:05:12 +02:00
Gerhard Potgieter 20a6c40bdf
Merge pull request #20856 from woocommerce/fix/custom-menu-order
Allow custom menu ordering when set by another filter
2018-07-25 13:55:58 +02:00
Gerhard Potgieter 8af8a77572 Bump template version 2018-07-25 08:04:25 +02:00
Gerhard Potgieter 9e207c9c11 You can apply more than one coupon, make sure to not hide the form when a coupon is already applied. 2018-07-25 08:03:17 +02:00
Brent Shepherd e00e728f1f Merge branch 'master' into issue_18003 2018-07-25 14:41:56 +10:00
claudiulodro 46b5794d63 Re-add woocommerce_order_details_after_customer_details_filter 2018-07-24 12:53:29 -07:00
Claudiu Lodromanean 59de4c7148
Merge pull request #20879 from woocommerce/fix/20671
Update redirect option during activation of MailChimp in Install Wizard.
2018-07-24 11:07:00 -07:00
Claudiu Lodromanean 4c945f2e7e
Merge pull request #20854 from EmranAhmed/master
Prevent JS Issue if `woocommerce_available_variation` filter return false
2018-07-24 10:50:08 -07:00
Claudiu Lodromanean 9e3da78c73
Merge pull request #20853 from woocommerce/reduce-test-suite-execution-time
Reduce WC_Tests_REST_System_Status tests execution time
2018-07-24 10:46:26 -07:00
Claudiu Lodromanean 4016925616
Merge pull request #20818 from woocommerce/fix/20797-2
Removed 100% width on images on single product page for 2017 theme
2018-07-24 10:40:42 -07:00
Claudiu Lodromanean 9886d678bb
Merge pull request #20812 from woocommerce/fix/20804
Do not build paypal pay link when no base country is set.
2018-07-24 10:31:34 -07:00
Claudiu Lodromanean 8cde592c54
Merge pull request #20787 from thenbrent/error_log_file_line
Expand fatal error logging and add file/line number to log entries
2018-07-24 10:28:38 -07:00
Claudiu Lodromanean a0b4a8df03
Merge pull request #20611 from woocommerce/fix/20349
Allow filtering variations by attributes in API.
2018-07-24 10:25:36 -07:00
Claudiu Lodromanean 87acfa731d
Merge pull request #20260 from leglesslizard/master
Set low stock notification threshold per product
2018-07-24 10:23:15 -07:00
Rodrigo Primo 558408da28 Check if $product is an instance of WC_Product before using its methods
Doing this to protect against the fatal error reported in issue #20880. I was not able to reproduce this problem but adding this check is probably a good idea anyway.
2018-07-24 11:00:37 -03:00
Rodrigo Primo 4ceee4cfc9 Fix phpcs violations 2018-07-24 10:50:19 -03:00
Peter Fabian d679a88156 Update redirect option during activation of MailChimp in Install Wizard. 2018-07-24 12:29:10 +02:00
LuigiPulcini 79cda7c2bc
Update add-to-cart.js 2018-07-23 08:11:21 -07:00