The deprecated (but not removed) `onChangeCallback` and `onSubmitCallback` props were not being called because of an error in the logic that checked for presence of the new callbacks (it was always truthy due to it having a fallback to an empty function).
This reverses the logic so that if the deprecated props are provided they will be called, if the new props (only) are provided they will be called instead.
This also pushes the removal of these back to 9.0.0, because in the past these deprecated version numbers had little thought behind them, but this gives a more realistic time frame for removal and an understanding that a *major* version will break compatibility, not a patch version as the old version number suggested.
* Using order items endpoint instead of reports and added customer and products support
* Add total_formatted key
* Converted component to functional component and memoized getItems function
* Using orders meta table instead of reports product_lookup table
* Add changelog entry
* Add components-dropdown__content class -- this is for Safari as Safari returns parent element as a related target in this case
* Remove unnecessary style
* Add TableSummaryPlaceholder
* Expose TableSummaryPlaceholder to package @woocommerce/components
* Add test instructions and changelog entries to MD files
* Add tests for TableSummaryPlaceholder
* Add storybook for TableSummaryPlaceholder
* bump E2E package versions to latest
* first pass on E2E test package.json
* move e2e specs to admin-e2e-tests
* add global types, reimplement tests/e2e/specs
* use consistent build dir with other packages
* add documentation, improve test:e2e script
* fix linting issues in admin-e2e-tests
* fix more linting issues
* disable lint on requires
* use e2e in the E2E container names
* move analytics overview test to package
* change extension on analytics-overview test file
* fix linting issues in e2e analytics overview
* remove package scripts from e2e package
* change test specs extensions to .tsx
* remove import from analytics overview test spec
* add .tsx to e2e test spec file extension list
* update e2e business features count expected
* add @slotFill to process
* add types
* committing data
* use filter instead of hook
* changelog
* add action type
* update paths to ignore builds and node_modules
* changelog
* Add action data type
Co-authored-by: Joshua T Flowers <joshuatf@gmail.com>
Co-authored-by: Joshua T Flowers <joshuatf@gmail.com>
* Make action button optional, and disable VerticalCSSTransition when expandable is false
* Update collapsible list to support nested element transitions
* Add changelog
* Address some small PR feedback, and fix tests
* Add expanded class, and remove cursor when expanded
* Make sure margin is added to container height
* Update broken tests
* Add radix to parseInt method
* on Filter update, keep all queries
* changelog
* package changelog
* instead of keeping everything else, remove advancedFilters when main filter is set to 'all'
* remove all queries associated with filter in question
* dedupe params
* add tests
* Added onDelete prop to `task-item`.
* Added `onDelete` and `Remid me later` options to task example in docs.
* Added changelog
* Fixed lint error
* Fixed another lint error
Co-authored-by: Fernando Marichal <contacto@fernandomarichal.com>
Co-authored-by: Adrian Duffell <9312929+adrianduffell@users.noreply.github.com>
- Make `getIdsFromQuery` consider `0` as a valid id.
Previously `Boolean` filter was removing it from the list.
Fixes https://github.com/woocommerce/woocommerce-admin/issues/6980
- Add a basic set of tests for `getIdsFromQuery`, as they were none.
- Replace `lodash.uniq` with ES6 equivalent.
- Update JSDoc for `getIdsFromQuery`, to specify default value, returned type and description.
* Add appropriate text props to supplement variant revamp
* Add font styles to navigation title since its removed in wp.components
* Add more missing styles
* Accidental change
* Add changelog
* Fix lint
* Update jest snapshots
* Add new VerticalCSSTransition component for vertical transitions
* Made use of VerticalCSSTransition in taskItem
* Updated vertical css transition to add support for appear
* Add changelog
* Fix task list tests
* Fix test lint error
* Use delete key instead of setting it to undefined
* Use order item data to match attributes.
Fixes matching on products with "any x" attributes.
* Fix attribute query on variations report.
* Fix variations report item count.
* Add test coverage.
* Add changelog entry.
* Fix non-string query prop warning in SelectControl component.
* Move custom attribute retrieval to a reusable Trait.
* Ensure all custom attribute terms are included in the API response.
* Combine all terms from custom attributes.
When they're split across multiple products.
* Update the wordpress/babel-preset to avoid crashes in WP5.8 beta2
* Also update other dependencies dropping IE11 support.
* Update data dep in data package.
* Add back regen runtime.
* Add regenerator-runtime dependency for setting up jest tests
Co-authored-by: Ilyas Foo <foo.ilyas@gmail.com>
* Add fallback for the select/dispatch data-controls for older WP versions
* Also update dispatch in payment-gateways and rename oldDispatch to depreciatedDispatch
* Add comments
* Initial ellipses menu render on task list
* Added remind me later functionality
* Fixed tests and wrote tests for ellipsis menu
* Update tracks
* Add changelog and update css
* Fix up spacing and track name
* Address PR feedback and add extra integration tests
* Remove the should render correctly test, as the other tests cover this
* Move logic out of mark up
* Directly reference the EllipsisMenu for now to circumvent a circular dependency
* Fix direct import in jest tests
* Preload remind me later optoin
* Some styling animation changes for the task list
* Stagger transitions for dismissing within collapsible list
* Fix lint warnings
* Update logic to prevent the use of TS `as`
* Add tests and comments
* Refactored the inbox note cards and moved to experimental package
* Update experimental dependencies
* Add tests for inbox-note components, and updated naming
* Add changelog
* Update readme and fix dismiss all
* Fixed lint errors
* Refactor dismiss logic in inbox-panel
* Add hook for handling inner link callbacks
* Export updates and a minor TS update
* Fix lint error
* Add action button to TaskItem.
* Pass through click event.
* Add separate action and label to onClick.
* Add initial copy for task expansion.
* Expand one task at a time.
* Add descriptive text to the payments step.
* Set the first incomplete task current by default.
* Revert expansion behavior.
* Fix margins.
* Curate purchase products task content based on selections.
* Fix appearance task copy.
* Fix payment task copy.
* Add conditional tax step title.
* Indicated if task is expanded to click handlers.
* Automatically enable WC Tax from the expanded CTA.
* Restore additional text property.
* Fix task title xpath selector in E2E test.
* Fix automatic tax setup query param logic.
* Add changelog entries.
* Hook up payment gateway data store
* Fix deprecated onSubmitCallback in dynamic form
* Throw catchable errors in data store
* Provide a way to get errors from the data store
* Hook up payment connection update with data store
* Remove redundant requesting state on selectors
* Add changelog entry
* Handle PR feedback
* Fix linting errors
* Updated mobile banner icon with cross-small gridicon
* Update analytics dashboard icons, removing use of dashicon
* Remove use of dash icon in tag component
* Remove dash icon from ellipsis menu
* Remove use of dashicon in calendar
* Update icon imports and remove use of Dashicon in collapsible list
* Remove Dashicon usage from store alerts as it is depreciated
* Remove dashicon usage in shipping label
* Fix up old css for icons
* Removed dashicon usage in favorite button
* Update the wordpress/icons package
* Add changelogs
* Fix broken test
* Add a new store to interact with WC Payments REST APIs
* Convert to Typescript
* Refactor payments store
* Fixed type on GET_PAYMENT_GATEWAYS_SUCCESS action name
* Added SettingDefinition
* Added PaymentSelectors type
* Updated Array<type> to string[]
* Update action name in test
* Move stub.ts out of test directory
* Set type for the test stub and change order type to number | ""
* Rename action type name
* Add changelog
* Follow _REQUEST _SUCCESS _ERROR action naming
* Add a new action and reducer for getPaymentGateway
* Change store key
* Move to packages/data
* Export store name
- Forward `autocompleter` prop from `CompareFilter` to `Search`.
Allow, to use the `custom` type of search,
previously it was complaining about lack of `autocompleter`,
even though it was provided.
- Move `path` in Storybooks example to a parameter, to allow setting it in unit tests.
- Add few tests for FilterPicker.
- it renders the basic storybook example without throwing an error
- it forwards `autocompleter` & `type` props
Fixes: woocommerce/woocommerce-admin#6890
* Replace google icon
* Remove note for Google Ads extension
* Replace extension in API OnboardingProfile
* Record event for new extension
* Replace extension in onboarding flow
* Replace extension benefits
* Change background colour of Google icon
* Fix svg warnings
* Add changelog entry
* Fix prettier error
* Add old note to obsolete list for removal
* Added payment method to onboarding data store
* Add reducer test
* Address feedback on reducer naming convention, isResolving, enabledMethods
* Move out types to live in its own island
* Add a comment to remind ourselves for utilizing payments data store for enabled payment gateways
* Update changelog
* Fix select-control component to preserve currently selected item on focus and de-focus
* No longer auto select option on initial render, pressing tab would only select if selection exists
* Fix to reflect the proper suggested changes
* Attempt to fix unnecessary search reset on pressing tab
* Fix for keyboard interactions and added accompanying tests
* Add disabled props to SelectControl
This commit adds "disabled" props to SelectControl
* Added changelog
* Fixed prop name
Co-authored-by: Fernando Marichal <contacto@fernandomarichal.com>
* Prototype the basic functionality of the list collapse component.
* Further work on the component.
* Add icons and some basic styling. Fix exports to include 'Experimental'
* Add CSSTransition to collapsible list item
* Add tests for collapsible component
* Add changelog
* Add collapse/expand callbacks
* Add tests for callbacks
* Replaced collapsible list item with a collapsible list instead
* Updated to use calculated height versus absolute height
* Removed fallback and removed animation from collapse footer
Co-authored-by: Lourens Schep <lourensschep@gmail.com>
* Add a Basic test for FilterPicker.
Test that it renders the basic storybook example without throwing an error.
Move `path` in Storybooks example to a parameter, to allow setting it in unit tests.
* Forward `autocompleter` prop from `FilterPicker` to `Search`.
Allow, to use the `custom` type of search, previously it was complaining about lack of `autocompleter`, even though it was provided.
Fixes: https://github.com/woocommerce/woocommerce-admin/issues/6062.
* Add changelog entry.
* Move `FilterPicker` config creation closer to tests that use it.
* Remove unused type prop from `FilterPicker` tests.
Addresses https://github.com/woocommerce/woocommerce-admin/pull/6880/files#r620285400.
* Add changelog note also to `CHANGELOG.md`.
Co-authored-by: Jeff Stieler <jeff.m.stieler@gmail.com>
Joel Thiessen
Sam Seay
Renovate Bot
Joshua T Flowers
Ilyas Foo
louwie17
Jeff Stieler
Moon
renovate[bot]
Dat Hoang
Paul Sealock
Ron Rennick
Hsing-yu Flowers
Fernando
Tomek Wytrębowicz
Mik
Christos Lilitsas