Commit Graph

6654 Commits

Author SHA1 Message Date
barryhughes 80397d4f73 Improve test description. 2022-03-29 10:18:31 -07:00
barryhughes 114480c23c Tweak commentary. 2022-03-29 10:18:31 -07:00
barryhughes 1aecb64be5 Cover further scenarios relating to relative URLs and traversals. 2022-03-29 10:18:31 -07:00
barryhughes cee42b7264 Enhance directory traversal handling/resolution. 2022-03-29 10:18:31 -07:00
Lourens Schep 3014f0f9f0 Update test readme with additional error for troubleshooting 2022-03-29 13:09:23 -03:00
Barry Hughes a98aa9c910
Merge pull request #32112 from woocommerce/bump-required-php-to-7.2
Bump WooCommerce minimum required PHP version to 7.2
2022-03-29 09:03:42 -07:00
Fernando bd0397285b
Merge pull request #32331 from woocommerce/update/32157_disable_welcome_modals
Experiment: disable welcome modal
2022-03-29 11:46:24 -03:00
Nestor Soriano be213eb821
Add return type setUp and tearDown methods in admin unit tests
After the bump to PHP 7.2 all the setUp and tearDown methods
in unit test classes need to have an explicit "void" return type
declaration. This commit adds those for the woocommerce-admin tests.
2022-03-29 12:08:08 +02:00
Chi-Hsuan Huang 4b21e1d913 Remove .vscode since it has been removed to root 2022-03-29 17:48:25 +08:00
Chi-Hsuan Huang ed8c114bdd Add back woocommerce-admin.php uninstall.php 2022-03-29 17:47:18 +08:00
Chi-Hsuan Huang 4c976ebd17 Remove unnecessary wooCommerce admin files
Add back languages/README.md
2022-03-29 17:47:18 +08:00
Chi-Hsuan Huang 386d173105 Update storybook webpack config to build stories 2022-03-29 16:46:40 +08:00
Chi-Hsuan Huang 0cc5c6d515 Add expose-loader for storybook webpack config 2022-03-29 16:46:40 +08:00
Chi-Hsuan Huang b658920898 Fix storybook packages paths 2022-03-29 16:45:39 +08:00
Nestor Soriano 25bf59d5e7
Merge branch 'trunk' into bump-required-php-to-7.2 2022-03-29 10:45:07 +02:00
Chi-Hsuan Huang 71350b4e8b Change script lint:js:packages to lint:js-packages 2022-03-29 16:38:26 +08:00
Chi-Hsuan Huang ecff6cd680 Remove lint-test-js.yml 2022-03-29 16:38:06 +08:00
Chi-Hsuan Huang f2a6f93684 Update wca test command and ignore api-core-test
Update test:packages cmd
2022-03-29 16:38:06 +08:00
Chi-Hsuan Huang 4baad1a6e3 Add pr-lint-test-js.yml and remove package-js-api.yml, js_lint_test.sh 2022-03-29 16:38:06 +08:00
Nestor Soriano 6befc1d62a
Small changes related to the bump of min PHP to 7.2
- Rename wrongly cased variable
- Require higher version of maxmind/dbreader
2022-03-29 10:29:15 +02:00
RJChow e9eac24793 tsconfig modifications
- moved and updated .vscode/tasks.json up to root level, and add exclusion to .gitignore
- added --pretty to ts:check in wca package.json (because otherwise there's no syntax highlighting in the output, not sure why this is needed with nx and not without)
- added references to root tsconfig.base.json
- update development.md with instructions for ts checking
2022-03-29 16:08:07 +08:00
Chi-Hsuan Huang 99e6f61dc8 Update woocommerce-admin/.eslintrc.js 2022-03-29 16:08:07 +08:00
Chi-Hsuan Huang df5b506b97 Add lint command to js packages
Update lint js commands

Update customer-effort-score/package.json
2022-03-29 16:08:06 +08:00
Chi-Hsuan Huang 8b2a97d405 Add lint cmd to project.json 2022-03-29 16:08:06 +08:00
Chi-Hsuan Huang 4592d49cfb Fix tsconfig path 2022-03-29 16:07:09 +08:00
Chi-Hsuan Huang b9eeb4991e Fix reminder-bar.scss lint error 2022-03-29 16:07:09 +08:00
Chi-Hsuan Huang 3e8c3be69d Ignore core js packages from woo admin's eslint 2022-03-29 16:07:09 +08:00
Chi-Hsuan Huang 2c5c7549b5 Fix client lint errors 2022-03-29 16:06:33 +08:00
Chi-Hsuan Huang 4ca1ae0032 Fix paths in tsconfig 2022-03-29 16:06:32 +08:00
Christopher Allford bc12f7a263
Merge pull request #32334 from woocommerce/update/woocommerce-blocks-7.2.1
This pull updates the WooCommerce Blocks plugin to 7.2.1. It is intended to target WooCommerce 6.4 for release. This supercedes https://github.com/woocommerce/woocommerce/pull/32075.
2022-03-28 19:42:45 -07:00
moon f2b03feb24 Update version 2022-03-28 18:14:26 -07:00
moon d915587f5d Update version 2022-03-28 17:55:07 -07:00
moon cda288d327 Update VERSION constant 2022-03-28 17:37:35 -07:00
moon 707b0bd74d Fix typo 2022-03-28 14:01:21 -07:00
moon 4a52285930 Deprecate WC_ADMIN_VERSION_NUMBER constant 2022-03-28 13:55:51 -07:00
Christopher Allford 14e852b4b2
Merge WooCommerce Admin Unit Tests (#32287)
This folds the unit tests from WooCommerce Admin into the core test suite, enabling them to run.
2022-03-28 12:53:33 -07:00
Barry Hughes e12d82ae46
Merge pull request #32376 from woocommerce/remove-php-72-version-bump-notice
Remove the admin notice about the upcoming PHP 7.2 requirement
2022-03-28 06:26:18 -07:00
louwie17 2215c9ab3e
Merge pull request #32347 from woocommerce/add-dev-scripts
Add build-watch command for woocommerce-admin
2022-03-28 08:55:57 -03:00
Nestor Soriano c8280c0aee
Remove the admin notice about the upcoming PHP 7.2 requirement 2022-03-28 10:45:08 +02:00
Lourens Schep 8508a46f31 Update watch command so there are no conflicts between build commands 2022-03-25 10:04:02 -03:00
Chi-Hsuan Huang b43d66f862
Merge pull request #32356 from woocommerce/remove/32352-admin-github-files
Remove unnecessary admin `.github` files
2022-03-25 18:24:55 +08:00
Nestor Soriano d7ee2914b7
Add visibility modifiers to constants in src
PHP 7.2 allows visibility modifiers in constants, so let's add these
to the code in the src directory.

The src/Admin and src/Internal/Admin directories are skipped as
they contain a lot of code and they deserve a separate project.
2022-03-25 11:00:17 +01:00
Chi-Hsuan Huang 554fc86441
Merge pull request #32322 from woocommerce/fix/lint_js-fix
Fix paths and argument forwarding for `script lint:js-fix`
2022-03-25 15:01:10 +08:00
Chi-Hsuan Huang 73cb00907b Remove unnecessary admin .github files 2022-03-25 14:26:37 +08:00
Chi-Hsuan Huang 1295c5052d
Merge pull request #32343 from woocommerce/update/admin-node-version
Update woocommerce admin node version to v16
2022-03-25 13:31:38 +08:00
louwie17 80ec23c425
Merge pull request #32298 from woocommerce/feature/32163_new_task_list_header
Add task list progress header
2022-03-24 16:32:46 -03:00
Lourens Schep 3ebf785665 Fix progress title logic 2022-03-24 15:25:07 -03:00
Lourens Schep 3ced44cc40 Fix task navigation that contains actionUrl 2022-03-24 15:25:07 -03:00
Lourens Schep c934c62351 Address PR feedback and fix some minor issues 2022-03-24 15:25:06 -03:00
Lourens Schep 569e27bf02 Add changelog 2022-03-24 15:25:06 -03:00
Lourens Schep c281ddb820 Add progress header bar to task list experiment 2022-03-24 15:25:06 -03:00
Lourens Schep 9a6c077b69 Add build-watch command for woocommerce-admin 2022-03-24 15:09:15 -03:00
Lourens Schep 4a76505fdf Add comment for woocommerce-reset plugin addition 2022-03-24 14:11:18 -03:00
Lourens Schep 20c0c85f9c Fix admin-e2e-test dependency and add new purchase task E2E test, also added the WooCommerce reset plugin 2022-03-24 14:08:03 -03:00
Barry Hughes 9056be919d
Merge pull request #32332 from woocommerce/fix/32329
Don't change quotes when replacing text domain.
2022-03-24 09:23:54 -07:00
Nestor Soriano 913c6bddb2
Add more "#[\ReturnTypeWillChange]" attributes.
These are needed for the code to be compatible with both PHP 7.x and 8.x
2022-03-24 14:08:18 +01:00
Nestor Soriano fbc77160db
Use CssInliner class instead of Emogrifier class
With the upgrade of the Emogrifier package we can't use the Emogrifier
class, since it was removed in v4 (we need to use at least v5 for
compatibility with PHP 8); so we now use the CssInliner class.

Note that this is a potential breaking change for consumers of the
woocommerce_emogrifier hook, which was getting an Emogrifier object
as parameter (now it gets a CssInliner object, which is partially
compatible).
2022-03-24 14:08:18 +01:00
Nestor Soriano 0f2b717462
Fix calls to deprecated PHPUnit methods in unit tests.
Fix tests where PHPUnit 8 would throw "this method is deprecated
and will be removed in PHPUnit 9, use this other one instead"
warnings, by replacing all those with the proper ones. This will help
once we are able to use PHP 8 (once WP requirement is bumped to 5.9)
2022-03-24 14:08:18 +01:00
Nestor Soriano 5837a53821
Add .phpunit.result.cache to .gitignore
This file is created by PHPUnit v8 when tests run.
2022-03-24 14:08:18 +01:00
Nestor Soriano 01073ec24f
Add return type setUp and tearDown methods in unit tests
After the bump to PHP 7.2 all the setUp and tearDown methods
in unit test classes need to have an explicit "void" return type
declaration.
2022-03-24 14:08:17 +01:00
Nestor Soriano 819494f2ed
Bump WooCommerce minimum required PHP version to 7.2
This includes:

- Changing "Requires PHP" in woocommerce.php
- Changing "require-php" and "config-platform-php" in composer.json
- Bumping pelago/emogrifier to ^6.0 in composer.json
- Bumping maxmind-db/reader to ^1.6 in composer.json
- Bumping composer/installers to ^1.9 in composer.json
  (bump to 2.0 not possible due to conflict with Admin package)
- Removing jobs for 7.0/.1 unit test runs in CI
- Explicitly specifying the PHPUnit version to be 7.5,
  otherwise it will install v8 which isn't compatible with
  WordPress <5.9
2022-03-24 14:08:11 +01:00
Peter Fabian 8cd3a86aaa
Merge pull request #31539 from nagpai/fix/30209
Fix columns in checkout page for TwentyTwenty theme
2022-03-24 10:57:22 +01:00
Chi-Hsuan Huang 096759862f Update woo admin node version to ^16 2022-03-24 16:33:53 +08:00
louwie17 eb081aa9fa
Merge pull request #32320 from woocommerce/add/32161_reminder_bar
Add reminder bar for task list experiment
2022-03-23 17:12:05 -03:00
Lourens Schep 44d9824d47 Fix error when tasks are not defined yet 2022-03-23 14:05:25 -03:00
Lourens Schep 371ce71173 Update completed tasks variable 2022-03-23 13:57:48 -03:00
Josh Betz 8446625b0d
Merge pull request #32073 from woocommerce/reviews-api/add-product-info
Added product name + permalink to the GET Reviews API endpoint response
2022-03-23 11:06:22 -05:00
Peter Fabian f2b534c687 WC Admin is no longer a package 2022-03-23 15:45:21 +01:00
Seghir Nadir 180178044a
Update WooCommerce Blocks package to 7.2.1
This pull updates the WooCommerce Blocks plugin to 7.2.1. It is intended to target WooCommerce 6.4 for release. This supercedes https://github.com/woocommerce/woocommerce/pull/32075.

Details from all the different releases included in this pull:

## Blocks 7.2.1
[Release PR](https://github.com/woocommerce/woocommerce-gutenberg-products-block/pull/6072)
[Testing Instruction](https://github.com/woocommerce/woocommerce-gutenberg-products-block/blob/trunk/docs/testing/releases/721.md)

### Changelog entry

#### The following changelog entries are only those that impact existing blocks and functionality surfaced to users:

#### Bug fixes

- Don't trigger class deprecations notices if headers are already sent [#6074](https://github.com/woocommerce/woocommerce-gutenberg-products-block/pull/6074)

### Changelog entry
> Dev - Update WooCommerce Blocks version to 7.2.1
2022-03-23 15:02:45 +01:00
Rodrigue Tusse e7f822e8eb Changes to class-wc-auth that allows it to work with sso auth 2022-03-23 15:51:42 +02:00
Peter Fabian d7642c7ae7 Don't change quotes when replacing text domain. 2022-03-23 13:50:37 +01:00
Fernando Marichal f276434ea4 Disable welcome modals 2022-03-23 09:11:34 -03:00
anitaamurthy 7603a2c02b Fixed spacing issue 2022-03-23 17:11:09 +05:30
Chi-Hsuan Huang e3d035a624
Merge pull request #32291 from woocommerce/add/32138-ability-for-code-based-notes-to-update
Add ability for code-based notes to update
2022-03-23 17:08:15 +08:00
RJ 04d94d0430
Merge pull request #32327 from woocommerce/dev/publish-wca-packages
Corrected path for publishing commands
2022-03-23 16:07:19 +08:00
rjchow 2d8214af2e Corrected path for publishing commands
- typo in the path in previous commit
2022-03-23 13:30:11 +08:00
Chi-Hsuan Huang 9d7879b254
Merge pull request #32290 from woocommerce/add/primary-arg-back-to-add-action
Add `$primary` param back to add_action method
2022-03-23 11:22:52 +08:00
RJ fc163b6dc9
Merge pull request #32313 from woocommerce/dev/publish-wca-packages
Bump WCA JS packages version numbers in package.json and changelogs
2022-03-23 11:18:04 +08:00
Tomek Wytrębowicz a67188b52e Fix argument forwarding for npm script lint:js-fix.
Redo 7d1a6661f9.
2022-03-22 16:36:17 +01:00
Tomek Wytrębowicz 4714289838 Fix `packages/` path for npm script `lint:js`. 2022-03-22 16:35:12 +01:00
Lourens Schep fdbc2190c0 Update changelog 2022-03-22 12:32:32 -03:00
Lourens Schep 25d6b6d528 Add reminder bar for task list experiment 2022-03-22 12:28:58 -03:00
louwie17 b27618e51d
Merge pull request #32304 from woocommerce/fix/add_feature_config_to_gitignore
Remove feature config from repo and add it to the gitignore
2022-03-22 08:56:38 -03:00
Chi-Hsuan Huang c9e9465802 Update indent 2022-03-22 16:13:22 +08:00
Chi-Hsuan Huang b7cee3e867 Add tests for update_note_field_if_changed method 2022-03-22 16:09:01 +08:00
rjchow 3c0cc02104 Updated WCA package publishing commands
- Updated path for packages
2022-03-22 16:07:36 +08:00
Chi-Hsuan Huang 5b294e4c11 Use in_array to check need_save logic 2022-03-22 15:29:30 +08:00
Chi-Hsuan Huang da241f6c70
Merge pull request #32293 from woocommerce/fix/admin-js-tests
Fix WooCommerce Admin JS unit tests
2022-03-22 14:11:08 +08:00
Chi-Hsuan Huang 1fcdc5b6a2 Update wc admin test command 2022-03-22 11:24:59 +08:00
Chi-Hsuan Huang 3dc5f95254 Update test mocks
Fix lint
2022-03-22 11:24:58 +08:00
Lourens Schep f82d3b7301 Remove feature config from repo and add it to the gitignore 2022-03-21 14:49:44 -03:00
barryhughes cadb25d1cf Amend `generate_generate_<CUSTOM>_html` hook docs. 2022-03-21 10:02:00 -07:00
Luigi Pulcini fc59fa5d5b converted action into filter 2022-03-21 09:47:52 -07:00
LuigiPulcini 6f5a8f4394 Add action hook to generate a custom field type
Adding a `woocommerce_generate_{$type}_html` action hook allows to generate the HTML output of a custom field type for those classes extending the `WC_Settings_API` (e.g. `WC_Email`).
2022-03-21 09:47:52 -07:00
Chi-Hsuan Huang 8ce25e6b1b Change @wordpress/data from devDependencies to peerDependencies
When @wordpress/data is included in devDependencies, all tests mocked @wordpress/data fails
2022-03-21 18:28:56 +08:00
Chi-Hsuan Huang 24595bd2cb Fix jest config paths 2022-03-21 18:28:05 +08:00
Chi-Hsuan Huang ffef8df540 Update possibly_update_note() to update other attributes 2022-03-21 12:03:29 +08:00
Chi-Hsuan Huang 58422dd008 Add $primary param back to add_action method
See https://github.com/woocommerce/woocommerce-admin/pull/8474/files#r829672400
2022-03-21 11:33:50 +08:00
Christopher Allford fdf88c0d94
Updated Core Build Script
Since the smoke and E2E tests don't use `nx` commands to build, we need to make sure
that the command they run builds our dependencies. In the future we should change
all of the scripts and Nx executors to make this all simpler.
2022-03-19 11:42:55 -07:00
Christopher Allford d928a5e1a6 Added missing namespace import 2022-03-18 16:23:00 -07:00