Commit Graph

16248 Commits

Author SHA1 Message Date
Gerhard Potgieter 75e462c448 Do not use array_merge for appending parent to tax classes rather +, array_merge will rewrite numeric keys which we allow for tax class names. 2018-07-27 11:16:28 +02:00
Claudiu Lodromanean 30d34dcf8c
Merge pull request #20910 from woocommerce/fix/tax-rate-non-numeric
Cast tax rate to float so that it can be treated as number further on.
2018-07-26 10:44:56 -07:00
Peter Fabian 9bca5abb40 Cast tax rate to float so that it can be treated as number going forward.
In case no tax rate is specified for the default catch-all tax rate, the tax rate was an empty string which caused a PHP notice when it was later used in arithmetic operations.
2018-07-26 14:32:48 +02:00
Claudio Sanches 575575d280 Fixed reset password cookie when REQUEST_URI includes cyrillic alphabet
WordPress core doesn't try to satinize this either.
See: ae2b929294/wp-login.php (L646)

Closes #20895
2018-07-25 20:33:11 -03:00
Gerhard Potgieter 20a6c40bdf
Merge pull request #20856 from woocommerce/fix/custom-menu-order
Allow custom menu ordering when set by another filter
2018-07-25 13:55:58 +02:00
Claudiu Lodromanean 59de4c7148
Merge pull request #20879 from woocommerce/fix/20671
Update redirect option during activation of MailChimp in Install Wizard.
2018-07-24 11:07:00 -07:00
Claudiu Lodromanean 4c945f2e7e
Merge pull request #20854 from EmranAhmed/master
Prevent JS Issue if `woocommerce_available_variation` filter return false
2018-07-24 10:50:08 -07:00
Claudiu Lodromanean 9886d678bb
Merge pull request #20812 from woocommerce/fix/20804
Do not build paypal pay link when no base country is set.
2018-07-24 10:31:34 -07:00
Claudiu Lodromanean 8cde592c54
Merge pull request #20787 from thenbrent/error_log_file_line
Expand fatal error logging and add file/line number to log entries
2018-07-24 10:28:38 -07:00
Claudiu Lodromanean a0b4a8df03
Merge pull request #20611 from woocommerce/fix/20349
Allow filtering variations by attributes in API.
2018-07-24 10:25:36 -07:00
Claudiu Lodromanean 87acfa731d
Merge pull request #20260 from leglesslizard/master
Set low stock notification threshold per product
2018-07-24 10:23:15 -07:00
Peter Fabian d679a88156 Update redirect option during activation of MailChimp in Install Wizard. 2018-07-24 12:29:10 +02:00
Khan M Rashedun-Naby 90b6f98582 PHPDoc | Return type changed to string from array. 2018-07-20 22:59:41 +06:00
Khan M Rashedun-Naby eb104ecd17 PHPDoc | Return type changed from array to string. 2018-07-20 22:53:16 +06:00
Emran Ahmed f0151ca873
Re-indexing `get_available_variations` method values when `woocommerce_available_variation` filter return false.
### All Submissions:

* [x] Have you followed the [WooCommerce Contributing guideline](https://github.com/woocommerce/woocommerce/blob/master/.github/CONTRIBUTING.md)?
* [x] Does your code follow the [WordPress' coding standards](https://make.wordpress.org/core/handbook/best-practices/coding-standards/)?
* [x] Have you checked to ensure there aren't other open [Pull Requests](../../pulls) for the same update/change?

<!-- Mark completed items with an [x] -->

<!-- You can erase any parts of this template not applicable to your Pull Request. -->

### Changes proposed in this Pull Request:

Re-indexing `get_available_variations` method values.

Suppose you made changed with `woocommerce_available_variation` hook and skip returning some specific variation product with false value. There is `array_filter` function to filter empty values from `get_available_variations` but it keeps index which convert to js object rather then array on `single-product/add-to-cart/variable.php` template variation form `data-product_variations` attribute, and select box dropdown doesn't show. I just added `array_values` PHP function to reindex after `array_filter` function which convert to js array rather then js object before `get_available_variations` function return.

Closes # .

### How to test the changes in this Pull Request:

1. Before approving pull req just return false on a specific variation via `woocommerce_available_variation` filter.
2. Now check that variation product dropdown doesn't show. Because it needs to reindex array.

### Other information:

* [x] Have you added an explanation of what your changes do and why you'd like us to include them?
* [ ] Have you written new tests for your changes, as applicable?
* [x] Have you successfully ran tests with your changes locally?

<!-- Mark completed items with an [x] -->

### Changelog entry

> Enter a short summary of all changes on this Pull Request. This will appear in the changelog if accepted.
2018-07-20 20:14:57 +06:00
Alex Sanford 0e1ec203cd Allow custom menu ordering when set by another filter
This fixes the case where another plugin sets custom menu ordering to be
true, but its filter runs before WooCommerce's filter. Otherwise
WooCommerce's filter will return false, and disallow the other plugin to
customize its menu items.
2018-07-19 17:39:41 -03:00
Emran Ahmed 33949f3c25
Prevent JS Issue if `woocommerce_available_variation` return false for a variation.
After checking some condition if `woocommerce_available_variation` filter return false. Then Option list don't show because of JS issue.
2018-07-20 01:33:25 +06:00
Peter Fabian b9cdc760ac
Merge pull request #20817 from keefyhub/master
Add class names to `edit_category_fields()` to be inline with other f…
2018-07-19 18:45:00 +02:00
Peter Fabian 22059880cd
Merge pull request #20842 from rnaby/180718-221942-wc-data
Unnecessary Variables and Spaces Removed
2018-07-19 13:49:25 +02:00
Khan M Rashedun-Naby 25ab294d40 Unnecessay Spaces Removed 2018-07-19 10:33:22 +06:00
Claudio Sanches 09d50df86b
Merge pull request #20753 from ldybecklee/master
Fix product csv exporter get stock value
2018-07-18 21:23:44 -03:00
Gerhard Potgieter ea2b3f9d7a
Merge pull request #20821 from woocommerce/fix/20718
Pass an instance of the background updater to the db update callbacks
2018-07-18 14:51:12 +02:00
ldybecklee a7de4672dc
Update class-wc-product-csv-exporter.php 2018-07-17 12:10:55 +08:00
ldybecklee 0cf070ed5e
fix method 'get_column_value_stock' 2018-07-17 12:09:34 +08:00
Rodrigo Primo b39b419e5b Pass an instance of the background updater to the db update callbacks
This commit changes the way that WC_Background_Updater::task() calls the database update callbacks and adds the WC_Background_Updater instance as the first parameter to the callbacks. This is used in wc_update_350_order_customer_id() (36b6bd79c0/includes/wc-update-functions.php (L1870)) to monitor memory usage while the function is running. This change was intended to ship with PR #17895 (see commit c77b2f20f4) but was accidentaly removed when merging commit 083c994732 from another PR.

Fixes #20718
2018-07-16 14:24:42 -03:00
Rodrigo Primo bfebd30565
Merge pull request #20726 from itowhid06/master
Convert  hardcoded db prefix to dynamic db prefix. Fixes #20718
2018-07-16 14:21:45 -03:00
Keith Light 4144211754 Add class names to `edit_category_fields()` to be inline with other fields
Class names are added in `add_category_fields()` but not `edit_category_fields()`
2018-07-16 15:24:57 +01:00
Gerhard Potgieter c7884003dc Do not build paypal pay link when no base country is set. 2018-07-16 11:44:58 +02:00
Brent Shepherd 67744b7768 Add 'woocommerce_shutdown_error' action 2018-07-13 17:08:34 +10:00
Brent Shepherd febea645f9 Log error's file and line number
To help with debugging.
2018-07-13 14:23:17 +10:00
Brent Shepherd 0c17fd49e4 Expand error logging to E_ERROR like errors
Including those triggered by code via trigger_error() and compile-time
parse errors (including those generated by Zend Scripting Engine).
2018-07-13 14:21:03 +10:00
Joey 6820de4f2f removed all low_stock additions to api files 2018-07-12 11:55:16 +01:00
Peter Fabian 3fa3830b6c
Merge pull request #20757 from woocommerce/update/wc_get_user_agent
Make wc_get_user_agent respect RFC2616
2018-07-12 11:46:51 +02:00
Claudiu Lodromanean 6dbd5d5323
Merge pull request #20731 from woocommerce/add/20724
Do not load all tables in multisite system status
2018-07-11 13:42:52 -07:00
Gerhard Potgieter f0bd830502 Do not return or store user agent in lower case as HTTP header fields values are case sensitive as per rfc2616 2018-07-11 13:54:14 +02:00
Peter Fabian 47d0bb7b6a Removed variables that are not needed. 2018-07-11 13:44:43 +02:00
Gerhard Potgieter 7fa802071e
Merge pull request #20490 from dezio1900/master
Allow items to be changed in wc_save_order_items function
2018-07-11 12:52:36 +02:00
ldybecklee 327fd26c70
Fix product csv exporter get stock value
seems the original get stock value is wrong, but I'm not sure if my change is correct...
what i'm considering is this line:  if ( $product->is_type( 'variation' && 'parent' === $manage_stock ) ) {
2018-07-11 17:28:50 +08:00
Gerhard Potgieter 3cda8c439c Better table matching on multisite, hat tip to @claudiulodro for pointing me in the right direction. 2018-07-11 11:19:10 +02:00
Claudiu Lodromanean 1ef4aa10a0
Merge pull request #20728 from woocommerce/fix/20708
Add edit_theme_options capability to shop manager role
2018-07-10 12:01:13 -07:00
Claudio Sanches 9b7fbff544
Merge pull request #20686 from woocommerce/fix/20673
Replaced query attribute placeholder with actual value for header link.
2018-07-10 15:22:30 -03:00
Claudio Sanches 4fd6dbd880
Merge pull request #20740 from woocommerce/fix/20224-b
Escape sku input properly for quick edit
2018-07-10 15:22:09 -03:00
Claudio Sanches 3ed4dea4bb
Merge pull request #20723 from woocommerce/fix/20707
Only wordwrap plain emails
2018-07-10 15:21:57 -03:00
Claudio Sanches 1c7b2f3100
Merge pull request #20670 from woocommerce/pr/20669
Deleting a product via API should handle children products regardless of type.
2018-07-10 15:16:13 -03:00
Gerhard Potgieter ac09473853 Escape sku input properly for quickedit 2018-07-10 10:56:49 +02:00
Gerhard Potgieter 36b6bd79c0 Add update routines to recreate user roles 2018-07-10 10:30:11 +02:00
Claudiu Lodromanean af98ef66e7
Merge pull request #20730 from woocommerce/fix/20716
Fix log file deletion
2018-07-09 11:35:45 -07:00
Claudiu Lodromanean 24a1ccf5fc
Merge pull request #20732 from woocommerce/update/20709
Outdated templates notice improvements
2018-07-09 11:27:46 -07:00
Claudiu Lodromanean 4d0890bf3b
Merge pull request #20714 from yratof/yratof-patch-item-name
Added filter on item name in quotes
2018-07-09 11:06:45 -07:00
Claudiu Lodromanean e8a2e19b27
Merge pull request #20648 from woocommerce/update/crud-get-image
Custom tables: Get image from ID, not post thumbnail
2018-07-09 11:04:52 -07:00