Commit Graph

52761 Commits

Author SHA1 Message Date
Barry Hughes 409c36a9e7
Fire HPOS bulk action hook for all custom bulk actions (#38747) 2023-06-16 11:35:25 -07:00
Barry Hughes ad2c156966
Single product tabs: improve compat with GTM and similar | #38711 2023-06-16 11:03:21 -07:00
Ron Rennick ada3031725 merge trunk 2023-06-16 14:50:42 -03:00
barryhughes d70c65c353 Add changelog. 2023-06-16 10:16:11 -07:00
jonathansadowski 178e731b9d
Sync 38702 (#38704)
Squashed commit of the following:

commit 8ccd8e26127594e859b37ead9fd150f05d36d9f5
Author: barryhughes <3594411+barryhughes@users.noreply.github.com>
Date:   Mon Jun 5 19:37:57 2023 -0700

    Do not output payment gateway nonce to unqualified users.

commit 882946bb18dee5eb7ffea48ddfbd4c14a5092c94
Author: barryhughes <3594411+barryhughes@users.noreply.github.com>
Date:   Wed Jun 7 14:24:58 2023 -0700

    Instead of looking for `?wc-ajax`, specifically exempt `admin-ajax.php`.

    This mimics the existing approach used for `admin-post.php` requests, and is stricter by default.

commit 99cffd7cde1aa87176254845c732c91a446232f7
Author: barryhughes <3594411+barryhughes@users.noreply.github.com>
Date:   Tue Jun 6 12:40:21 2023 -0700

    Nonce verification not needed when evaluating ajax properties.

commit 99157d2a18ea78c68c265609dfdd1bddadeee7b2
Author: barryhughes <3594411+barryhughes@users.noreply.github.com>
Date:   Tue Jun 6 12:38:53 2023 -0700

    Document `woocommerce_disable_admin_bar` hook.

commit badcf8f50099dd38fa855d2aa71c8507d3f2a252
Author: barryhughes <3594411+barryhughes@users.noreply.github.com>
Date:   Mon Jun 5 18:49:25 2023 -0700

    Describe expectations around customer access to the dashboard.

commit 127053e1c27e7da5515c6638859fa09384241624
Author: barryhughes <3594411+barryhughes@users.noreply.github.com>
Date:   Mon Jun 5 13:30:03 2023 -0700

    'wc-ajax' requests should be filtered out of admin access logic.

commit 2e8182761e050cc4371181eaa197b6d4b2867f89
Author: Vedanshu Jain <vedanshu.jain.2012@gmail.com>
Date:   Fri May 12 15:15:57 2023 +0530

    Clean up individual escape to also do it again when it is used.
2023-06-16 11:04:45 -05:00
Matt Sherman 9a6d9533c9
Keep showing product editor feedback bar after feedback modal shown (#38773)
* Show feedback bar even after feedback is given

* Changelog
2023-06-16 11:51:18 -04:00
Ilyas Foo 71a039852f
Fix payment gateway suggestions display logic (#38658)
* add: updated payment gateways for 2023 Q3

* Update payment gateway suggestions display logic, better comments and variable names, added core onboarding profiler option to support offline venue, added IN to paypal visibility rule

* Lint

* Update for better WCPay logic

* Remove accidental imports

* Added return object comment

* More lint

* Changelog

---------

Co-authored-by: rjchow <me@rjchow.com>
2023-06-16 23:46:37 +08:00
Ismael Martín Alabarce 9a49ff72da
Update WCPay welcome page incentives (#38689)
* Initial refactor of components

Move out from index every UI component to make it easier to maintain.

* Initial implementation of new design

Some minor adjustments are missing, and I've added a few TODOs to complete later.

* Add changelog entry

* Finish design update

* Compress menu icon

* Add user's first name to heading copy

* Fetch and cache eligible incentive from WCPay API

Sharing its properties under `window.WcSettings.admin`

* Filter `allowed_promo_notes`

To be able to add those form WCPay API request

* Update JS side to use the new shared incentive details

* Ensure we cache requests even if there are no eligible incentives

* Fix a typo in WCPayBanner

* Move incentive preloaded data from wcSettings

to a new window variable which will be only loaded on WCPay welcome page.

* Simplify `has_wcpay` check

* Render sanitized HTML from incentive description

* Update get incentive logic to also cache non success responses

* Add incentive ID to page view track

* Add changelog entry for the onboarding package

* Update used options names

and add them to `get_default_option_permissions

* Differentiate every dismissed incentive

Reuse WCPay welcome page logic for notes display conditions

* Use tos_url instead of tos_link to match response

* Fix incentives endpoint request payload

* Back to preload incentive on admin shared settings

* Move promo notes filter to where it's used

to avoid any possible race conditions.

* Replace every occurrence of `WooCommerce Payments` with `WooPayments`

* Prevent modal large padding-bottom

* Prevent another global style override on modal

* Fix TS error coming from trunk merge

* Fix wrong style property

* Further restrict WCPay incentives to plugin not active and countries supported

* Adjust the meaning of has_wcpay

* Wait for dismiss option update before redirect

to prevent the side menu entry to be visible after redirecting back to WC admin.

* Enforce TOS asterix at the end of incentive description

* Remove underscore from priavate instance var.

* Fix ESLint error

* Fix SCSS linting issues

* Refine `has_wcpay` and `has_orders`

* Enforce consistent WooPayments branding

* Enforce stricter i18n calls with escape

* Update page title to match new branding

* docs: Enforce branding in code docs also

* Remove method that is unreliable to be used outside of onboarding

* Remove unused constant

* Missing new line

Co-authored-by: Ilyas Foo <foo.ilyas@gmail.com>

---------

Co-authored-by: Vlad Olaru <vlad@pixelgrade.com>
Co-authored-by: Ilyas Foo <foo.ilyas@gmail.com>
2023-06-16 16:32:58 +02:00
Daniel Dudzic 382291cd90 Add changelog entry 2023-06-16 15:18:14 +02:00
Daniel Dudzic 641f56072f Site Editor: Load frontend styles. Closes #35495 2023-06-16 15:14:22 +02:00
Ilyas Foo 0a50173976
Fix infinite redirect from homescreen to core profiler (#38768)
* Fix infinite redirect using useEffect to remove unintentional rerendering

* Changelog
2023-06-16 20:28:25 +08:00
Jorge A. Torres 6b86fc64de
Fix selection of multiple orders in HPOS list table (#38749)
* Fix selection of multiple orders in HPOS list table

* Add changelog
2023-06-16 09:10:27 -03:00
Ilyas Foo 1e72bb0401
Allow `plugins_page_skipped` parameter in Onboarding API endpoint (#38764)
* Append plugins_page_skipped parameter to onboarding API

* Changelog

* Rename property to is_plugins_page_skipped and fixed tests

* Changelog

* Fix lint
2023-06-16 18:06:58 +08:00
Tarun Vijwani 1f3022e9e8
Update WooCommerce blocks package to 10.4.2 (#38656) 2023-06-16 13:25:47 +04:00
Tarun Vijwani f896f268e0
Merge branch 'trunk' into update/woocommerce-blocks-10.4.0 2023-06-16 12:27:35 +04:00
Moon 1a42094e5e
Fix Jetpack redirection issue when the auth endpoint returns an invalid url (#38760)
* Return full response from getJetpackAuth

* Add success and errors

* Redirect to Home in case of an error from getJetpackAuth endpoint

* Add changelog

* Use redirectToJetpackAuthPage

* Replace window.location.href with navigateTo

* Fix type issue with getJetpackAuthUrl

* Update plugins/woocommerce-admin/client/core-profiler/index.tsx

Co-authored-by: Chi-Hsuan Huang <chihsuan.tw@gmail.com>

---------

Co-authored-by: Chi-Hsuan Huang <chihsuan.tw@gmail.com>
2023-06-16 00:56:30 -07:00
Samuele Mancuso 740b2a7424
Update plugins/woocommerce/client/legacy/js/frontend/single-product.js
Co-authored-by: Barry Hughes <3594411+barryhughes@users.noreply.github.com>
2023-06-16 09:22:38 +02:00
Moon 630faadb81
Update/implement connect to jetpack (#38674)
* Add install-and-activate-plugins-async action to onboarding

* Add label and learn_more_link types

* Use label and learn_more_link

* Remove unused imports

* ts fixes

* Visual changes on the plugin page

* Change CTA font size from 13px to 14px
* Change spacing between the chebox and logo to 24px
* Change heading font-weight to 500

* Fix css lint error

* Add back learn more link that was removed from rebase

* Add required packages

* Load Jetpack Config

* Add getJetpackAuthUrl to data/onboarding

* Add Connection Rest Auth -- seems like this is required for Jetpack to communicate back to the connected site

* Add jetpack-authorization-url REST API

* Redirect to Jetpack Auth page after the installatino process if jetpack was selected

* Require can_install_plugins permission for jetpack auth url endpoint

* Update packages/js/data/src/onboarding/resolvers.ts

Co-authored-by: Ilyas Foo <foo.ilyas@gmail.com>

* Update plugins/woocommerce/src/Admin/API/OnboardingPlugins.php

Co-authored-by: Ilyas Foo <foo.ilyas@gmail.com>

* Remove automattic/jetpack-sync and its config

* Support redirect_url and from params

* Do not redirect to Jetpack auth if it is already connected

* Add installed_ext_success=1

* Use woocommerce-core-profiler for from value

* Revert unrelated lock file changes

* Minor refactor

* Extracted out isJetpackConnected cond to a guard

* Added meta data for isJetpackConnected to prevent unwanted spinner

* Add Changelog

* Lint fix

* Move Jetpack Connection config init to class-woocommerce

* Add changelog

* Remove unnecessary require

* Note jetpack-authorization-url endpoint is experimental

* Fix broken test

* Add component to sendToJetPackAuthPage state

* Fix lint error

---------

Co-authored-by: rjchow <me@rjchow.com>
Co-authored-by: Ilyas Foo <foo.ilyas@gmail.com>
2023-06-15 20:28:18 -07:00
Paul Sealock 950c25b4a0
Monorepo Setup: Pin phpcs-changed version (#38754)
pin phpcs-changed dependency
2023-06-16 14:04:18 +12:00
github-actions[bot] adb8058b96
Update changelog.txt from release 7.7.2 (#38555)
Prep trunk post release 7.7.2

Co-authored-by: WooCommerce Bot <no-reply@woocommerce.com>
Co-authored-by: Paul Sealock <psealock@gmail.com>
2023-06-16 11:36:36 +12:00
Joshua T Flowers 3ad98ec8b4
Add tool selector option to iframe editor (#38686)
* Add tool selector option to iframe editor

* Fix lint errors
2023-06-15 16:29:12 -07:00
Moon d51f69d2d7
Update track name prefix for core profiler (#38710)
* Use coreprofiler_ prefix

* Add Changelog

* Track name changes

* Rename intro_optin to intro_opt_in

* Extracted out recordFailedPluginInstallations and recordSuccessfulPluginInstallation to tracks

* Fix js lint error -- remove unused import
2023-06-15 13:37:14 -07:00
RJ 723c68e240
fix: core profiler plugins list race condition (#38732) 2023-06-15 12:45:54 -07:00
Jorge A. Torres ebd26bb036 Add changelog 2023-06-15 15:55:34 -03:00
Jorge A. Torres 2415ee9888 Make sure `handle_bulk_actions-woocommerce_page_wc-orders` is fired for all custom actions
Actions starting with “mark_” were silently handled by our own code, preventing 3rd parties from adding their own “mark_” bulk actions and acting on them.
2023-06-15 15:55:21 -03:00
Maikel David Pérez Gómez fe7933e7a9
Implement experiment within code for new users (#38700)
* Configure the expiriment to redirect variation treatment to the new product editor

* Add changelog file

* Fix experiment name

* Fix changelog description
2023-06-15 14:42:57 -04:00
Joshua T Flowers ce770bbfd2
Fix empty state for currency inputs in product editor (#38697) 2023-06-15 09:32:57 -07:00
Nathan Silveira bfd720c28f
Extract usePublishedProductsCount hook and use it in about-the-editor-menu-item (#38742) 2023-06-15 13:03:18 -03:00
Maikel David Pérez Gómez 2471dcba05
Replace 'use classic editor' with 'Turn off the new product editor' in options menu (#38693)
* Options menu in product editor view should show Turn off the new product editor with some subtext

* Record event product_editor_options_turn_off_editor_click when clicking Turn off the new product form menu item

* Add changelog file
2023-06-15 10:55:11 -04:00
Fernando Marichal d74904b1bd
Fix number of orders under tax report (#38525)
* Count unique post_id

* Add changelog

* Fix lint

* Fix Reports table

* Fix lint

* Fix $key
2023-06-15 11:11:10 -03:00
Nathan Silveira 5f94b411f0
Product Editor Onboarding: Add About the editor... option the more menu in product block editor (#38691)
* Add 'About the Editor' menu item

* Show the guide when clicking the menu item

* Add track event when clicking about the editor

* Add changelog

* Remove from product more menu
2023-06-15 10:07:46 -03:00
Matt Sherman 9d7b68b82c
Update product editor tour design (#38726) 2023-06-15 08:23:13 -04:00
Moon e50fb51b26
Set skipped flag when guided setup is skipped (#38730)
* Set woocommerce_onboarding_profile.skipped when guided setup is skipped

* Add Changelog
2023-06-14 21:12:03 -07:00
Moon 1e8bbb2800
Remove StoreDetails task when core-profiler flag is on (#38722)
* Remove StoreDetails task when core-profiler flag is on

* Add Changelog
2023-06-14 20:37:07 -07:00
Barry Hughes bd696c0f90
Update deprecated method call in `tools/create-extension` (#38706) 2023-06-14 17:06:58 -07:00
Corey McKrill 0cea2c6900
Add changelog file 2023-06-14 14:58:16 -07:00
Corey McKrill 446c8c1b0b
Linting: Add pnpm commands and update contributing guidelines
Adds the following pnpm commands for utilizing the new phpcs-changed
composer scripts (see #37465 and #38085):

- `pnpm --filter=woocommerce run lint:php:changes`
- `pnpm --filter=woocommerce run lint:php:changes:staged`
- `pnpm --filter=woocommerce run lint:php:changes:branch`

Also updates the contributing guidelines to make these commands more
discoverable.
2023-06-14 14:52:09 -07:00
Chris Runnells 1e19d186c2
Fix task list header overlap (#38707) 2023-06-14 11:44:30 -10:00
jonathansadowski 9404a7dff3
Update Action Scheduler to 3.6.1 (#38721) 2023-06-14 15:38:11 -05:00
Matt Sherman de6f77d8be
Fix transient notices overlapping product editor footer (take 2) (#38698)
* Use WooFooterItem for Footer

* Use WooFooterItem fill for TransientNotices

* Adjust TransientNotices styling to work in footer

* Fix footer width when in setup wizard

* Change export of TransientNotices from default to named

* Add border to footer

* Changelog

* Changelog

* Mock WooFooterItem to allow unit tests to pass

* Fix lint error in test
2023-06-14 16:32:28 -04:00
Ron Rennick b0c06849a9
Update status only when its changed. (#38696) 2023-06-14 16:50:09 -03:00
Corey McKrill 3595622e09
WC Tracker: Add info about features and plugin compatibility (#38613)
* Adds a data key with the list of WC features that are currently enabled on the site.
* Adds a feature_compat key to each plugin that shows its compatibility with each feature (compatible, incompatible, or uncertain) if the plugin is "WooCommerce aware", otherwise just an empty array.
2023-06-14 12:40:41 -07:00
Corey McKrill 9704873fb6
add HPOSToggleTrait.php to unit test loader (#38684)
This PR fixes two unit test files that could not be run individually by adding HPOSToggleTrait.php to the unit test boot loader. It also does a bit of namespace cleanup in HPOSToggleTrait.php.
2023-06-14 11:03:04 -07:00
Corey McKrill cf3346e739
Test removal cleanup 2023-06-14 10:56:22 -07:00
Corey McKrill 1804d44be1
Remove feature compatibility unit test
The mocks in this test were affecting other unit tests for the
PluginUtil class, but only when run in GitHub actions (the tests were
working fine locally). Rather than hold up this PR, I've created
issue #38720 as a future task to add the unit test back in once we've
figured out if there's something buggy happening with dependency
injection.
2023-06-14 10:49:50 -07:00
Fernando Marichal 47481490d8
CES modal modifications (#38643)
* Add extraFields prop

# Conflicts:
#	packages/js/product-editor/src/components/product-mvp-ces-footer/product-mvp-ces-footer.tsx

* Add changelog

* Add changelogs

* Fix styles

# Conflicts:
#	packages/js/product-editor/src/components/product-mvp-ces-footer/style.scss

* Add extraFields validation

* Remove files

* Add styles and js

* Modify the other share feedback form

* Change modal title

* Fix feedback-bar

* Fix return

* Fix params types

* Rename `extraFields` to `getExtraFieldsToBeShown`

* Fix styles

* Fix error handling

* Fix styles

* Rename prop

* Fix error message
2023-06-14 11:25:51 -03:00
Ron Rennick 0ef06972af Merge branch 'trunk' into fix/hpos-unit-test-trait 2023-06-14 11:01:28 -03:00
Vedanshu Jain e4f3273fb5
Add meta boxes for custom taxonomies in order edit screens (#38676) 2023-06-14 15:47:22 +02:00
Ron Rennick 960fa1035a
Add re-migrate support to HPOS CLI. (#38690) 2023-06-14 10:05:38 -03:00
Nathan Silveira b006eee3ae
Add `wcadmin_settings_change` tracks event when adding/removing entries in shipping (#38465)
* Add support for new properties "added" and "deleted" in settings tracking

* Add calls to actions when adding and deleting shipping zones and classes

* Add changelog

* Cover an edge case where the zone is created through adding a method and add more comments

* Fix lint issues

* Add inline comment explaining if statement
Refactor WC_Settings_Tracking to work with a single action with an additional parameter
2023-06-14 09:25:37 -03:00