Rodrigo Primo
8ebead165e
Replace usages of depracted jQuery.fn.click() event shorthand
...
This commit replaces all instances in WooCommerce codebase (except included third-party libraries) where jQuery.fn.click( handler ) event shorthand was used. This shorthand was deprecated in jQuery 3.3 (see https://github.com/jquery/jquery/issues/3214 ). The jQuery documentation was not updated yet (see https://github.com/jquery/jquery-migrate/issues/288 and https://github.com/jquery/api.jquery.com/issues/972 ).
jQuery.click() was not deprecated and so it was not replaced.
2020-11-18 15:27:46 -03:00
Rodrigo Primo
5c8491c862
Remove jQuery code that does nothing
...
This commit replaces a block of jQuery code that I believe does nothing. I found it while starting the work to make our JS code compatible with jQuery 3 as it uses jQuery.fn.keyup() which has been deprecated.
As far as I can understand, this block of code is supposed to change the focus to the coupon description when the user hits the tab key while the focus is on the title field. It doesn't work because the keyup event is not fired for the tab key. The current behavior is that when the user hits the tab key, the focus changes to the "Generate coupon code" button, and if the tab key is pressed another time, the focus changes to the description text field. Which seems fine to me and that is why I'm suggesting we remove this code instead of fixing it.
I believe it was added in this c15b8e817c
commit six years ago and unfortunatelly the commit doesn't provide much information on why it was added.
2020-11-17 14:39:55 -03:00
Rodrigo Primo
291884e154
Replace all occurrences of jQuery.parseJSON()
...
jQuery.parseJSON() is deprecated (https://api.jquery.com/jquery.parsejson/ ). This commit replaces all of its occurrences with JSON.parse().
2020-10-22 10:11:27 -03:00
Ron Rennick
43051a0950
update deprecation versions to 4.6.0
2020-09-18 13:16:46 -03:00
Ron Rennick
8fe3bcb90e
rebase to current master
2020-08-28 10:59:43 -03:00
Hayden Whiteman
3fca3caf1d
Fix #27413
2020-08-22 19:35:13 +12:00
Ron Rennick
72df8aecfa
updated deprecated version to 4.5.0
2020-08-13 14:46:12 -03:00
Ron Rennick
f0ad8a01be
merge current master
2020-08-13 14:33:07 -03:00
Claudio Sanches
94f8d2d576
Fixed jQuery selector
2020-07-29 19:21:24 -03:00
Claudio Sanches
97c7937fd9
Fixed "Product type" dropdown on WP 5.5
...
WP 5.5 doesn't introduce a <span> tag inside metaboxes headings
2020-07-29 19:12:02 -03:00
Claudio Sanches
7bd34e3545
Merge branch 'master' into fix/25843
2020-07-24 17:04:28 -03:00
Claudio Sanches
e340a20312
Merge pull request #26880 from wpdesk/bugfix/settings-changes-warning
...
Changed settings warning when leaving page
2020-07-14 13:40:05 -03:00
Nestor Soriano
d2787818e3
Rename `quick-edit-warning` style with `wc-` prefix, and add styling.
2020-07-14 16:02:59 +02:00
Nestor Soriano
a33bcaf532
Remove unnecessary phpcs disabler in quick-edit.js
2020-07-14 11:42:22 +02:00
Nestor Soriano
fd34cf76b2
Fix stock status setting for variable products on bulk & quick edits.
...
For bulk edit: even if stock status was left as "No change", the
status of all variations was being changed to whatever the status
of the product was before it was converted to variable. Now
no change is performed when "No change" is selected, and all
variations change to whatever is selected otherwise.
For quick edit: a new "No change" option is added that will be
preselected when the product is variable. Previously, whatever
status the product had before being converted to variable was being
shown, and that's the status that would be set when saving.
Also, a "This will change the stock status of all variations"
message is displayed before the selector.
2020-07-14 11:42:21 +02:00
Nestor Soriano
39e5a1bfb1
Fix code sniffer errors on quick-edit.js
2020-07-14 11:42:21 +02:00
Claudio Sanches
dec50429b4
Merge pull request #25240 from shamalisulakhe/issue-24266-solution
...
Issue 24266 solution - with rerf of
2020-07-01 13:00:58 -03:00
Claudio Sanches
61caec9a24
Fixed coding standards
2020-07-01 13:00:25 -03:00
Claudio Sanches
d74b73f014
Merge pull request #26558 from woocommerce/fix/26555
...
Fix tooltip flashing
2020-07-01 12:47:14 -03:00
Grzegorz Rola
598100eeb0
Settings lost warning should be shown always.
2020-06-26 10:52:28 +02:00
Claudio Sanches
f4d11c89f3
Merge branch 'master' into issue-24266-solution
2020-06-23 16:47:30 -03:00
Claudio Sanches
a008e8a9ac
Fixed coding standards
2020-06-23 16:40:53 -03:00
Ron Rennick
aaae319a65
deprecate wc-setup
2020-06-23 15:29:58 -03:00
Claudio Sanches
b4ab40ae34
Adds a prompt to confirm if should run tools in the Status page.
2020-06-01 18:56:38 -03:00
David Stone
4486f06cda
Use keepAlive for better user experience
...
keepAlive lets the user hover over the tooltip without closing it.
closes # 26555
2020-05-19 14:40:56 -06:00
Christopher Allford
0d6675b490
Corrected ESLint violations in JS files
2020-05-04 20:49:29 -07:00
Christopher Allford
1358cca6d1
Revert "Improved performance when saving variations"
2020-03-17 08:55:09 -07:00
Christopher Allford
6ca7b9fa4a
Merge pull request #25382 from smachi/master
...
Improved performance when saving variations
2020-02-05 13:14:13 -08:00
Peter Fabian
b85d314d5d
Find the correct form element to update.
...
Previously it just found the first one, which made the second checkbox buggy.
2020-01-31 12:45:08 +01:00
Salva Machí
c4a7e19534
Refactory: code style
2020-01-31 09:23:28 +01:00
Salva Machí
d1dc5f8c20
Bypass inputs without name
2020-01-13 11:31:20 +01:00
Salva Machí
2ca6c12089
Bypass unchecked radio buttons, unchecked checkboxes and disabled inputs
2020-01-13 10:24:12 +01:00
Salva Machí
37d7d498ec
Improved performance when saving variations
...
The serializeJSON function was causing a long delay when preparing the JSON if there are many input fields within the variations (even worse if 3rd party plugins add their own extra fields there too).
2020-01-10 11:38:38 +01:00
Shamali Sulakhe
ec09daeadc
Merge remote-tracking branch 'upstream/master' into issue-24266-solution
2019-12-16 15:11:07 +05:30
Shamali Sulakhe
e5e9d440a4
Merge branch 'master' of https://github.com/shamalisulakhe/woocommerce into issue-24266-solution
2019-12-16 15:08:30 +05:30
Claudio Sanches
104f40c36e
Merge pull request #24281 from woocommerce/fix/24269
...
Handle multiple decimal points
2019-12-09 14:07:29 -03:00
Claudio Sanches
5dac360e8a
Merge pull request #24208 from woocommerce/fix/order-screen-tax-calculation-to-honor-rounding-setting
...
Honor tax rounding preference in edit item and refund flows
2019-12-05 20:52:48 -03:00
Gerhard Potgieter
7d39222334
Merge pull request #25162 from woocommerce/fix/24018
...
Hid variable parent products from "Add Products" search on order page
2019-12-05 14:22:43 +02:00
Christopher Allford
d1e25c9118
Added support for excluding certain product types from AJAX product searches
2019-12-03 14:14:47 -08:00
Paul Dechov
7f65a33fe8
Honor tax rounding preference in edit item and refund flows
...
The default value ('no') of the setting to round taxes at subtotal was not being honored on the Edit Order screen, which resulted in off-by-one discrepancies between the checkout item total and the edited or refunded item total.
This change is to round to the proper precision (w.r.t. the 'woocommerce_tax_round_at_subtotal' setting) for the default value of the form, as well as when the values are dynamically recomputed.
2019-11-25 17:49:43 +05:30
Justin Shreve
18925f2218
Adds an a/b test for the new onboarding experience
2019-11-21 12:00:04 -05:00
Shamali Sulakhe
64fbb197d7
Removed patch file and merged changed with ver 3.9.0-dev
2019-11-15 17:58:54 +05:30
Mehidi Hassan
3f8e3fdb2d
Add space before parentheses of if condition for JS consistency
2019-10-10 23:37:56 +06:00
Claudio Sanches
9851b1f0f3
DRY
2019-10-03 21:19:52 -03:00
Gerhard Potgieter
ee1b438c3c
Merge pull request #24517 from woocommerce/fix/24511
...
Control categories export field based on export type
2019-09-30 15:39:21 +02:00
Justin Shreve
0c3fc315c5
Update tracking opt-in UI.
2019-09-24 14:26:21 -04:00
Claudio Sanches
08e9d0bdc9
Control categories export field based on export type
2019-08-27 16:11:05 -03:00
Claudio Sanches
2b0fc6f50a
Added sanitization for number of decimal points in JS
2019-08-02 14:02:33 -03:00
Claudio Sanches
375b989322
Added validation for multiple decimal points
2019-08-02 13:58:02 -03:00
Gerhard
02f9c7c8ff
Use strict checking
2019-08-02 14:55:17 +02:00
Gerhard
34e883ce81
Apply patch by @dtwist
2019-08-02 14:19:37 +02:00
Hardik Thakkar
27689ba0ca
Fixed #23870
2019-08-02 14:10:39 +02:00
Gerhard Potgieter
7c0d0251ee
Merge pull request #23883 from woocommerce/add/new-edit-order-tracks
...
Track more events on the edit order screen for future design validation.
2019-07-15 09:36:01 +02:00
haszari
3e7da11c30
fix logic for new tab check on edit product page
2019-07-12 13:42:36 +12:00
haszari
5bac98fd80
open marketplace suggestions links in same tab to simplify experience:
...
- except when inconvenient - when editing a product
2019-07-12 13:42:36 +12:00
haszari
46f2b98bca
add in-app-purchase url params to marketplace suggestions buttons
2019-07-12 13:42:35 +12:00
Claudio Sanches
5b8694e92a
Merge pull request #23915 from woocommerce/fix/23544
...
[Setup] Make PostCode optional as few countries don't use them
2019-07-10 15:45:32 -03:00
Claudio Sanches
d18c3f8ed1
Merge pull request #24069 from woocommerce/add/coupon-code-generator
...
Add generate coupon code button
2019-07-09 16:50:24 -03:00
Claudio Sanches
18b876a95c
Always load generate code button
...
Some improvements in the button label and names
2019-07-09 16:46:17 -03:00
vedanshujain
e2577b3a06
[Setup] Make PostCode optional as few countries don't use them
...
Some countries like Hong Kong, UAE etc don't use post codes, in which case this commit will make the field optional.
If its not known whether a country uses postcode or not, it will be required.
2019-07-09 14:37:03 +05:30
Gerhard
7038c73ab4
Merge branch 'master' into update/exclude-compiled-assets-from-git
2019-07-09 10:57:40 +02:00
Rodrigo Primo
a26f38f3a1
Merge pull request #23133 from woocommerce/update/23111
...
If variations are missing prices, show notice
2019-07-04 10:08:41 -03:00
Gerhard
5d604329fc
Reword postfix to suffix
2019-07-04 09:07:02 +02:00
Gerhard
538edcaac0
Make button text translatable.
2019-07-03 22:57:08 +02:00
Gerhard
24fc4948c0
Add generate coupon code button for quick coupon code generation.
2019-07-03 22:48:30 +02:00
Peter Fabian
9671810159
Added event to track `Add item(s)` button click.
2019-06-27 13:22:19 +02:00
Peter Fabian
7b03fe62f3
Added event to track `Add fee` button click and Cancel in the prompt.
2019-06-27 13:21:37 +02:00
Peter Fabian
90c0954d21
Renamed add_fee event to added_fee.
...
Makes it consistent with e.g. coupon addition tracks.
2019-06-27 13:20:03 +02:00
Peter Fabian
7ef4cb637a
Fixed spacing issue.
2019-06-27 13:19:24 +02:00
Peter Fabian
930fd983cb
Merge branch 'add/new-edit-order-tracks' of https://github.com/woocommerce/woocommerce into add/new-edit-order-tracks
2019-06-07 14:59:11 +02:00
Peter Fabian
34c6933586
Added more params to the tracks.
2019-06-07 14:58:55 +02:00
Jeff Stieler
1bd9a7d9a7
Use a consistent tracks event naming scheme.
2019-06-07 12:31:42 +02:00
Peter Fabian
083c616f18
Added tracks to record when order note is added in edit order screen.
2019-06-07 12:04:38 +02:00
Peter Fabian
b880159dbe
Added tracks to record when products, fees, taxes or shipping are added to order in edit order screen.
2019-06-07 11:39:03 +02:00
Jeff Stieler
02785bc14c
Track adding coupons to orders on edit screen.
2019-06-07 11:31:53 +02:00
Jeff Stieler
02a7654532
Fix eslint errors/warnings.
2019-06-07 11:25:39 +02:00
Jeff Stieler
05ad6b260f
Track interaction with the order refund UI.
2019-06-06 18:18:46 +02:00
Peter Fabian
b22c788081
Added tracks for Recalculate button and edit/remove/save line items.
2019-06-06 18:14:21 +02:00
Jeff Stieler
a22c1dabf3
Track when billing or shipping address edit buttons are clicked.
2019-06-06 16:12:09 +02:00
Jeff Stieler
9776cbc2d8
Track order tax column deletion.
2019-06-06 13:18:29 +02:00
Rodrigo Primo
3d12ec4ae2
Remove extra comma to prevent issues with older versions of IE
...
This commit simply removes an extra comma that was added in
52fced8d7a
to prevent issues with older
versions of IE. I found this when running grunt to prepare the 3.6.4
release:
```
Running "jshint:all" (jshint) task
assets/js/admin/meta-boxes-order.js
413 | user_email : user_email,
^ Extra comma. (it breaks older versions of IE)
```
We might want to add jshint to the pre-commit hook and to Travis.
2019-05-27 14:38:54 -03:00
Gerhard Potgieter
b2ed079520
Manual orders coupon usage limits by email ( #23775 )
...
* Add functionality to wp-admin order to check for coupon usage based on email addresses, similar to how WC_Cart handles this seperately, included unit tests.
* Only do the coupon by email usage check if order is from a guest. Fix issue with unit test.
2019-05-27 11:45:29 -03:00
Claudio Sanches
17da960abe
Merge pull request #23137 from woocommerce/fix/23051
...
Change coupon amount field type based on coupon type
2019-05-22 21:19:03 -03:00
Gerhard Potgieter
229675c96a
Merge pull request #23603 from Chirag3119/23602
...
#23602 - I have fixed issue.
2019-05-16 14:05:45 +02:00
Gerhard
b79c02658d
Fix eslint for meta-boxes-product-variation.js
2019-05-13 13:36:21 +02:00
Gerhard
b77c7fbbd8
Trigger input_changed function when download files removed for variations.
2019-05-13 13:32:30 +02:00
Gerhard Potgieter
984357fb41
Merge pull request #23597 from woocommerce/fix/23509
...
Added confirmation before saving empty list of countries to sell to.
2019-05-10 10:56:13 +02:00
Gerhard
411e963b00
Remove all admin minified js files
2019-05-07 10:19:02 +02:00
Chirag3119
58c3374276
#23602 - I have fixed issue.
2019-05-03 15:02:55 +05:30
Claudio Sanches
eba7940228
Fixed jshint errors
2019-05-02 19:20:33 -03:00
Peter Fabian
98edbd2f78
Added confirmation before saving an empty list of countries to sell to in general WC settings.
2019-05-02 21:26:29 +02:00
Peter Fabian
e647e4143a
Fixed linter problem.
2019-05-02 21:22:36 +02:00
Hardik Thakkar
be40faba61
Fixes #23440 : # symbol in Product Category name breaks Reports CSV export
2019-04-23 18:19:17 +05:30
Mike Jolley
6579972fd3
Minify
2019-04-16 14:36:37 +01:00
Mike Jolley
4e4e084e0f
min
2019-04-16 14:33:09 +01:00
Mike Jolley
0602f45096
Add props using jquery when creating state fields
2019-04-16 14:32:50 +01:00
haszari
7ede25add7
use admin_url to generate manage suggestions url (support multisite etc)
2019-04-10 12:16:49 +12:00
haszari
cd9101bb58
fix target url of 'Manage Suggestions', settings are now in 'Advanced'
2019-04-10 12:02:09 +12:00
haszari
164eca6270
reinstate `displayed` event for suggestions not displayed in metabox:
...
- add func defining which suggestions contexts are hidden/revealable
- reinstate tracks event when rendering suggestion (for non-hidden
suggestions)
- add check in (context-sensitive) tab click handler to abort if
that context has already fired displayed events
2019-04-10 09:40:06 +12:00
Jeff Stieler
742b3d6b66
Only track product page marketplace suggestions when visible.
2019-04-09 10:23:02 -06:00