Commit Graph

567 Commits

Author SHA1 Message Date
Nestor Soriano 52eed70f04 Add a 'NumberUtil' class with a 'round' method.
There's a number of places in the WooCommerce codebase where the
built-in function 'round' is executed passing a non-numeric value
(not a number and not a string that can be parsed as a number),
for example round(''). In PHP 7 this yields a value of 0, but in
PHP 8 this throws an error.

This commit adds a 'NumberUtil' class with a static 'round' method,
this method checks if the passed value is numeric and if so it just
executes the built-in function, otherwise it returns 0. And all the
calls to 'round' in the codebase are replaced with 'NumberUtil::round'.
2020-10-01 11:08:51 +02:00
Rodrigo Primo 197e8d274c
Merge pull request #27616 from woocommerce/fix/26960
Paypal gateway: protect code against a fatal error if WooCommerce is unable to communicate with PayPal
2020-09-18 09:34:57 -03:00
Claudio Sanches 3377c60c5e
Merge pull request #27433 from woocommerce/fix/remove-relative-include-paths
Change relative include paths to absolute include paths
2020-09-17 13:15:40 -03:00
Rodrigo Primo 3aed780443 Paypal gateway: protect code against a fatal error
This commit changes the order of the error handling check to protect the code against a possible fatal error if wp_safe_remote_post() returns an instance of WP_Error().
2020-09-08 16:57:48 -03:00
Claudio Sanches c4ccc38780 Fixed use __DIR__ for relative paths 2020-08-26 18:46:44 -03:00
Brent Shepherd a2e2d63265 Rename PayPal to PayPal Standard
In the admin area, not the front-end of the site.

Fixes #27467
2020-08-25 12:25:44 +10:00
Claudio Sanches d48f1d4e2e Fixed package tag usage 2020-08-05 13:36:24 -03:00
Szabolcs Légrádi 5174baca35
Extend BACS accounts filter with order ID 2020-07-06 13:36:24 +02:00
Christopher Allford b5d5be7df1 Removed the admin screen checking in favor of good old fashioned request parameters for COD gateway setting loading 2020-02-06 12:29:01 -08:00
Christopher Allford 30fd538acf Added function_exists check to COD gateway settings check 2020-02-06 10:03:26 -08:00
Christopher Allford 8140f7e0a1 Extracted shipping method loading for COD field into its own method 2020-02-05 06:59:02 -08:00
Christopher Allford 2f024ff024 Added tab check to COD gateway options loading 2020-02-05 06:49:33 -08:00
Christopher Allford b9ceabaa52 Utilized the constants package to fix the failing tests 2020-02-04 15:50:23 -08:00
Christopher Allford 1d15df860e Merge branch 'master' into fix/25438.2 2020-02-04 15:06:26 -08:00
Christopher Allford 4ae1e1f5fc Extracted the repetitive Constants::get_constant( 'WC_VERSION' ) calls where possible 2020-02-04 14:02:57 -08:00
Christopher Allford 1d1413b4ee Replaced direct access of many constants with the Constants library 2020-01-31 22:18:47 -08:00
Christopher Allford 6ad091a9b7 Changed all of the constant accesses into corresponding Automattic\Jetpack\Constants usages 2020-01-28 21:21:29 -08:00
Christopher Allford bb09a8a4ea Prevented the COD payment gateway's "enable_for_methods" option loading outside of correct use-cases
Note: The tests fail in this commit because of the defines. Ran individually there are no problems, but I'm going to make another PR to merge in a package to make testing constants possible, and then come back to fix this after it gets merged.
2020-01-28 14:33:53 -08:00
Peter Fabian 30dde8f53c The JS might still be needed as merchants can manage/change settings even for a disabled gateway. 2020-01-28 14:13:03 +01:00
Peter Fabian 217c9d2adc Fix incorrect comment. 2020-01-28 14:10:10 +01:00
Peter Fabian 8600987591 Functions are not needed when the gateway is disabled. 2020-01-28 14:07:50 +01:00
Peter Fabian dc9d4496e9 Require order object to prevent error. 2020-01-28 14:06:02 +01:00
Rodrigo Primo f06ad5d78a Replace removed WordPress.Security.NonceVerification.NoNonceVerification
WordPress Coding Standard 2.0 removed the sniff
WordPress.Security.NonceVerification.NoNonceVerification:

```
The WordPress.Security.NonceVerification sniff used the same error code for both an error as well as a warning.
The old error code NoNonceVerification is no longer used.
The error now uses the Missing error code, while the warning now uses the Recommended error code.
```

(from
d45f5e5cf3/CHANGELOG.md (200-rc1---2018-12-31))

This commit updates WooCommerce code and replaces all instances where WordPress.Security.NonceVerification.NoNonceVerification verification was used with either WordPress.Security.NonceVerification.Missing or
WordPress.Security.NonceVerification.Recommended. In a few cases WordPress.Security.NonceVerification.NoNonceVerification was used but was not needed, so instead of replacing the sniff, the line was removed. In two other cases, I removed other unrelated sniffs that were not needed.
2019-12-13 17:45:32 -03:00
Claudio Sanches 2453dc9fe1 Fixed check for the method 2019-10-02 14:36:05 -03:00
Claudio Sanches 4c023c5e8a Changed thank you page text to follow PayPal guidelines
Also fixed coding standards
2019-10-02 14:21:12 -03:00
Claudio Sanches 3c9b9ac6a0 Revert changes from PayPal 2019-10-02 14:20:13 -03:00
Claudio Sanches 20ee6c7aed Fixed coding standards 2019-10-02 14:18:03 -03:00
Claudio Sanches b655af2e3b Changed thank you page text to follow PayPal guidelines 2019-10-02 14:17:25 -03:00
Rodrigo Primo b63ecca450
Merge pull request #24249 from miguelfspinto/patch-2
Avoid duplicated process for IPN and PDT payment
2019-09-24 17:59:56 -03:00
Rodrigo Primo e7b8e3ed7b Fix typo in order note
PR #24501 fixed a typo in a order note string. This commit fix the same
problem in another place where the same string is used.
2019-08-30 10:01:55 -03:00
Miguel Pinto 60ac27ba3e
Update class-wc-gateway-paypal-response.php 2019-08-27 22:30:33 +01:00
Mithu A Quayium fa62be3fa1
Typo fix in line: 428
The string "Payment could not captured" in line:428 should be "Payment could not be captured" instead, since it is appropriate grammatically.
2019-08-26 11:32:40 +06:00
Miguel Pinto ae4eba45ec
Update class-wc-gateway-paypal-response.php 2019-08-01 16:19:17 +01:00
Miguel Pinto 77f4a3e25b
Update class-wc-gateway-paypal-response.php 2019-07-31 09:48:41 +01:00
Miguel Pinto de978dad28
Update class-wc-gateway-paypal-response.php 2019-07-30 21:31:55 +01:00
Miguel Pinto d7b54ccb35
Update class-wc-gateway-paypal-response.php 2019-07-30 20:56:43 +01:00
Miguel Pinto ce4f0edc3a
Avoid duplicated process for IPN and PDT payment
Currently, Woocommerce is processing twice the payment when IPN and PDT notifications are enable. This mean that stock is reduced twice.
2019-07-29 09:25:30 +01:00
Gerhard 70231461b2 Refactor logic for passing no_shipping, it should only be passed when no shipping items are available. 2019-05-21 08:11:36 +02:00
Gerhard 8332bed7bc Do not pass no_shipping when not using send shipping address options in paypal, it still needs to use the billing details. 2019-05-20 14:59:48 +02:00
Gerhard af678dfc84 Switch paypal capture_payment method to use woocommerce_order_status_processing and woocommerce_order_status_completed instead to avoid issues with custom from status transitions.
Update get_post_meta usage with $order->get_meta instead.
2019-05-07 12:57:59 +02:00
David Jensen 9b58e68e85 Remove html tags from product name in request to PayPal 2019-04-12 12:36:30 -07:00
Claudio Sanches e5e64d1618 Apply wc_sanitize_phone_number in WC_Gateway_Paypal_Request 2019-03-07 14:08:40 -03:00
Mike Jolley 55b27a2afc Adjust calling code prefix logic in paypal 2019-03-06 12:33:46 +00:00
Mike Jolley 65c0169726 Merge branch 'master' into fix/21110 2019-03-06 12:25:12 +00:00
Mike Jolley 4330b2eb38 Update calling code handling 2019-03-06 12:25:06 +00:00
Mike Jolley 49065c0d1a Add meta data, before changing order status 2019-02-27 14:50:37 +00:00
Mike Jolley 7306bf6382
Merge pull request #22763 from woocommerce/fix/paypal-bn-code
Move PayPal BN partner ID
2019-02-19 09:42:05 +00:00
Mike Jolley 8abe75f36d Merge branch 'fix/21463' 2019-02-18 17:20:48 +00:00
Mike Jolley 3ededc2a07 Move BN partner ID 2019-02-18 16:29:29 +00:00
Mike Jolley f0675781c8 Include calling code in pp request 2019-02-08 11:10:26 +00:00