Néstor Soriano
c15488d840
Merge pull request #27830 from woocommerce/php8/fix-round-function-with-non-numeric-argument
2020-10-09 08:01:44 +02:00
Christopher Allford
f9ef91adc1
Merge pull request #27836 from woocommerce/packages/api/add/repository-listing
...
@woocommerce/api: Added list() repository operation and classes for managing store settings
2020-10-08 13:20:12 -07:00
Christopher Allford
1d0cbc8187
Merge branch 'master' into packages/api/add/repository-listing
2020-10-08 11:48:22 -07:00
Ron Rennick
31001036c9
Merge branch 'master' into fix/25962
2020-10-08 15:30:25 -03:00
Néstor Soriano
e4b78cedbf
Merge pull request #27748 from woocommerce/remove-leftovers-from-improved-filtering-by-attribute-for-variations
...
Remove leftovers from the reverted improved filtering mechanism for variations
2020-10-08 15:45:09 +02:00
Néstor Soriano
ab529835fa
Merge pull request #27840 from woocommerce/php8/fix-required-parameters-after-optional
...
[PHP 8] Convert optional-before-required parameters into required parameters
2020-10-08 14:22:52 +02:00
Nestor Soriano
ac0641d02a
Fix a couple of incompatibilities with NumberUtils::round
...
- Passing a string that represents a number but has spaces (e.g. ' 1 ')
now works as expected (the number is properly interpreted)
- Passing the boolean true now returns 1, not 0
- Passing an object throws an error, instead of returning 0
2020-10-08 13:13:53 +02:00
Nestor Soriano
b71f876cba
Reintroduce the dependency injection related code.
...
After the League's Container package has been reintroduced, all the
code that implements the dependency injection mechanism in woocommerce
can be brought back as well.
2020-10-08 09:28:05 +02:00
Néstor Soriano
3e6861189e
Merge pull request #27848 from woocommerce/php8/remove-useless-test-assertion
...
[PHP 8] Remove a useless test assertion that fails in PHP 8
2020-10-08 09:06:39 +02:00
Ron Rennick
3a980a1241
merge current master
2020-10-07 03:17:38 -03:00
Ron Rennick
84fdfb6769
merge master
2020-10-07 03:05:04 -03:00
Julia Amosova
aac4db94b2
Merge pull request #27679 from woocommerce/packages/e2e/config-functions
...
add eslint & babel config functions to e2e-environment
2020-10-06 14:15:56 -04:00
Ron Rennick
df60bfb054
Merge pull request #27276 from woocommerce/fix/docker-ssh
...
Fix e2e docker:ssh command to work in any repo
2020-10-05 09:51:56 -03:00
Ron Rennick
610e787a86
package lock maintenance
2020-10-05 09:31:48 -03:00
Ron Rennick
5139c73029
allow running named test files that don't match test spec pattern
2020-10-05 09:16:27 -03:00
Christopher Allford
3558a9a025
Fixed a bug caused by differences in the URL when creating signatures on the client and server
2020-10-02 16:34:07 -07:00
Christopher Allford
6b5ff6d494
Fixed a bug that would cause Axios errors to be consumed by interceptors
2020-10-02 15:37:09 -07:00
Christopher Allford
b74adf215a
Adjusted the error mechanism to better follow the standard practice of rejecting HTTP errors
2020-10-02 14:10:24 -07:00
Nestor Soriano
ed33a607a7
Remove a useless test assertion that fails in PHP 8
...
The assertion is useless (the constant is already tested a few Lines
above), and it was failing in PHP 8 because 'auto' < 2 is evaluated
as false, while it's evaluated to true in PHP 7.
2020-10-02 15:27:26 +02:00
Nestor Soriano
7485b9165f
Convert optional-before-required arguments to required.
...
In PHP 8 required parameters after optional parameters in
function/method signatures trigger a deprecation notice. These type
of parameters are pointless since a value needs to always be
provided for them anyway, so they are actually de-facto required.
This commit converts all these not-so-optional parameters into
truly required parameters by removing their default values.
2020-10-02 09:45:09 +02:00
Christopher Allford
54b876fc75
Adjusted the typing of the ModelRepository and related interfaces to better distinguish between parent & child models
2020-10-01 18:06:34 -07:00
Christopher Allford
8f5ff436a2
Added support for flat parents to simplify calls with them
2020-10-01 17:48:37 -07:00
Christopher Allford
a01da2da93
Updated the lock files
2020-10-01 16:04:03 -07:00
Christopher Allford
e6efbdde34
Merge branch 'master' into packages/api/add/repository-listing
2020-10-01 15:58:48 -07:00
Christopher Allford
8ee89eb85d
Documentation fixes
2020-10-01 15:53:30 -07:00
Christopher Allford
cfa20570c1
Added appropriate HTTP errors to REST repository methods
2020-10-01 15:37:58 -07:00
Christopher Allford
f8574bed56
Added a utility service for updating settings
2020-10-01 15:23:46 -07:00
Christopher Allford
f0ad6e4fc2
Added aliases to make repository types easier to read
2020-10-01 15:00:27 -07:00
Christopher Allford
787040db4c
Adjusted the ModelRepository to make repository methods more type-safe
2020-10-01 14:31:55 -07:00
Christopher Allford
f2dda16c40
Updated lock files
2020-10-01 14:28:14 -07:00
Ron Rennick
c17b6b5ad0
Update expected industry count
2020-10-01 14:46:04 -03:00
Ron Rennick
4af90518da
lock file maintenance
2020-10-01 14:21:40 -03:00
Ron Rennick
8910357437
add missing test stubs
2020-10-01 10:25:22 -03:00
Nestor Soriano
52eed70f04
Add a 'NumberUtil' class with a 'round' method.
...
There's a number of places in the WooCommerce codebase where the
built-in function 'round' is executed passing a non-numeric value
(not a number and not a string that can be parsed as a number),
for example round(''). In PHP 7 this yields a value of 0, but in
PHP 8 this throws an error.
This commit adds a 'NumberUtil' class with a static 'round' method,
this method checks if the passed value is numeric and if so it just
executes the built-in function, otherwise it returns 0. And all the
calls to 'round' in the codebase are replaced with 'NumberUtil::round'.
2020-10-01 11:08:51 +02:00
Nestor Soriano
b1e81d02da
Fix code style/sniffer errors in a few files.
2020-10-01 11:08:51 +02:00
Christopher Allford
f6cbab8d07
Added missing static helpers for fetching repositories
2020-09-30 13:16:46 -07:00
Christopher Allford
fccf1fb66e
Added settings and group repositories with some basic functionality
2020-09-30 13:11:31 -07:00
Ron Rennick
be15429c30
restore ability to run individual tests
2020-09-30 17:05:02 -03:00
Ron Rennick
72219b2323
move merchant tests to package
2020-09-30 14:41:31 -03:00
Christopher Allford
4c2637c479
Added a `list` operation to the repository
2020-09-30 07:59:10 -07:00
Christopher Allford
f571324a09
Added better type-safety when distinguishing between resources that are children and those that are not
2020-09-29 18:40:50 -07:00
Ron Rennick
76f591251a
move front end tests to package
2020-09-29 17:00:34 -03:00
Ron Rennick
27e79f465f
split activation, onboarding, setup tests into separate files
2020-09-29 16:16:43 -03:00
Christopher Allford
8c5548d06e
Added @template JSDoc tag to API package for better IDE support
2020-09-29 12:00:09 -07:00
Ron Rennick
1abbe3f273
initial core test package files, move setup tests to package
2020-09-29 15:22:20 -03:00
Ron Rennick
fd60f7052a
Merge branch 'master' into fix/e2e-url-no-port
2020-09-28 16:15:22 -03:00
Christopher Allford
ef93f22321
Moved the product model for consistency with other model types
2020-09-25 14:08:19 -07:00
Christopher Allford
789773c65c
Fixed E2E test
2020-09-25 14:05:11 -07:00
Christopher Allford
44c7428358
Updated package lock files and fixed test error
2020-09-25 13:49:54 -07:00
Christopher Allford
760b0e4cdb
Merge branch 'master' into packages/factories-to-api-refactor
2020-09-25 13:19:36 -07:00