Commit Graph

43 Commits

Author SHA1 Message Date
Cesar Rodas 8c64631041 Remove whitespace added by mistake 2017-04-26 02:59:16 -04:00
Cesar Rodas 38f379a7d7 Make get_item() consistent (like get_items())
Right now get_item() is loading an item from the database directly. It doesn't
take advantage of our cache and it doesn't check if the item is already loaded in memory.

There is also another bug (or feature?) that it will let you load any item, even if the item is not related to the current order. I believe this is a bug, if somebody really wants to load any item regardless of the order they should use `WC_Order_Factory::get_order_item`.

Another bug is that items loaded with get_item() are not related to the order object, therefore any calls to Order::save() won't persist the changes made to the item.

This commits makes sure the item returned by get_item is loaded similarly like get_items() does, taking advantage of the cache and the $items protected property (chances are the item is already in memory, ready to be used).

If a given item is not found false will be returned. If item exists but it is not related to the current object it will return false as well (If this behaviour is wanted, I can easily change it load the item anyways instead of returning false).
2017-04-26 02:54:14 -04:00
Mike Jolley c4c8edee5f Remove order and product factory cache 2017-03-21 23:37:38 +00:00
Jeroen Sormani 9724bcd698 Change filter 'get_order_item_classname' to have $id 2017-03-20 21:42:57 +01:00
Jeroen Sormani d07d32c3d2 Add empty/not-false
Ref: https://github.com/woocommerce/woocommerce/pull/13665/files#r106967582
2017-03-20 20:17:49 +01:00
JeroenSormani 373bdda4f8 Add required filters to allow custom order item types 2017-03-20 10:37:06 +01:00
Claudio Sanches 59c2849736 Changed version 2.7 to 3.0 2017-03-15 13:36:53 -03:00
Mike Jolley 1a8737fdeb Standardize cache group names 2017-03-02 17:15:39 +00:00
Mike Jolley 7ff301e2ca Merge branch 'master' into crud-perf-tweaks
# Conflicts:
#	includes/data-stores/class-wc-order-item-data-store.php
2017-02-09 12:31:25 +00:00
Justin Shreve 65b99bf240 moved order item type check to order item data store 2017-02-08 11:42:36 -08:00
Justin Shreve ae5293aeb9 Move the get type logic out of the product factories and into the data stores. 2017-02-08 11:18:39 -08:00
Mike Jolley 3529d7cafd Cache items 2017-02-01 14:54:18 +01:00
Justin Shreve 8d551c01e6 Merge pull request #12403 from woocommerce/order-item-data-store
Order Item Data Store
2016-11-22 03:39:53 -08:00
Mike Jolley 3b9934a2b1 Try catch and false for products 2016-11-22 10:46:19 +00:00
Justin Shreve f15867bb67 Fix ajax actions for saving items, and misc issues. 2016-11-21 10:57:33 -08:00
Justin Shreve 51a55b6782 Add interface, renaming main order item data store to abstract. Various fixes. 2016-11-21 10:57:33 -08:00
Justin Shreve b20b3590c8 First pass at order items 2016-11-21 10:56:21 -08:00
Mike Jolley edf973d35f Feedback 2016-11-21 14:30:56 +00:00
Mike Jolley 7e977f60e2 Feedback 2016-11-18 10:13:54 +00:00
Mike Jolley 792a92e166 Factory 2016-11-17 16:12:04 +00:00
Mike Jolley d88b512143 Setters 2016-11-17 15:17:23 +00:00
Aristeides Stathopoulos 82f3cc221e WordPress.WhiteSpace.ControlStructureSpacing.NoSpaceBeforeOpenParenthesis 2016-08-27 07:23:02 +03:00
Mike Jolley 9e45927803 Create refund with crud 2016-08-22 13:15:15 +01:00
Mike Jolley 21ad196297 Use CRUD in wc_save_order_items 2016-08-19 13:43:33 +01:00
Mike Jolley aa7f6a6cf7 Factory 2016-06-21 20:07:31 +01:00
Fredrik Forsmo bb19615029 Improve docblock comments in various WC_* classes
* Added comments to various methods
* Fixed various properties comments and param types
2016-01-06 16:24:47 +01:00
Nicola Mustone c9da4f928a check if ABSPATH is defined 2015-11-06 10:22:19 +01:00
Claudio Sanches 5893875b0c Removed period for file headers 2015-11-03 11:53:50 -02:00
Claudio Sanches ee30b5b308 Fixed php docs standards 2015-11-03 11:31:20 -02:00
JeroenSormani b95b22d144 Add wc_get_order() tests + Order helper class 2015-05-23 10:48:07 +02:00
Claudio Sanches 79a5c2e98d Moved the order type verification to WC_Order_Factory::get_order() #8180 2015-05-19 13:51:04 -03:00
Nguyễn Văn Được 3b3c6754cb Add $the_order to woocommerce_order_class filter
My be developer using another class to wrap the order. and in this case, the value of $classname allway is false. Send $the_order to filter is the solution.
2015-03-23 15:22:02 +07:00
Mike Jolley 35f006d282 This can return a bool 2015-02-03 15:55:40 +00:00
shivapoudel 73b1185375 Removed newline ;) 2014-09-21 00:36:42 +05:45
Barry Kooij 9d5ce49805 Passed $args to dynamic class that inherits WC_Abstract_Order is never used.
Therefor the $args in the function and method in factory class seems unnecessary.
2014-08-15 14:56:43 +02:00
Mike Jolley c465c7235d Merge branch 'credit-notes'
Conflicts:
	includes/abstracts/abstract-wc-order.php
	includes/class-wc-order-factory.php
	includes/class-wc-post-types.php
	includes/wc-formatting-functions.php
	includes/wc-order-functions.php
2014-07-29 12:09:52 +01:00
Mike Jolley 755001f19b Use order types where required 2014-07-11 12:43:42 +01:00
claudiosmweb 7e36d05c75 created order_type taxonomy 2014-07-08 14:23:11 -03:00
Claudio Sanches 9701cfe2a7 Revert "order_type taxonomy and register_order_type() function" 2014-07-08 14:10:37 -03:00
claudiosmweb 72aae0e69d created order_type taxonomy and register_order_type() function 2014-07-07 16:19:51 -03:00
Mike Jolley f6b78be21c Prevent notices in factory 2014-07-07 11:44:27 +01:00
Coen Jacobs 66006a18b0 WC_Order is default class for order factory 2014-06-14 23:26:01 +02:00
Coen Jacobs 9c68f71500 Basic order factory class 2014-06-13 15:20:14 +02:00