Commit Graph

29143 Commits

Author SHA1 Message Date
Rodrigo Primo b4b7062d7b Improve performance of the query to delete version transients
This commit removes the `ORDER BY option_id` part of the query to remove the version transients from the `wp_options` table. This change should help users having performance issues with this query (see for example #21215) and, as far as I can see, ordering is not necessary in this context.

Removing the `ORDER BY` from the query means that MySQL won't have to use filesort:

```
MySQL [wccore]> explain DELETE FROM wp_options WHERE option_name LIKE '\\_transient\\_%1510258328' ORDER BY option_id LIMIT 1000;
+----+-------------+------------+------------+-------+---------------+-------------+---------+-------+------+----------+-----------------------------+
| id | select_type | table      | partitions | type  | possible_keys | key         | key_len | ref   | rows | filtered | Extra                       |
+----+-------------+------------+------------+-------+---------------+-------------+---------+-------+------+----------+-----------------------------+
|  1 | DELETE      | wp_options | NULL       | range | option_name   | option_name | 766     | const |   67 |   100.00 | Using where; Using filesort |
+----+-------------+------------+------------+-------+---------------+-------------+---------+-------+------+----------+-----------------------------+
1 row in set (0.02 sec)

MySQL [wccore]> explain DELETE FROM wp_options WHERE option_name LIKE '\\_transient\\_%1510258328' LIMIT 1000;
+----+-------------+------------+------------+-------+---------------+-------------+---------+-------+------+----------+-------------+
| id | select_type | table      | partitions | type  | possible_keys | key         | key_len | ref   | rows | filtered | Extra       |
+----+-------------+------------+------------+-------+---------------+-------------+---------+-------+------+----------+-------------+
|  1 | DELETE      | wp_options | NULL       | range | option_name   | option_name | 766     | const |   67 |   100.00 | Using where |
+----+-------------+------------+------------+-------+---------------+-------------+---------+-------+------+----------+-------------+
1 row in set (0.00 sec)
```
2018-09-04 17:20:35 -03:00
Rodrigo Primo b7cc3077ca Remove unneeded usage of @codingStandardsIgnoreStart 2018-09-04 16:03:02 -03:00
Claudiu Lodromanean 77f78415e4
Merge pull request #21248 from robertdevore/add/template-form-action-hooks
Add/template form action hooks
2018-09-04 11:47:25 -07:00
Claudiu Lodromanean 5aa1656297
Update readme.txt 2018-09-04 11:46:58 -07:00
Robert DeVore 348307eb5e
Update spacing 2018-09-04 14:20:14 -04:00
Robert DeVore e4ec0cb148
Spacing update 2018-09-04 14:19:28 -04:00
Claudiu Lodromanean 9abbbb4c48
Merge pull request #21242 from woocommerce/fix/obw-payment-step-email-validation-on-hidden-field
OBW: Avoid Payment form breaking due to email validation on hidden field
2018-09-04 11:18:47 -07:00
Claudiu Lodromanean 24d9133a6b
Merge pull request #21266 from woocommerce/feature/21117
REST API] Make product's created date editable
2018-09-04 10:46:26 -07:00
Jesse Pearson 2faadce24f Add action for when system tools are run 2018-09-04 09:33:16 -04:00
Claudio Sanches bf69627cb1 Unit tests 2018-09-03 11:05:17 -03:00
Claudio Sanches 6a3483fa8a [REST API] Make product's created date editable 2018-09-03 10:57:28 -03:00
Manos Psychogyiopoulos 74ca1ebe6a Remove unnecessary space in mini-cart template 2018-09-03 13:50:48 +03:00
Robert DeVore 4a71ce4659 Add action hook to register form tag 2018-09-01 11:24:33 -04:00
Robert DeVore 03900a43cb Add action hook to edit account form tag 2018-09-01 11:24:04 -04:00
Nikhil Barar 9407f0c8c7 Fix for 21214 - Regions text field not in line. 2018-09-01 18:55:14 +05:30
Rodrigo Primo 2740a686dc Change wp_woocommerce_sessions primary key
This commit changes wp_woocommerce_sessions primary key to the bigint field session_id. Before it was the char(32) field session_key. Doing this change primarily as it should reduce the occurrence of deadlocks, but also because it is not a good practice to use a char(32) field as the primary key of a table.
2018-08-31 16:56:30 -03:00
Ruben 081125043d
wordpress coding standards 2018-08-31 19:12:12 +02:00
Ruben d0db74edd5
Fix variable product cache misses
If the child product doesn't have weight or dimensions, the value is not being cached correctly as a ```false``` value is being stored and it always recheck that on every page load.
2018-08-31 19:10:32 +02:00
claudiulodro 33154afd03 Send emails for cancelled_to_* orders 2018-08-31 09:31:16 -07:00
Paul Dechov a486f50cfd OBW: Avoid form breaking due to email validation on hidden field 2018-08-31 11:36:41 -04:00
claudiulodro e24aa057ad Revise coupon behavior and add unit tests 2018-08-31 08:35:41 -07:00
Coen Jacobs e737d879e1 Make related unit test variables more readable 2018-08-31 07:47:05 -07:00
Jeff Stieler 412a3fb17f OBW: render the product dimension and weight units selection inline in a sentence. 2018-08-30 15:36:08 -06:00
Jeff Stieler b3532dc4de OBW: hook up WCS / ShipStation install in shipping step save handler. 2018-08-30 15:36:08 -06:00
Jeff Stieler c179f7c5c6 OBW: remove live rates method setup from shipping step save handler. 2018-08-30 15:36:08 -06:00
Jeff Stieler fde57ab5d9 OBW: recommend either WCS or ShipStation (based on location) for label printing on shipping step. 2018-08-30 15:36:08 -06:00
Jeff Stieler 2a243915f1 OBW: remove now defunct WCS shipping carrier by country helper function. 2018-08-30 15:36:08 -06:00
Jeff Stieler 23e0174c19 OBW: add information about live rate extensions to shipping step.
This commit also refactors the script/style enqueueing in the wizard.
2018-08-30 15:36:08 -06:00
Jeff Stieler 934b6e1698 OBW: remove live rates from shipping step. 2018-08-30 15:35:16 -06:00
Claudiu Lodromanean dc55b9b002
Merge pull request #21232 from hahn208/fix/21229-shipping-class
#21229 Updated class attribute for shipping class meta box
2018-08-30 12:17:49 -07:00
Claudio Sanches 4738162c25 Improvements to wc_create_attributes (DRI) 2018-08-30 12:13:16 -07:00
Hahn 6623db017b #21229 Updated class attribute for shipping class meta box 2018-08-30 12:17:43 -06:00
claudiulodro 4d6ab678c1 Fix linter errors 2018-08-30 09:56:26 -07:00
Claudiu Lodromanean fd722da88a
Merge pull request #21188 from woocommerce/fix/21156
Updated phone validation and formatting rules.
2018-08-30 09:52:13 -07:00
Claudiu Lodromanean 20fee86913
Update readme.txt 2018-08-30 09:52:08 -07:00
Claudiu Lodromanean 14ea478ed6
Merge pull request #21224 from woocommerce/update/obw-payment-account-setup-defaults
OBW: Change Stripe + PayPal account provisioning to be enabled by default.
2018-08-30 09:27:02 -07:00
Jeff Stieler 8a29945531 OBW: move Jetpack+WCS requirement description to plugin install info area at bottom of payment step. 2018-08-29 16:47:46 -06:00
Jeff Stieler 0028902eb2 OBW: change Stripe and PayPal account creation to opt-out and remove descriptions. 2018-08-29 16:44:47 -06:00
Rodrigo Primo 0946233e07 3.4.5 changelog 2018-08-29 15:53:41 -03:00
Rodrigo Primo 76312d546f
Merge pull request #21219 from woocommerce/kakshak-issue/21062
Coupon validation changes
2018-08-29 13:58:11 -03:00
Claudiu Lodromanean 89e2d3c023
Update readme.txt 2018-08-29 09:47:32 -07:00
claudiulodro 20886138aa Add unit test to verify coupon validation changes 2018-08-29 13:28:43 -03:00
Rodrigo Primo eee61b7880 Merge branch 'issue/21062' of https://github.com/kakshak/woocommerce into kakshak-issue/21062 2018-08-29 13:27:39 -03:00
Rodrigo Primo e3cbebf29e
Merge pull request #21192 from woocommerce/fix/20979
Restrict category creation in importer to appropriate permissions
2018-08-29 11:27:49 -03:00
Rodrigo Primo f1c2dbbf2b Remove unneeded phpcs ignore comment 2018-08-29 10:34:06 -03:00
Rodrigo Primo e28bdddbc2
Merge pull request #21191 from woocommerce/fix/21161
Only suppress comments number on unsupported theme shop page
2018-08-29 10:29:20 -03:00
Claudiu Lodromanean b80c6d86fc
Merge pull request #21207 from woocommerce/speedup-get-request-url-test
Reduce WC_Tests_Paypal_Gateway_Request::test_request_url() execution time
2018-08-28 13:25:09 -07:00
Claudiu Lodromanean 1258f242ff
Merge pull request #21204 from woocommerce/fix/21197
Corrected wording of stock quantity description.
2018-08-28 13:23:49 -07:00
Claudiu Lodromanean dc5858e7e5
Update readme.txt 2018-08-28 13:06:34 -07:00
Claudiu Lodromanean 03659ff67e
Merge pull request #21211 from Dedi-Data/patch-2
unnecessary aria-required for elements that have required
2018-08-28 13:05:31 -07:00