Commit Graph

18908 Commits

Author SHA1 Message Date
Paul Sealock bc23340909 Use #doaction to target bulk actions 2019-07-05 17:02:30 +12:00
Paul Sealock 7af9d1813d Tracks: Add coupons view events 2019-07-05 16:46:58 +12:00
Paul Sealock 8777dc4c01 Revert title to WooCommerce Admin 2019-07-05 16:11:35 +12:00
Paul Sealock 1116e5516d update 'free' usage and wc-admin description 2019-07-05 16:10:10 +12:00
Rodrigo Primo b648647893
Merge pull request #23741 from woocommerce/feature/23728
Allows customize buyer name in orders list screen
2019-07-04 16:23:43 -03:00
Rodrigo Primo 9eed45af4e
Merge pull request #23740 from woocommerce/fix/23735
Rename "Postcode / ZIP" to "Postal code" when select Canada
2019-07-04 16:20:11 -03:00
Rodrigo Primo 4712f75f67 Merge branch 'master' into fix/23508 2019-07-04 16:13:01 -03:00
Rodrigo Primo 4de12633d6
Merge pull request #24073 from woocommerce/fix/status-helper-disconnected-typo
Fix missing space and closing <strong> tag in WooCommerce.com disconnect message
2019-07-04 16:05:59 -03:00
Rodrigo Primo 9325e233d7
Merge pull request #23190 from woocommerce/tracks/status-events
Tracks: Status page events
2019-07-04 15:21:07 -03:00
oscargare 2c8e45830a Added new action "woocommerce_product_read" (#23181)
* Added new action "woocommerce_read_product_data"

* Added new action woocommerce_product_read
2019-07-04 14:17:34 -03:00
vedanshujain 8ab6cb2b5a Round late when rounding at subtotal to reduce rounding error.
We were earlier rounding different tax rate values while they are merged, even if rounding at subtotal setting is enabled. This increases the rounding error, especially when prices are inclusive of taxes, and thus there is a chance that the total will be slightly different from when add the original values. For egs: https://github.com/woocommerce/woocommerce/issues/23917 .

This commit changes this behavior to round *after* we have summed all the precise unround values. Similar for items prices, we now round as late as possible, if rounding at subtotal is enabled.
2019-07-04 22:34:29 +05:30
Rodrigo Primo a26f38f3a1
Merge pull request #23133 from woocommerce/update/23111
If variations are missing prices, show notice
2019-07-04 10:08:41 -03:00
Gerhard Potgieter 213e52852c
Merge pull request #23968 from woocommerce/fix/23954
Allow display multiple error messages through registration validation
2019-07-04 13:17:39 +02:00
Gerhard Potgieter a91d271ae2
Merge pull request #23776 from woocommerce/fix/23699
Moved the JS enqueue from get_instance_form_fields to admin_footer hook.
2019-07-04 13:13:35 +02:00
Gerhard Potgieter 12fbfa5677
Merge pull request #22927 from woocommerce/update/22895
Allow "Thanks" wording in emails to be reworded by admin
2019-07-04 12:43:00 +02:00
Gerhard 52ef1d0b5f Remove esc_html call, it messes with the code tags. 2019-07-04 11:33:05 +02:00
Gerhard Potgieter c484fdd6d9
Merge pull request #24023 from woocommerce/fix/engine-php-notice
DB received `ENGINE` instead of `engine`, so PHP notices appear
2019-07-04 10:55:03 +02:00
Gerhard d4eb233843 Deprecate email_footer_replace_site_title and use replace_placeholders 2019-07-04 09:36:05 +02:00
Daniel Bitzer 20625e9a45 Fix missing space and closing <strong> tag
Strong tag was not being echoed and space was missing after full stop.
2019-07-04 16:57:50 +09:30
Gerhard Potgieter c3a25bb6bf
Merge pull request #23884 from woocommerce/fix/23875
Prevents taxes columns from being removed when the order is no longer editable
2019-07-04 09:25:49 +02:00
Gerhard Potgieter 007fc457a3
Merge pull request #24020 from woocommerce/fix/plural-forms-usage
Correct singular form usage in class-wc-admin-report.php
2019-07-04 09:23:14 +02:00
Gerhard Potgieter 762f051080
Merge pull request #24071 from woocommerce/add/action_log-excluded-comment-type
WC_Comments: Add action_log to excluded types in wp_count_comments
2019-07-04 09:18:03 +02:00
Gerhard Potgieter 54cab8086c
Merge pull request #23998 from yash-webkul/patch-1
Update class-wc-ajax.php
2019-07-04 09:17:03 +02:00
Gerhard 5d604329fc Reword postfix to suffix 2019-07-04 09:07:02 +02:00
Gerhard 9e2ba43d3b Forgot the 9 2019-07-04 09:05:05 +02:00
Gerhard 164f09e9c7 Remove abiguous characters that are dificult to read. 2019-07-04 09:00:15 +02:00
Paul Sealock 08224c06f2 Add facebook and wc-admin to 'obw_recommended' Tracks event properties 2019-07-04 13:07:18 +12:00
Timmy Crawford e5b9f508bc WC_Comments: Add action_log to excluded comment_types in wp_count_comments 2019-07-03 15:06:21 -07:00
Gerhard 538edcaac0 Make button text translatable. 2019-07-03 22:57:08 +02:00
Gerhard 24fc4948c0 Add generate coupon code button for quick coupon code generation. 2019-07-03 22:48:30 +02:00
Mark Senff 9c013b132b
Update html-product-attribute.php 2019-07-03 07:30:32 -04:00
Gerhard 8a972ee5c3 Add check for empty string when checking meta_value since checking an empty string in mysql against an int results in a 0 value. 2019-07-03 12:37:28 +02:00
Gerhard 7ff9788450 Use plugin_path instead of plugin_url. 2019-07-03 11:49:51 +02:00
Gerhard 77e8e36f72 Add notice when assets are not built, introduce grunt assets task for compiling and minifying assets. 2019-07-03 11:46:28 +02:00
Paul Sealock 01f428d34f install plugin 2019-07-03 13:12:24 +12:00
Paul Sealock b65ce3dd26 OBW: Add wc-admin to recommended page 2019-07-03 13:02:07 +12:00
Timmy Crawford 6f6265f8e3 Track views of the last step in the OBW. 2019-07-02 14:56:08 -07:00
Timmy Crawford 3f6d5eb49a Tracks: Fix marketing signup track. 2019-07-02 14:47:41 -07:00
Peter Fabian 6727fdba62 Updated constants' names to better reflect their usage. 2019-07-02 18:44:43 +02:00
Claudio Sanches cb12b30c85 Fixed @since tag version 2019-07-02 12:51:36 -03:00
Rodrigo Primo 737f6af5e8 Introduce file type check for tax rate importer 2019-07-02 10:44:21 -03:00
Rodrigo Primo cabf9de71a Added nonce check to CSV importer actions 2019-07-02 10:37:46 -03:00
Rodrigo Primo 18813662dd Fix link to documentation about WordPress and PHP minimum requirements 2019-07-02 09:19:39 -03:00
Gerhard f74c32c17b Add return 2019-07-02 10:25:32 +02:00
Gerhard e08279d190 Add support for namespaced Jetpack tracks_get_identity from Jetpack 7.5 2019-07-02 10:20:57 +02:00
Andy Mardell 821d387c19 Add full-stop to inline comment 2019-07-01 08:31:10 +01:00
Rodrigo Primo b08fd05a7d Fix: check if DB_NAME is defined before using it
WooCommerce relies on the constant DB_NAME to display information about the database tables in the system status page. The problem is that this constant is not always defined (e.g., when the plugin HyperDB is used to replace the standard wpdb class). When that is the case, WooCommerce will incorrectly say that its core tables are missing and the following PHP warning will be generated:

```
Use of undefined constant DB_NAME - assumed 'DB_NAME' (this will throw an Error in a future version of PHP)
wp-content/plugins/woocommerce/includes/api/v2/class-wc-rest-system-status-v2-controller.php:708
```

To fix this, this commit checks to see if DB_NAME is defined before using it. When the constant is not set, WooCommerce will display the following message to the users instead of the list of supposedly missing tables:

```
Database information: Unable to retrieve database information. Usually, this is not a problem, and it only means that your install is using a class that replaces the WordPress database class (e.g., HyperDB) and WooCommerce is unable to get database information.
```
2019-06-28 17:57:54 -03:00
Jeff Stieler 3bf58f2d48 Tracks: fix blog ID retrieval from Jetpack options.
JavaScripty syntax resulted in boolean values.
2019-06-27 14:15:17 -06:00
Boro Sitnikovski a7f5d87f5e DB received `ENGINE` instead of `engine`, so PHP notices appear 2019-06-27 17:34:08 +02:00
Rodrigo Primo 68f5ccabc1
Merge pull request #23811 from woocommerce/feature/23807
Allow enforce password strength meter on checkout
2019-06-27 11:39:00 -03:00
Rodrigo Primo f3b0d755fd Correct singular form usage in class-wc-admin-report.php
For more information see https://github.com/woocommerce/woocommerce/issues/24004
2019-06-27 11:03:35 -03:00
Andy Mardell f2152e665e Allow notice type changes when updating cart 2019-06-27 14:54:35 +01:00
Rodrigo Primo 3f2cacb1be Use phpcbf to fix phpcs violations in class-wc-admin-report.php 2019-06-27 10:48:31 -03:00
Rodrigo Primo 12d03d8d57
Merge pull request #23863 from Jon007/patch-2
Avoid attempting to cache expired sessions
2019-06-27 10:15:39 -03:00
Gerhard Potgieter 698625ce1d WP & PHP Upgrade Notices (#23975)
This commit introduces a banner that notifies and prompts users to upgrade their WordPress and/or PHP if they are outdated and not part of the minimum required versions going into WooCommerce 3.7.

* Add backward compatible function wp_check_php_version for sites running WP version smaller than 5.1

* Refactor some messaging, move widget to top of WC dashboard widgets, add buttons linking out to WP pages with instructions.

* Add missing variables for adding nag class

* Add styling to dashboard widget

* Rework css to use exclamation instead

* Clean up widget, make sure no widget is registered when dismissed. Add banner that links to widget and make it dismissable.

* Update constant to reflect minimum requirements.

* Don't show banner. Fix undefined variable.

* Remove dashboard widget

* Update banner link to docs site

* Add link to docs page where instructions live for updating

* Change button text

* Add UTM params to docs link

* Moved the msg logic from template to php file.

* Bail out early when PHP and WP versions are ok.

* Added missing translation functiog

* Extracted notice function from reset_admin_notices.

To follow suit with other similar functions in the file.

* Synchronize fetching of WP version.

* Removed unused functions.

* Corrected indent.

* Reduce number of variables and fixed coding standards

* Updated wording of the notice.
2019-06-26 14:09:20 -03:00
Mike Jolley a0a58cfb15 update from master 2019-06-26 15:26:47 +01:00
Mike Jolley 48e1dc5bec Remove init_packages from class-woocommerce 2019-06-25 13:12:14 +01:00
MD0123-Hardip 60cafccb37 added new line in update-function.php file 2019-06-25 15:20:26 +05:30
MD0123-Hardip 530d53c428 added new 370 function for currency updater. 2019-06-25 15:17:16 +05:30
Yash Kapoor 84fd2bbca9
Update class-wc-ajax.php
Removed unused code.
2019-06-25 10:58:56 +05:30
Claudio Sanches deec93f8ca
Merge pull request #23769 from mch0lic/master
Forward query (GET) parameters when executing a batch REST API request.
2019-06-24 12:39:36 -03:00
Claudio Sanches 1f73c63a57
Merge pull request #23909 from woocommerce/fix/23895
Explicitly check 0 value attributes when looking up variations.
2019-06-24 12:35:39 -03:00
Claudio Sanches 45f1ac63e0
Merge pull request #23935 from malviyaritesh/fix/23931-sale-tooltip
Change misleading tooltip for product sale meta box
2019-06-24 12:35:04 -03:00
Claudio Sanches fe4dfea8eb
Merge pull request #23771 from woocommerce/fix/23756
Fix Top rated shortcode results
2019-06-24 12:18:57 -03:00
Claudio Sanches 912ee38836
Merge pull request #23812 from woocommerce/fix/rest-api-customers-type
Fixed a typo in customers endpoint
2019-06-24 12:18:15 -03:00
Claudio Sanches 606c0417a9
Merge pull request #23837 from woocommerce/fix/23834
Make NL postcode validation more flexible
2019-06-24 12:17:53 -03:00
Claudio Sanches 8d0e2f632b
Merge pull request #23878 from woocommerce/fix/23865
Shows city as an optional field for Singapore
2019-06-24 12:17:30 -03:00
Claudio Sanches c04f7b79f9
Merge pull request #23919 from woocommerce/fix/codex-memory-limit-link
Updated documentation about increasing memory allocated to php
2019-06-24 12:12:11 -03:00
Claudio Sanches 35c4183cad
Merge pull request #23966 from woocommerce/fix/23946
Fixed database update tool, fixing System Status, REST API and CLI
2019-06-24 12:11:47 -03:00
Claudio Sanches 09408d9296
Merge pull request #23967 from woocommerce/fix/23947
Fix phone number format to accept "(", and ")"
2019-06-24 12:09:09 -03:00
Mike Jolley 558a330291 Update version/path getters 2019-06-21 20:00:03 +01:00
Mike Jolley 6bfe8d63c5 Load Packge files 2019-06-21 19:58:38 +01:00
Mike Jolley d31f6f70a2 Package init method 2019-06-21 17:28:46 +01:00
Mike Jolley e3dc79481d Init the blocks library using autoloading 2019-06-21 15:03:28 +01:00
Mike Jolley ed0a4aae1f update shipping saving in setup wizard 2019-06-21 13:59:51 +01:00
Mike Jolley 3a1c401a5b update status report 2019-06-21 13:59:40 +01:00
Mike Jolley 833ad116c6 Update webhooks 2019-06-21 13:59:32 +01:00
Mike Jolley ab37649474 get_endpoint_data helper 2019-06-21 13:59:25 +01:00
Mike Jolley 5b105d0c7f Init the API and add to status report 2019-06-21 13:40:53 +01:00
Mike Jolley 950f31a9e0 Remove abstract rest class that is in the package 2019-06-21 13:40:10 +01:00
Mike Jolley 8b41b03f2e Remove blocks files 2019-06-21 12:23:41 +01:00
Gerhard 9212ee5082 Add check before calling wc_delete_order_item for taxes to make sure order is editable. 2019-06-20 15:01:01 +02:00
Peter Fabian a6a26633a4 Removed extra check if the code is executed within admin. 2019-06-20 14:07:52 +02:00
MD0123-Hardip a01d59e581 added db currency updater for both currency 2019-06-20 16:17:23 +05:30
Claudio Sanches 02aafa1948
Merge pull request #23911 from woocommerce/update/23887
Update auto username generation description
2019-06-19 20:22:02 -03:00
Claudio Sanches 88100b8f8e
Merge pull request #23926 from malviyaritesh/fix/23922-quote-in-pass
Stop unslashing password while registering user
2019-06-19 19:39:39 -03:00
Claudio Sanches e759317ef4
Merge pull request #23891 from malviyaritesh/fix/23888
Send boolean as expected, not string
2019-06-19 19:36:34 -03:00
Claudio Sanches 569e8a5b8f
Merge pull request #23925 from webdados/patch-2
Display Status > Logs timestamp with the Y-m-d H:i:s format
2019-06-19 19:11:13 -03:00
Claudio Sanches 84c8a2c165
Merge pull request #23936 from malviyaritesh/fix/23923-categories-link
Add missing post_type=product query var in url
2019-06-19 18:59:20 -03:00
Claudio Sanches 6989532274 Allow display multiple error messages through registration validation 2019-06-19 18:09:28 -03:00
Claudio Sanches 7073c6b3a2 Allow "(", and ")" in wc_format_phone_number() 2019-06-19 17:39:08 -03:00
Claudio Sanches d17b96646c Fixed database update tool, fixing System Status, REST API and CLI 2019-06-19 17:19:13 -03:00
Mike Jolley 145cf3b770 Remove rest includes and controllers init 2019-06-19 11:56:51 +01:00
Mike Jolley ce3a6cbbf8 Remove old include 2019-06-19 11:54:55 +01:00
Mike Jolley 78f9ea59ed Moved auth and exception classes to main includes directory - these are shared between legacy and new API. The package may replace these in the future. 2019-06-19 11:52:50 +01:00
Mike Jolley 7451659b24 Delete REST API abstract classes 2019-06-19 11:49:28 +01:00
Mike Jolley 03e60ebb7c Delete REST API classes 2019-06-19 11:48:12 +01:00
Mike Jolley 6ca9dac7d7 Remove REST API autoloader 2019-06-19 11:44:57 +01:00
Mike Jolley 9a07e92eba Remove parent construct call since init() is used. 2019-06-19 11:31:04 +01:00
Mike Jolley 038bac16f5 Update paths to legacy API and implement init method. 2019-06-19 11:29:49 +01:00
Mike Jolley 00a8ef5d4d Move legacy API files from /api/ to /legacy/api 2019-06-19 11:23:47 +01:00
Albert Juhé Lluveras 9e641e08dd
Merge pull request #23953 from woocommerce/fix/tracks-pixel-fixed
Set Tracks image position to fixed
2019-06-19 10:41:39 +02:00
Jonathan Moore d8470aa45a
implementing review from @claudiosanches 2019-06-18 21:20:39 +01:00
Claudio Sanches 4061f870a2
Merge pull request #23720 from parmarhardip/FIX-23589
fix- 23589 I have fixed pricing issue.
2019-06-18 16:04:45 -03:00
Claudio Sanches e18481e795
Merge pull request #23824 from woocommerce/fix/23799
Update Emogrifier library
2019-06-18 16:03:40 -03:00
Claudio Sanches e849a5e044
Merge pull request #23877 from jdeeburke/fix/apply-coupon-fatal
Fix fatal error when applying a virtual coupon to an order placed by a guest
2019-06-18 16:00:39 -03:00
Claudio Sanches a36dcf8aae
Merge pull request #23849 from woocommerce/fix/wc-tracker-reviews
Tracker: fix review count
2019-06-18 15:52:25 -03:00
Claudio Sanches 96787d62f9
Merge pull request #23828 from Jon007/patch-1
Avoid outputting a rating of zero when product has comments without a review rating.
2019-06-18 15:51:55 -03:00
Claudio Sanches bf01eccfcd
Merge pull request #23840 from unfulvio/23839-do-not-throw-notice-rest-api-includes
[#23839] Do not throw autoloader notice if following notice instructions
2019-06-18 15:51:22 -03:00
Albert Juhé Lluveras 26c2d49586 Set Tracks image position to fixed 2019-06-18 13:05:30 +02:00
MD0123-Hardip 715528e58e changes applied 2019-06-18 12:07:55 +05:30
rmalviya 4190e9fd4b Add missing post_type=product in url
Show Products->Categories active when clicked on "Make Default" link
under any product category and fix #23923.
2019-06-14 12:28:08 +05:30
rmalviya 0e896f82fa Change misleading tooltip for product sale meta box
Clarify the sale start and end time by changing the tooltip for
product sale price dates and fix #23931.
2019-06-14 11:12:54 +05:30
rmalviya 5df3621640 Do not unslash password when resetting
Similar to PR(#23926) don't unslash password fields when posted
while resetting password or changing account details.
2019-06-14 09:16:21 +05:30
rmalviya 01025f9628 Stop unslashing password while registering user
After 79ff1b10e password is not unslashed while logging in but
this missed removing `wp_unslash` from password while registering.
This causes the mismatch of password if user registered with a
password containing quote (`"`).
Fixes #23922.
2019-06-14 09:16:21 +05:30
Marco Almeida 3b7be608e4
Display Status > Log timestamp with the Y-m-d H:i:s format
Display WooCommerce > Statis > Log timestamp, when using WC_Log_Handler_DB, with the Y-m-d H:i:s format instead of the WordPress global date and time format options, because we need more detail on the shown timestamps and that might not be compatible with what we want for our global options.
2019-06-13 10:58:41 +01:00
Claudio Sanches 3ce6acec74 Updated outdated codex URLs 2019-06-12 19:31:01 -03:00
Claudio Sanches 5624af43a7 Updated docs about increasing memory allocated to php 2019-06-12 19:04:24 -03:00
Gerhard 84b6fa144f Update description for automatic username generation to reflect how it actually works. 2019-06-12 12:13:41 +02:00
Gerhard 3894d156e6 Explicitly check 0 value attributes when looking up variations. 2019-06-12 11:27:27 +02:00
justlevine efb8b9af57
Added missing quote
Quote missing between `placeholder` and `data-input-classes` attributes.
2019-06-11 20:47:22 +03:00
rmalviya 5bf8adf2dd Send boolean as expected, not string
Originally checkout.js:336 expected string but changed to boolean
with 4ad370985. Send boolean for `reload` in json and fix #23888.
2019-06-08 20:12:44 +05:30
Claudio Sanches 47c370809e Prevents taxes columns from being removed when the order is no longer editable 2019-06-07 10:07:32 -03:00
Jeff Stieler 05fd441145 Add payment method to order status change tracking. 2019-06-07 12:52:22 +02:00
Jeff Stieler 1bd9a7d9a7 Use a consistent tracks event naming scheme. 2019-06-07 12:31:42 +02:00
Jeff Stieler e251557550 Track when users click “add order” from an order edit screen. 2019-06-07 12:21:04 +02:00
Ionut Calara 26dfe11493 Update find matching variation method inner query
Fix variation query to prevent the order by being ignored in some mysql
and mariadb versions. The order by has been moved outside and a left
join was added.
2019-06-07 13:05:01 +03:00
Jeff Stieler 6c90d9da57 Track order actions. 2019-06-07 10:55:33 +02:00
Claudio Sanches c0a9b57d72 Shows city as an optional field for Singapore 2019-06-06 20:13:55 -03:00
Jared Burke 332c94c13a Fix fatal error when applying a virtual coupon to an order placed by a guest 2019-06-06 15:37:08 -05:00
Dan Wyman 3edd30757b Tracker: apply coding standards. 2019-06-06 13:23:11 -07:00
Jeff Stieler f9d064e778 Track changes to order creation date. 2019-06-06 17:09:50 +02:00
Fulvio Notarstefano aba51d4c76 [#23839] Use false arg in class_exists() 2019-06-06 09:56:30 +08:00
Risto Niinemets dbc9719d76 Use order raw address instead of formatted for filter 2019-06-04 08:13:40 +03:00
Jonathan Moore 9e8debd7ba
Avoid attempting to cache expired sessions
get_session() attempts to cache a session even if it is already expired.
The code used passes negative expiry seconds to wp_cache_add if the session expired in the past:
wp_cache_add( $this->get_cache_prefix() . $customer_id, $value, WC_SESSION_CACHE_GROUP, $this->_session_expiration - time() );

Depending on the caching layers used this will give errors in the logs such as:
ERR invalid expire time in setex in /var/www/html/wp-content/plugins/redis-cache/includes/predis/src/Client.php:370
as reported on: https://wordpress.org/support/topic/error-when-trying-to-get-a-get-a-cache-not-available/
2019-06-03 22:11:46 +01:00
Ajay Ghaghretiya c9bcce3a31 #23850 Fixed the coupon usage limit issue when apply coupon from admin panel (#23851)
* fix the coupon usage limit issue

* fix the if condition for the usage limit

* fixed coding standard

* fix the if conditions for coupon usage limit per user
2019-06-03 10:47:32 -03:00
Risto Niinemets de1dfbb1b4 Allow filtering formatted shipping address 2019-06-03 09:18:36 +03:00
Claudio Sanches 3a47453d68 Improve regex 2019-06-01 11:52:15 -03:00
Dan Wyman 7355fadfdd Tracker: fix review count.
Fixes #23848
2019-05-30 12:45:47 -07:00
Fulvio Notarstefano ab1ba58128 [#23839] Do not throw an autoloader notice if following the notice recommendation 2019-05-29 12:47:26 +08:00
Claudio Sanches b5da70c74a Introduced woocommerce_search_products_post_statuses filter 2019-05-28 21:05:26 -03:00
Claudio Sanches e04e9ae521 Make NL postcode validation more flexible
Allows postcode without spaces and in lowercase.
2019-05-28 20:51:07 -03:00
Claudio Sanches 2e90e9ab65
Merge pull request #23743 from Sisanu/issue-23717-enhancement-hook
Implement the info & extra actions new filter for Product gallery
2019-05-28 18:22:33 -03:00
Claudio Sanches 2fdf6de827
Merge pull request #23764 from jorgept/patch-1
Update class-wc-countries.php
2019-05-28 18:19:41 -03:00
Claudio Sanches c28af404ad
Merge pull request #23814 from woocommerce/add/x-sendfile-file-filter
Add filters to file paths passed to the different xsendfile like backends
2019-05-28 17:41:49 -03:00
Jonathan Moore 5d6574a00a
rating optional = generate_product_data incorrect
If rating is not mandatory on comments, generate_product_data() produces incorrect output.
For example items with comments but no reviews are output with rating of zero which is getting flagged in google webmasters tools under the heading "Rating is missing required best and/or worst values".

The output google is objecting to is eg:
"aggregateRating":{"@type":"AggregateRating","ratingValue":"0","reviewCount":1}}

postmeta in this case is:
_wc_average_rating 0
_wc_rating_count 0.0
_wc_review_count 1

product lookup table is reporting
rating_count 0
average_rating 0.00

the meta is correct and reflected in the product object, it is the test that is wrong since
if $product->get_review_count() 
may be true even if there are no ratings.

This is solved by substituting get_rating_count() which has the correct number of ratings.
2019-05-28 07:38:07 +01:00
Rodrigo Primo 000c95ea88
Merge pull request #23659 from woocommerce/add/wc-admin-install-nudge
Add wc-admin notice.
2019-05-27 12:29:43 -03:00
Rodrigo Primo ff1020a787
Merge pull request #23787 from woocommerce/fix/tracks-cookie-set-action
Tracks: set cookie on admin_init insead of wp_loaded
2019-05-27 12:16:27 -03:00
Rodrigo Primo 67663836c0
Merge pull request #23739 from woocommerce/fix/23737
Remove administrative message from refund reason
2019-05-27 12:12:07 -03:00
Rodrigo Primo ce6f6a6ddb
Merge pull request #23772 from woocommerce/fix/OBW-tracks-not-enabled
Tracks: Add check for OBW is-opting-in
2019-05-27 12:09:00 -03:00
Gerhard Potgieter b2ed079520 Manual orders coupon usage limits by email (#23775)
* Add functionality to wp-admin order to check for coupon usage based on email addresses, similar to how WC_Cart handles this seperately, included unit tests.

* Only do the coupon by email usage check if order is from a guest. Fix issue with unit test.
2019-05-27 11:45:29 -03:00
Gerhard f5c5ced6b8 Update Emogirifier library 2019-05-27 11:39:33 +02:00
Peter Westwood 4448235a16
Coding Standards: Add missing space. 2019-05-24 18:15:24 -06:00
Peter Westwood f70dcc6a01 Add filters to file paths passed to the different xsendfile like backends.
Different server configurations can require different paths to be sent and it isn't always possible for a plugin to know the correct path for a platform.
These filters will allow a hosting provider to install a platform level configuration via an `mu-plugin` to make sure things work in there configuration.
2019-05-24 17:10:17 -06:00
Claudio Sanches 3a79970289 Fixed a typo in customers endpoint 2019-05-24 15:34:25 -03:00
Claudio Sanches 61346720c7 Allow enforce password strength meter on checkout 2019-05-24 15:27:26 -03:00
Valerie 136613f539 OBW Shipping: Update labels description
- replace "Print shipping labels at home" heading with
"Did you know you can print shipping labels at home?"
- Use new description for WooCommerce Services:
"'Use WooCommerce Shipping (powered by WooCommerce Services & Jetpack)
to save time at the post office by printing your shipping labels
at home."
- do not capitalize post office
2019-05-23 22:17:17 -04:00
Valerie b379739ea6 OBW Shipping: Switch label and zone sections 2019-05-23 22:17:13 -04:00
Valerie 6d77056e77 OBW: Fix stranded ul closing tag 2019-05-23 22:17:03 -04:00
Iulia Cazan f49cec5108 Coding standard updates 2019-05-23 08:58:13 +03:00
Claudio Sanches 17da960abe
Merge pull request #23137 from woocommerce/fix/23051
Change coupon amount field type based on coupon type
2019-05-22 21:19:03 -03:00
Claudio Sanches 15aa298585
Merge pull request #23159 from woocommerce/fix/23157
If orderby is used on static homepage, force query to be a page query
2019-05-22 21:17:01 -03:00
Claudio Sanches dc35b89df7
Merge pull request #23178 from davidofug/master
Uganda Billing/Shipping address
2019-05-22 21:07:09 -03:00
Claudio Sanches 793519137a
Merge pull request #23794 from woocommerce/update/23792
Introduce wc_load_cart to dynamically load the cart
2019-05-22 20:51:09 -03:00
Claudio Sanches 28d49031d3
Merge pull request #23695 from james-allan/calc-base-zip-city
Calculate base store taxes including the store's zip and city
2019-05-22 20:49:57 -03:00
Claudio Sanches 8ea6c7c80e
Merge pull request #23651 from woocommerce/update/register-rest-routes
Set register_rest_route override to TRUE in Blocks REST API
2019-05-22 20:49:15 -03:00
Claudio Sanches 359fd9d7d5
Merge pull request #23791 from woocommerce/fix/23630
Clear notices when calling cart-errors.php template
2019-05-22 20:40:21 -03:00
Claudio Sanches 91a8592ebb Fixed conditional logic 2019-05-22 20:16:10 -03:00
Claudio Sanches 688d35e206
Merge pull request #23562 from benhuson/update/23558-related-product-order
Update/23558 Related product order
2019-05-22 19:59:25 -03:00
Claudio Sanches 3cc3565e61
Merge pull request #23774 from connorhu/patch-1
fixed availability schema protocol
2019-05-22 18:07:05 -03:00
Gerhard f6d9faa062 Introducde wc_load_cart to dynamically load the cart, this allows for functionality outside of frontend to initialise the cart. 2019-05-22 12:24:31 +02:00
sergey.r 98586f10f4 Catch WC_REST_Exception while calling do_action( "woocommerce_rest_insert_{$this->post_type}_object" 2019-05-22 13:00:34 +03:00
Gerhard 3a49e7a53b Clear notices after calling checkout/cart-errors.php to avoid duplicate notices on the cart page. cart-errors.php does not output notices but a general notice message yet error notices are still enqueued before calling the template. 2019-05-22 09:49:53 +02:00
Paul Sealock f7e56be638 Tracks: set cookie on admin_init 2019-05-22 12:14:28 +12:00
Claudio Sanches 196d5e77cb
Merge pull request #23041 from woocommerce/update/21701
Add hooks for helper subscription changes
2019-05-21 18:27:15 -03:00
Paul Sealock c74d5b30ca Tracks: use woocommerce_apply_user_tracking and woocommerce_apply_tracking 2019-05-22 09:18:34 +12:00
Claudio Sanches edd0e7de8c Bump template versions 2019-05-21 17:53:03 -03:00
Claudio Sanches 22f9cdcb0d Allow {woocommerce} placeholder in lowercase 2019-05-21 17:47:54 -03:00
Claudio Sanches 4a99a11009 Merge branch 'master' into update/22895 2019-05-21 17:46:16 -03:00
Rodrigo Primo 870ea9a935
Merge pull request #23704 from woocommerce/fix/23703
Fixed number of args for woocommerce_valid_order_statuses_for_cancel
2019-05-21 17:24:43 -03:00
Claudio Sanches bd36434174 Use WP 5.0 determine_locale() function 2019-05-21 17:19:50 -03:00
Rodrigo Primo fbdfb7b87f
Merge pull request #23468 from woocommerce/update/23366
Return WP_Error messages from wp_insert_user()
2019-05-21 17:10:32 -03:00
Rodrigo Primo ae50379f7e
Merge pull request #23325 from woocommerce/fix/rest-api-purge-invalid-orders
[REST API] Stop orders being created if invalid data is sent
2019-05-21 16:36:04 -03:00
Rodrigo Primo 5a15713f95
Merge pull request #23207 from woocommerce/update/23205
Introduce `parse_published_field` in CSV importer
2019-05-21 16:24:03 -03:00
Rodrigo Primo c21a69ff6d Complement WC_Product_CSV_Importer::parse_published_field() phpdoc
Add a phrase to WC_Product_CSV_Importer::parse_published_field() phpdoc
to note that 'true' and 'false' are also supported to set product
published status.
2019-05-21 15:55:41 -03:00
Rodrigo Primo 3fed0d7cbc
Merge pull request #23112 from woocommerce/fix/persistent-cart-filter
Persistent cart improvements
2019-05-21 15:07:55 -03:00
Karoly Gossler a135f02f41
fixed availability schema protocol
As you can see in the example, the scheme only can be on http:
https://schema.org/InStock
The Google Search console has also marked it invalid.
2019-05-21 09:10:56 +02:00
Iulia Cazan 051277d26e Rename the hook 2019-05-21 09:20:46 +03:00
Iulia Cazan 1187563c93 Transform the filter into action, rewrite the piece of code to pass the coding standards, remove markup restriction. 2019-05-21 09:18:15 +03:00
Gerhard 70231461b2 Refactor logic for passing no_shipping, it should only be passed when no shipping items are available. 2019-05-21 08:11:36 +02:00
Paul Sealock ca4e79bdd1 Tracks: Add check for OBW is-opting-in 2019-05-21 12:20:25 +12:00
Claudio Sanches a2301dc0cb Removed deprecated PHPCS flags 2019-05-20 17:06:41 -03:00
Claudio Sanches 5eaf71b483 Fixed coding standards 2019-05-20 17:04:24 -03:00
Claudio Sanches cc6d7996fd Restored WC_Shortcode_Products::order_by_rating_post_clauses 2019-05-20 16:57:14 -03:00
Gerhard 8332bed7bc Do not pass no_shipping when not using send shipping address options in paypal, it still needs to use the billing details. 2019-05-20 14:59:48 +02:00
Peter Fabian 91839ce078 Moved the JS enqueue from get_instance_form_fields to admin_footer action hook.
This should prevent multiple enqueues.
2019-05-20 12:56:01 +02:00
Mindaugas Budreika d67381148a Forward query (GET) parameters when executing a batch REST API request. 2019-05-20 14:24:48 +04:00
jorgept e214a85a8c
Update class-wc-countries.php
Add MZ array
postcode => false, 
hidden => true
2019-05-19 22:23:36 +01:00
Ibrahim 0db84aec56
Fixes #23756 2019-05-18 21:04:13 +05:30
Timmy Crawford 01f1749684 Change version compare. 2019-05-17 13:53:38 -07:00