Commit Graph

324 Commits

Author SHA1 Message Date
James Allan b1a2fa01a6 Check the cart exists before emptying it after PayPal response 2020-10-21 10:32:37 +10:00
Nestor Soriano 52eed70f04 Add a 'NumberUtil' class with a 'round' method.
There's a number of places in the WooCommerce codebase where the
built-in function 'round' is executed passing a non-numeric value
(not a number and not a string that can be parsed as a number),
for example round(''). In PHP 7 this yields a value of 0, but in
PHP 8 this throws an error.

This commit adds a 'NumberUtil' class with a static 'round' method,
this method checks if the passed value is numeric and if so it just
executes the built-in function, otherwise it returns 0. And all the
calls to 'round' in the codebase are replaced with 'NumberUtil::round'.
2020-10-01 11:08:51 +02:00
Rodrigo Primo 197e8d274c
Merge pull request #27616 from woocommerce/fix/26960
Paypal gateway: protect code against a fatal error if WooCommerce is unable to communicate with PayPal
2020-09-18 09:34:57 -03:00
Claudio Sanches 3377c60c5e
Merge pull request #27433 from woocommerce/fix/remove-relative-include-paths
Change relative include paths to absolute include paths
2020-09-17 13:15:40 -03:00
Rodrigo Primo 3aed780443 Paypal gateway: protect code against a fatal error
This commit changes the order of the error handling check to protect the code against a possible fatal error if wp_safe_remote_post() returns an instance of WP_Error().
2020-09-08 16:57:48 -03:00
Claudio Sanches c4ccc38780 Fixed use __DIR__ for relative paths 2020-08-26 18:46:44 -03:00
Brent Shepherd a2e2d63265 Rename PayPal to PayPal Standard
In the admin area, not the front-end of the site.

Fixes #27467
2020-08-25 12:25:44 +10:00
Claudio Sanches d48f1d4e2e Fixed package tag usage 2020-08-05 13:36:24 -03:00
Christopher Allford 4ae1e1f5fc Extracted the repetitive Constants::get_constant( 'WC_VERSION' ) calls where possible 2020-02-04 14:02:57 -08:00
Christopher Allford 1d1413b4ee Replaced direct access of many constants with the Constants library 2020-01-31 22:18:47 -08:00
Christopher Allford 6ad091a9b7 Changed all of the constant accesses into corresponding Automattic\Jetpack\Constants usages 2020-01-28 21:21:29 -08:00
Peter Fabian 30dde8f53c The JS might still be needed as merchants can manage/change settings even for a disabled gateway. 2020-01-28 14:13:03 +01:00
Peter Fabian 217c9d2adc Fix incorrect comment. 2020-01-28 14:10:10 +01:00
Peter Fabian 8600987591 Functions are not needed when the gateway is disabled. 2020-01-28 14:07:50 +01:00
Peter Fabian dc9d4496e9 Require order object to prevent error. 2020-01-28 14:06:02 +01:00
Claudio Sanches 2453dc9fe1 Fixed check for the method 2019-10-02 14:36:05 -03:00
Claudio Sanches 4c023c5e8a Changed thank you page text to follow PayPal guidelines
Also fixed coding standards
2019-10-02 14:21:12 -03:00
Claudio Sanches 3c9b9ac6a0 Revert changes from PayPal 2019-10-02 14:20:13 -03:00
Claudio Sanches 20ee6c7aed Fixed coding standards 2019-10-02 14:18:03 -03:00
Claudio Sanches b655af2e3b Changed thank you page text to follow PayPal guidelines 2019-10-02 14:17:25 -03:00
Rodrigo Primo b63ecca450
Merge pull request #24249 from miguelfspinto/patch-2
Avoid duplicated process for IPN and PDT payment
2019-09-24 17:59:56 -03:00
Rodrigo Primo e7b8e3ed7b Fix typo in order note
PR #24501 fixed a typo in a order note string. This commit fix the same
problem in another place where the same string is used.
2019-08-30 10:01:55 -03:00
Miguel Pinto 60ac27ba3e
Update class-wc-gateway-paypal-response.php 2019-08-27 22:30:33 +01:00
Mithu A Quayium fa62be3fa1
Typo fix in line: 428
The string "Payment could not captured" in line:428 should be "Payment could not be captured" instead, since it is appropriate grammatically.
2019-08-26 11:32:40 +06:00
Miguel Pinto ae4eba45ec
Update class-wc-gateway-paypal-response.php 2019-08-01 16:19:17 +01:00
Miguel Pinto 77f4a3e25b
Update class-wc-gateway-paypal-response.php 2019-07-31 09:48:41 +01:00
Miguel Pinto de978dad28
Update class-wc-gateway-paypal-response.php 2019-07-30 21:31:55 +01:00
Miguel Pinto d7b54ccb35
Update class-wc-gateway-paypal-response.php 2019-07-30 20:56:43 +01:00
Miguel Pinto ce4f0edc3a
Avoid duplicated process for IPN and PDT payment
Currently, Woocommerce is processing twice the payment when IPN and PDT notifications are enable. This mean that stock is reduced twice.
2019-07-29 09:25:30 +01:00
Gerhard 70231461b2 Refactor logic for passing no_shipping, it should only be passed when no shipping items are available. 2019-05-21 08:11:36 +02:00
Gerhard 8332bed7bc Do not pass no_shipping when not using send shipping address options in paypal, it still needs to use the billing details. 2019-05-20 14:59:48 +02:00
Gerhard af678dfc84 Switch paypal capture_payment method to use woocommerce_order_status_processing and woocommerce_order_status_completed instead to avoid issues with custom from status transitions.
Update get_post_meta usage with $order->get_meta instead.
2019-05-07 12:57:59 +02:00
David Jensen 9b58e68e85 Remove html tags from product name in request to PayPal 2019-04-12 12:36:30 -07:00
Claudio Sanches e5e64d1618 Apply wc_sanitize_phone_number in WC_Gateway_Paypal_Request 2019-03-07 14:08:40 -03:00
Mike Jolley 55b27a2afc Adjust calling code prefix logic in paypal 2019-03-06 12:33:46 +00:00
Mike Jolley 65c0169726 Merge branch 'master' into fix/21110 2019-03-06 12:25:12 +00:00
Mike Jolley 4330b2eb38 Update calling code handling 2019-03-06 12:25:06 +00:00
Mike Jolley 49065c0d1a Add meta data, before changing order status 2019-02-27 14:50:37 +00:00
Mike Jolley 7306bf6382
Merge pull request #22763 from woocommerce/fix/paypal-bn-code
Move PayPal BN partner ID
2019-02-19 09:42:05 +00:00
Mike Jolley 8abe75f36d Merge branch 'fix/21463' 2019-02-18 17:20:48 +00:00
Mike Jolley 3ededc2a07 Move BN partner ID 2019-02-18 16:29:29 +00:00
Mike Jolley f0675781c8 Include calling code in pp request 2019-02-08 11:10:26 +00:00
Mike Jolley dca47d5d14 Use mb functions for limiting string length 2019-02-07 19:09:41 +00:00
Mike Jolley dbd324abc3 phpcs 2019-02-07 14:55:56 +00:00
Mike Jolley ebdeab4c22 Added woocommerce_paypal_force_one_line_item filter 2019-02-04 16:31:17 +00:00
Mike Jolley 6367d19615 phpcs 2019-01-21 08:11:40 -08:00
Claudiu Lodromanean 00d254ac18
Merge pull request #21715 from angelleye/21714
Sets signature field type to password for security, resolves #21714
2018-11-02 08:09:56 -07:00
angelleye f995c2e070 Changes field type to password for live Signature field, resolves #21714 2018-10-31 12:32:40 -05:00
Gerhard aba734f033 Make PDT validation use the same rounding as the IPN validation. 2018-10-29 11:50:47 +02:00
angelleye 7ec6f3f67b Sets signature field type to password for security, resolves #21714 2018-10-27 06:21:56 -05:00