vedanshujain
c01f32a390
Use default value if formatted value is not available
2020-10-14 14:51:19 +05:30
vedanshujain
8e12de5d3c
Merge branch 'fix/api/229-unit-test' of https://github.com/shiki/woocommerce into fix/api/229
2020-10-14 13:53:03 +05:30
Rua Haszard
95f4b5b81e
restore original comment (related changes are gone)
2020-10-14 12:35:32 +13:00
Rua Haszard
5e3713da75
check password-set user token before redirecting to set password form:
...
- this prevents the password reset process earlier (before the redirect)
- also now shows a notice informing the user that they need to log out
of (other) account
2020-10-14 12:26:51 +13:00
Rua Haszard
1f5601f0fe
ensure lost-password form only resets password for correct user:
...
- if a user is logged in, check their ID matches the ID in the reset
key / token
2020-10-14 12:12:01 +13:00
Rua Haszard
5e5d06cfab
show lost-password form when logged-in user:
...
- in the checkout signup use case, the user may be setting their
password in a logged-in browser session; they need to be able to set an
initial account password
2020-10-14 09:50:36 +13:00
Rua Haszard
b34ad5be5c
improve PHPdocs for get_endpoint_title and related hook:
...
- add @since (original since based on git blame)
- document all params
- add @since for newly-added params
- add docs for woocommerce_endpoint_{$endpoint}_title
2020-10-14 09:50:36 +13:00
Rua Haszard
6032962e59
use "Set password" title for lost-password endpoint for more actions:
...
- 'rp' and 'resetpass' are used in WordPress core
1079647d30/wp-login.php (L913)
- using 'newaccount' for checkout signup case
2020-10-14 09:50:36 +13:00
Rua Haszard
1eb02845aa
support overriding/customising password reset page title via `action`:
...
- get_endpoint_title now takes an extra `action` param
- this also is passed to the relevant hook (as an additional arg)
- woocommerce_endpoint_{$endpoint}_title
- for `lost-password?action=rp`, use `Set password`
- pass action query param through when using get_endpoint_title
2020-10-14 09:50:36 +13:00
Claudio Sanches
e655b44717
Fixed coding standards
2020-10-13 22:32:32 +05:30
Shiki
2e165e7558
Orders: Make display_key and _value meta available for v3 and v3
...
This resolves the intentionally failing
WC_Tests_API_Orders_V2::test_get_item_with_line_items_meta_data.
2020-10-13 22:32:31 +05:30
Shiki
a3f46e5526
Schema: Make display_key and *_value available for v3 and v2
...
This is just the schema and the actual functionality isn't implemented yet.
2020-10-13 22:32:30 +05:30
Shiki
b9ae830da5
Fix formatting in Orders V2 unit test
2020-10-13 22:32:30 +05:30
Shiki
f45e8b884b
Orders V3: Reuse WC_Order_Item->get_formatted_meta_data
...
Previously, I was using my own function. This time, we're using the function
available in WC_Order_Item but sanitizing the results after.
2020-10-13 22:32:30 +05:30
Shiki
2e92460df2
Orders V3: Include display_key and display_value in item meta_data
2020-10-13 22:32:30 +05:30
Shiki
d8ac282c80
Orders V3 Schema: Add display_key and display_value for meta props
2020-10-13 22:32:29 +05:30
James Allan
1fcedb5279
Removes the remaining uses of $order->get_product_from_item
2020-10-13 11:24:48 +10:00
sudoshreyansh
f1d89e6e78
Fixed taxonomy term message
2020-10-09 13:16:40 +05:30
Néstor Soriano
c15488d840
Merge pull request #27830 from woocommerce/php8/fix-round-function-with-non-numeric-argument
2020-10-09 08:01:44 +02:00
Rodrigo Primo
6861fdab5d
Update @version in which a filter was added
2020-10-08 17:03:09 -03:00
Jon Campbell
0fedb0db7a
Added filter for low stock notification emails ( #27819 )
...
* Adding new filter for low stock notification
* Update class-wc-emails.php
fixing whitespace
2020-10-08 17:02:09 -03:00
Ron Rennick
4a8898dfbd
restore $attachment_ids for product thumbnails template
2020-10-08 15:08:03 -03:00
Néstor Soriano
e4b78cedbf
Merge pull request #27748 from woocommerce/remove-leftovers-from-improved-filtering-by-attribute-for-variations
...
Remove leftovers from the reverted improved filtering mechanism for variations
2020-10-08 15:45:09 +02:00
Rodrigo Primo
0771138604
Merge pull request #27707 from dd32/php8/warnings
...
PHP8 Warning: Change __wakeup() to a public method
2020-10-08 10:01:21 -03:00
Néstor Soriano
ab529835fa
Merge pull request #27840 from woocommerce/php8/fix-required-parameters-after-optional
...
[PHP 8] Convert optional-before-required parameters into required parameters
2020-10-08 14:22:52 +02:00
Vedanshu Jain
8a9fa0d27b
Merge pull request #27587 from om4james/fix/26847-rest-api-auth
...
Fix HTTP 401 `woocommerce_rest_cannot_view` `Sorry, you cannot list resources` REST API response
2020-10-08 16:32:03 +05:30
Nestor Soriano
b71f876cba
Reintroduce the dependency injection related code.
...
After the League's Container package has been reintroduced, all the
code that implements the dependency injection mechanism in woocommerce
can be brought back as well.
2020-10-08 09:28:05 +02:00
James Collins
79dd557b77
Return true to indicate that authentication using this method was successful
2020-10-08 09:33:33 +08:00
Ron Rennick
175499b40a
Merge branch 'master' into fix/27215
2020-10-07 15:59:19 -03:00
Ron Rennick
577494796c
Merge pull request #27736 from woocommerce/fix/27681
...
Update taxonomy template file names to `-`
2020-10-07 15:23:11 -03:00
Ron Rennick
24ec59cf26
fix merge conflict
2020-10-07 15:19:05 -03:00
Ron Rennick
67a54b3aa3
Merge pull request #27289 from woocommerce/fix/27222
...
use first gallery image on single product when image not assigned
2020-10-07 15:06:30 -03:00
Dominic Vermeulen-Smith
c054a2803b
issue #24631 - Updated needs payment check to use order
2020-10-06 17:38:07 +01:00
Knyazevich
ce59afb2b9
Simplify drafts excluding logic (ref #24136 )
2020-10-06 18:11:58 +03:00
Knyazevich
f551c6c792
Exclude drafts from the "Shop page" select (ref #24136 )
2020-10-06 06:42:56 +03:00
Ron Rennick
ab4a46e32e
Merge pull request #27299 from woocommerce/fix/27116
...
allow variation image to be removed via REST API
2020-10-05 09:33:50 -03:00
rowayda_khayri
547451560c
Add punctuation mark to function's docblock
2020-10-03 20:52:57 +02:00
sudoshreyansh
7f9162d776
Fixed update term messages. Issue: #27831
2020-10-03 22:55:16 +05:30
sudoshreyansh
dd9bf06594
Fixed </strong> closing tag position. Issue: #27839
2020-10-02 15:46:41 +05:30
Nestor Soriano
7485b9165f
Convert optional-before-required arguments to required.
...
In PHP 8 required parameters after optional parameters in
function/method signatures trigger a deprecation notice. These type
of parameters are pointless since a value needs to always be
provided for them anyway, so they are actually de-facto required.
This commit converts all these not-so-optional parameters into
truly required parameters by removing their default values.
2020-10-02 09:45:09 +02:00
Nestor Soriano
53d33457e3
Fix code style/sniffer errors in a few files.
2020-10-02 09:34:09 +02:00
Nestor Soriano
52eed70f04
Add a 'NumberUtil' class with a 'round' method.
...
There's a number of places in the WooCommerce codebase where the
built-in function 'round' is executed passing a non-numeric value
(not a number and not a string that can be parsed as a number),
for example round(''). In PHP 7 this yields a value of 0, but in
PHP 8 this throws an error.
This commit adds a 'NumberUtil' class with a static 'round' method,
this method checks if the passed value is numeric and if so it just
executes the built-in function, otherwise it returns 0. And all the
calls to 'round' in the codebase are replaced with 'NumberUtil::round'.
2020-10-01 11:08:51 +02:00
Nestor Soriano
b1e81d02da
Fix code style/sniffer errors in a few files.
2020-10-01 11:08:51 +02:00
Jonathan Sadowski
e540b4820e
Rename maybe_enable_setup_wizard to maybe_set_activation_transients
2020-09-30 17:27:43 -05:00
Jonathan Sadowski
83238ec1d7
Move maybe_enable_setup_wizard abode update_wc_version so new install is detected
2020-09-30 17:01:43 -05:00
Jonathan Sadowski
95755cb59d
Update the activation transient to only get added on new installs
2020-09-30 16:00:45 -05:00
Joshua Flowers
048c43a37f
Add back in activation transient to redirect on install
2020-09-29 14:25:15 -04:00
Mateusz Gbiorczyk
b730298ee6
Escaping output for field label
2020-09-29 14:25:56 +02:00
Ron Rennick
802b364b05
Merge branch 'master' into fix/27681
2020-09-28 16:17:51 -03:00
Nestor Soriano
f419335cdf
Remove the migration to delete variation term relationships.
2020-09-28 09:35:13 +02:00
Milana Cap
7c184e5f25
Update class-wc-countries.php
2020-09-24 22:41:33 +02:00
vedanshujain
c69e1f5799
Remove protection as we already diff and update only if needed.
...
In #26642 we removed adding reduced_stock meta when adding new order item to prevent ghost entries, but in inadvertently exposed an underlying bug where _reduced_stock meta was getting set to 0 if its emtpy.
We were then checking the presence of this meta, but also not reducing the stock in case it was not set.
2020-09-24 00:54:24 +05:30
Nestor Soriano
849a64d67c
Add a data migration for removing term relationships related to variations
...
After the code that creates term relationships for variations has been
removed, a data migration is required to remove all the no longer needed
term relationships.
Also, the original migration that backfilled those relationships has
been removed (the migration function is kept but with an empty body).
2020-09-22 16:31:38 +02:00
Nestor Soriano
a94ea7f51f
Remove logic for storage of attribute terms for variations
...
A mechanism for improved filtering by attribute for variations was
introduced some time ago. This mechanism implied maintaining term
relationships for variations, where the terms were the attributes
that defined the variation.
The mechanism was reverted because it was complex and presented many
issues, but the code that created those term relationships was kept.
This pull request removes that code and the associated unit tests.
2020-09-22 16:31:06 +02:00
Rodrigo Primo
c3a72b994a
Fix version in which the setup wizard was deprecated
...
The setup wizard is going to be deprecated in WC 4.6.0 which should be
released soon. Some functions were marked as if they were deprecated in
WC 4.5.0 which is not the case.
2020-09-22 11:20:33 -03:00
Rodrigo Primo
51fd4af1b2
Remove call to __() from deprecation messages
...
Doing this as AFAIK we don't typically support traslation for
deprecation messages.
2020-09-22 11:18:43 -03:00
James Collins
ce31260452
Return early if another plugin has already declared an auth failure
2020-09-22 16:17:35 +08:00
Claudio Sanches
3391d8c0b0
Merge pull request #27718 from woocommerce/bump-versions-to-4.7.0
...
Bump WC version to 4.7.0
2020-09-21 16:21:09 -03:00
Ron Rennick
6a36bce334
tweak logic to use `woocommerce/*-*` templates in theme folder
2020-09-21 14:12:22 -03:00
Ron Rennick
bb6ded857d
phpcs fixes
2020-09-21 13:34:14 -03:00
Ron Rennick
57fa6aff83
update taxonomy template names from `_` to `-`
2020-09-21 13:30:29 -03:00
Alex Stewart
b58dc02183
Introduced fine-grained cultural adaptation for Jamaican-based WooCommerce stores
2020-09-20 14:10:27 -05:00
Rodrigo Primo
6a641c4b1d
Bump WC version to 4.7.0
2020-09-19 15:24:12 -03:00
Rodrigo Primo
7401982d37
Merge pull request #27047 from woocommerce/fix/26972
...
Removed Features settings and home screen option
2020-09-18 16:46:43 -03:00
Ron Rennick
9ae1ba92c6
remove WC_Admin_Setup_Wizard_Tracking from tracking classes
2020-09-18 15:26:18 -03:00
Ron Rennick
0735ed9f40
Merge branch 'fix/26173' of github.com:woocommerce/woocommerce into fix/26173
2020-09-18 15:23:08 -03:00
Ron Rennick
4b3b40d42e
address feedback
2020-09-18 15:22:24 -03:00
Rodrigo Primo
f3191907d9
Add missing line break
2020-09-18 14:25:25 -03:00
Ron Rennick
43051a0950
update deprecation versions to 4.6.0
2020-09-18 13:16:46 -03:00
Ron Rennick
cca97599d7
only automatically create pages on new install
2020-09-18 13:10:11 -03:00
Ron Rennick
9915a5b142
merge master
2020-09-18 12:53:28 -03:00
Ron Rennick
6630f3fdba
remove class accidentally added to PR
2020-09-18 12:41:57 -03:00
Rodrigo Primo
d99053dbed
Update version in @since tag of the woocommerce_should_send_no_stock_notification filter
2020-09-18 12:08:36 -03:00
Rodrigo Primo
8be6dc5b96
Merge pull request #27634 from jondcampbell/master
...
Added filter for no stock notification emails
2020-09-18 12:07:04 -03:00
Rodrigo Primo
60d6510cb0
Merge pull request #27685 from woocommerce/add/wp-env-type-to-wc-tracker
...
Added environment type var to WC tracker.
2020-09-18 11:30:35 -03:00
Rodrigo Primo
197e8d274c
Merge pull request #27616 from woocommerce/fix/26960
...
Paypal gateway: protect code against a fatal error if WooCommerce is unable to communicate with PayPal
2020-09-18 09:34:57 -03:00
Peter Fabian
ed9c1e2f93
Update includes/class-wc-tracker.php
...
Co-authored-by: Claudio Sanches <contato@claudiosanches.com>
2020-09-18 14:30:39 +02:00
Dion Hulse
9440ec3570
Change __wakeup() to a public method to avoid PHP8 warning.
2020-09-18 07:55:26 +00:00
Claudio Sanches
29b8b0d60d
Merge pull request #27701 from woocommerce/fix/rest-api-package-tag
...
Fixed usage of package tag in REST API and templates
2020-09-17 18:45:14 -03:00
Claudio Sanches
153ce009de
Fixed helper header
2020-09-17 16:50:17 -03:00
Claudio Sanches
3377c60c5e
Merge pull request #27433 from woocommerce/fix/remove-relative-include-paths
...
Change relative include paths to absolute include paths
2020-09-17 13:15:40 -03:00
Claudio Sanches
f4e9fcc1a4
Fixed missing include
2020-09-17 13:12:57 -03:00
Claudio Sanches
70c7adfeb7
Fixed usage of package tag in REST API and templates
2020-09-17 11:56:08 -03:00
Claudio Sanches
ed1a59b39b
Merge pull request #27416 from woocommerce/fix/27415
...
Fixed country list sorting
2020-09-17 10:35:43 -03:00
Konstantin Kovshenin
a100ed67b2
Fix race conditions in WC_Install
...
In an environment with persistent object caching, concurrent calls
to delete_option() + add_option() can result in the option value
leaking out of the alloptions cache key, and into its own cache
item under the options group, while deleting the value from the
database.
This causes future function calls to add_option() to fail, since
the value already exists in cache (under the wrong key). It also
causes calls to delete_option() to fail, since the value is not
in the database.
This commit forces update_option() instead of the delete + add
combination, as well as removes multiple unnecessary calls to
update the woocommerce_db_version from admin notes and notices.
2020-09-17 11:59:50 +03:00
Peter Fabian
b8670162a7
Added environment type var to WC tracker.
2020-09-16 13:44:36 +02:00
Grzegorz Rola
75d9a8942c
Fixed cart weight return type.
2020-09-14 11:32:05 +02:00
Anton Timmermans
723f14e44a
Improve bool <-> string conversion functions docs
...
These functions are polymorphic towards their input types to be more useful in more cases. Change the documentation to reflect this fact.
2020-09-13 13:01:14 +02:00
Rodrigo Primo
9bdafbeb18
Merge pull request #27219 from woocommerce/fix/filter-quantity-in-add_to_cart_handler_grouped
...
Filter quantity in add_to_cart_handler_grouped
2020-09-12 15:56:49 -03:00
Rodrigo Primo
a24937556a
Merge pull request #27658 from woocommerce/update/4.6.0-dev
...
Prepare master for 4.6.0 development
2020-09-12 11:18:22 -03:00
Rodrigo Primo
f345a1e0c8
Merge pull request #27615 from woocommerce/fix/26590
...
Fix bug when using tax classes with some non-ASCII characters
2020-09-11 14:48:10 -03:00
Rodrigo Primo
d7b2207e75
Merge pull request #27610 from attitude/patch-1
...
Encapsulate scope of `c` variable
2020-09-11 14:27:06 -03:00
Rodrigo Primo
fd25815a7c
Prepare master for 4.6.0 development
2020-09-11 14:07:58 -03:00
Jon Campbell
bb949ae474
simplifying filter usage
...
Switched to product id instead of product object
Moving the filter into the if condition instead of having a single use variable
2020-09-11 09:38:52 -07:00
Claudio Sanches
b5d8d94bc8
Use reference in wc_asort_by_locale
2020-09-10 16:02:39 -03:00
jonathansadowski
2bcdbacc98
Merge pull request #27625 from woocommerce/revert-improved-filtering-for-variations
...
Revert improved filtering for variations
2020-09-10 12:42:15 -05:00
Nestor Soriano
4411a394dc
Reintroduce adjust_posts_count, and remove unnecessary comment.
...
We can't remove that method since it's public, but its body has
been changed so that it just returns the input unchanged.
2020-09-10 15:17:43 +02:00
Jon Campbell
642b5b958e
Update class-wc-emails.php
...
removing whitespace to be coding standards compliant.
2020-09-09 16:32:12 -07:00
Jon Campbell
188f839e70
add no stock notification filter
2020-09-09 12:07:15 -07:00
Christopher Allford
ae697f9fe2
Prevented zero from being considered empty when validating posted variation attributes
2020-09-09 11:29:31 -07:00