Commit Graph

13472 Commits

Author SHA1 Message Date
The Dramatist 1783953f15 Admin metaboxes views translation escaping fix (#17776)
* Data escaped and validated. Plus translator comment documentation added.

* If it should be int then we should change the empty string default parameter to 0 as in 'if' condition checking 0 and empty string are same.

* Extra bracket removed.

* Indentation is fixed now.

* The taxonomy object should not be assigned to a variable before checking if this is a taxonomy or not.

* echo esc_attr__ replaced by esc_attr_e and visually tested.

* As I use WordPress VIP Coding Standard, they were marking them as warnings. But now it's fixed again.

* Escaping fix

* Extra Bracket Fix Again
2017-11-21 17:50:30 +00:00
Claudiu Lodromanean 5af225a2c8
Merge pull request #17846 from woocommerce/fix/17845
Slugs are encoded, so decode before outputting to the form
2017-11-21 09:27:03 -08:00
Mike Jolley 208b2d1b81 Slugs are encoded, so decode before outputting to the form
Fixes #17845
2017-11-21 16:50:33 +00:00
JeroenSormani b96fea3e47 Add quantity arg to woocommerce_add_cart_item_data filter 2017-11-21 16:01:23 +01:00
Mike Jolley 78ddd97472
Merge pull request #17822 from woocommerce/fix/17733
Use WC_Query->get_query_vars() instead of WC_Query->query_vars
2017-11-21 14:00:53 +00:00
Mike Jolley 8b02185596
Merge pull request #17817 from JeroenSormani/exclude-virtual-from-shipping-tax
Exclude virtual tax classes from calcluation for shipping taxes
2017-11-21 13:21:13 +00:00
Mike Jolley 1c12459367
Merge pull request #17827 from woocommerce/fix/missing-text-domain
Fixed missing text domain in setup wizard
2017-11-21 13:13:59 +00:00
Claudio Sanches 34ec7a013f
Merge pull request #17835 from woocommerce/fix/17815
Checkout should store fee tax lines
2017-11-21 11:06:01 -02:00
Claudio Sanches 216ddc799a Fixed VSCode auto align mistake
One more reason to go back to sublime
2017-11-21 10:53:15 -02:00
Mike Jolley d9913c0d77 Checkout should store fee tax lines
Fixes #17815
2017-11-21 10:49:26 +00:00
Claudio Sanches f395fcd2e8 Fixed missing text domain in setup wizard 2017-11-20 22:08:23 -02:00
Claudio Sanches 9681a331e9 Fixed coding standards 2017-11-20 20:19:09 -02:00
Mike Jolley 2e08bfdb33 Tweak where meta gets sanitized before passing to comparison function 2017-11-20 21:48:35 +00:00
Mike Jolley 698db6c131 When custom attributes are created, they are decoded. Make the values match.
When we create/link variations, the entities are decoded.

When the variation form is posted, the entities are encoded (esc_attr).
This decodes them so they match correctly. Fixes #17820
2017-11-20 20:51:32 +00:00
JeroenSormani 14e5bcd51d Exclude virtual tax classes from calcluation for shipping taxes 2017-11-20 20:14:23 +01:00
Claudio Sanches 5a858eb2b1 Use WC_Query->get_query_vars() instead of WC_Query->query_vars
Closes #17733
2017-11-20 14:40:56 -02:00
Mike Jolley c8d1a46315 Default rounding to true. 2017-11-20 16:37:44 +00:00
Mike Jolley ec5db3b123 When adding precision to taxes, don't round when adding precision. 2017-11-20 16:30:23 +00:00
Mike Jolley 80ffcfb45d Add round param for `wc_add_number_precision`
Let’s us return the cent value without rounding to an integer.
2017-11-20 16:30:04 +00:00
Mike Jolley 1bd30af0d0
Merge pull request #17803 from woocommerce/fix/17600
Regenerate download permissions when linking orders.
2017-11-20 12:38:46 +00:00
Mike Jolley 99d8d30ec0
Merge pull request #17810 from woocommerce/fix/17762
Apostrophe in product search breaks nav filters (invalid characters in hrefs & form data)
2017-11-20 12:16:01 +00:00
Mike Jolley 46775c2f7d standards 2017-11-20 12:14:05 +00:00
The Dramatist 67aced7d62 Unused variable removed and some comment added. (#17786) 2017-11-20 11:47:16 +00:00
Mike Jolley 6e581a313d
Merge pull request #17802 from woocommerce/fix/17780
Image resize sizes array exist check
2017-11-20 11:32:27 +00:00
Mike Jolley c05d8ac94f
Merge pull request #17799 from axelmm/patch-2
Access to importer parameters - DRY
2017-11-20 11:31:57 +00:00
Mike Jolley bfdd5e2e45
Merge pull request #17800 from shivapoudel/tweak/api-request
Tweak - Fix IPN validation for PayPal as its notify URL has different case
2017-11-20 11:31:17 +00:00
Gerhard Potgieter 26c7cf15cd Use single isset with multiple params instead of multiple isset's 2017-11-20 13:23:10 +02:00
Mike Jolley dff41d3e83
Merge pull request #17793 from jamesckemp/patch-7
Minor grammar change
2017-11-20 11:17:34 +00:00
Mike Jolley deeadccf78
Merge pull request #17790 from mensmaximus/patch-2
Fix method upload_dir in class WC_Admin_Post_Types
2017-11-20 11:16:05 +00:00
Gerhard Potgieter 95b669280a Refactor wc_update_new_customer_past_orders to not call update_post_meta directly but use the datastore. Check if order has downloadable items and then regenerate permissions. 2017-11-20 08:44:42 +02:00
Gerhard Potgieter b7f76e1a1b Make sure sizes array exist before checking for children 2017-11-20 07:50:35 +02:00
Shiva Poudel 4eaeff1729 Tweak - Fix IPN validation for PayPal as its notify URL has different case 2017-11-20 07:52:15 +05:45
axelmm 1a309856c3
Access to importer parameters - DRY
Access (read only) to params can be required in many cases when you're playing with importing. 
In my case it was extending importer with filters and actions (procedural way - within original csv importer process) but it relates to objective way (extending importer class), too.

I wanted to know if 'update_existing' flag is set (other way than $_POST values) within filter 'woocommerce_product_importer_parsed_data' in parse/expand loop (called from class-wc-product-csv-importer.php 'set_parsed_data' method). Unfortunately this (and similiar) filter doesn't receive importer instance, only row data (raw, parsed and product object). Thanks to https://github.com/woocommerce/woocommerce/pull/15796 we have 'woocommerce_product_importer_formatting_callbacks' filter receiving importer instance. Unfortunately importer '$params' field is not accessible (protected in abstract). This PR resolves this simple problem - we can get this flag (and other params) before importing loops, processing rows etc.
2017-11-20 02:09:49 +01:00
James Kemp 5c03d9cbd5
Minor grammar change 2017-11-18 22:08:42 +00:00
Claudiu Lodromanean 106e6533f2
Merge pull request #17781 from woocommerce/fix/17629
When populating defaults, sanitize
2017-11-18 13:40:40 -08:00
Claudiu Lodromanean 89e729cd8e
Merge pull request #17784 from woocommerce/fix/17775-4.9
Fix 4.9 conflict with variation names
2017-11-18 13:37:20 -08:00
Alexandre GASNE 0018b4349e Fix: Apostrophe wrongly escaped for price nav filter and widget nav filters 2017-11-18 20:11:53 +01:00
Michael Weichselgartner ff8326b20e
Fix method upload_dir in class WC_Admin_Post_Types
Fix undefined variable `$uploads` in method `upload_dir` from class `WC_Admin_Post_Types` by reverting back to `$pathdata` as reported in #17789
2017-11-18 20:06:45 +01:00
Mike Jolley 55433aa7a9
Merge pull request #17785 from shivapoudel/fix/visibility-featured
Correct escape for featured product checkbox
2017-11-18 18:29:30 +00:00
Mike Jolley a765367dd5
Merge pull request #17747 from woocommerce/feature/allow-add-content-to-order-preview
Introduce hooks to allow custom content into order preview
2017-11-18 18:26:08 +00:00
Michael Weichselgartner 7164a7e190
Update class-wc-admin-post-types.php 2017-11-18 18:16:18 +01:00
Shiva Poudel 1fbc4e77cc Tweak - Display featured product checkbox inline 2017-11-18 21:43:09 +05:45
Mike Jolley a23541ad5d Fix 4.9 conflict with variation names
`santiize-title` works differently with `/` chars in 4.9. This update
routine keeps variations functioning by doing a DB update on read.

Fixes #17775
2017-11-18 14:53:18 +00:00
Mike Jolley 8a2050e066 When populating defaults, sanitize
part of #17775

Caused by https://github.com/woocommerce/woocommerce/pull/17629/files
leaving attribute names uppercase.
2017-11-18 13:55:26 +00:00
Claudio Sanches b4347f4071 Restore global $GLOBALS['post'] after render products shortcode
Closes #17769
2017-11-17 18:38:30 -02:00
Claudio Sanches 7c955591d7 Introduces _start and _end hooks into order preview template 2017-11-17 18:30:01 -02:00
Claudio Sanches 3f6dfb531c
Merge pull request #17748 from woocommerce/fix/orders-rest-api-schema-types
Rest API: Update the schema types for tax_class and price
2017-11-17 17:54:10 -02:00
Claudio Sanches d9d27a9a97 Fixed "tax_class" type in REST API v1 2017-11-17 17:52:12 -02:00
Claudiu Lodromanean 9c1d3b8108
Merge pull request #17726 from woocommerce/fix/17713
non-enabled children should not be ignored
2017-11-17 10:07:38 -08:00
Mike Jolley 72e078e83e Merge branch 'fix/17236'
# Conflicts:
#	includes/class-woocommerce.php
2017-11-17 12:49:02 +00:00
Mike Jolley 21e51b9fc6
Merge pull request #17692 from woocommerce/update/16925
Add add_to_cart_description method and aria-labels to cart buttons in the loop
2017-11-17 12:35:50 +00:00
Mike Jolley 14a657e7cc
Merge pull request #17728 from woocommerce/fix/17712
Default variation tax class should be 'same as parent'
2017-11-17 12:22:11 +00:00
Mike Jolley 8fe5d6bad0
Merge pull request #17676 from woocommerce/update/17672
Clear transients when product terms are updated
2017-11-17 12:21:53 +00:00
Mike Jolley 97d9a35437 Merge branch 'feature/regenerate-images'
# Conflicts:
#	includes/class-woocommerce.php
2017-11-17 12:12:35 +00:00
Mike Jolley 9b68610c7b
Merge pull request #17718 from woocommerce/fix/17717
Added missing meta info (author and date) when adding order note.
2017-11-17 12:03:31 +00:00
Mike Jolley e9ba9736fc
Merge pull request #17740 from woocommerce/fix/wizard-payment-escaping
Wizard: Fix escaping in payment description
2017-11-17 11:47:59 +00:00
The Dramatist 85ce4e0078 Class wc emails backorder method extract function removed (#17724)
* Replaced extract() function usage.

Usage of `extract()` is kinda discouraged. Though here the array `$args` is verified, I think avoiding this `extract()` function will make it better. Besides, without `extract()` the code is more readable and easily understandable.

* Object checking should be done.

Checking `$args['product']` is an object or not should be done before `get_formatted_name()` method is being called.
2017-11-17 11:38:26 +00:00
Kelly Dwan 5bb04dd61f Rest API: Update the schema types for tax_class and price 2017-11-16 16:39:14 -05:00
Claudio Sanches 563896931e Introduced hooks to allow custom content into order preview 2017-11-16 18:48:47 -02:00
Mike Jolley bdea242019 Schema: Attributes are an array of strings 2017-11-16 19:44:14 +00:00
Mike Jolley a899b53b57 Unit test fix: Exclude syntax_highlighting 2017-11-16 18:58:09 +00:00
Claudio Sanches 01983e6b96 Query and save only IDs of products when fetching products by shortcode 2017-11-16 15:14:36 -02:00
Valerie e9985146d5 Wizard: Fix escaping in payment description 2017-11-16 11:29:21 -05:00
claudiulodro dd0f748211 Fix invalid html 2017-11-16 08:01:59 -08:00
Mike Jolley 591806fd20
Merge pull request #17730 from JeroenSormani/profile-copy-button
Assign type='button' to 'Copy from billing address'
2017-11-16 14:43:46 +00:00
JeroenSormani 453862c02f Assign type='button' to 'Copy from billing address' 2017-11-16 14:46:05 +01:00
Gerhard Potgieter a4532b1e0b Make method private again and add new method that checks if new theme declares theme support with custom sizes before generating images. 2017-11-16 15:02:34 +02:00
Gerhard Potgieter c9cd9b033b Public method not private, self not $this. 2017-11-16 14:53:44 +02:00
Boro Sitnikovski fe9b9658a5 Skip wp_kses_post call on image 2017-11-16 13:48:04 +01:00
Gerhard Potgieter 17e588d713 Add method to regenerate images when the theme is switched. 2017-11-16 14:37:33 +02:00
Mike Jolley 710927a278 Default variation tax class should be 'same as parent'
Closes #17712
2017-11-16 12:19:31 +00:00
Gerhard Potgieter 3a738d9235 Move filters before calling the callback. Target specific option only when doing the check. 2017-11-16 14:15:30 +02:00
Mike Jolley 4e836754a8 Merge branch 'master' into fix/17713 2017-11-16 12:04:26 +00:00
Mike Jolley 72b3b5055b FIx variable in get_object_subtotal 2017-11-16 12:03:02 +00:00
Mike Jolley 11d0293ddd non-enabled children should not be ignored
This fixes #17713 by also returning private children (non-enabled).
2017-11-16 11:56:51 +00:00
Mike Jolley 541dde95b3
Merge pull request #17710 from woocommerce/fix/17697-coupon-spend-incl-taxes
Coupon min/max spend based on displayed subtotal
2017-11-16 10:59:43 +00:00
Gerhard Potgieter a59f325f41 Add get_object_subtotal helper method, remove subtotal variable in favor of helper method 2017-11-16 12:43:50 +02:00
Gerhard Potgieter 3af77f13d8 Change tooltip to just say subtotal 2017-11-16 12:28:43 +02:00
Claudiu Lodromanean 6c82861522
Merge pull request #17716 from woocommerce/fix/use-add_filter
Use `add_filter` for `comment_feed_where` hook.
2017-11-15 14:37:34 -08:00
Claudiu Lodromanean 6b3fd8e403
Merge pull request #17715 from woocommerce/update/17601
Variation add to cart logic
2017-11-15 14:35:52 -08:00
Akeda Bagus 6572ee7852
Added missing meta info (author and date) when adding order note.
Fixes #17717.
2017-11-16 02:03:07 +07:00
Akeda Bagus 6ae10e64e2
Use `add_filter` for `comment_feed_where` hook. 2017-11-16 00:43:12 +07:00
The Dramatist 31155ed531 Woocommerce download readfile chunk number hook proposal (#17699)
* A hook proposal to modify the chunk number.

`woocommerce_download_readfile_chunk_number` hook is proposed to make modifying the chunk number easily.

* Constant IMO declared for changeable chunk size. 

New constant `WC_CHUNK_SIZE` declared to make `WC_Download_Handler` class's `readfile_chunked` method's chunk size changeable.
2017-11-15 16:32:28 +00:00
Mike Jolley c92f61d6d4 Variation add to cart logic 2017-11-15 16:29:04 +00:00
Mike Jolley 17710b864d Tweak IPN setting wording
@claudiulodro
2017-11-15 15:12:52 +00:00
Mike Jolley 56d86aee96 trashed styling 2017-11-15 13:41:20 +00:00
Mike Jolley 128b826791 Merge branch 'master' into tweak/order-screens
# Conflicts:
#	assets/css/admin-rtl.css
#	assets/css/admin.css
#	includes/admin/class-wc-admin-post-types.php
2017-11-15 13:36:13 +00:00
Mike Jolley dea454c88e Clickable elements 2017-11-15 12:51:14 +00:00
Mike Jolley da004f3229 fix edit link 2017-11-15 12:25:44 +00:00
Mike Jolley a57edb97a7 Use passed location 2017-11-15 12:14:55 +00:00
Gerhard Potgieter 4521011219 Adjust discount on min/max spend to work based on the displayed subtotal. 2017-11-15 13:44:07 +02:00
Mike Jolley ef4859aaf0
Merge pull request #17711 from woocommerce/update/17502
Improve the Add Payment Methods display
2017-11-15 11:05:11 +00:00
Mike Jolley 599b10b286 Merge branch 'pr/17664' 2017-11-15 10:31:40 +00:00
Mike Jolley 9e2786a0a3 Today up logic 2017-11-15 10:31:31 +00:00
Gerhard Potgieter 0436e9afcb Rework tax calculations to work with inclusive and exclusive pricing 2017-11-15 12:23:52 +02:00
Mike Jolley 6a8966382d Merge branch 'pr/17690' 2017-11-15 10:21:49 +00:00
Mike Jolley e9bbb3a10f phpcs 2017-11-15 10:21:38 +00:00
Mike Jolley 76adff572e woocommerce_recently_viewed_products_widget_query_args filter
Closes #17678
2017-11-15 10:19:11 +00:00
Gerhard Potgieter 8cbca4d9d9 Include taxes in minimum and maximum coupon validation checks. 2017-11-15 12:04:02 +02:00
Mike Jolley 8dcd7f5b59
Merge pull request #17696 from yratof/patch-1
Removed class within class for admin meta boxes
2017-11-15 10:02:19 +00:00