Commit Graph

7 Commits

Author SHA1 Message Date
Tomek Wytrębowicz 5918c8ff1e Make `getIdsFromQuery` consider `0` as a valid id. (https://github.com/woocommerce/woocommerce-admin/pull/7028)
Co-authored-by: Adrian Duffell <9312929+adrianduffell@users.noreply.github.com>

- Make `getIdsFromQuery` consider `0` as a valid id.
	Previously `Boolean` filter was removing it from the list.
	Fixes https://github.com/woocommerce/woocommerce-admin/issues/6980
- Add a basic set of tests for `getIdsFromQuery`, as they were none.
- Replace `lodash.uniq` with ES6 equivalent.
- Update JSDoc for `getIdsFromQuery`, to specify default value, returned type and description.
2021-06-28 13:34:29 +02:00
Ron Rennick 9b02ba526e Use consistent markdown headers in navigation readme (https://github.com/woocommerce/woocommerce-admin/pull/5417) 2020-10-29 21:33:31 +13:00
Jeff Stieler c2020507e3 Decouple Navigation from `wcSettings`. (https://github.com/woocommerce/woocommerce-admin/pull/3294)
* Move getAdminLink to wc-admin-settings.

* Add changelog entries.

* Look for `getAdminLink()` in @woocommerce/settings first.
2019-11-22 12:07:26 -05:00
Albert Juhé Lluveras f392b5588d Replace 'stringifyQuery' with 'addQueryArgs' (https://github.com/woocommerce/woocommerce-admin/pull/2655) 2019-07-16 10:56:24 +02:00
Kevin Killingsworth 8b7e309e6f navigation: Lazy-create history (https://github.com/woocommerce/woocommerce-admin/pull/1472)
history.createHashHistory() is being called whenever this package is
imported, which causes the URL to redirect to a hash. This is
unnecessary in cases where elements of wc-admin are used outside of a
completely controlled/routed page.

This lazy-creates the history object only when it's needed and therefore
avoids the URL redirection unless history features are in use.
2019-02-06 13:28:29 -06:00
Kelly Dwan 89cee0df90 Build: Move filter code to the navigation package (https://github.com/woocommerce/woocommerce-admin/pull/803)
* Move filter code to the navigation package

- Moves filter-related code to navigation, so it can be shared between components and the app
- Fixes spelling of “flatten”
- Update README docs with new functions

* Use `get` to prevent errors if options is not an array/is empty

* Update documentation and tests
2018-11-12 11:17:18 -05:00
Kelly Dwan d27cb26ef7 Build: Move `lib/nav-utils` and `lib/history` to `@woocommerce/navigation` (https://github.com/woocommerce/woocommerce-admin/pull/763)
* Move nav-utils and history to new package

* Update config to build and use new navigation package

* Update all imports to use new navigation package

* Remove unnecessary README

* Update nav-utils path
2018-11-05 16:02:04 -05:00