In #23690 we implemented a few changes to the logic to decide which
payment gateways to display in the onboarding wizard. When working on
this code, we noticed that there was a bit of duplication in it that was
not necessary (see
https://github.com/woocommerce/woocommerce/pull/23690#discussion_r284004924).
We opted to remove this duplication in a different commit, since that PR
was included in a patch release.
This commit deletes the files assets/images/klarna-white.png and
assets/images/square-white.png. In #23690 we stopped using those two
files so there is no reason to keep them in the repository. Since #23690
was included in a patch release, we opted to keep the images for a
little longer and remove them in a minor release.
This commits changes the query used to get the number of low stock
products in the WooCommerce Status widget in the admin dashboard. This
query should only count published products and ignore products with
other statuses to match the behavior used in the low stock report.
In the query to get the number of out of stock products for the admin
dashboard widget, it is not necessary to use `1=1` and also not
necessary to use `posts.post_type IN ( 'product', 'product_variation' )`
as only products are added to wp_wc_product_meta_lookup.
NOWAIT is not supported on MySQL server 5.5,
SELECT ... FOR UPDATE can leave lingering locks on InnoDB ("When InnoDB performs a complete rollback of a transaction, all locks set by the transaction are released. However, if just a single SQL statement is rolled back as a result of an error, some of the locks set by the statement may be preserved. This happens because InnoDB stores row locks in a format such that it cannot know afterward which lock was set by which statement.", via https://dev.mysql.com/doc/refman/5.5/en/innodb-deadlock-detection.html)
This commit moves two functions declared inside a test method to their
own protected methods inside the same test class to make it easier to
read the tests and it fixes the order of the parameters for the calls to
Assert::assertEquals(). The first parameter passed to this method should
be the expected value and the second parameter should be the actual
value and not the opposite.
jorgept
Ewout Fernhout
Timmy Crawford
Rodrigo Primo
Iulia Cazan
Claudio Sanches
Gerhard Potgieter
Ron Rennick
Boris Djemrovski
Peter Fabian
parmarhardip
sokolby
James Allan
Renovate Bot