Rodrigo Primo
8ebead165e
Replace usages of depracted jQuery.fn.click() event shorthand
...
This commit replaces all instances in WooCommerce codebase (except included third-party libraries) where jQuery.fn.click( handler ) event shorthand was used. This shorthand was deprecated in jQuery 3.3 (see https://github.com/jquery/jquery/issues/3214 ). The jQuery documentation was not updated yet (see https://github.com/jquery/jquery-migrate/issues/288 and https://github.com/jquery/api.jquery.com/issues/972 ).
jQuery.click() was not deprecated and so it was not replaced.
2020-11-18 15:27:46 -03:00
haszari
3e7da11c30
fix logic for new tab check on edit product page
2019-07-12 13:42:36 +12:00
haszari
5bac98fd80
open marketplace suggestions links in same tab to simplify experience:
...
- except when inconvenient - when editing a product
2019-07-12 13:42:36 +12:00
haszari
46f2b98bca
add in-app-purchase url params to marketplace suggestions buttons
2019-07-12 13:42:35 +12:00
haszari
7ede25add7
use admin_url to generate manage suggestions url (support multisite etc)
2019-04-10 12:16:49 +12:00
haszari
cd9101bb58
fix target url of 'Manage Suggestions', settings are now in 'Advanced'
2019-04-10 12:02:09 +12:00
haszari
164eca6270
reinstate `displayed` event for suggestions not displayed in metabox:
...
- add func defining which suggestions contexts are hidden/revealable
- reinstate tracks event when rendering suggestion (for non-hidden
suggestions)
- add check in (context-sensitive) tab click handler to abort if
that context has already fired displayed events
2019-04-10 09:40:06 +12:00
Jeff Stieler
742b3d6b66
Only track product page marketplace suggestions when visible.
2019-04-09 10:23:02 -06:00
haszari
884474d133
add tracks event for clicks on `marketplace-suggestion-manage-link`
2019-04-09 13:44:15 +12:00
haszari
06de62177c
inject manage link into browse-all metabox footer suggestion
2019-04-08 10:00:25 +12:00
haszari
e75dd2c5ac
disable products list suggestions (js)
2019-04-05 11:41:15 +13:00
Claudio Sanches
08bb78a817
Fixed JSHint warnings on marketplace suggestions script
...
Fixes the follow error:
```
assets/js/admin/marketplace-suggestions.js
278 | return ! _.contains( marketplace_suggestions.active_plugins, promo['product'] );
^ ['product'] is better written in dot notation.
```
2019-03-27 13:21:54 -03:00
haszari
6294dd14e2
send empty string instead of "undefined" for optional suggestions props
2019-03-26 09:59:28 +13:00
haszari
cc78cf040f
send additional properties with suggestions tracks events:
...
- send the context/area
- details about what's promoted (product or otherwise)
- target url
2019-03-22 15:42:30 +13:00
Mike Jolley
f90f0203b5
Grunt dev
2019-03-15 12:21:51 +00:00
haszari
657b78ada2
fix up built js & missing slug prop fix after rebase
2019-03-14 15:01:45 +13:00
haszari
e3d891868d
hide product metabox suggestions markup when there are no suggestions
2019-03-14 14:55:42 +13:00
haszari
f02ba1d727
fix style for tracks prop `suggestion_slug` (lower_case not camelCase)
2019-03-14 14:08:46 +13:00
haszari
8704a32302
put products list suggestions on hiatus (month) if user dismisses 5:
...
- track the number of dismissals of products list suggestions in a cookie
- if this exceeds 5, don't show any product list suggestions
- set that cookie to expire in one month – suggestions will resume then
2019-03-08 13:11:00 +13:00
haszari
4676491c88
snooze product-list suggestions for 2 days after dismiss (was 1)
2019-03-07 10:06:52 +13:00
haszari
f944da3eac
refresh products list suggestion colspan when screen options change
2019-03-06 14:44:58 +13:00
haszari
d0fd15ea8c
Ensure product list suggestion works with different screen options
...
- calculate product-table suggestion colspan using number of columns
- was previously hard-coded
2019-03-06 14:08:14 +13:00
haszari
37cff0c7ca
fix jshint issue (const => var) + minify marketplace-suggestions
2019-03-06 13:57:18 +13:00
haszari
1ed027bb09
snooze suggestions in product list (for 24 hours) after a suggestion is dismissed
2019-03-06 10:50:22 +13:00
haszari
6caaf80fa6
add a tooltip (Dismiss this suggestion) to clarify dismiss button
2019-03-05 12:20:13 +13:00
haszari
1c53614297
fix jshint warnings
2019-03-05 10:54:06 +13:00
haszari
8b0672f6cf
streamline product edit metabox when no suggestions are visible:
...
- hide title (animate slide up)
- trigger this after dismiss, so we're not left with a heading
and no content
2019-03-05 10:38:11 +13:00
haszari
06b5b89336
fade in product list table-row suggestions, so it's less jarring
2019-03-05 10:15:18 +13:00
haszari
023579cc17
localise default CTA text + code-style improvements:
...
- else style, fix stale/presumptuous variable names
- localise default CTA text
- use `Learn More` for default, more in line with our latest content
- switch CTA default to button - link style is less common
2019-03-01 14:22:02 +13:00
haszari
fb4e574511
remove unused function arg `slug`
2019-03-01 08:40:47 +13:00
haszari
8ce8cdde6e
update suggestions JS code to use `active` (WCCOM endpoint has updated schema)
2019-02-27 16:16:49 +13:00
haszari
243f885a13
randomly select suggestions to display, to improve visibility of each one
2019-02-27 12:29:45 +13:00
haszari
0dcc87110b
Merge branch feature/marketplace-suggestions into add/product-edit-suggestions
...
# Conflicts:
#assets/css/admin-rtl.css
#assets/css/admin.css
#assets/css/marketplace-suggestions-rtl.css
#assets/css/marketplace-suggestions.css
#assets/css/marketplace-suggestions.scss
#assets/js/admin/marketplace-suggestions.js
#includes/admin/class-wc-admin-assets.php
#includes/admin/marketplace-suggestions/class-wc-marketplace-suggestions.php
2019-02-27 10:56:13 +13:00
haszari
69e3856188
show/hide suggestions based on which extensions are active:
...
- was previously based on folder names of installed plugins
2019-02-27 10:13:48 +13:00
Gerhard Potgieter
cc857be201
Merge pull request #22811 from woocommerce/add/orders-list-suggestions
...
Show marketplace suggestions in orders list empty state
2019-02-26 18:22:02 +02:00
haszari
dfae7cb9b5
automatically add utm params to suggestion urls, based on context
2019-02-26 15:48:35 +13:00
haszari
1446424ba4
hide product metabox suggestions tab (etc) when there are no suggestions
2019-02-25 16:27:49 +13:00
haszari
6a571dc353
fix regression introduced in merge - visibleSuggestions renamed
2019-02-25 16:06:50 +13:00
haszari
1aff17f0b9
Merge branch 'feature/marketplace-suggestions' into add/orders-list-suggestions
2019-02-25 16:05:04 +13:00
haszari
c1a2821410
limit maximum of 5 suggestions displayed in any given context
2019-02-25 16:00:47 +13:00
haszari
ae3f397855
allow suggestions in multiple contexts:
...
- fix regression when hiding footer
- rename `visibleSuggestions` for clarity
2019-02-25 15:59:11 +13:00
haszari
1df74d504e
allow suggestions to target multiple contexts:
...
If an array of context strings is specified in json, the suggestion will
be available for display in all specified contexts.
2019-02-25 15:30:00 +13:00
haszari
27195c3834
hide footer, screen options when show suggestions in orders empty state
2019-02-25 13:46:43 +13:00
haszari
79e7699ccd
JS code-style fixes
2019-02-22 12:54:51 +13:00
haszari
9ed6f591d3
use updated tracks API wcSettings.recordEvent => wcTracks.recordEvent
2019-02-22 11:38:55 +13:00
haszari
a7dd094b3a
frontload suggestion data as script data, remove ajax request
2019-02-22 11:23:09 +13:00
haszari
f2deef861e
prefix AJAX actions to reduce chance of collision
2019-02-21 15:56:26 +13:00
haszari
b4a36dc620
document all js methods
2019-02-21 15:51:41 +13:00
haszari
eaa1108df6
fix client side data access after change to `wp_send_json_success`
2019-02-21 10:50:43 +13:00
haszari
e37583bb2b
remove dismissed suggestions from DOM so styling updates accordingly
2019-02-21 09:52:37 +13:00