Commit Graph

325 Commits

Author SHA1 Message Date
angelleye 7ec6f3f67b Sets signature field type to password for security, resolves #21714 2018-10-27 06:21:56 -05:00
Maria Górska 0369e3d622 Enable PDT handling for custom pending statuses 2018-08-27 12:10:36 +02:00
Gerhard Potgieter c7884003dc Do not build paypal pay link when no base country is set. 2018-07-16 11:44:58 +02:00
Mike Jolley a17945d9a8
Merge pull request #20574 from woocommerce/fix/20551
Fix: set order status to refunded when a PayPal transaction is refunded
2018-06-20 14:56:25 +01:00
Rodrigo Primo 5b5256370a Ignore a single PHPCS rule instead of ignoring all rules
Replace the usage of `// @codingStandardsIgnoreStart` and `// @codingStandardsIgnoreEnd` with `// phpcs:ignore WordPress.NamingConventions.ValidHookName.UseUnderscores` on WC_Gateway_Paypal_IPN_Handler::check_response(). Ignoring a single PHPCS rule is better than ignoring everything to protect the line against potential violations of the other rules.
2018-06-19 10:44:45 -03:00
Rodrigo Primo 9263a0b169 Fix: set order status to refunded when a PayPal transaction is refunded
Commit c7a3fd2 changed the logic to check if the refund is a full refund to use the strict equal operator (`===`) in the following line:

25be9fc13c/includes/gateways/paypal/includes/class-wc-gateway-paypal-ipn-handler.php (L295)

This change broke the comparison as `$order->get_total()` will return the value respecting the number of decimals after the decimal point set in the option `woocommerce_price_num_decimals` and `wc_format_decimal()`, when called without a second parameter, will not format the received value to use the same number of decimals set in `woocommerce_price_num_decimals`. To fix this issue, this commit passes `wc_get_price_decimals()` as the second parameter to `wc_format_decimal()`. This way both values will always have the same number of decimals and the comparison should work when handling a full refund.

Fixes #20551
2018-06-19 10:42:27 -03:00
Mike Jolley 2cad2414b3 Remove manual wc_reduce_stock_levels calls 2018-06-07 18:01:38 +01:00
Mike Jolley 57ae8285b6 Mask logged PayPal data. 2018-04-30 18:17:12 +01:00
Mike Jolley aef46ce8d3 Clear paypal logs when debug mode is turned off. 2018-04-30 18:04:52 +01:00
Mike Jolley 610e9b0989 Add disclaimer to debug logging setting 2018-04-30 17:30:55 +01:00
Mike Jolley d14e59cdb0 Remove some PII from paypal logs and avoid storing custom meta from responses 2018-04-30 17:30:39 +01:00
Claudio Sanches 781d38dc51 Removed undefined wp_json_decode() function from PayPal response
Closes #19807
2018-04-20 13:26:05 -03:00
Mike Jolley 1b34cd4745 Moved settings tabs around to allow for privacy page. 2018-04-12 16:59:42 +01:00
Mike Jolley 5ac7aac369 Improve can_refund_order and add unit tests 2018-04-03 17:09:09 +01:00
Mike Jolley 7b45e90357 Merge branch 'master' into update/19302 2018-04-03 14:57:24 +01:00
Mike Jolley 51252915e1
Merge pull request #19493 from woocommerce/fix/19404
Removed line item limit and made sure the URL is shorter than 2083 ch…
2018-03-28 13:56:57 +01:00
Peter Fabian 3809ab3f4c Fixed shipping tax logic to behave the same as originally 2018-03-28 13:08:05 +02:00
Peter Fabian 59c47c4407 Refactored line item logic
- prepare_line_items is not used as a test anymore, it only updates line items
- add_line_item is not used as a test anymore, only adds line items
- added method line_items_valid to test for valid line items
- shipping tax inclusion test moved to get_shipping_cost_line_item to encapsulate shipping tax-related logic
2018-03-28 11:04:34 +02:00
Peter Fabian f39e8e3900 Removed incorrect comment 2018-03-27 16:28:25 +02:00
Peter Fabian 5eda49f98a Line item logic refactored
Renamed function get_non_line_item_args
Documentation updates
...all part of code review fixes
2018-03-27 15:55:03 +02:00
Peter Fabian 88588eccbc Code duplication removed
Added test for non line item agrument presence
Fixed incorrect comment
2018-03-26 13:05:55 +02:00
Peter Fabian e19d64e51e Fixed PHPCS violations 2018-03-26 11:00:28 +02:00
Peter Fabian 26144afbc6 Test request length after applying filter
- added default value to get_line_item_args to not break interface
- smaller code review updates
2018-03-23 17:22:09 +01:00
Mike Jolley 0573232c62 Call empty cart when completing payment in PayPal 2018-03-23 12:54:03 +00:00
Peter Fabian 27a309d2df Removed line item limit and make sure the URL is shorter than 2083 characters
- removed limit to 9 line items per Paypal order
- if the request URL with all line items will be longer than 2083 characters, send it as one line item
- fix the character limit function to account for URL encoding happening in http_build_query
2018-03-22 15:39:30 +01:00
Mike Jolley 291de9c1fb Override supports for PayPal to see if credentials exist 2018-03-13 11:35:20 +00:00
Rodrigo Primo 4e3ba1b73b phpcs fixes in includes/gateways/paypal/includes/class-wc-gateway-paypal-response.php 2018-03-09 15:45:47 -03:00
Rodrigo Primo cf5ce33e29 phpcs fixes in includes/gateways/paypal/includes/class-wc-gateway-paypal-request.php 2018-03-09 15:45:35 -03:00
Rodrigo Primo 128c4398a5 phpcs fixes in includes/gateways/paypal/includes/class-wc-gateway-paypal-pdt-handler.php 2018-03-09 15:45:22 -03:00
Rodrigo Primo 06af993595 phpcs fixes in includes/gateways/paypal/includes/class-wc-gateway-paypal-api-handler.php 2018-03-09 15:45:13 -03:00
Rodrigo Primo 93a50caa42 phpcs fixes in includes/gateways/paypal/class-wc-gateway-paypal.php 2018-03-09 15:45:00 -03:00
Rodrigo Primo 8678ed8685 Fix phpcs violations using phpcbf 2018-03-09 09:53:10 -03:00
danielshields e2da7fd277
Fix the PayPal API URL
Assuming they changed the section title, as the permalink is now "create" vs "creating"
2018-03-01 12:30:38 -05:00
Mike Jolley 46f9e00497 Tweak paypal seller protection text
Closes #18632
2018-01-29 14:43:25 +00:00
Paul Dechov 54fa85f388 Disable all payment gateways by default
Switches defaults for Check payments and PayPal Standard to 'no', so that no payment gateways are enabled by default before running through setup wizard.
2018-01-19 02:23:55 -05:00
Mike Jolley 405c2614a8 Use new methods 2018-01-11 12:54:48 +00:00
Mike Jolley c7a3fd266c phpcs 2018-01-11 12:53:47 +00:00
Mike Jolley 17710b864d Tweak IPN setting wording
@claudiulodro
2017-11-15 15:12:52 +00:00
George Lagonikas 6b7cc782d2
Removing obsolete code 2017-11-14 22:30:28 +00:00
George Lagonikas bca6bc7375
Text changes 2017-11-14 20:31:39 +00:00
George Lagonikas 87a75ce96e
Simplifying logic 2017-11-14 20:30:49 +00:00
SGroupGeorge 64332d82c7 Text changes 2017-11-14 17:51:46 +00:00
SGroupGeorge 3b2eec75d3 Adding checkbox to make IPN emails optional 2017-11-14 17:34:48 +00:00
Mike Jolley ced4551413 Merge branch 'pr/16986' 2017-10-27 15:49:00 +01:00
Mike Jolley 7cafc71526 Wording tweaks 2017-10-27 15:48:50 +01:00
Mike Jolley c15491b9ad Improved PDT handling and logs 2017-10-02 14:24:39 +01:00
SGroupGeorge 8a95d1111b Text changes 2017-09-29 10:47:07 +01:00
SGroupGeorge 38e6f07c70 Store both Live and Sandbox details for PayPal 2017-09-29 10:41:09 +01:00
Mike Jolley 9728cb5252 Added PayPal India support 2017-09-27 16:14:26 +01:00
Claudio Sanches fa850ecfb4 Removed PayPal legacy code 2017-07-11 12:09:57 -03:00
Mike Jolley 59a4f3b0d9 Remove sandbox status forcing in PayPal gateway
Closes #15899

@californiakat Should we add
https://stackoverflow.com/questions/4298117/paypal-ipn-always-return-pay
ment-status-pending-on-sandbox to the docs when 3.2 launches?
2017-07-03 10:46:32 +01:00
Mike Jolley bf6c39fbf2 Use wc_float_to_string on item prices sent to paypal
Fixes #15872
2017-06-30 10:28:21 +01:00
Boro Sitnikovski 8a615a6e79 Update conditional for non-auth payments 2017-06-05 14:07:49 +02:00
Boro Sitnikovski 4b82a750fc Fix IPN authorization setting orders to completed automatically 2017-06-05 10:07:22 +02:00
Rasmus Bengtsson 185934fad9 Fix phpdoc to include params and correct types 2017-05-15 13:50:52 +02:00
Mike Jolley 801f5e1eb1 Avoid escaped quote chars in strings
Closes #14670
2017-04-26 13:51:53 +01:00
Mike Jolley bcd39e9a79 Pass id not object to wc_reduce_stock_levels 2017-04-10 21:55:17 +01:00
Mike Jolley 8fa73602eb Correct calls to wc_reduce_stock_levels in PayPal and Simplify gateways
Fixes #14186
2017-04-10 11:56:52 +01:00
Akeda Bagus 0b416439c8
Fixed all typos of all files in includes/ directory.
Scanning and fixing were done automatically by codespell,
https://github.com/lucasdemarchi/codespell.
2017-03-29 00:58:51 +07:00
Mike Jolley 129293ab6f Remove array filter
No args should be null/not set since all args defined by WC have values.

Closes #13786
2017-03-28 11:49:27 +01:00
Claudio Sanches 59c2849736 Changed version 2.7 to 3.0 2017-03-15 13:36:53 -03:00
Jon Surrell e4d5886427 Replace log `tag` with log `source` 2016-12-29 11:58:43 +01:00
Jon Surrell 03889f77cc Update use of deprecated wc_get_log_file_path 2016-12-29 11:58:43 +01:00
Jon Surrell aee5917440 Change wc_safe_dump to wc_print_r
Match print_r arguments, this makes usage obvious.
2016-12-29 11:58:43 +01:00
Jon Surrell 66b0620f7c remove print_r calls from paypal handler 2016-12-29 11:58:42 +01:00
Jon Surrell 96f9de2106 update paypal gateway logs 2016-12-29 11:58:42 +01:00
Jon Surrell 36201d38ec Update paypal gateway log method 2016-12-29 11:58:42 +01:00
Mike Jolley 23c500986e Limit lengths of PayPal Args 2016-12-20 10:58:10 +00:00
Mike Jolley dcc47e395f Add email for case #12603
Closes #12603
2016-12-15 15:21:53 +00:00
Mike Jolley 36f7c3c810 woocommerce_paypal_line_item filter
Closes #12554
2016-12-09 16:59:29 +00:00
Mike Jolley edfc54dff5 Add image_url setting to PayPal Standard. 2016-12-08 12:28:05 +00:00
Mike Jolley b620a8c8fb Move paypal CMD to end of post vars. 2016-11-25 11:41:49 +00:00
Claudio Sanches 10f10d1644 [2.6] Ensure that PayPal always receive float amounts, closes #12291 (#12293) 2016-11-10 10:18:35 +00:00
Rami Yushuvaev 9469673c05 a11y: remove unneeded `title` attributes 2016-11-04 17:40:15 +02:00
Mike Jolley 32e814eef1 Use all paid statuses in $customer->get_total_spent() 2016-11-03 11:27:03 +00:00
Claudio Sanches fa0c710802 i18n <a> links, closes #12195 2016-10-27 15:36:24 -02:00
Rami Yushuvaev 140d0efb99 i18n: Avoid using HTML tags in translation strings (#12166)
* i18n: Remove some HTML tags from translation strings

* i18n: simpler translation string

* i18n: translations strings with surrounding `<strong>` HTML tags should be moved outside the translation string

* i18n: Avoide using `<code>' HTML tags in translation strings

* i18n: Split the notice to avoide using HTML tags in translation strings
2016-10-24 21:56:37 -02:00
Claudio Sanches 07ae13c51b Fixed coding standards recommended by WPCS 2016-10-13 16:51:18 -03:00
Mike Jolley 5304d6ef9d Add filters and include meta in item names sent to paypal
Closes #12022
2016-10-13 15:18:01 +01:00
Claudio Sanches 657c312cae Fix strings case (#12069)
* Fixed case for all _e, esc_attr_e and esc_html_e strings

* Fixed case for all _n_noop strings

* Fixed case for all _x strings

* Fixed case for all __, esc_html__ and esc_attr__ strings

* Fixed a few more strings

* Fixed strings in unit tests

* Fix PayPal Standard case.

* Save Order text
2016-10-12 11:16:30 +01:00
Rami Yushuvaev 83e938af1e i18n: Merge similar translation strings to reduce the total strings count #11905 2016-10-11 04:39:13 +03:00
Aristeides Stathopoulos e07511502d Additional coding-standards fixes. 2016-09-02 03:26:24 +03:00
Aristeides Stathopoulos fde1037757 fix failing tests. 2016-09-01 23:50:14 +03:00
Aristeides Stathopoulos f2730eea02 WordPress.WhiteSpace.ControlStructureSpacing.BlankLineAfterEnd 2016-08-27 08:57:05 +03:00
Aristeides Stathopoulos 58b9df6564 WordPress.Arrays.ArrayDeclaration.NoSpaceAfterOpenParenthesis 2016-08-27 05:23:54 +03:00
Aristeides Stathopoulos 32ddc22465 WordPress.Arrays.ArrayDeclaration.NoSpaceAfterComma 2016-08-27 05:14:16 +03:00
Aristeides Stathopoulos ec8a0b288b PHPCS: WordPress.Arrays.ArrayDeclaration.NoCommaAfterLast 2016-08-27 05:08:49 +03:00
Aristeides Stathopoulos b063bcfe4c last item in a multiline-array should end in a comma 2016-08-27 04:46:45 +03:00
Mike Jolley 7cf75f5085 Remove use of deprecated functions 2016-08-22 16:57:54 +01:00
Mike Jolley 95b11606fc get_product_from_item -> get_product 2016-08-22 16:51:24 +01:00
Thi 43cd8c9578 Add PayPal Here as a valid transaction type 2016-08-20 18:19:49 +09:00
Mike Jolley 190cd0bf86 Remove direct access of item props in admin 2016-08-19 15:08:00 +01:00
Mike Jolley f4a4f6c361 Reduce stock and other notices 2016-08-09 14:15:04 +01:00
Mike Jolley 39eb584321 Merge branch 'master' into orders-crud-function-update 2016-08-08 17:24:40 +01:00
Mike Jolley 31803f4e51 Billing/shipping 2016-08-08 16:46:58 +01:00
Mike Jolley cfe28c9b25 Made WC_Logger pluggable via wc_get_logger function.
Closes #11474
2016-08-08 13:59:23 +01:00
Mike Jolley 007a767657 billing_phone 2016-08-05 16:09:04 +01:00
Mike Jolley 7685587b22 payment_method 2016-08-05 16:04:41 +01:00
Mike Jolley 693e5ece36 billing_company 2016-08-05 16:03:09 +01:00
Mike Jolley 1c18c2f44a billing_first_name 2016-08-05 15:58:44 +01:00