Commit Graph

16166 Commits

Author SHA1 Message Date
Mike Jolley 49d0a09242
Merge pull request #20569 from davefx/patch-8
Cast multiselect and select keys as strings
2018-06-19 15:22:22 +01:00
Mike Jolley f6519e3361
Merge pull request #20524 from woocommerce/add/wootenbergjitm
Wootenberg JITM
2018-06-19 15:20:16 +01:00
Rodrigo Primo 5b5256370a Ignore a single PHPCS rule instead of ignoring all rules
Replace the usage of `// @codingStandardsIgnoreStart` and `// @codingStandardsIgnoreEnd` with `// phpcs:ignore WordPress.NamingConventions.ValidHookName.UseUnderscores` on WC_Gateway_Paypal_IPN_Handler::check_response(). Ignoring a single PHPCS rule is better than ignoring everything to protect the line against potential violations of the other rules.
2018-06-19 10:44:45 -03:00
Rodrigo Primo 9263a0b169 Fix: set order status to refunded when a PayPal transaction is refunded
Commit c7a3fd2 changed the logic to check if the refund is a full refund to use the strict equal operator (`===`) in the following line:

25be9fc13c/includes/gateways/paypal/includes/class-wc-gateway-paypal-ipn-handler.php (L295)

This change broke the comparison as `$order->get_total()` will return the value respecting the number of decimals after the decimal point set in the option `woocommerce_price_num_decimals` and `wc_format_decimal()`, when called without a second parameter, will not format the received value to use the same number of decimals set in `woocommerce_price_num_decimals`. To fix this issue, this commit passes `wc_get_price_decimals()` as the second parameter to `wc_format_decimal()`. This way both values will always have the same number of decimals and the comparison should work when handling a full refund.

Fixes #20551
2018-06-19 10:42:27 -03:00
Mike Jolley 0cee6a69b0 Update status based on stock, always 2018-06-19 13:35:17 +01:00
Mike Jolley 66ae57699a Return error code if parent is invalid 2018-06-19 12:54:57 +01:00
David Marín f28b00d5df
Fixing bug: I was casting the wrong value 😖 2018-06-19 13:31:48 +02:00
Mike Jolley e0ccc64571
Merge pull request #20560 from shivapoudel/tweak/admin-bar-menu
Tweak - logged in user is also checked by is_admin_bar_showing
2018-06-19 10:58:42 +01:00
Gerhard Potgieter 90387e7d7e Revert "Deprecate manage_stock methods in favor of stock_status methods."
This reverts commit 2d9c058876.
2018-06-19 11:54:07 +02:00
Gerhard Potgieter 8602fd0276 Revert "Deprecate wc_get_product_variation_attributes in favour of WC_Product::get_attributes()"
This reverts commit fe7a6c25df.
2018-06-19 11:53:50 +02:00
Gerhard Potgieter 2d9c058876 Deprecate manage_stock methods in favor of stock_status methods.
Closes https://github.com/woocommerce/woocommerce-product-tables-feature-plugin/issues/100
2018-06-19 11:35:57 +02:00
Gerhard Potgieter fe7a6c25df Deprecate wc_get_product_variation_attributes in favour of WC_Product::get_attributes()
Closes https://github.com/woocommerce/woocommerce-product-tables-feature-plugin/issues/102
2018-06-19 11:22:24 +02:00
David Marín 6649569aa2
Update abstract-wc-settings-api.php 2018-06-19 07:12:39 +02:00
David Marín 597ba7df98
Cast multiselect keys as strings 2018-06-19 06:41:44 +02:00
Rodrigo Primo 5c5cddf26a Add @return for wc_update_350_order_customer_id() docblock 2018-06-18 15:17:39 -03:00
Rodrigo Primo 43d22a2349 Merge branch 'master' into update/use-post-author-for-customer-id 2018-06-18 15:17:19 -03:00
claudiulodro 1890ef788d Persist wootenberg notice dismissal 2018-06-18 10:54:01 -07:00
claudiulodro 7148f8da2d Install/activate the plugin from the notice 2018-06-18 10:42:52 -07:00
Gerhard Potgieter 36d1c318cb Download Log FK Contraint check (#20478)
This PR introduces a check on the permission_id FK to ensure that it is not added multiple times on upgrades. It also names the key specifically to ensure future changes to the key can be targeted properly and removes old keys that were added since 3.4.0.

* Add FK check before adding the FK. Also give the FK a name to avoid auto generated names and duplicate keys.

* Remove additional OR

* Remove additional OR

* Final FK check query

* Add foreign key cleanup routine to 3.4.3 db version

* Only check on named foreign key now that we have a cleanup routine in place, use specific phpcignore

* Rework formatting of SQL query

* Change way to fetch and add FK, can't use procedural SQL, needs to be done via statements.

* Add table name to lookup

* Only clean up FK on the wc_download_log table

* Remove erenouse bracket
2018-06-18 11:47:47 -03:00
Shiva Poudel dcc2e595f2 Tweak - logged in user is also checked by is_admin_bar_showing 2018-06-18 16:52:56 +05:45
Dan Wyman f41b774dc2 Mailing list - update form action
Mailing list form now identifies itself to the mailing list server.
2018-06-15 14:27:43 -07:00
Rodrigo Primo b6e73f528b Merge branch 'master' into feature/product-custom-tables-supporting-changes 2018-06-15 14:56:31 -03:00
Rodrigo Primo 7a7130c9d0 Improve WC_Query::get_layered_nav_chosen_attributes() performance
This commits improves the performance of the method WC_Query::get_layered_nav_chosen_attributes() when a site has a significant number of product attributes. Instead of looping over all existent product attributes to find which have been passed in the request, the new code loops over all the request parameters and checks which are valid product attributes.

On a test site with 2000 product attributes, the old version of WC_Query::get_layered_nav_chosen_attributes() was responsible for 25% of the shop page generation time. With the new version, the amount that this method contributes to the page generation time is negligible.

Related #20262
2018-06-15 14:39:56 -03:00
Rodrigo Primo 35d5bf31dd phpcs fixes 2018-06-15 14:26:47 -03:00
Claudiu Lodromanean 25be9fc13c
Merge pull request #20546 from woocommerce/fix/20509
Normalize parent tax class
2018-06-15 09:23:27 -07:00
Claudiu Lodromanean ee47ceb361
Merge pull request #20537 from woocommerce/update/transactions-revert
Transactions, caching, and version transient cleanup issues
2018-06-15 09:11:23 -07:00
Claudiu Lodromanean c203ff16d9
Merge pull request #20482 from woocommerce/fix/20452
Avoid price setting when synced with children
2018-06-15 09:05:13 -07:00
Claudiu Lodromanean fc02687545
Merge pull request #20470 from woocommerce/update/20454
Support limiting search results
2018-06-15 09:03:07 -07:00
Claudiu Lodromanean 843f19738a
Merge pull request #20458 from woocommerce/update/13359
Improved Stock Reduction Events
2018-06-15 09:00:32 -07:00
Mike Jolley 7800ca284a Merge branch 'pr/20500'
Arguments passed to end function should be passed by reference.
2018-06-15 15:50:06 +01:00
Mike Jolley 880cebbe1b align 2018-06-15 15:49:51 +01:00
Mike Jolley a0eb6843c2 define limit query 2018-06-15 15:28:29 +01:00
Risto Niinemets 174fd95765 fix undefined index attribute in layered nav widget without attributes (#20544) 2018-06-15 15:20:21 +01:00
Mike Jolley 5e6405b650 Merge branch 'master' into update/13359 2018-06-15 15:12:12 +01:00
Mike Jolley 04e304921a Show stock based on querystring var 2018-06-15 15:11:07 +01:00
Mike Jolley f633d9a0eb Update remove item notice based on order status 2018-06-15 14:38:35 +01:00
Mike Jolley a1bd9ab2ae Input type number with correct width 2018-06-15 14:32:30 +01:00
Mike Jolley 17e97c2580 Clear version cache if time is unchanged 2018-06-15 13:56:23 +01:00
Mike Jolley 217e825e22 supports_emogrifier 2018-06-15 12:43:27 +01:00
Mike Jolley be9162e869 Remove namespace 2018-06-15 12:43:19 +01:00
Mike Jolley c3144012a5 Include as needed 2018-06-15 12:43:10 +01:00
Mike Jolley 0d79ced8e4 Update emogrifier 2018-06-15 12:25:07 +01:00
Mike Jolley a8e2eaee2a Normalize parent tax class 2018-06-15 11:35:22 +01:00
Claudiu Lodromanean 4c47574d7c
Merge pull request #20533 from woocommerce/fix/20505
Round items for order total
2018-06-14 09:11:57 -07:00
Mike Jolley 4b1e08b9b9
Merge pull request #20445 from roshansameer/webhook-bulk-delete-bottom
Fix - on webhook bulk action footer delete selection
2018-06-14 17:00:57 +01:00
Mike Jolley 9b0de1a221 Missing static keyword 2018-06-14 16:35:34 +01:00
Claudiu Lodromanean cdee048337
Merge pull request #20531 from woocommerce/fix/20519
Shipping tax may be a string, so cast it
2018-06-14 08:25:09 -07:00
Mike Jolley c5429244b2
Merge pull request #20504 from cmarangon/master
Conform returned error messages
2018-06-14 16:23:51 +01:00
Mike Jolley 6152aea961
Merge pull request #20506 from woocommerce/refactor/20420
Tokenization form refactor
2018-06-14 16:22:45 +01:00
Mike Jolley 2c8106075a Merge branch 'master' into fix/20218-clearer-friendly-names 2018-06-14 16:12:53 +01:00
Mike Jolley eef1eb44d8 WooCommerce prefix only 2018-06-14 15:47:15 +01:00
Mike Jolley ce1810cd1a
Merge pull request #20497 from woocommerce/fix/20485
API: Order images by position before saving
2018-06-14 15:24:49 +01:00
Mike Jolley 78636b1f12 Only cache if order ID is set. 2018-06-14 14:52:25 +01:00
Mike Jolley 2f8a3eae49 Defer all transient cleanup 2018-06-14 14:40:08 +01:00
Mike Jolley 9f86839cab Remove wc_transaction_query in favour of logging 2018-06-14 14:39:18 +01:00
Mike Jolley 893e6affb1 Revert this change - no issue, just keeping diff small 2018-06-14 12:56:21 +01:00
Mike Jolley 90c90591f3 Round items for order total 2018-06-14 12:52:13 +01:00
Roshan Sameer 384f54f951 Static call 2018-06-14 16:40:48 +05:45
Mike Jolley aa4a89f92d Shipping tax may be a string, so cast it
Fixes #20519
2018-06-14 11:49:45 +01:00
claudiulodro 79551e9843 Wootenberg JITM 2018-06-13 11:36:36 -07:00
Claudiu Lodromanean 73dbec001a
Merge pull request #20456 from JPry/custom_coupon_item_limit
Custom coupon item limit
2018-06-13 09:57:47 -07:00
Mike Jolley 812586742b Allow only valid default attributes 2018-06-13 14:33:13 +01:00
Mike Jolley 01a3e359c3 Merge branch 'master' into feature/product-custom-tables-supporting-changes 2018-06-13 10:18:38 +01:00
Claudio Sanches ed4c6898f7
Merge pull request #20472 from rnaby/090618-232243
Remove unused variable and unnecessary else if
2018-06-12 13:28:48 -03:00
Claudio Sanches 6b230706fb
Merge pull request #20502 from woocommerce/fix/20466
Initialize payment gateways before running bulk actions
2018-06-12 11:59:47 -03:00
Mike Jolley cfe1cb5c16 Handle login and change events 2018-06-12 15:32:01 +01:00
Claudio Sanches 5f37fe110a
Merge pull request #20499 from woocommerce/fix/20496
Remove API enabled check from auth endpoint
2018-06-12 11:22:54 -03:00
Mike Jolley 10a5779fd1 wp_localize_script 2018-06-12 14:57:44 +01:00
Claudio Marangon e3447635ae Conform returned error messages
The <strong>Error:</strong> should be removed because:

- the other errors in this function don't provide it either
- the process_registration() function in class-wc-form-handler.php also adds this string so it's added twice
2018-06-12 15:48:59 +02:00
Mike Jolley cca7972d8f Initialize payment gateways before running bulk actions 2018-06-12 13:14:09 +01:00
Jon Besga e75c3716d2
Update wc-rest-functions.php
Arguments passed to end function should be passed by reference.
2018-06-12 12:45:22 +01:00
Mike Jolley ddf9ab0605 Remove API enabled check from auth endpoint 2018-06-12 12:37:36 +01:00
Mike Jolley fcd23567f6 Clear transients tool; clear wc_layered_nav_counts 2018-06-12 12:31:15 +01:00
Mike Jolley cfda380d2f API: Order images by position before saving 2018-06-12 12:13:10 +01:00
therealgilles 3818598811 Rename woocommerce_checkout_skip_update_order_review_expired to woocommerce_checkout_update_order_review_expired and change filter polarity. 2018-06-11 20:29:16 +00:00
therealgilles 43db16a708 Merge branch 'master' of https://github.com/woocommerce/woocommerce 2018-06-11 18:14:30 +00:00
Claudiu Lodromanean 2c1c32bf91
Merge pull request #20487 from willgorham/remove-malta-checkout-state
Remove Malta checkout 'State' field
2018-06-11 10:34:52 -07:00
Claudiu Lodromanean c93a922876
Merge pull request #20486 from woocommerce/fix/20430
sanitize_special_column_name_regex trim
2018-06-11 10:28:41 -07:00
Claudiu Lodromanean b351bcac50
Merge pull request #20483 from woocommerce/fix/20431
Search for matching keys when updating meta data
2018-06-11 10:26:24 -07:00
Claudiu Lodromanean 4ba04cfc4e
Merge pull request #20481 from woocommerce/update/20444
Remove personal data confirmation notice
2018-06-11 09:56:26 -07:00
Will Gorham 1d4f76490e Remove malta state field 2018-06-11 11:23:27 -04:00
Rodrigo Primo 397e40f165 Fix indentation 2018-06-11 11:14:04 -03:00
Rodrigo Primo 77add46705 Pass user_id via $wpdb->prepare() 2018-06-11 11:04:19 -03:00
Mike Jolley 38be26e7a5 sanitize_special_column_name_regex trim 2018-06-11 14:55:36 +01:00
Rodrigo Primo f1f49bb27a Add WC 3.5.0 DB version update callback 2018-06-11 10:54:02 -03:00
Rodrigo Primo 7f70c6372c Fix some code untitentional code changes added during the last merge from master 2018-06-11 10:48:28 -03:00
Rodrigo Primo dd8bf8b522 Merge branch 'master' into update/use-post-author-for-customer-id 2018-06-11 10:44:14 -03:00
Mike Jolley 588be3a780 merge master 2018-06-11 13:46:04 +01:00
Mike Jolley 52a7fafd74 Search for matching keys when updating meta data 2018-06-11 12:50:49 +01:00
Mike Jolley 5e14953796 Avoid price setting when synced with children 2018-06-11 11:44:58 +01:00
Mike Jolley 35db31db32 Add notice text, fix typos 2018-06-11 10:35:34 +01:00
Roshan Sameer 32b734a1c1 Implementation of current action check in list table 2018-06-11 15:05:13 +05:45
Gerhard Potgieter 90a9fd49e6 X_FORWARDED_FOR standard states either just an IP or a comma seperated list of IP, Proxy, Proxy, ... 2018-06-11 10:49:03 +02:00
therealgilles 9adff87a1c Rename woocommerce_checkout_skip_cart_is_empty_check to woocommerce_checkout_redirect_empty_cart and invert filter polarity. 2018-06-10 18:58:47 +00:00
therealgilles 1d733236e0 Merge branch 'master' of https://github.com/woocommerce/woocommerce 2018-06-10 18:53:13 +00:00
Khan M Rashedun-Naby 8d7ae8b413 Remove unused variable and unnecesary else if 2018-06-09 23:24:08 +06:00
Mike Jolley 4bc7841325 search_products limit support 2018-06-09 17:23:07 +01:00
Mike Jolley 81149157a3 woocommerce_json_search_limit filter 2018-06-09 17:22:26 +01:00
Claudiu Lodromanean 3d4dfda568
Merge pull request #20435 from rnaby/070618-212333-wc-privacy-exporters-customer_data_exporter
Removed unnecessary parameter. Also removed from tests.
2018-06-08 11:34:42 -07:00
Jeremy Pry 01e1ef73e7 Handle item limit for custom coupon types
Fixes #20455
2018-06-08 14:18:16 -04:00
Claudiu Lodromanean 0c8b8e9dd7
Merge pull request #20429 from woocommerce/fix/add-nonce-to-update-url
Add nonces to WC update database and force update database URLs
2018-06-08 10:52:17 -07:00
Claudiu Lodromanean 327401e4ea
Merge pull request #20406 from unfulvio/20404-custom-webhook-topic-dropdown-bug
[#20404] Fix custom webhook topic selection in dropdown
2018-06-08 09:43:50 -07:00
Mike Jolley 6a59a1b498
Merge pull request #20438 from rnaby/070618-215706-wc-privacy-exporters-get_customer_personal_data
PHPDoc @throws Tag Added
2018-06-08 17:27:18 +01:00
Mike Jolley baa5abcffa
Merge pull request #20437 from rnaby/070618-214301-wc-privacy-exporters-download_data_exporter
PHPDoc Fixed | Used Unused Variable | Else Removed
2018-06-08 17:27:05 +01:00
Mike Jolley f70e8b4bd2
Merge pull request #20436 from rnaby/070618-214347-wc-privacy-exporters-order_data_exporter
Made use unused variable and removed else
2018-06-08 17:26:47 +01:00
Beka Rice 818c68fc83 Fix multisite dashboard widget to use proper order number 2018-06-08 11:59:27 -04:00
Mike Jolley e92463632b Held stock qty check for pay page 2018-06-08 16:58:33 +01:00
Mike Jolley d76474789d variable name 2018-06-08 16:30:58 +01:00
Mike Jolley 52854b7690 Add qty to order via modal, include stock qty in formatted name display for reference 2018-06-08 16:18:32 +01:00
Fulvio Notarstefano 468fb14c3c [#20404] Further indentation 2018-06-09 00:08:20 +09:00
Fulvio Notarstefano 38b1381fff [#20404] Code style standards 2018-06-09 00:07:20 +09:00
Mike Jolley ce8eabc4a5 Include qty and reduce stock field on add item modal 2018-06-08 12:19:14 +01:00
Mike Jolley 8084100cbb Tweak meta naming and order notes 2018-06-08 12:18:33 +01:00
Mike Jolley 6b8cd9661f exclude new meta data from admin screens 2018-06-08 12:18:15 +01:00
Roshan Sameer 72c8e3b9cc Fix - on webhook bulk action footer delete selection 2018-06-08 11:54:47 +05:45
Claudiu Lodromanean dc20237f40
Merge pull request #20426 from woocommerce/fix/20386
Made path /orders/refund_id return invalid order id msg instead of error.
2018-06-07 10:50:46 -07:00
Mike Jolley 2cad2414b3 Remove manual wc_reduce_stock_levels calls 2018-06-07 18:01:38 +01:00
Mike Jolley 8261cffaa7 Remove bulk actions 2018-06-07 18:01:21 +01:00
Mike Jolley 2657db4a97 Pending should restore stock too 2018-06-07 17:42:58 +01:00
Mike Jolley e38eccf828 Check pending orders even when hold stock is disabled 2018-06-07 17:42:23 +01:00
Mike Jolley 70c9cff608 Increase/decrease stock handling 2018-06-07 17:41:36 +01:00
Claudiu Lodromanean c8480b68f1
Merge pull request #20338 from Spreeuw/patch-5
apply bulk actions oldest to newest
2018-06-07 09:34:38 -07:00
Khan M Rashedun-Naby f617a84b1f PHPDoc @throws Tag Added 2018-06-07 22:02:11 +06:00
Khan M Rashedun-Naby ec76e60e33 PHPDoc Fixed | Used Unused Variable | Else Removed 2018-06-07 21:52:28 +06:00
Khan M Rashedun-Naby c773b9cb4c Made use unused variable and removed else 2018-06-07 21:45:03 +06:00
Khan M Rashedun-Naby 4b14cbc727 Removed unnecessary parameter. Also removed from tests. 2018-06-07 21:25:13 +06:00
Fulvio Notarstefano e68aa7c027 [#20404] Address code review feedback 2018-06-07 23:33:13 +09:00
Rodrigo Primo fc5aef8478 Add nonce to force update WC database URL
Doing this to check if the user has intention to perform a WC database update before starting the process.
2018-06-07 09:55:47 -03:00
Rodrigo Primo 467bd73ea9 phpcs fixes 2018-06-07 09:45:23 -03:00
Rodrigo Primo a200686005 Add nonce to update WC database URL
Doing this to check if the user has intention to perform a WC database update before starting the process.
2018-06-07 09:45:18 -03:00
Rodrigo Primo 860e3e6d93 phpcs fixes 2018-06-07 08:57:57 -03:00
Peter Fabian db9d2f2c30 Made path /orders/refund_id return invalid order id msg. 2018-06-07 13:26:29 +02:00
Mike Jolley de567c6a2e merge mistake 2018-06-07 11:26:19 +01:00
Mike Jolley 4df54b4e53 Merge branch 'master' 2018-06-07 11:24:12 +01:00
Mike Jolley db9ab9cb8f
Merge pull request #20330 from woocommerce/update/19745
Eircode validation and formatting tweaks
2018-06-07 10:41:35 +01:00
Mike Jolley 38e3e3f570
Merge pull request #20425 from rnaby/070618-130531-wc-core-functions-wc_get_logger
Simplified and Early Returned | wc_get_logger refactored
2018-06-07 10:34:51 +01:00
Mike Jolley 493060dcb6
Merge pull request #20424 from kravco/master
Fix: order billing fields do overwrite value, even if provided
2018-06-07 10:34:04 +01:00
Mike Jolley 86993a4f70 Merge branch 'master' into update/13624 2018-06-07 10:30:52 +01:00
Roshan Sameer c31b9acc8c If wp_doing_ajax is defined return it (#20421)
* If wp_doing_ajax is defined return it

* Simplify the function exits check
2018-06-07 10:21:22 +01:00
Mike Jolley 44404f2f7a
Merge pull request #20422 from rnaby/070618-115632-wc-core-functions
@access tag removed
2018-06-07 10:17:22 +01:00
Khan M Rashedun-Naby 76a9e19471 wc_get_logger refactored 2018-06-07 13:46:06 +06:00
Matej Kravjar 233ac4b313 order billing fields do not overwrite value, if provided
(overwriting introduced by 1fa36b5f15)
2018-06-07 09:02:12 +02:00
Khan M Rashedun-Naby 5442d30b6d Checking Improved 2018-06-07 12:35:58 +06:00
Khan M Rashedun-Naby 964435a34b @access tag removed 2018-06-07 12:31:35 +06:00
Khan M Rashedun-Naby 20c8468fe4 handle_auth_requests PHPDoc and WPCS Fix 2018-06-06 17:35:15 +06:00
TheDramatist 93e7419b17 Simplified wc_review_is_from_verified_owner (#20393)
* Simplified wc_review_is_from_verified_owner

* wc_review_is_from_verified_owner simplified
2018-06-06 12:16:43 +01:00
Mike Jolley 869415763c
Merge pull request #20396 from rnaby/060618-005642-wc-discounts-object-var-type
WC_Discounts | object Property Type PHPDoc Fix
2018-06-06 12:15:46 +01:00
Mike Jolley f9d9c395c7
Merge pull request #20397 from rnaby/060618-010003-wc-discounts-set_items_from_order
WC_Discounts|set_items_from_order Param Type Fix
2018-06-06 12:15:33 +01:00
Mike Jolley 833df18dff
Merge pull request #20398 from rnaby/060618-010246-wc-discounts-constructor
WC_Discounts | __construct PHPDoc and Param Fix
2018-06-06 12:15:19 +01:00
Mike Jolley 113d7ad781
Merge pull request #20400 from rnaby/060618-014013-wc-discounts-apply_coupon
WC_Discounts | apply_coupon Removed Unused Variable
2018-06-06 12:14:32 +01:00