Mike Jolley
a3b89a9efc
Merge pull request #15144 from timondavis/fix/15103-cannot_set_default_variation_to_string_zero
...
#15103 Variation default value of '0' fails to save on product.
2017-05-23 19:31:38 +01:00
Mike Jolley
6dfdc86111
Merge branch 'pr/14678'
2017-05-23 19:16:37 +01:00
Mike Jolley
109e951de3
Renamed filters and actions
2017-05-23 19:16:30 +01:00
Mike Jolley
c16acc6b51
Merge remote-tracking branch 'origin/master'
...
# Conflicts:
# assets/css/wc-setup-rtl.css
# assets/css/wc-setup.css
2017-05-23 19:00:24 +01:00
Mike Jolley
d3666738d8
Merge branch 'pr/15069'
2017-05-23 18:56:58 +01:00
Mike Jolley
00e5189a05
Merge pull request #15070 from rasmusbe/phpdoc-missing-return-throws
...
Phpdoc: Add missing return and throws
2017-05-23 18:50:58 +01:00
Mike Jolley
db012b3a12
Merge pull request #15011 from woocommerce/fix/14999
...
Add abspath checks
2017-05-23 15:57:35 +01:00
Mike Jolley
d31a58b117
More abspath
2017-05-23 15:40:19 +01:00
Timon Davis
af308da6b9
Fix bug #15103 where site operator cannot assign a variation with value of '0' as the default choice on the customer facing form.
...
The WC_Product::set_default_attributes function uses an array_filter (using the default callback for filtration)
to remove null and false values from the defaults array for a given product. The issue here is that, in the above use case,
the array_filter will evaluate '0' as 0 and therefore as false. Ultimately, array_filter then prevents the value from being
recorded, moving forward.
I've added a new filter callback to includes/wc-attribute-functions which will disregard all FALSE PHP equivalents except for
'0' (as a a string). Also, I've updated the filter_array call in WC_Product::set_default_attributes so that it uses this new callback,
instead of the PHP default. Finally, I've added a phpunit test to assert that, when storing default variations / attributes on a product,
the false/true PHP synonyms are evaluating and storing like one would normally expect, with the exception that (string) '0'
evaluates as true in this special case.
This solution could potentially be broadened to facililate similar rules elsewhere, but the need raised in the bug is specific and
this is a specific solution.
2017-05-18 02:43:14 -07:00
Mike Jolley
dd798d219e
Make calculate tax function clear taxes if disabled on recalculation
...
Fixes #15057
2017-05-15 14:55:39 +01:00
Rasmus Bengtsson
185934fad9
Fix phpdoc to include params and correct types
2017-05-15 13:50:52 +02:00
Rasmus Bengtsson
4f00d7e5e3
PHPDoc: Add missing return statement
2017-05-15 13:37:59 +02:00
claudiulodro
3861e32803
Migrate wc_get_orders
2017-05-12 11:45:01 -07:00
Mike Jolley
bc4d36fd3f
Add abspath checks
...
Closes #14999
2017-05-10 19:03:19 +01:00
Rasmus
98833fa9c5
Fix param documentation for WC_Product::is_type
2017-05-09 14:10:27 +02:00
Claudio Sanches
257594a67c
Merge pull request #14945 from woocommerce/pr/14875
...
Pr/14875
2017-05-08 13:56:12 -03:00
Mike Jolley
03a69e1d44
Prepend new item keys with `$items_key` to make them unique.
...
Fixes #14875
2017-05-08 17:44:10 +01:00
Mike Jolley
dd3be1278b
Merge pull request #14733 from woocommerce/feature/13646
...
WC_Object_Query & WC_Order_Query
2017-05-07 14:24:12 +01:00
Claudio Sanches
9930099b98
Merge pull request #14846 from woocommerce/fix/non-numeric-warning-order
...
Fix non numeric warning for orders.
2017-05-04 18:35:51 -03:00
Boro Sitnikovski
f493afe718
intval -> floatval
2017-05-04 10:09:16 +02:00
Claudio Sanches
84dfaf3c09
Merge pull request #14851 from franticpsyx/clone-meta-data
...
[3.0] Clone each meta stdClass object when cloning a WC_Data object
2017-05-03 18:03:54 -03:00
Manos Psychogyiopoulos
8f7671f066
Clone each meta object when cloning WC_Data object to avoid modifying original meta stdClass objects
2017-05-03 16:37:01 +03:00
Boro Sitnikovski
8f63211f1c
Fix non numeric warning for orders.
2017-05-03 08:31:35 +02:00
claudiulodro
c93c45b15e
Docblock
2017-04-28 09:55:49 -07:00
claudiulodro
30d2332f48
Handle paginate
2017-04-27 19:14:48 -07:00
claudiulodro
4eb1396e85
Offload more to subclasses
2017-04-27 14:09:10 -07:00
claudiulodro
db3de7375d
Tweaks from feedback
2017-04-27 11:07:03 -07:00
Mike Jolley
796ab0f257
Merge pull request #14756 from woocommerce/fix/14753
...
Compare with timestamp and remove start date once passed for sale products
2017-04-27 18:06:18 +01:00
Mike Jolley
a68934d7db
Merge pull request #14731 from crodas/make_sure_meta_data_cache_is_not_shared
...
Make sure the meta data cache is not shared among instances
2017-04-27 16:50:10 +01:00
claudiulodro
6aecb15505
Reduce scope
2017-04-27 08:38:18 -07:00
Mike Jolley
eedcdd97ba
Compare with timestamp and remove start date once passed for sale products
...
Fixes #14753
2017-04-27 14:35:33 +01:00
Mike Jolley
a6329fa68c
Merge pull request #14752 from woocommerce/pr/14732
...
revert price handling of get_price_html()
2017-04-27 13:03:15 +01:00
Mike Jolley
db5e2572f6
clean up
2017-04-27 13:01:52 +01:00
claudiulodro
2fad12221d
Better comments
2017-04-26 11:04:28 -07:00
Cesar Rodas
91de312eb2
Make sure the meta data cache is not shared among instances
...
See #14620 for more context. In there I thought this was the desired behaviour and I enhanced it. After talking with @mikejolley he explained to me that it was not by designed.
This commit makes sure the meta data cache is not shared among instances
2017-04-26 13:51:52 -04:00
Kathy Darling
36dbe64170
revert price handling so null price still is filtered by woocommerce_get_price_html. closes #14727 .
2017-04-26 12:37:30 -05:00
claudiulodro
efa1dbbda5
Basic working order queries
2017-04-25 14:52:17 -07:00
Petar Petrov
fdb28218ea
items_type_key filter and woocommerce_order_line_item_object fix
2017-04-25 18:07:40 +03:00
Mike Jolley
9923612832
Prevent orders being their own parent (!)
...
Closes #14660
2017-04-25 14:18:27 +01:00
Petar Petrov
2b3ec357ad
fix-14302
2017-04-25 14:12:36 +03:00
claudiulodro
553a12203b
WC_Order_Query
2017-04-24 16:28:13 -07:00
claudiulodro
29fa59a0b7
WC_Object_Query
2017-04-24 11:33:17 -07:00
Mike Jolley
4a6c87d1cc
docblock
2017-04-20 16:03:40 +01:00
Mike Jolley
8e28af8b87
define get_user_id/get_user methods for bw compat
...
Closes #14543
2017-04-20 16:02:10 +01:00
Mike Jolley
69a8b6c9b5
When on backorder without notifications, hide the text
...
Fixes #14530
2017-04-19 16:57:49 +01:00
Claudio Sanches
d94f3883da
Merge pull request #14497 from woocommerce/fix/14416
...
Fixed docblocks in REST API v1
2017-04-18 18:43:06 -03:00
Claudio Sanches
81dcd6e79e
Fixed docblocks in REST API v1 for #14416
2017-04-18 13:40:10 -03:00
Mike Jolley
de016c6615
Fix call to is_compound method
...
Fixes #14484
2017-04-18 12:00:21 +01:00
Govind Kumar
200cd2de63
Fixed: get_term() returns objects not array.
2017-04-18 13:00:04 +05:30
Mike Jolley
71929666ac
Merge pull request #14404 from thenbrent/fix_get_meta_returning_deleted_values
...
Don't return deleted meta in get_meta_data()
2017-04-17 11:38:12 +01:00