c6a95ae9bf
Rename callback props in IntroductionBanner to make them clearer.
2023-03-19 21:10:22 +08:00
6b75b5db38
Rename variables to make them clearer.
2023-03-19 20:58:54 +08:00
155211d77a
Remove unneeded Icon component.
2023-03-19 20:56:00 +08:00
65523e36dd
Fix spacing for close button in IntroductionBanner.
2023-03-19 20:54:34 +08:00
1b65be0a53
Fix useSelect dependency in useIntroductionBanner.
2023-03-19 20:50:37 +08:00
99c6ebff15
Remove the use of isOptionsUpdating in useIntroductionBanner.
...
isOptionsUpdating will return true for any option update, not just our option here. This causes issue as shown in demo video in https://github.com/woocommerce/woocommerce/pull/37110#discussion_r1130531104 .
We can just depend on getOption. When we update an option, it will be updated immediately in wp.data store before making API request to update the option in database (see c5564a15c1/packages/js/data/src/options/actions.ts (L44)
2023-03-19 20:38:20 +08:00
162d790a7a
Update option name and value to make it more indicative.
2023-03-19 20:16:04 +08:00
49253425b2
Specify dependency for useSelect in useIntroductionBanner.
...
Co-authored-by: Eason <eason.su.tw@gmail.com>
2023-03-19 20:12:09 +08:00
7cc8e065f9
Merge branch 'trunk' into feature/34904-marketing-introduction-banner
2023-03-19 20:09:23 +08:00
f769a8c6f5
Merge branch 'trunk' into feature/34904-marketing-introduction-banner
...
Conflicts:
plugins/woocommerce-admin/client/marketing/overview-multichannel/MarketingOverviewMultichannel.tsx
2023-03-17 01:21:13 +08:00
aef22190d2
Make sure expression before && is always boolean in React rendering in marketing page.
2023-03-15 08:24:00 +08:00
0316fbb265
Specify empty array as hasFinishedResolution args.
...
This is to make things consistent with invalidateResolution to make things work with WP 5.9.
2023-03-14 03:35:20 +08:00
5a58784a62
Specify empty array as invalidateResolution and hasFinishedResolution args.
...
This is to make things work with WP 5.9.
2023-03-14 03:32:54 +08:00
0cf56774f5
Merge branch 'trunk' into feature/34909-marketing-create-campaign-modal
2023-03-13 12:51:24 +08:00
baf9408f69
Merge branch 'feature/34909-marketing-create-campaign-modal' into feature/34904-marketing-introduction-banner
...
Conflicts:
plugins/woocommerce-admin/client/marketing/overview-multichannel/Campaigns/Campaigns.test.tsx
plugins/woocommerce-admin/client/marketing/overview-multichannel/Campaigns/Campaigns.tsx
plugins/woocommerce-admin/client/marketing/overview-multichannel/MarketingOverviewMultichannel.tsx
2023-03-13 01:02:12 +08:00
c6e6f8774d
Specify empty array dependency in useCampaignTypes.
...
This is to make it work with WP 5.9. See https://github.com/woocommerce/woocommerce/pull/37044#discussion_r1132062493 .
2023-03-11 00:42:09 +08:00
1fea0185fe
Don't throw error in getCampaignTypes.
...
In WP 5.9, if we throw error, there would be an uncaught promise, and it causes UI to break.
2023-03-11 00:31:23 +08:00
af24637439
Create @woocommerce/admin-layout package ( #37094 )
...
* Initial admin-layout package skeleton
* Changelog files
* Use createOrderedChildren and sortFillsByOrder from @woocommerce/components for WooFooterItem
* Move WooFooterItem to @woocommerce/admin-layout
* Use WooFooterItem from @woocommerce/admin-layout
* Suppress errant TS lint errors
* Exports for @woocommerce/admin-layout
* Fill updates and eslint suppression
* Changelogs
* Remove suppression of tslint errors
* Fix react and @types/react versions
* Load @woocommerce/admin-layout script and styles
* Move WooHeaderItem, WooHeaderNavigationItem, and WooHeaderPageTitle to @woocommerce/admin-layout
* Regenerate lock file post-rebase
* Remove duplicate import post-rebase
* Add wc-admin-layout to app style dependency
* Fix jest mock of @woocommerce/admin-layout
* Fix spacing.
* Export slot names
* Fix typo in .npmrc
* Update lock file
* Try updating lock file
* Update lock file
* Update lock file
* Update to latest lock file from trunk
* Update lock file
* Sync dependencies of @woocommerce/admin-layout
* Manually sync @wordpress dependencies
2023-03-10 09:58:02 -05:00
0a58ec19f8
Remove unneeded div in CreateNewCampaignModal.
2023-03-10 02:14:35 +08:00
e4da8cba09
Display info message when there are no campaign types.
2023-03-10 02:13:05 +08:00
6446053784
Load campaign types in overview and refetch after installeing a channel.
2023-03-09 23:46:54 +08:00
8b6aad4138
Refetch campaign types after installing a channel in CreateNewCampaignModal.
2023-03-09 22:51:12 +08:00
29d67a3a21
Refactor test data in CreateNewCampaignModal tests.
2023-03-09 22:31:51 +08:00
9f0326b398
Remove unneeded return in CreateNewCampaignModal.
...
This helps us save indentation and make the code few lines shorter.
2023-03-09 22:26:06 +08:00
e15305b7c3
Remove unneeded CardDivider in CreateNewCampaignModal.
...
The code is copied from the Channels component, but in CreateNewCampaignModal, we don't need to display the divider, so we can just remove the divider code.
2023-03-09 22:23:27 +08:00
c6dcee426b
Make it clear that title and classname cannot be overwritten by props.
2023-03-09 22:17:03 +08:00
f5bb8490ea
Rename open and setOpen to isModalOpen and setModalOpen in Campaigns.
2023-03-09 22:11:53 +08:00
e831e89997
Make the mocked modal clearer.
...
The previous text "Create a new campaign" can be a bit confusing with the other text "Create new campaign" in the test.
2023-03-09 22:09:24 +08:00
551db21e9b
Remove unneeded getByText in Campaigns test.
2023-03-09 22:05:17 +08:00
f19969dacb
Change NewCampaignTypes to CampaignTypes.
2023-03-09 21:52:11 +08:00
39ce470fe8
Specify dependency for useSelect in useNewCampaignTypes.
2023-03-09 21:43:54 +08:00
3ba492f32b
Move convert function out of useSelect in useNewCampaignTypes.
...
This is so that it doesn't become dependency in useSelect.
2023-03-09 21:42:59 +08:00
6d72c2bbe1
Fix failed test for Campaigns component.
2023-03-09 01:08:28 +08:00
66e46d8942
Run lint:css-fix.
2023-03-09 00:34:20 +08:00
4068808f0a
Merge branch 'feature/34909-marketing-create-campaign-modal' into feature/34904-marketing-introduction-banner
2023-03-08 03:03:31 +08:00
97ed1d2a7d
Fix array length rendering literal 0 in CreateNewCampaignModal.
2023-03-08 02:57:02 +08:00
42ac7e4d28
Better logic for displaying buttons in IntroductionBanner.
2023-03-08 02:54:43 +08:00
8fe3781266
Use ref instead of location hash to scroll to add channels section.
2023-03-08 02:06:06 +08:00
0cb2fb1cd0
Display CreateNewCampaignModal upon button click in IntroductionBanner.
2023-03-08 00:37:55 +08:00
a9b696d28c
Move CreateNewCampaignModal to shared components folder.
2023-03-08 00:34:09 +08:00
ed6c19b827
Fix 0 rendered on short-circuit evaluation.
2023-03-07 15:06:25 +02:00
7c9eedbbb4
Merge branch 'feature/34909-marketing-create-campaign-modal' into feature/34904-marketing-introduction-banner
...
Conflicts:
plugins/woocommerce-admin/client/marketing/hooks/index.ts
plugins/woocommerce-admin/client/marketing/overview-multichannel/Channels/RecommendedChannels.tsx
plugins/woocommerce-admin/client/marketing/overview-multichannel/MarketingOverviewMultichannel.tsx
2023-03-07 00:46:38 +08:00
3e620c41c6
Add tests for CreateNewCampaignModal.
2023-03-04 01:02:46 +08:00
15c57bf712
Fix and add tests for Campaigns card.
2023-03-03 03:25:00 +08:00
913f7176b2
Refetch registered channels after installing channel in Campaigns card.
2023-03-03 02:34:16 +08:00
ec15697d44
Load campaign types in Campaigns card.
2023-03-03 01:08:21 +08:00
e13112875b
Move useNewCampaignTypes to shared hooks directory.
2023-03-03 01:05:14 +08:00
51a5a18448
Simplify receiveCampaignTypes.
2023-03-03 00:54:21 +08:00
8132addd18
Simplify wp.data for receiveCampaignTypes.
2023-03-03 00:24:51 +08:00
2443bfd7a0
Merge branch 'feature/34905-marketing-campaigns-card' into feature/34909-marketing-create-campaign-modal
...
Conflicts:
plugins/woocommerce-admin/client/marketing/data-multichannel/action-types.ts
plugins/woocommerce-admin/client/marketing/data-multichannel/actions.ts
plugins/woocommerce-admin/client/marketing/data-multichannel/resolvers.ts
2023-03-03 00:11:35 +08:00
Gan Eng Chin
Matt Sherman
Rodrigue Tusse