Commit Graph

26977 Commits

Author SHA1 Message Date
Rodrigo Primo d603ba0b68 Check if wp_insert_term() returned a term before using it
This commit adds a check to make sure wp_insert_term() returned a term and not an instance of WP_Error before trying to access it. Without this change, the old code could produce the following fatal error:

Uncaught Error: Cannot use object of type WP_Error as array in includes/class-wc-install.php:478

Fixes #19377
2018-03-13 11:02:55 -03:00
Rodrigo Primo 40c56d8ee3 Fix default product category check
This commit casts the 'default_product_cat' option to integer before passing it to `term_exists()`. If we don't do this, `get_option( 'default_product_cat' )` return a string that is passed to `term_exists( $woocommerce_default_category, 'product_cat' )`. `term_exists()` assumes that strings are term names or slugs and search only for this fields to check if the given term exist. So it will return false (unless the term name equals to the term ID which is unlikely) even though the term exists. To make it search for terms IDs to check if the given term exists, it is necessary to pass an integer.
2018-03-13 10:19:35 -03:00
Mike Jolley a5a6d02f86 Fix null check introduced by phpcs changes 2018-03-13 11:57:51 +00:00
Mike Jolley 1dd558ac69 Loading should be false 2018-03-13 11:50:43 +00:00
Rodrigo Primo 4229b3c5b2 Rename WC_Validation::is_GB_postcode() to WC_Validation::is_gb_postcode()
To follow WP coding standards
2018-03-13 08:49:40 -03:00
Rodrigo Primo 850bbc1c40 PHPCS fixes in includes/class-wc-validation.php 2018-03-13 08:49:34 -03:00
Rodrigo Primo c2c1501acc PHPCS fixes in includes/class-wc-webhook.php 2018-03-13 08:35:25 -03:00
Mike Jolley 291de9c1fb Override supports for PayPal to see if credentials exist 2018-03-13 11:35:20 +00:00
Rodrigo Primo 52e067eeef PHPCS fixes in includes/wc-conditional-functions.php 2018-03-13 08:33:48 -03:00
Mike Jolley d910f11b49 Delete orphans after import 2018-03-13 11:14:24 +00:00
Mike Jolley 387ea23d39 phpcs 2018-03-13 11:11:11 +00:00
Mike Jolley e4e581c2ef Correctly handle default ordering on the search page
Fixes woocommerce_catalog_ordering function and closes #19362.
2018-03-13 10:43:58 +00:00
Torre Lasley 64f85346c0 Add filter to allow plugins to override the default coupon apply order. (#19339)
* Fix for Issue #10523 - Variations ID lookup by SKU

I copied the code from the bulk() function to look up the Variation ID by the Variation SKU if the Variation ID is missing.

* Added new filter woocommerce_coupon_sort to allow plugins to override the default coupon apply order.
2018-03-13 10:26:22 +00:00
Mike Jolley ffcfbd2108 version 2018-03-13 10:21:57 +00:00
Mike Jolley 7acb475c59 escape and strip tags in the quantity template
Closes #19356
2018-03-13 10:21:42 +00:00
Mike Jolley 200f2371fd
Merge pull request #19342 from woocommerce/update/walkers-phpcs
Fixed walkers PHPCS violations
2018-03-13 10:17:27 +00:00
Mike Jolley 1b905b2975
Merge pull request #19331 from woocommerce/add/coupon-wildcard-email
Add wildcard email support for coupons.
2018-03-13 10:05:06 +00:00
Mike Jolley b875299b65
Merge pull request #19372 from woocommerce/fix/broke-shipping-zones
Fixed missing shipping zones on settings
2018-03-13 10:02:30 +00:00
Mike Jolley 923bb58f9d
Merge pull request #19369 from woocommerce/fix/19247
Properly check for old and new slug while updating attributes
2018-03-13 10:01:43 +00:00
Mike Jolley 4bf8fbf9f4
Merge pull request #19371 from woocommerce/fix/19309
Clean up widget options and order_notes on uninstall
2018-03-13 10:00:32 +00:00
Mike Jolley 48303278f6
Merge pull request #19373 from nishitlangaliya/issue-19323
missing single quote added
2018-03-13 09:59:55 +00:00
Mike Jolley 272c43f0d8 Just ENT_QUOTES is enough in https://github.com/woocommerce/woocommerce/pull/19349 2018-03-13 09:58:38 +00:00
Anders Skouboe 363fb54a2d Decode single quotes in short description editor 2018-03-13 09:58:38 +00:00
Gerhard Potgieter 9a13b4d365 Add unit tests for is_coupon_emails_allowed 2018-03-13 08:03:00 +02:00
nishitlangaliya 4b4fd3931e missing single quote added 2018-03-13 11:15:43 +05:30
Gerhard Potgieter 01775a4443 Missing space 2018-03-13 07:34:47 +02:00
Claudio Sanches 988e5e576e Fixed spacing 2018-03-12 17:40:13 -03:00
Claudio Sanches 03c98e7ae7 Fixed missing shipping zones on settings
Fixed empty wp_localize_script() when WC_Shipping_Zone->get_shipping_methods() loads as admin data instead of json.
2018-03-12 17:37:45 -03:00
Mike Jolley a6b6685353
Merge pull request #19335 from woocommerce/fix/19244
Use gallery thumbnail size for variation image switcher.
2018-03-12 20:09:03 +00:00
Mike Jolley e936cbdf9c todo note for #19293 2018-03-12 19:53:14 +00:00
Mike Jolley 15a25972c4 Clean up widget options and order_notes on uninstall
Closes #19309
2018-03-12 19:47:44 +00:00
Mike Jolley 858c5e60a5
Merge pull request #19368 from woocommerce/fix-unit-tests
Make unit tests work again with PHP 5.2
2018-03-12 19:38:15 +00:00
Mike Jolley 895df71b9e
Merge pull request #19310 from woocommerce/fix/19294
Only add schema for ratings when enabled.
2018-03-12 19:37:24 +00:00
Mike Jolley 906aa97aea Merge branch 'master' into update/19061 2018-03-12 19:28:53 +00:00
Claudio Sanches 9ca7e83262
Merge pull request #19311 from mweimerskirch/patch-2
Added a filter allowing to change the order status to the BACS gateway
2018-03-12 16:28:23 -03:00
Claudio Sanches 54a0e01b8a
Merge branch 'master' into patch-2 2018-03-12 16:28:00 -03:00
Rodrigo Primo 5a5a2bc1fb Make unit tests work again with PHP 5.2
This commit fixes WC PHPUnit tests in PHP 5.2 that have been broken since commit e68084d7b8 (diff-b43983ff635e47e2ec510ae07726f0b4R30) was merged. The mentioned commit added a new method to WC_Unit_Test_Case that uses late static binding. The problem is that late static binding is available only since PHP 5.3 and WooCommerce still support PHP 5.2. Running WC tests with PHP 5.2 resulted in the following error:

Parse error: syntax error, unexpected T_STATIC, expecting T_STRING or T_VARIABLE or '$' in /home/travis/build/woocommerce/woocommerce/tests/framework/class-wc-unit-test-case.php on line 40 (see https://travis-ci.org/woocommerce/woocommerce/jobs/350303315#L281)

For now, I'm simply removing the method that used late static binding (WC_Unit_Test_Case::include_dependencies()) and manually loading the required dependencies in the two test classes that relied on it. I'm happy to add WC_Unit_Test_Case::include_dependencies() again if someone can find a way to make it compatible with PHP 5.2. If not, we can revisit this once WC drops support for PHP 5.2.
2018-03-12 16:19:47 -03:00
Mike Jolley f0aa07fbf7 Case insensitive or handling 2018-03-12 19:18:13 +00:00
Mike Jolley b0a4502e0f Unslash quotes 2018-03-12 19:11:48 +00:00
Claudio Sanches 6130a222cc Properly check for old and new slug while updating attributes
Closes #19247
2018-03-12 15:52:26 -03:00
Roy Lindauer 7016762dd5 Merge branch '17355-SplitAndFilter' of github.com:roylindauer/woocommerce into 17355-SplitAndFilter 2018-03-12 10:58:31 -07:00
Claudiu Lodromanean 0cc1b78341
Merge pull request #19296 from woocommerce/fix/hash-function
Hash may not exist
2018-03-12 10:58:31 -07:00
Roy Lindauer 6fba320040 Delete tax specific transients 2018-03-12 10:57:14 -07:00
Claudiu Lodromanean 4fbd01f003
Merge pull request #19288 from woocommerce/fix/19210
Introduce woocommerce_product_loop helper for loops
2018-03-12 10:50:25 -07:00
Mike Jolley 6e13ac7dc2
Merge pull request #19174 from woocommerce/fix/19152
Leave line height alone for inputs
2018-03-12 17:33:01 +00:00
Mike Jolley 2f73afcb70 Merge branch 'master' into fix/19152 2018-03-12 17:23:21 +00:00
Mike Jolley 2b7be75b44
Merge pull request #19366 from woocommerce/fix/19347
Check if product has weight before calculate weigth total in cart
2018-03-12 16:55:22 +00:00
Claudio Sanches 768a21e788 Check if product has weight before calculate weigth total in cart
Closes #19347
2018-03-12 12:54:00 -03:00
Claudiu Lodromanean 1b3e0b39b1
Merge pull request #19363 from nishitlangaliya/issue-19323
Add Filter to woocommerce_output_product_categories
2018-03-12 08:50:22 -07:00
Claudio Sanches 82fec65fa0 Merge branch 'master' into update/walkers-phpcs 2018-03-12 12:31:57 -03:00