Commit Graph

2231 Commits

Author SHA1 Message Date
Lourens Schep 44d9824d47 Fix error when tasks are not defined yet 2022-03-23 14:05:25 -03:00
Lourens Schep 371ce71173 Update completed tasks variable 2022-03-23 13:57:48 -03:00
Lourens Schep 25d6b6d528 Add reminder bar for task list experiment 2022-03-22 12:28:58 -03:00
Chi-Hsuan Huang 3dc5f95254 Update test mocks
Fix lint
2022-03-22 11:24:58 +08:00
Chi-Hsuan Huang 24595bd2cb Fix jest config paths 2022-03-21 18:28:05 +08:00
louwie17 4bff4d1302 Fix php notice when selecting paid theme (https://github.com/woocommerce/woocommerce-admin/pull/8493)
* Add initial E2E tests for purchase task

* Update paid theme logic to remove PHP warning and keep the correct price

* Fix php unit tests

* Address some PR feedback

* Add changelog

* Include the purchase task e2e test

* Disable test

* Delete purchase E2E test file
2022-03-18 16:05:38 -03:00
Chi-Hsuan Huang c05605fddf Update linting, testing, `@types/*` dependencies (https://github.com/woocommerce/woocommerce-admin/pull/8475)
* Update husky from 4 to 7

* Update @types/jest from 26 to 27

* Update lint-staged from 10 to 12

* Update babel-jest from 26 to 27

* Update @typescript-eslint/eslint-plugin from 4 to 5

* Update @typescript-eslint/parser from 4 to 5

* Update chalk from 4 to 5

* Update concurrently from 5 to 7

* Update stylelint from 9 to 14 and stylelint-config-wordpress from 13 to 17

* Update @wordpress/prettier-config from 0.4 to 1.1

* Update eslint from 7 to 8, @wordpress/eslint-plugin from 8 to 10, eslint-plugin-testing-library to 5

* Fix lint errors after updating eslint-plugin-testing-library

* Fix style lint

* Rename .stylelintrc.json -> stylelint.config.js & add todo comment

Fix stylelint.config.js

* Remove @wordpress/e2e-test-utils

* Add changelogs for eslint-plugin

* Update storybook/preview.js since addDecorator has been deprecated

Remove parameters

* Import directly from @storybook/addon-docs

* Migrate some stories to use @storybook/addon-controls

Add a comment for @storybook/addon-knobs

* Update changelogs

* Update preview.js to fix lint warning

* Update pnpm-lock.yaml

* Fix eslint layout errors (https://github.com/woocommerce/woocommerce-admin/pull/8484)
2022-03-18 19:45:14 +08:00
Chi-Hsuan Huang 6d139e063d Fix industry tab not clickable after going back (https://github.com/woocommerce/woocommerce-admin/pull/8469)
* Fix industry tab not clickable after going back

* Add changelog

* Add e2e test for testing industry tab going back

* Add changelog

* Add navigate to fix the test
2022-03-17 17:39:50 +08:00
louwie17 f37af20b5f New task list version 1 (https://github.com/woocommerce/woocommerce-admin/pull/8457)
* Allow for easy task component switch

* Add past tense feature addition with cross out

* Add visible option for task lists and make use of new feature config

* Fix lint errors

* Fix lint errors

* Fix css lint

* Fix js unit tests

* Address PR feedback

* Add js tests for task list changes

* Add php tests for updated logic

* Add changelog

* Update copy

* Make snooze test a little more robust
2022-03-15 14:40:22 -03:00
Moon 8232b226f7 Use constant to construct image URLs (https://github.com/woocommerce/woocommerce-admin/pull/8451)
* Add WC_ADMIN_IMAGES_FOLDER constant

* Use WC_ADMIN_IMAGES_FOLDER to construct image URL

* Rename WC_ADMIN_IMAGES_FOLDER to WC_ADMIN_IMAGES_FOLDER_URL

* Use WC_ADMIN_IMAGES_FOLDER_URL to construct image URLs

* Move wcpay-banner.png to client dir

* Move wcpay-banner.png to client dir

* Use WC_ADMIN_IMAGES_FOLDER_URL for wcAdminAssetUrl

* Use WC_ADMIN_IMAGES_FOLDER_URL to construct image URLs

* Use WC_ADMIN_IMAGES_FOLDER_URL to construct image URLs

* Revert to images

* Add / to the path
2022-03-14 15:01:03 -07:00
Matt Sherman 1ccb11c0f6 Experimental: Add filters to allow simple products to be included in Variations analytics report (https://github.com/woocommerce/woocommerce-admin/pull/8462) 2022-03-14 17:06:05 -04:00
Joshua T Flowers 834307e155 Merge payment gateway suggestion classes into single source of truth (https://github.com/woocommerce/woocommerce-admin/pull/8252)
* Rename route to payment gateway suggestions

* Create separate payment gateway suggestions controller

* Move payment gateway logic into feature class

* Merge payment gateway information into single source of truth

* Filter out WCPay client-side

* Fix up frontend

* Redirect to payment settings page on install

* Add test around showing installed gateways

* Remove check for marketplace suggestions at the endpoint level

* Fix up payment gateway conflicts after rebase

* Handle PR feedback

* Optimistically dismiss the payment gateway suggestions

* Add changelog entry

* Add square_image support for new API param

* Fixed lint error

Co-authored-by: Lourens Schep <lourensschep@gmail.com>
2022-03-07 09:15:06 -04:00
Chi-Hsuan Huang 3dff2fe11e Fix inbox letters truncator to support multi characters (https://github.com/woocommerce/woocommerce-admin/pull/8404)
* Install grapheme-splitter

* Support multi-characters Unicode letters for inbox html truncator

* Fix truncateRenderableHTML length compare

* Change note to immutable

* Add changelog

* Use hasChildNodes() to check if we should call truncateElement

* Add tests for truncate()
2022-03-07 12:09:26 +08:00
Moon 5d55b9b625 Redirect customers back to the payment task after enabling an offline gateway (https://github.com/woocommerce/woocommerce-admin/pull/8389)
* Redirect customers back to the payment task page after enabling an offline payment

* Add changelog

* Make hasPlugins property boolean

* Remove unnecessary type checking

* Fix the comparison logic
2022-03-01 17:45:44 -08:00
RJ d2205a6faf Stop showing actioned inbox items (https://github.com/woocommerce/woocommerce-admin/pull/8394)
* Stop showing actioned inbox items

- revert of https://github.com/woocommerce/woocommerce-admin/pull/7983/

* Trigger rerun of CI
2022-03-01 21:08:29 +08:00
louwie17 b871cbf09b Fix/8251 woocommerce payments task list logic (https://github.com/woocommerce/woocommerce-admin/pull/8332)
* Allow the support of multiple task lists with overlapping tasks

* Add filter by task ids

* Revert getTaskListById call

* Fix notices

* Move prefix event to task and task list classes instead

* Fix track events and extended task list

* Fix php unit tests

* Remove the seperate task list classes as this was unnecessary.

* Fix tests

* Remove unneeded allowed-tasks

* Change onboarding task list redux store structure

* Add extra id for handling hidden param for experimental task lists

* Fix lint errors

* Fix forgotten change

* Add changelog
2022-03-01 08:34:18 -04:00
louwie17 212d1c6e96 Remove the use of preloaded countries (https://github.com/woocommerce/woocommerce-admin/pull/8380)
* Remove the use of preloaded countries and make use of country data store instead

* Fix shipping task

* Add changelog

* Fix lint errors
2022-03-01 08:33:41 -04:00
RJ f306cc2ba5 Enable Typescript checking on ./client folder (https://github.com/woocommerce/woocommerce-admin/pull/8372)
* Copied .tsconfig into ./client to enable ts checking

- Made sub-repos composite typescript packages where necessary

* Prevent tsc from transpiling ./client

 - we use webpack for transpiling so no need for this

* Added tsc resolution path for @automattic/explat-client

- Seems like there's a type export issue (?) with @automattic/explat-client and @automattic/explat-client-react-helpers
- adding the node_modules/@automattic/explat-client path in tsconfig seems to help TS resolve this using the source .ts files
- found answer here: https://github.com/microsoft/TypeScript/issues/42873
- should figure out what's actually wrong with the type exports and fix that there instead

* Removed mandatory checking from webpack

- removed this for now as it will block all development until all type inconsistencies are fixed
- for now, run the optional ts:check task either in console or vscode for highlighting type errors

* Added vscode tasks for typescript checking

* Patch @automattic/explat-client-react-helpers

- this changes the installed code in node_modules (post-installation) for @automattic/explat-client-react-helpers so that it exports the necessary type interfaces required by us
- attempted unsuccessfully to override type exports using declare module
- not too sure how to fix this internally by other means
- have to investigate what fixes to propose to @automattic/explat-client-react-helpers team

* changed tests in ./client to use ts-jest instead of babel-jest

- rewrote jest config to use ts-jest instead of babel-jest
- set ts errors to warnings instead so that tests don't fail on type errors
- created new tsconfig for ./packages/js-tests so that build and ts-check are separate, as js-tests need to be built for commonjs
2022-03-01 12:19:07 +08:00
Moon 3e672d7664 Redirect to the WC Pay onboarding when WC Pay is installed (https://github.com/woocommerce/woocommerce-admin/pull/8367)
* Redirect to the connect page when WC Pay is installed

* Add comment
2022-02-28 11:40:45 -08:00
Moon a2dfbffe89 Remove inbox_action_click event -- this is called from backend by triggerNoteAction (https://github.com/woocommerce/woocommerce-admin/pull/8376) 2022-02-28 11:40:35 -08:00
Fernando 77fb10c53e OBW: fix copy on Business Details when "WooCommerce Shipping" is not listed (https://github.com/woocommerce/woocommerce-admin/pull/8324)
* Fix wc-shipping copy

* Fix method `createInstallExtensionOptions`

* Fix tests

* Add changelog

* Add WCTax logic

Co-authored-by: Fernando Marichal <contacto@fernandomarichal.com>
2022-02-25 18:26:44 -03:00
Chi-Hsuan Huang c05ed7777a Update dependencies to support react 17 (https://github.com/woocommerce/woocommerce-admin/pull/8305)
* Upgrade dependencies to support react17

Update pkg

Update @wordpress/api-fetch and gridicons

* Update test snapshots

* Update SnackbarList with latest react-spring

* Mock data.dispatch for task-list-item.test.tsx

* Remove '@wordpress/components/src/visually-hidden/style' import

wp-components has included it

* Update interpolateComponents import path

* Fix display-options test

* Add changelogs

Update changelogs

* Add @automattic/explat-client-react-helpers back

* Update webpack.config for explat-client-react-helpers

Update webpack config comment

Fix grammar
2022-02-21 10:34:25 +08:00
louwie17 42625174d9 Have free subscriptions adhere to cbd industry (https://github.com/woocommerce/woocommerce-admin/pull/8323)
* Make sure the free subscriptions does not show when cbd industry is selected

* Add changelog and fix productTypes not being defined

* Fix lint issue

* Fix lint error
2022-02-18 10:23:37 -04:00
louwie17 7c6a1f3b5b Fix payment task conflicts (https://github.com/woocommerce/woocommerce-admin/pull/8321)
* Fix payment logic of payment tasks between current task list and experimental one.

* Revert testing changes

* Fix linting

* Add changelog
2022-02-18 09:59:39 -04:00
Moon 718bac6981 Prompt a modal to save any unsaved changes in OBW (https://github.com/woocommerce/woocommerce-admin/pull/8278)
* Add a modal to show when unsaved changes are detected

* Add functions to track value changes from the steps

* Warn unsaved changes for the store details

* Add styles for the unsaved modal

* Warn unsaved changes for the Industry

* Warn unsaved changes for the Product Types

* Warn unsaved changes for the Business Details

* Add changelog

* Add testing instructions.

* Sort array values before comparison

* Use only the array values to compare the diff

* Catch rejected promise on continue

* Set initial value to an empty object

* Fix failing tests
2022-02-17 11:15:11 -08:00
Ilyas Foo 5840898524 Add card fees to specify what the discount applies to (https://github.com/woocommerce/woocommerce-admin/pull/8319) 2022-02-17 11:30:59 +08:00
Ilyas Foo d590b1116f Fix WCPay in core texts and promo slug (https://github.com/woocommerce/woocommerce-admin/pull/8296)
* Fix texts and change promo slug

* Changelog
2022-02-16 11:10:59 +08:00
RJ ab1cbfb6f2 Added tracks test for PaymentGatewaySuggestions (https://github.com/woocommerce/woocommerce-admin/pull/8306) 2022-02-15 10:30:46 +08:00
Paul Sealock e41441f83e Add hook reference generator README and documentation (https://github.com/woocommerce/woocommerce-admin/pull/8004)
* Add hook reference README

* update hook reference

* better

* changelog

* add pr number

* remove example

* add desc

* add stats

* jsdoc REPORTS_FILTER

* Category configs

* configs

* data

* dashboard

* dashboard charts

* save

* save

* save

* done with filters

* Add scope to slotFill docs

* data

* add all slotfills

* data

* Fix error when scope is not present, and make use of typedef imports

* Move chart and filter jsdoc definitions to the reports index file

* Update hook reference data.json

* Make use of import for filter typedef and address some typos

Co-authored-by: Lourens Schep <lourensschep@gmail.com>
2022-02-11 10:38:38 -04:00
louwie17 0deb1c33bc Add wc_version to store profiler view and complete tracks (https://github.com/woocommerce/woocommerce-admin/pull/8290)
* Add wc_version to store profiler view and complete tracks

* Add changelog

* Update changelog
2022-02-11 10:03:37 -04:00
Chi-Hsuan Huang e1ac06afa7 Fix payments extensions displayed below the offline payments options (https://github.com/woocommerce/woocommerce-admin/pull/8232)
* Fix payments extensions displayed below the offline payments options

Add spaces back

* Add changelog

* Remove the snapshot test and update payment gateway render test

* Make sorting compare function as a helper function
2022-02-09 14:12:20 +08:00
Chi-Hsuan Huang 6dc5189fc2 Replace "any" type with an explicit type (https://github.com/woocommerce/woocommerce-admin/pull/8262)
* Replace "any" type with an explicit type

* Add types in utils and import FormInputProps to store address
2022-02-09 12:40:44 +08:00
louwie17 83e1addd82 Fix minor process issues (https://github.com/woocommerce/woocommerce-admin/pull/8279) 2022-02-08 18:22:26 -04:00
louwie17 7d2aa04b2a Add business-details step complete track (https://github.com/woocommerce/woocommerce-admin/pull/8265)
* Add business-details step complete track

* Add changelog

* Update tab name and treat each tab as an individual step when trickering tracks

* Add comment

* Fix linting

* Remove unnecessary css selector

* Update goToNextStep param to make it less confusing

* Update jsdoc param
2022-02-08 14:29:17 -04:00
RJ b9806c5087 Made email in OBW optional again (https://github.com/woocommerce/woocommerce-admin/pull/8263) 2022-02-08 08:56:45 +08:00
louwie17 23505c1e58 Make sure hidden fields are cleared when definition changes (https://github.com/woocommerce/woocommerce-admin/pull/8250)
* Make sure hidden fields are cleared when definition changes

* Make use of shortened condition available in TS
2022-02-07 19:31:08 -04:00
louwie17 c2537136bb Fix shipping task step when store location isn't filled out (https://github.com/woocommerce/woocommerce-admin/pull/8260)
* Remove completeStep call in StoreLocation callback to avoid duplicate call.

* Add changelog
2022-02-07 14:55:35 -04:00
Moon 080dc48a9b Fix/8191 deleting products adds blank space to analytics data (https://github.com/woocommerce/woocommerce-admin/pull/8255)
* Retrieve variation name from woocommerce_order_items for deleted products

* Remove test code

* Refactor to use wc_order_product_lookup table

* Identation fix

* Remove link if the variation/product has been deleted

* Add changelog

* Remove (deleted) suffix

* Add (Deleted) suffix in frontend
2022-02-07 10:13:27 -08:00
Ilyas Foo dfdafc1568 Update headercard to use filter to add ExPlat parameter (https://github.com/woocommerce/woocommerce-admin/pull/8233)
* Add changelog

* Update headercard experiment hook to utilize `woocommerce_explat_request_args` filter

* Add test

* Fix experiment name check

* Update parameter name

* Add changelog

* Removed old changelog

* Added prop comments to Layout component

* Add preload option for homescreen

* Fix class attribute typo

* Hide extended tasklist when task detail is shown

* Add local Suspense to stop lazy component bubbling up to Controller's Suspense

* Remove unused props

* Add missed Suspense, add loading logic to ActivityHeader

Co-authored-by: Moon <moon.kyong@automattic.com>
2022-02-07 08:50:20 +08:00
Joshua T Flowers 517d248ed7 Remove unused task styling classes (https://github.com/woocommerce/woocommerce-admin/pull/8234)
* Remove unused task styling classes

* Rename typo in dismiss modals

* Remove extra styling selector class

* Add changelog entry
2022-02-04 10:26:56 -05:00
Chi-Hsuan Huang e6f19d0d91 Fix country/region selection not preserved in store details task (https://github.com/woocommerce/woocommerce-admin/pull/8228)
* Fix country/region selection not preserved in store details task

* Update store-adress test cases

* Add changelog

* Check alphabets regx for isStateAbbreviation

* Update comments

* Use unknown type for locale

* Add Disable reason
2022-02-01 14:13:54 -04:00
Joshua T Flowers ea6b50f241 Show single success message for theme install and activation (https://github.com/woocommerce/woocommerce-admin/pull/8236)
* Show single success message for theme install and activation

* Add changelog entry
2022-02-01 12:02:33 -05:00
Joshua T Flowers ace300b4cd Fix setup wizard title and flash of content (https://github.com/woocommerce/woocommerce-admin/pull/8201)
* Fix setup wizard title and flash of content

* Redirect to profiler server-side if landing on the homepage

* Add changelog entry
2022-01-26 15:28:52 -05:00
louwie17 2e3b9f1e01 Add tasklist_payment_setup track for WooCommerce Payments (https://github.com/woocommerce/woocommerce-admin/pull/8146)
* Add changelog

* Move payment setup even to Action button
2022-01-25 17:47:36 -04:00
Jacob Sewell 917545577f Task List: Personalize your store / Import products - error message is not formatted correctly (https://github.com/woocommerce/woocommerce-admin/pull/8173)
* Use __() to display a generic error message on sample item import rather than passing through the server message because it probably has tags.

* Add changelog for 4314/8173.

* Add support for __unstableHTML option to Snackbar.

* Use __unstableHTML option to display server-side error messages as they come in.

* Update changelog description for 4314/8173.
2022-01-25 13:06:38 -06:00
louwie17 3742be465e Add performance tracks to onboarding flow (https://github.com/woocommerce/woocommerce-admin/pull/8042)
* Add payment_setup track for WooCommerce Payments

* Add timing props to tracks in onboarding when installing extensions

* Update extension key logic

* Add changelog

* Add tests for extension installation data for tracks

* Add util function for plugin slug parsing

* Only install and activate plugins that are not already active
2022-01-24 12:23:12 -04:00
Jacob Sewell 2b1dd08040 Fix/7174 dismiss button alignment (https://github.com/woocommerce/woocommerce-admin/pull/8168)
* Combine all the .woocommerce-task-dashboard__container .woocommerce-task-card rules in one block.

* Move the .woocommerce-task-card__section-controls text-align center rule up in specificity so it overrides the rule in experimental-list.
Do we need the experimental-list package still?

* Changelog for 7174/8168.

* Expand button to container width and center text rather than centering the entire button in the ellipsis menu.

* Move ellipsis menu button style to _global so it applies, um, globally.

* Update changelog description for 7174/8186.

* Move ellipsis-menu popover button style to package from _global.

* Add components package changelog for Dismiss button in Unreleased section.
2022-01-22 11:48:01 -06:00
Jacob Sewell 1e8cdb3543 Reduce padding around plugin list titles for marketing tools page. (https://github.com/woocommerce/woocommerce-admin/pull/8171)
* Reduce padding around plugin list titles for marketing tools page.

* Changelog for 8164/8171.

* Update plugin list title padding

Co-authored-by: Ilyas Foo <foo.ilyas@gmail.com>

Co-authored-by: Ilyas Foo <foo.ilyas@gmail.com>
2022-01-20 20:50:21 -06:00
RJ 49bf6a5c81 Updated frontend email validation to use @wordpress/url (https://github.com/woocommerce/woocommerce-admin/pull/8197)
* Updated frontend email validation to use @wordpress/url

- added testing for StoreDetails
- changed basic email validation to use @wordpress/url isEmail
2022-01-20 16:40:20 +08:00
Chi-Hsuan Huang ff1e31cfd4 Enhance report chart i18n support (https://github.com/woocommerce/woocommerce-admin/pull/8129)
* Support i18n texts for report chart

* Add changelogs

* Add d3-time-format to date pkg devDependencies

* Fix date php format and add tests

* Add date changelog

* Fix date test

* Escape week of string for php formatter
2022-01-20 08:20:18 +08:00