Commit Graph

5330 Commits

Author SHA1 Message Date
Peter Fabian 63486a1cb0 Force the saving of notices for the 'install' notice to prevent performance problems for all notices, while also making it less prone to race conditions during the installation. 2020-02-25 15:00:37 +01:00
Peter Fabian 992c6538dc Force the saving of notices only for the 'update' notice to prevent performance problems. 2020-02-25 14:58:02 +01:00
Peter Fabian f3dceae5df Added more exclusions for the DB notice show_reminder method.
Also, moved `woocommerce_hide_update_notice` outside those exclusions in case
it would get triggered from cron or via AJAX.
2020-02-25 14:51:09 +01:00
vedanshujain f5220383a5 Add defensive checks because `configure` is not present in older jetpack version 2020-02-25 15:03:15 +05:30
Peter Fabian d4933d9a5d Run configure for Jetpack plugin before attempting to try_registration.
This should prevent the fatal error otherwise occuring when connecting with Jetpack
during the OBW if Jetpack is inactive/not installed.
2020-02-24 17:47:07 +01:00
Peter Fabian 7ec65a1b35 Added the WC Admin enabled db update notice. 2020-02-23 21:59:03 +01:00
picocodes 91b01ccaff
fix typo 2020-02-12 17:13:13 +03:00
vedanshujain ee0e94e909 Change how filter is implemented to help both 3PD and translators 2020-02-07 17:54:54 +05:30
vedanshujain 707a9bf9a0 Bump versions 2020-02-07 17:54:54 +05:30
vedanshujain cc26fdb2e3 Updated docs link 2020-02-07 17:54:54 +05:30
vedanshujain b29219969c Addressed code review comments 2020-02-07 17:54:54 +05:30
vedanshujain ca5fd12103 Add setting to configure hash appends 2020-02-07 17:54:54 +05:30
vedanshujain 56176e0479 Append unique hash to filename for added security 2020-02-07 17:54:54 +05:30
vedanshujain dc060fe700 Add notice when "redirect only" download method is selected.
This download is insecure as it reveals the original file location. We will try to nudge user to use any of the other download method instead.
2020-02-07 17:54:54 +05:30
vedanshujain d7bac6313c Add suffix "Insecure" to indicate that this method is insecure 2020-02-07 17:54:54 +05:30
Peter Fabian 4f485a14de Added explanation comments. 2020-02-07 12:58:31 +01:00
Peter Fabian 5fc2e8fba9 Only skip the store_notices during new install in AS. 2020-02-07 11:06:35 +01:00
Peter Fabian 4c4f9f1164 Don't save notices when running from AS. 2020-02-07 00:21:03 +01:00
Peter Fabian 06d0bbefc4 Don't run setup wizard redirects from AS. 2020-02-07 00:20:42 +01:00
Peter Fabian ee865fe0b4
Merge pull request #25504 from woocommerce/update/order-detail-summary
Enhance order details and payment summary
2020-02-06 11:40:45 +01:00
Peter Fabian 5c23d013d7 Added info about packages to System Status Report. 2020-02-05 21:54:05 +01:00
Rodrigo Primo 44ecb0ec9e Only display the "Paid by customer" section if the order has been paid
This commit changes the condition in the if the statement that decides
whether or not to display the "Paid by customer" section in the order admin
page. Before it, this section was displayed for all orders that
contained one of the following statuses: 'processing', 'completed' or 'refunded'.

The problem with this approach is that offline payment gateways, like
'Cash on Delivery', set the order status to processing when the order is
placed but before the customer pays for it. So the "Paid by customer"
section was being displayed in some cases where the order was not
actually paid yet creating a confusing experience to store managers.

To fix this, this commit also checks for the presence of the
`_date_paid` order meta. If this order meta is present and the order
status corresponds to one of the three statuses listed above, it means that
the order has been paid and we can display the "Paid by customer"
section. If this order meta is not present, we don't display the "Paid
by customer" section.
2020-02-05 16:08:13 -03:00
Christopher Allford 57734ca8ce Merge branch 'master' into refactor/add-jetpack-constants 2020-02-04 14:36:35 -08:00
Christopher Allford 4ae1e1f5fc Extracted the repetitive Constants::get_constant( 'WC_VERSION' ) calls where possible 2020-02-04 14:02:57 -08:00
Peter Fabian 147266f44f Updates to reflect PR feedback. 2020-02-04 21:43:29 +01:00
Peter Fabian 5001e14086 Renamed Discounts to Coupons. 2020-02-04 18:27:53 +01:00
Claudio Sanches f021a6559f
Merge pull request #25562 from woocommerce/fix/25560
Removed WC Admin from the Setup Wizard if it's already active.
2020-02-04 14:03:55 -03:00
Peter Fabian e5e5d5997e Better name for the new function. 2020-02-04 17:53:28 +01:00
Claudio Sanches 6f37df1961
Merge pull request #25502 from woocommerce/fix/25488
[4.0] Remove wc-admin install nudge.
2020-02-04 13:19:57 -03:00
Claudio Sanches 3fa9c79d94 Remove old notice file 2020-02-04 13:17:36 -03:00
Claudio Sanches 94d1b742ad
Merge pull request #25545 from woocommerce/prep/after-3.9
Bumped versions for the upcoming release.
2020-02-04 13:05:27 -03:00
Claudio Sanches ab147f7a71
Merge pull request #25532 from woocommerce/update/wccom-helper-api-authentication
Add query params as fallback for passing authentication data to WC Helper API
2020-02-04 13:04:11 -03:00
Peter Fabian 4a506ebcf7
Merge pull request #25530 from woocommerce/fix/country-region-label
Fix/country region label
2020-02-04 13:54:22 +01:00
vedanshujain ee274be95a Modified "Country" to "country / Region" for more inclusiveness 2020-02-04 13:46:13 +05:30
Peter Fabian d588218eb6 PHPCS 2020-02-03 23:18:12 +01:00
Peter Fabian 12fe0e6815 Corrected tax amount displayed in the summary. 2020-02-03 23:09:59 +01:00
Peter Fabian f9c9498e7c Replaced deprecated call with a substitute function. 2020-02-03 23:09:19 +01:00
Christopher Allford bf02776a3b Corrected inconsistent uses of the Constants library 2020-02-03 13:15:12 -08:00
Christopher Allford c5e1fc6c45 Merge remote-tracking branch 'origin/master' into refactor/add-jetpack-constants 2020-02-03 11:50:16 -08:00
Denis Dvali e496d6ea3f Adding doc comments to comply with coding standard. 2020-02-03 22:14:00 +03:00
Peter Fabian 04c4732e13 Unified the check for presence of WC Admin. 2020-02-03 18:04:18 +01:00
Peter Fabian aa8e8992cc Merge branch 'master' into fix/25560
# Conflicts:
#	includes/admin/class-wc-admin-setup-wizard.php
2020-02-03 17:59:24 +01:00
Peter Fabian 670dbbc5e7 Removed WC Admin from the OBW if it's already active.
Also, removed info about plugin installation if the plugin is active.
2020-02-03 17:41:50 +01:00
Peter Fabian 152a5cd52c
Merge pull request #25527 from woocommerce/fix/25526
Use enable onboarding path instead of manually setting onboarding option
2020-02-03 17:18:02 +01:00
Christopher Allford 1d1413b4ee Replaced direct access of many constants with the Constants library 2020-01-31 22:18:47 -08:00
Peter Fabian 132ced6039 Fixed test for 4.0. 2020-01-31 21:05:50 +01:00
Peter Fabian 331b953c0c Harmonize aria-label with other labels. 2020-01-31 08:59:52 +01:00
Peter Fabian e87cea8688
Merge pull request #25501 from woocommerce/fix/25487
[4.0] Increase Onboarding A/B Test to 50%
2020-01-31 08:54:14 +01:00
Joshua Flowers 236bae9b6a Check for wc_admin_url function in onboarding redirect 2020-01-31 10:56:44 +08:00
Joshua Flowers 28af08a1cb Move exit 2020-01-31 10:52:49 +08:00
Peter Fabian 248e69960b Merge branch 'master' into update/order-detail-summary 2020-01-30 17:41:32 +01:00
Denis Dvali 9e25706467 Add query params as fallback for passing authentication data to WC Helper API. 2020-01-30 15:17:50 +03:00
Peter Fabian 7c07b192af Changed country to country/region label. 2020-01-30 12:42:41 +01:00
Joshua Flowers 74917a1548 Use enable onboarding path instead of manually setting onboarding option 2020-01-30 12:52:05 +08:00
Christopher Allford ceeba16014
Merge pull request #24919 from TimBHowe/fix/20921
Fix/20921 - Throw error for invalid character in flat rate cost.
2020-01-29 13:32:49 -08:00
Christopher Allford 6ad091a9b7 Changed all of the constant accesses into corresponding Automattic\Jetpack\Constants usages 2020-01-28 21:21:29 -08:00
TimBHowe f488f46b37 remove the pattern constraint on the flatrate input in the setup wiz 2020-01-28 11:01:13 -05:00
TimBHowe d377f002aa Added pattern attribute to the flat rate cost input field to only allow US and EU currency formating 2020-01-28 10:44:37 -05:00
TimBHowe 8b71dc0abb Updated the wc_setup_shipping_save() function to sanitize the flatrate cost input 2020-01-28 10:44:36 -05:00
David Levin ee2c6b8096 Change net payment to net total 2020-01-27 21:10:11 -08:00
David Levin 3c92aacfcb update shipping methods 2020-01-27 19:22:04 -08:00
Timmy Crawford 9bfc7db3fb Remove wc-admin install nudge. 2020-01-27 09:24:46 -08:00
Timmy Crawford 081afa256c Change a/b test size of new onboarding to 50 percent. 2020-01-27 09:01:27 -08:00
vedanshujain d768fcb139 Apply rounding only if value is integer to display "-" when needed. 2020-01-23 17:36:49 +05:30
Rodrigo Primo 8489d1bd33 Merge branch 'master' into fix/25394 2020-01-16 16:35:43 -03:00
Claudio Sanches eedf82da38 Fixed coding standards 2020-01-15 20:40:55 -03:00
Claudio Sanches 5bafac3012 Improved maxmind_missing_license_key_notice logic 2020-01-14 23:32:55 -03:00
Christopher Allford 42269f965c Added clarification that the MaxMind license key is not strictly necessary 2020-01-14 14:09:51 -08:00
Rodrigo Primo 241c6cd590 Make context for admin notice documentation more clear 2020-01-14 17:07:12 -03:00
Rodrigo Primo 23e1abe1dc Fix typo in php docblock 2020-01-14 16:45:57 -03:00
Claudio Sanches 10cdbf88be Use shop base address as default customer location 2020-01-14 16:29:48 -03:00
Claudio Sanches 978c5b5fb9 Apply woocommerce_maxmind_geolocation_display_notices filter in notices class 2020-01-14 15:22:53 -03:00
Claudio Sanches 1c874264d8 Removed MaxMind from System Status page 2020-01-13 21:48:23 -03:00
Joshua Flowers 902e1cc184 Check for the WooCommerce Admin class before adding notice 2020-01-13 17:43:27 +08:00
Christopher Allford f5d07c954c Adjusted the MaxMind license key notice to be clearer 2020-01-10 13:07:26 -08:00
Claudio Sanches c3abe8ac65 Added missing license key notice and triggers 2020-01-10 15:07:05 -03:00
Claudio Sanches cfeb07eaf7 Removed legacy code 2020-01-10 13:18:25 -03:00
David Levin 40c76b83a2 update order to play nice with gateways, add paid by customer when order is paid in full 2019-12-22 20:14:31 -08:00
David Levin e4fcfc4d1a add net payment calculation, and re-order refund item to bottom of rows 2019-12-20 14:28:06 -08:00
David Levin 34ff4544ff trying to get net payment to work 2019-12-20 12:27:17 -08:00
David Levin b7c455c9d1 Add line for net payment post refund 2019-12-20 12:06:11 -08:00
Rodrigo Primo 7337ab60c2 Fix PEAR.Functions.FunctionCallSignature violations
This commit fixes all violations of the PEAR.Functions.FunctionCallSignature sniff automatically using phpcbf.
2019-12-20 15:25:23 -03:00
Rodrigo Primo 86c1b61f03 Fix Generic.WhiteSpace.ScopeIndent violations
This commit fixes all violations of the Generic.WhiteSpace.ScopeIndent sniff automatically using phpcbf.
2019-12-20 14:48:11 -03:00
Rodrigo Primo 487f96d844 Fix WordPress.DateTime.CurrentTimeTimestamp vilations
This commit fixes all violations of the WordPress.DateTime.CurrentTimeTimestamp sniff automatically using phpcbf.
2019-12-20 14:23:05 -03:00
Rodrigo Primo 62d6b05b58 Fix Generic.Formatting.MultipleStatementAlignment violations
This commit fixes all violations of the Generic.Formatting.MultipleStatementAlignment sniff automatically using phpcbf.
2019-12-20 14:21:08 -03:00
Rodrigo Primo 94373f78ea Fix WordPress.Arrays.MultipleStatementAlignment errors automatically using phpcbf 2019-12-20 13:51:26 -03:00
David Levin b5bdb3dae0 change the order of shipping and fees in order line items 2019-12-19 12:11:50 -08:00
David Levin 25603cc190 display actual item price before discount in order item cost 2019-12-19 08:14:03 -08:00
David Levin 7ecae84d99 Rename coupons to discounts in order summary 2019-12-19 08:00:21 -08:00
David Levin 8c62fc72a6 update order summary totals 2019-12-19 07:53:35 -08:00
David Levin 5df30cdbd6 rename method to get fee totals 2019-12-18 21:34:40 -08:00
David Levin c6cd7331f9 update order details summary with items subtotal and start to add fees 2019-12-18 20:51:45 -08:00
Justin Shreve a5ee52a6c6 Add WP version check before recommending WooCommerce Admin 2019-12-18 09:29:21 -05:00
Rodrigo Primo ae1717cd4f Fix PHPCS violations automatically using PHPCBF 2019-12-13 17:51:14 -03:00
Rodrigo Primo f06ad5d78a Replace removed WordPress.Security.NonceVerification.NoNonceVerification
WordPress Coding Standard 2.0 removed the sniff
WordPress.Security.NonceVerification.NoNonceVerification:

```
The WordPress.Security.NonceVerification sniff used the same error code for both an error as well as a warning.
The old error code NoNonceVerification is no longer used.
The error now uses the Missing error code, while the warning now uses the Recommended error code.
```

(from
d45f5e5cf3/CHANGELOG.md (200-rc1---2018-12-31))

This commit updates WooCommerce code and replaces all instances where WordPress.Security.NonceVerification.NoNonceVerification verification was used with either WordPress.Security.NonceVerification.Missing or
WordPress.Security.NonceVerification.Recommended. In a few cases WordPress.Security.NonceVerification.NoNonceVerification was used but was not needed, so instead of replacing the sniff, the line was removed. In two other cases, I removed other unrelated sniffs that were not needed.
2019-12-13 17:45:32 -03:00
Rodrigo Primo 9c4de8f5e7 Fix indentation 2019-12-13 16:48:17 -03:00
Rodrigo Primo d451b68488
Merge pull request #24929 from helgatheviking/feature/woocommerce_process_variation_object
Add woocommerce_admin_process_variation_object before $variation->save()
2019-12-13 16:46:22 -03:00
Peter Fabian 72925ef41c Centralize check for default themes.
This should make Storefront appear in the Setup Wizard again.
2019-12-11 18:35:04 +01:00
Claudio Sanches 02ae29c8fc Fixed support to older versions of WordPress 2019-12-10 22:12:50 -03:00
dsmithweb 5a17c63cc9 Update links 2019-12-10 18:41:55 -06:00