Commit Graph

17620 Commits

Author SHA1 Message Date
Mike Jolley 40694118fc Merge branch 'pr/21050' 2019-01-31 15:47:52 +00:00
Mike Jolley a68ed39e63 use cart hash method on checkout 2019-01-31 15:46:41 +00:00
Mike Jolley 25ebc45fbc Make consistent with checkout and rename filter 2019-01-31 15:46:26 +00:00
Ron Rennick 9855a18036 phpcs sniff fixes for class-wc-query.php 2019-01-31 11:18:19 -04:00
Ron Rennick f5f020e6f4 add logic for $main_query parameter in get_meta_query 2019-01-31 11:15:14 -04:00
Galen Wright-Watson 64c76ee8b9 Adds filter for product categories displayed by `product_categories` shortcode. 2019-01-31 15:01:33 +00:00
Mike Jolley effa51829c
Merge pull request #22573 from outis/fix-expired-link
Fix: #22572-can't access settings ("The link you followed has expired")
2019-01-31 14:50:36 +00:00
Mike Jolley 1e3e5a4528
Merge pull request #22580 from woocommerce/fix/22515
recalculate coupons after adding coupon to order
2019-01-31 14:38:59 +00:00
Mike Jolley 5e9253980b
Merge pull request #22566 from jenkoian/change-for-network-media-library-compatibility
Remove possibe superfluous wp_attachment_is_image() filter.
2019-01-31 14:20:35 +00:00
Mike Jolley 8ed1dacdc9
Merge pull request #22581 from woocommerce/fix/22561
include refunded orders in top sellers, earners in sales by product report
2019-01-31 13:51:51 +00:00
Mike Jolley 8c860c65bd
Merge pull request #22554 from woocommerce/fix/seo
Better `@id` generation for product structured data
2019-01-31 13:47:08 +00:00
Mike Jolley ea0e8155eb
Merge pull request #22553 from woocommerce/fix/22449
use `name` for POST/PUT category image name for consistency
2019-01-31 13:46:33 +00:00
Mike Jolley 1dea9d6f48 Merge branch 'enhancement/21758' 2019-01-31 13:44:35 +00:00
Mike Jolley 74cd1ced37 Merge branch 'fix/20710' 2019-01-31 13:37:02 +00:00
Mike Jolley a77578a989
Merge pull request #22347 from woocommerce/fix/20911
Tweak tax handling when exempt of VAT and woocommerce_adjust_non_base…
2019-01-31 13:33:36 +00:00
Mike Jolley effb7b0a64
Merge pull request #22342 from woocommerce/update/22315
Update Emogrifier
2019-01-31 13:32:36 +00:00
Mike Jolley a9bc5cf5ae
Merge pull request #22421 from woocommerce/update/22034
Clarify how discount is applied
2019-01-31 13:30:25 +00:00
Mike Jolley 7df55922ae
Merge pull request #22587 from woocommerce/performance/prime-variation-cache
Prime caches when reading variations
2019-01-31 13:29:28 +00:00
Mike Jolley cb59b2c1d2
Merge pull request #22594 from woocommerce/fix/22583
Keep track of reload checkout when doing ajax order review
2019-01-31 13:28:29 +00:00
Mike Jolley f7f2b99211
Merge pull request #22551 from princeahmed/master
Fix test get request
2019-01-31 13:11:03 +00:00
Shubham Mathur 1f21fd86c5 Fix for images with no metadata (#22562)
* Fix for images with no metadata

Fix for error when images have no metadata or their metadata is removed.

* Fix for images with no metadata

Fix for error when images have no metadata or their metadata is removed.

* Fix for images with no metadata

Fix for error when images have no metadata or their metadata is removed.

* Fix for images with no metadata

Fix for error when images have no metadata or their metadata is removed.
2019-01-31 13:01:59 +00:00
Mike Jolley 133d108bd8
Merge pull request #22269 from Prospress/fix/22247
convert user creation GMT datestamp to local datetime in API
2019-01-31 12:56:40 +00:00
Mike Jolley 808c90b5df
Merge pull request #22605 from woocommerce/add/22579
Filter for modifying the user queries on customer reports
2019-01-31 12:49:28 +00:00
Mike Jolley c5b28e49be
Merge pull request #22602 from 10by/patch-1
Updating Peruvian currency
2019-01-31 12:42:50 +00:00
Gregory Karpinsky 17a59c5004
Typo in class-wc-log-levels.php 2019-01-30 23:31:39 -05:00
Mike Jolley dd981be615 We need auth early 2019-01-30 18:12:33 +00:00
Mike Jolley cd4039e078 Only do includes on rest requests 2019-01-30 17:38:41 +00:00
Mike Jolley 5b57cb5356 Layered nav should use base link 2019-01-30 16:29:01 +00:00
Mike Jolley 77eba86818 Get rid of reflection method to speed up set_props 2019-01-30 16:21:06 +00:00
Mike Jolley 9a8d11e9f6 phpcs 2019-01-30 16:20:49 +00:00
Mike Jolley 7eda1bb412 Only use WP Error when needed 2019-01-30 16:20:41 +00:00
Mike Jolley a16c677baf Missing _price 2019-01-30 16:20:23 +00:00
Mike Jolley 8e51ab2fcd Set props using one get_post_meta call 2019-01-30 16:20:17 +00:00
Mike Jolley e129d18c00 get_current_page_url should not persist 2019-01-30 16:18:56 +00:00
Mike Jolley 23b0fdbc1f Fix id usage 2019-01-30 16:11:44 +00:00
Mike Jolley 8fc7e2be99 prefix tax cache key 2019-01-30 16:11:37 +00:00
Mike Jolley 57ccde6643 get_product_type cache 2019-01-30 16:11:29 +00:00
Mike Jolley cb1c579262 Cache tax class slugs 2019-01-30 16:11:19 +00:00
Mike Jolley 874f4830a6 cache_value cleanup 2019-01-30 16:11:11 +00:00
Mike Jolley 4622af890a wc_attribute_taxonomy_slug cache 2019-01-30 16:11:04 +00:00
Mike Jolley a5bc236c66 get_current_page_url cache set 2019-01-30 16:10:56 +00:00
Mike Jolley fa58f3bb9f Lax the kses here - link and name is already escaped. 2019-01-30 16:10:48 +00:00
Mike Jolley 536d71a5f6 cache get_current_page_url 2019-01-30 16:09:16 +00:00
Mike Jolley d167cb0a95 Add caching for template names to avoid multiple lookups 2019-01-30 16:09:08 +00:00
Mike Jolley 6fa7995f3a Only check file exists if filtered 2019-01-30 16:09:01 +00:00
Mike Jolley 35819ccb6e Small refactor for clarity 2019-01-30 16:08:53 +00:00
Mike Jolley 4eb0080605 apply_filters_deprecated to avoid conflict with wp profile 2019-01-30 16:06:51 +00:00
Mike Jolley 0dd7cd2b8b Improved post_class generation to avoid loading more product objects 2019-01-30 16:02:22 +00:00
Mike Jolley bd076d42da Refactor wc_get_product_class to avoid $post object 2019-01-30 16:02:00 +00:00
Mike Jolley 59e0867afe Add missing post_password prop 2019-01-30 16:01:54 +00:00
Mike Jolley 1ba0194685 Remove external lookup of ips on localhost 2019-01-30 15:59:02 +00:00
Gerhard a2e4ca70b6 PHPCS fixes 2019-01-30 11:33:51 +02:00
Gerhard 429f515704 Introduce woocommerce_admin_report_customers_user_query_args and woocommerce_admin_report_customer_list_user_query_args filters to altering the queries running when retrieving users for reports. 2019-01-30 11:19:34 +02:00
Toby Robles 7fa1bd78c9
Updating Peruvian currency
Since 2015, the government ordered that the "Nuevo Sol (S /.)" be renamed simply "Sol (S/)", also suppressing the use of the point (S/.) in the monetary sign (S/)
2019-01-29 20:01:04 -05:00
Job 185041da87
Removed title case
As requested here by https://github.com/woocommerce/woocommerce/pull/22584#pullrequestreview-197707971
2019-01-29 20:40:59 +01:00
Boost d9c971ee20 Update class-wc-structured-data.php. Line 214, changed wpautop to wp_filter_nohtml_kses 2019-01-29 13:27:05 +00:00
Gerhard 69baf175c1 After some testing using area-hidden seems to deliver the best results for not producing the hissing sound on reviews. 2019-01-29 13:48:47 +02:00
Gerhard 94f64f3851 PHPCS fixes 2019-01-29 13:36:16 +02:00
Gerhard e74f0acc19 Add a screen reader label to the star rating div to avoid screen readers trying to read the text of the star font. 2019-01-29 13:34:04 +02:00
Gerhard 25e562400e Put reload checkout in variable before unsetting it and then calling it again after it was unset. 2019-01-29 13:05:02 +02:00
Ron Rennick a663f56306 two more sniffs in wc-template-functions.php 2019-01-28 14:36:39 -04:00
Ron Rennick 8e18d05634 phpcs sniff fixes for class-wc-breadcrumb.php 2019-01-28 11:30:11 -04:00
Ron Rennick 475c35ed7a phpcs sniff fixes for wc-template-functions.php 2019-01-28 11:25:45 -04:00
Ron Rennick db2bc48849 don't force shop loop display mode to products when query page >1 2019-01-28 11:23:25 -04:00
Mike Jolley 7c0273fa12 Prime caches when reading variations 2019-01-28 15:00:48 +00:00
Peter Fabian dda4cab70c Updated todo to use the common format. 2019-01-28 13:13:12 +01:00
Job 2174937f4f
Translatable 2019-01-28 12:28:48 +01:00
Job b0aa198d4c
Updated system status report
Two changes:

* Followed the WP core order of mentioning wordpress URL and site URL
* Followed the WP core naming of these two URLs - confusingly the home URL in core is described be "Site Address ()"

![http://cld.wthms.co/xo5xtL](http://cld.wthms.co/xo5xtL+)
Link to image here: http://cld.wthms.co/xo5xtL.
2019-01-28 12:24:57 +01:00
Ron Rennick a93418b826 phpcs sniff fixes for class-wc-report-sales-by-product.php 2019-01-27 19:27:30 -04:00
Ron Rennick f42c42066b include refunded orders in top sellers, earners in sales by product report 2019-01-27 19:24:08 -04:00
Ron Rennick 3f24ad8d4c phpcs sniff fixes for abstract-wc-order.php 2019-01-27 11:38:08 -04:00
Ron Rennick d32f189f27 recalculate coupons after adding to order 2019-01-26 23:57:32 -04:00
Galen Wright-Watson 65bb805cbb Fix: #22572-can't access settings ("The link you followed has expired"). Cause: if anything adds to `$_POST`, this triggers WooCommerce to try to save settings; if there's no nonce, authorization fails, resulting in the message. Soln: check for specific element ('save') in `$_POST` to determine whether to save elements, rather than testing that `$_POST` is non-empty. 2019-01-25 18:08:00 -08:00
Ian Jenkins d7e32e1c77 Remove possibe superfluous wp_attachment_is_image() filter.
The reason to remove this is that this function uses get_post() under
the hood which always assumes the attachment is on the same site, where
as if you're using a plugin such as
https://github.com/humanmade/network-media-library it might not be.

I'm not sure if there's any adverse affects of not doing this filtering,
from my testing, it still seems to work in the same way.
2019-01-25 15:11:58 +00:00
Ron Rennick 60a6895eee php sniff fixes for class-wc-rest-product-categories-controller.php 2019-01-25 09:53:37 -04:00
Peter Fabian 33584e767f Renamed function
As legacy REST API will be removed soon anyway.
2019-01-25 10:07:32 +01:00
claudiulodro 78e5189334 Better @id generation for product structured data 2019-01-24 11:49:44 -08:00
Ron Rennick e73eabf679 use `name` for POST/PUT category image name for consistency in api V3 2019-01-24 15:38:45 -04:00
claudiulodro 8078e6bfc2 Simplified title check that works on all wc widgets 2019-01-24 10:47:05 -08:00
Prince Ahmed 78e4ef5f38
Fix test get request
During test Remote GET Request,
in the error checking area used $post_response instead of using $get_response.
2019-01-24 21:59:09 +06:00
Peter Fabian d390528d79 Updated check to only cover non-legacy REST API requests.
Updated filter name.
2019-01-24 12:06:47 +01:00
Peter Fabian 2d5fc8ef7d Merge branch 'master' into fix/20937-v0.1 2019-01-24 11:19:46 +01:00
Mike Jolley 00a93ae8f0
Merge pull request #22112 from Prospress/fix/22101
Introduce wc_attribute_taxonomy_slug()
2019-01-23 21:57:07 +00:00
Mike Jolley 5b40f24adc
Merge pull request #22526 from woocommerce/fix/21299
Sort terms by parent and work back from bottommost term
2019-01-23 21:36:55 +00:00
Mike Jolley e171718534
Merge pull request #22529 from james-allan/custom_coupon_usage_limit
Keep count of the number of times custom coupons apply
2019-01-23 21:36:19 +00:00
Mike Jolley 9b655c0ba7 Use hasSelectiveRefresh 2019-01-23 21:29:55 +00:00
Mike Jolley 624700267b Merge branch 'master' into pr/20830 2019-01-23 20:56:35 +00:00
Mike Jolley 20330b01bd
Merge pull request #22531 from rellect/fix_ssl_check
Fix ssl check in case shop page no longer exists
2019-01-23 20:18:43 +00:00
Mike Jolley 467681c788
Merge pull request #22537 from woocommerce/fix/22450
round variation percentage price adjustments to decimal setting
2019-01-23 20:15:12 +00:00
Mike Jolley 407a5954dc
Merge pull request #22464 from woocommerce/fix/22245
include tax in subtotals when validating coupon minimum and maximum
2019-01-23 19:54:12 +00:00
Ron Rennick 6709049cbc round variation percentage price adjustments to decimal setting 2019-01-23 14:04:04 -04:00
Mike Jolley e9f0490829
Merge pull request #21719 from vyskoczilova/master
Custom settings on shipping section (#13463, #13461)
2019-01-23 17:07:13 +00:00
Mike Jolley 6a89a76c11 Merge 17796 2019-01-23 16:39:21 +00:00
Mike Jolley 59c97539b3 Trigger loaded hook once plugins are loaded. 2019-01-23 16:20:26 +00:00
Mike Jolley 613a095362 Exclude paged from price slider 2019-01-23 15:31:26 +00:00
Mike Jolley 9cdcc3f1e5
Merge pull request #21817 from woocommerce/feature/pages-gutenberg-support
Use shortcode block for WooCommerce default pages
2019-01-23 15:25:28 +00:00
Mike Jolley f96d59ac2b Merge branch 'pr/21043' 2019-01-23 15:16:50 +00:00
Mike Jolley 987a24afdc Timeout param 2019-01-23 15:16:40 +00:00
Ron Rennick a6b1c45740 phpcs sniff fixes for class-wc-rest-products-v2-controller.php 2019-01-23 11:13:25 -04:00
Gerhard Potgieter f77e2d7316 Handle full refunds in the taxes by code report (#21843)
* Add full refund support to the taxes by code report.

* Some PHPCS fixes

* Do not include refund in initial tax lookup for report.

* Correct logic which loops orders

* match date report
2019-01-23 15:12:58 +00:00
Ron Rennick 8709351994 update function name to `wc_attribute_taxonomy_slug` 2019-01-23 11:11:27 -04:00
Ron Rennick b868b484f7 fix merge conflicts 2019-01-23 10:53:42 -04:00
Refael Iliaguyev 8f0f22c11b Fix ssl check in case shop page does not exists. 2019-01-23 16:08:13 +02:00
Luigi 548b00c660 Improve the way we do queries (#22043)
* Improve the way we do queries

* PHP legacy compatible

* Update aproach to filter queries with empty values

* Fixing Unit Tests

* Moving Unit Test to its the correct test function

* Filter missing the new param, allow_empty, also simplifiying unit test.

* Helper function to create counpon does not support empty coupon codes

* Helper function does not need to allot empty search

* Wrong code standard

* Fixing Code Standard Unit Test
2019-01-23 13:46:32 +00:00
Mike Jolley e8710e4ad6
Merge pull request #22530 from treibalen/master
Change footer wording for WooCommerce emails
2019-01-23 13:28:31 +00:00
Mike Jolley 99f663ad5c
Merge pull request #22131 from willgorham/improve-shipping-zone-continents
Improve shipping zone continents [Fixes #22130]
2019-01-23 13:27:16 +00:00
Mike Jolley 57ae0bec9d
Merge pull request #22073 from bekarice/fix/partial-refund-webhooks
Send webhooks for partial refund creation
2019-01-23 13:02:44 +00:00
treibalen 178c7a7a9c Change wording for WooCommerce emails
Change emails footer from "Powered by WooCommerce" to "Built with WooCommerce"
2019-01-23 13:50:08 +05:30
James Allan 767abb3a8a Keep count of the number of times custom coupons apply 2019-01-23 16:47:52 +10:00
Ron Rennick 8e12f9607d use WP standard datetime format for installs where timezone_string setting is not set 2019-01-22 15:47:56 -04:00
Mike Jolley 7cd20021e0 Sort terms by parent and work back from bottommost term
Fixes the issue described in #21299 by sorting terms by parent ID.

Remove the extra get_term call because we already have a term object.

Since we support 4.7+, also removed function exists for wp_list_sort function.
2019-01-22 19:06:58 +00:00
Will Gorham 45e7f344b1 Use shipping countries instead of selling countries 2019-01-22 13:51:35 -05:00
Mike Jolley 2a2863c5ba
Merge pull request #21648 from EmranAhmed/master
Add 3rd param on `woocommerce_product_option_terms` action to use custom attribute types on product attribute create
2019-01-22 18:28:24 +00:00
Mike Jolley 9b2866a310 Merge branch 'pr/21722' 2019-01-22 18:20:45 +00:00
Ron Rennick 343a217939 move add order tax to get_object_subtotal() 2019-01-22 13:42:37 -04:00
Mike Jolley 43ba62dc86
Merge pull request #22067 from Prospress/fix/22046
populate default variation attributes when it is the first variation
2019-01-22 17:29:54 +00:00
Mike Jolley ed95fe2cd3
Merge pull request #22066 from Prospress/fix/22065
add is_array check to catalog ordering orderby
2019-01-22 16:25:20 +00:00
Mike Jolley c99495488b
Merge pull request #22458 from woocommerce/fix/22456
Set order vat exempt status to that of customer on checkout.
2019-01-22 16:13:36 +00:00
Mike Jolley 581d3c3195 Merge branch 'pr/22290' 2019-01-22 16:05:56 +00:00
Mike Jolley 11b172d583 phpcs 2019-01-22 16:04:16 +00:00
Mike Jolley 9b6694341f Fix code and improve indenting 2019-01-22 16:01:17 +00:00
Mike Jolley e3a1c1c3c0
Merge pull request #22475 from woocommerce/add/22474
Add stock qty increase/decrease option to bulk edit
2019-01-22 15:20:44 +00:00
Mike Jolley 380201be33
Merge pull request #22417 from woocommerce/fix/21175
Sort countries using new ascii comparison function
2019-01-22 14:47:41 +00:00
Mike Jolley 34a3d77080
Merge pull request #22303 from Prospress/fix/22063
only hide price filter widget when archive has no products
2019-01-22 14:44:48 +00:00
Mike Jolley 10518228aa
Merge pull request #22318 from Prospress/fix/21202
Only include the network orders widget on the main site dashboard
2019-01-22 14:38:46 +00:00
Mike Jolley d7f768f779
Merge pull request #21069 from tomaskavalek/patch-1
Added missing HTML filter for quantity
2019-01-22 14:36:20 +00:00
Mike Jolley 1a18297aa2
Merge pull request #22398 from Prospress/fix/22382
update default attribute slug when attribute term slug is changed
2019-01-22 14:32:56 +00:00
Gerhard 4fa2856d86 Renamed vars so need to used the new vars. 2019-01-22 15:39:17 +02:00
Mike Jolley 084dab4553
Merge pull request #22476 from woocommerce/fix/22470
Hide ratings when reviews are disabled
2019-01-22 13:32:22 +00:00
Mike Jolley 7ac26ce893
Merge pull request #22518 from Prospress/fix/21779_redux
Fix/21779 redux
2019-01-22 13:29:40 +00:00
Gerhard 1664181a63 Wrap iconv usage in function_exists for compatibility. 2019-01-22 15:26:40 +02:00
Gerhard 0beadb3bab Upate function @since to 3.6.0 2019-01-22 15:22:14 +02:00
Gerhard bfda9c0ac8 Use wc_update_product_stock instead of manually adding and subtracting. 2019-01-22 15:14:41 +02:00
Mike Jolley afbdd06e83 Merge branch 'pr/22409' 2019-01-22 13:12:34 +00:00
Mike Jolley 892ec24fed correct version 2019-01-22 13:12:26 +00:00
Mike Jolley ebac35e2c5
Merge pull request #22324 from Prospress/fix/21380
update variation guid with the id after creation
2019-01-22 13:07:42 +00:00
Mike Jolley ee158ae044
Merge pull request #22411 from Gator92/order_item_meta_filter
pass all arguments to woocommerce_order_item_display_meta_value filter
2019-01-22 13:04:02 +00:00
Mike Jolley 83aa070654
Merge pull request #22412 from woocommerce/fix-minor-issues-in-webhook-class
Fix minor issues in WC_Webhook_Data_Store class
2019-01-22 12:51:42 +00:00
Mike Jolley 4d4d34a2d1
Merge pull request #22514 from woocommerce/update/mailchimp-branding-setup-wizard
Updates Mailchimp branding in setup wizard
2019-01-22 12:39:24 +00:00
Mike Jolley 5cb60b840c
Merge pull request #21859 from ChromeOrange/master
Add filter to save_payment_method_checkbox
2019-01-22 12:05:42 +00:00
Mike Jolley 4c28ba612c
Merge pull request #21884 from woocommerce/add/wc-admin-taxonomy-instance/21883
Add WC_Admin_Taxonomies instance method
2019-01-22 12:01:33 +00:00
Ron Rennick c3879f0d63 only deduct refunded shipping, taxes once from gross to get net sales by date CSV 2019-01-21 15:44:53 -04:00
Ron Rennick aa9961695f phpcs sniff fixes for class-wc-report-orders-by-date.php 2019-01-21 15:36:29 -04:00
Mike Jolley e5af25e994
Merge pull request #21341 from kinging123/patch-2
Added action 'woocommerce_variation_header' after actions in variations list
2019-01-21 16:59:48 +00:00
Mike Jolley 6367d19615 phpcs 2019-01-21 08:11:40 -08:00
Mike Jolley 759424a5fb
Merge pull request #22394 from fitimvata/master
Add filters for mail callback in WC_Email::send method.
2019-01-21 16:00:10 +00:00
Alessandro Morelli be0f4b45e3 Fix coding standard violations 2019-01-21 16:54:49 +01:00
Mike Jolley d096d17d25 Merge branch 'pr/22488' 2019-01-21 15:39:00 +00:00
Mike Jolley 2d14315f3d woocommerce_cart_totals_get_item_tax_rates 2019-01-21 15:38:48 +00:00
Mike Jolley 0c9de00b74
Merge pull request #22425 from helgatheviking/issue-21845-b
switch woocommerce_ordered_again hook to ref_array
2019-01-21 15:15:54 +00:00
Mike Jolley c830d429ef
Merge pull request #22435 from zJesusJavier/patch-2
Updating Venezuelan Currency
2019-01-21 15:01:18 +00:00
Mike Jolley 944ece0fad
Merge pull request #22414 from woocommerce/update/22406
Add a fallback to cURL version check in system status
2019-01-21 15:00:35 +00:00
Mike Jolley 7433dfe6f3
Merge pull request #22424 from Prospress/fix/22422
return coupon error messages as text message for alert()
2019-01-21 14:57:34 +00:00
Mike Jolley 120add0bff
Merge pull request #22487 from woocommerce/fix/22485
Made municipality address field optional for Latvia.
2019-01-21 14:54:05 +00:00
Gareth Allison 2dcc823e46 Updates mentions of "MailChimp"
Updates mentions of "MailChimp" to "Mailchimp" as per their branding guidelines: https://mailchimp.com/about/brand-assets/
2019-01-21 16:34:31 +02:00
Mike Jolley e91f3b88f5
Merge pull request #22448 from woocommerce/fix/21580
Multisite - Load customer data for logged in users regardless of being member of sub-site
2019-01-21 14:21:21 +00:00
Mike Jolley 0c70945bcb Merge branch 'fix/21580' of https://github.com/woocommerce/woocommerce into fix/21580 2019-01-21 14:05:50 +00:00
Mike Jolley 7db783d7a1 revert admin bar change 2019-01-21 14:05:48 +00:00
Mike Jolley dc01d1de76 Deprecate delete_version_transients 2019-01-21 13:08:01 +00:00
Mike Jolley d3ac50d47f Remove heavy queries from transient cleanup function
Remove heavy queries from transient cleanup function

Removes unneccessary loops and heavy queries.

There is a parent update and cache clear which was added in #17141. This cleanup is handled in `update_attributes` so doing it again here should be unneccessary.

Finally, the layered nav cleanup here can be moved. #22029 notes that this was needed in case of a stock change affecting product visibility. If we move to the data store, we can avoid getting the product here which is slower.
2019-01-21 13:02:31 +00:00
Mike Jolley 7744879326 wc_delete_product_transients for parent 2019-01-21 13:01:18 +00:00
Mike Jolley 8ede6bcb74 Added helpers to clean transients during shutdown and clean layered nav counts 2019-01-21 13:00:21 +00:00
Mike Jolley c5da2dbcde Remove unrelated transient
wc_count_comments is completely unrelated to products. This can be moved to the transient cleanup tool, because code already exists to clear this cache when needed in WC_Comments.
2019-01-21 12:59:39 +00:00
Rodrigo Primo eea4810c49 Revert change to defer transient cleanup
This commit reverts commits 2f8a3eae49 and 17e97c2580 that were created to defer transient cleanup (see #20537) and avoid deadlocks on the wp_options table (see #20528 and #17632). The problem is that deferring transient cleanup to a cron job created an issue when creating or importing multiple products at once (see #21100 and https://github.com/woocommerce/wc-smooth-generator/issues/14#issuecomment-413342136) and has the potential to impact the checkout as well if we start using more versioned transients for orders.

This problem is happening because when importing or creating multiple products at once, for each product that is created or imported, WooCommerce core enqueues a few 'delete_version_transients' cron events. Events are enqueued faster than they are executed and after a few hundred products are generated, the size of the cron queue, which is stored in a single wp_options entry, starts to impact WordPress performance in general.

To reduce the chance of deadlocks happening again after this change, I already created another PR to optimize the query used to delete transients (#21274) by avoiding an unnecessary filesort, and I'm planning, on a subsequent commit, to improve it further by prefixing the transient name with its version instead of suffixing it as it is currently done. But the ultimate solution for high traffic stores is to use a persistent cache plugin.
2019-01-21 12:58:19 +00:00
Mike Jolley 08d7e319b6 Version handling for var prices 2019-01-21 12:56:55 +00:00
Mike Jolley eabc30be5e wc_customer_bought_product - move version within transient 2019-01-21 12:38:40 +00:00
Mike Jolley 452bb5b5e7 Include version within transient 2019-01-21 12:31:48 +00:00
Mike Jolley 0cf82b8937 Use fixed transient naming in wc_get_shipping_method_count 2019-01-21 12:05:58 +00:00
Mike Jolley 5280ceb8d9 Improve inline docs in calculate_shipping_for_package 2019-01-21 11:49:44 +00:00
Ron Rennick b774968c81 set refund prices_include_tax meta to be the same as the order receiving the refund 2019-01-18 23:38:36 -04:00
Ron Rennick d826aba858 phpcs sniff fixes for wc-order-functions.php 2019-01-18 23:36:46 -04:00
Claudiu Lodromanean 7f78cc3acc
Merge pull request #22334 from Prospress/fix/22326
add gutenberg block preprocessor filter to shop page content
2019-01-18 09:29:28 -08:00
Brent Shepherd 2ed2572afe Clear webhook transients when status changes
Background discussion: https://github.com/woocommerce/woocommerce/pull/21427#discussion_r246881785
2019-01-18 14:30:35 +10:00
Brent Shepherd 28ca9f1ec4 Remove unused $wpdb 2019-01-18 14:30:35 +10:00
Brent Shepherd 21d724c65d PHPCS fixes
Add fixes required for Travis to pass the PR, but which aren't
related to the PR diff.
2019-01-18 14:30:35 +10:00
Brent Shepherd 0708c738b9 Only load 100 webhooks per request
To avoid slowing down page loads on sites with a large numbers of
webhooks.
2019-01-18 14:30:35 +10:00
Brent Shepherd 9fdbb124ae Add $limit param to wc_load_webhooks()
And the corresponding data stores. Defaults to null, meaning do not
limit, for backward compatibility.
2019-01-18 14:30:35 +10:00
Brent Shepherd e7a5a2ab2f Only load active webhooks on each request
To avoid slowing down page loads on sites with a large number of
disabled or paused webhooks, which do not need to be loaded or
enqueued.
2019-01-18 14:29:35 +10:00
Brent Shepherd f86b738db3 Use search_webhooks()
To avoid duplicate SQL
2019-01-18 14:29:34 +10:00
Brent Shepherd 67bf101aaf Add $status param to wc_load_webhooks()
And the corresponding data stores. Defaults to '', meaning do not
load only webhooks with a specific status. This maintains backward
compatibility. However, the call to wc_load_webhooks() within
WooCommerce::load_webhooks() can now only load active webhooks, as
they are the only ones that should be enqueued.
2019-01-18 14:29:34 +10:00
Ron Rennick dad1ffb4c9 use function_exists instead of version_compare 2019-01-17 16:14:53 -04:00
Claudiu Lodromanean 3bb5d2ee79
Merge pull request #22446 from woocommerce/fix/22285
Hide 0 costs for local pickup
2019-01-17 12:10:37 -08:00
Rodrigo Primo 29ff0b9b88 fix phpcs errors 2019-01-17 14:55:24 -02:00
Mike Jolley fa6e2536db Tweak cost display logic 2019-01-17 13:56:11 +00:00
RobertoDonPedro 3a2b3d10ad
Filter get_item_tax_rates in class-wc-cart-totals.php
Adds filter on the return value of function 'get_item_tax_rates' to prevent the mandatory caching of tax rates, described in https://github.com/woocommerce/woocommerce/issues/21855
2019-01-17 13:57:31 +01:00
Peter Fabian ede86d8307 Made municipality address field optional for Latvia. 2019-01-17 13:18:31 +01:00
Gerhard 98948a2faf PHPCS fixes 2019-01-17 08:32:42 +02:00
Gerhard f3d9eeeef3 Introduce wc_reviews_enabled, wc_review_ratings_enabled and wc_review_ratings_required as helper functions and update all places where options are accessed directly. 2019-01-17 08:04:57 +02:00
Gerhard 8a685c3303 is_vat_exempt check on orders expect a yes/no and not a bool, save values as string. 2019-01-17 07:46:45 +02:00
Jesús Ramirez 4c8662c7f1
Update wc-core-functions.php 2019-01-16 16:51:07 -04:00
Claudiu Lodromanean 3dee72eddc
Merge pull request #22452 from woocommerce/fix/21700
[REST API] Variations endpoint - Removed extra inherited filters from product endpoint
2019-01-16 09:41:40 -08:00
Claudiu Lodromanean 6540e89425
Merge pull request #22445 from woocommerce/fix/21996
Change priority of notices on the account page
2019-01-16 09:40:51 -08:00
Claudiu Lodromanean c2c7cbeccb
Merge pull request #22444 from woocommerce/fix/22119
Fix checkout field locales on first load
2019-01-16 09:39:42 -08:00
Claudiu Lodromanean df2cd4b232
Merge pull request #22439 from woocommerce/fix/22430
Make sure WC active before running queries for MS widget
2019-01-16 09:38:24 -08:00
Claudiu Lodromanean f4d1587652
Merge pull request #22419 from woocommerce/fix/22010
Remove on-hold orders from tax reports
2019-01-16 09:37:09 -08:00
Claudiu Lodromanean 989865469e
Merge pull request #22416 from woocommerce/fix/21871
Incorrect rounding of multiple tax rates per location
2019-01-16 09:32:51 -08:00
Claudiu Lodromanean 86f05bbd7a
Merge pull request #22320 from Prospress/fix/22197
use slug sanitization on product export category slugs
2019-01-16 09:31:43 -08:00
Ron Rennick 9337ca51e4 add WP version check for short description block filter 2019-01-16 12:49:25 -04:00
Mike Jolley ca3623fa41
Merge pull request #22461 from woocommerce/fix/21761
Bail if getimagesize fails in filter_image_sizes_to_only_missing_thumbnails
2019-01-16 16:37:09 +00:00
Mike Jolley 78ca5c0290
Merge pull request #22277 from johnrom/fix/22276
Add a filter, woocommerce_current_user_can_edit_customer_meta_fields
2019-01-16 16:31:18 +00:00
John Rom 741435d816 Switch user meta permissions filter from user data to user id 2019-01-16 11:20:42 -05:00
John Rom 130a36107c Added filter to the save method so it is not bypassable 2019-01-16 11:00:46 -05:00
John Rom 186a1d5b7e Combine permission conditions into a single filter provided the default value 2019-01-16 10:56:26 -05:00
plexus admin 9acc7ced5d Add function wc_get_is_pending_statuses 2019-01-16 09:54:02 -06:00
Mike Jolley 4fc197c67d
Merge pull request #21003 from Chunkford/patch-2
Giving the ability to add custom pricing data - read_price_data()
2019-01-16 15:22:40 +00:00
Mike Jolley 1125a5d76d
Merge pull request #22380 from Prospress/fix/22261
register order auto drafts post status
2019-01-16 15:11:48 +00:00
Mike Jolley c70bef3e9c Merge branch 'pr/22350' 2019-01-16 14:48:14 +00:00
Mike Jolley 2d44e90542 CS 2019-01-16 14:47:59 +00:00
Ron Rennick bc33f19630 add order draft status filter to allow resuming editing 2019-01-16 09:52:18 -04:00
Mike Jolley 213ba99664
Merge pull request #21961 from sebastianpisula/patch-1
New params for woocommerce_shipping_zone_*_methods_table actions
2019-01-16 13:01:45 +00:00
Jesús Ramirez 7e1ef44b02
Update wc-core-functions.php 2019-01-16 08:49:17 -04:00
Mike Jolley 2ea7e4fb6a woocommerce_display_product_attributes filter 2019-01-16 12:25:19 +00:00
Mike Jolley 766dea1125
Merge pull request #22316 from ictbeheer/master
Support for Dutch postcodes
2019-01-16 11:38:21 +00:00
Mike Jolley 50a86a1a33
Merge pull request #21562 from terence1990/feature/rest-api-crud-params-filter
Add a filter to WC_REST_CRUD_Controller::get_collection_params method to allow developers to change params
2019-01-16 11:32:03 +00:00
Gerhard 683111b4a5 PHPCS fixes 2019-01-16 11:32:00 +02:00
Gerhard 6b211ab25b Add increase and decrease stock qty option to bulk product edit. 2019-01-16 11:22:11 +02:00
Gerhard 26f9aad65c add_meta_data not add_meta 2019-01-16 09:18:54 +02:00
Mike Jolley f68a547f53 Don't mix session and customer data 2019-01-15 16:49:01 +00:00
Ron Rennick 0f94bed1ec only add tax when comparing coupon against order 2019-01-15 11:33:44 -04:00
Mike Jolley d3d1864b4e Select an option vs state 2019-01-15 15:24:17 +00:00
Ron Rennick d654107cb0 include taxes in subtotal when validating tax inclusive coupon maximum as well 2019-01-15 10:33:57 -04:00
Ron Rennick acf46fa28d phpcs sniff fixes for class-wc-discounts.php 2019-01-15 10:21:21 -04:00
Ron Rennick 5f2bc29e3d include taxes in subtotal when coupon price includes taxes 2019-01-15 10:17:31 -04:00
Gerhard 6e428e6c58 PHPCS fixes 2019-01-15 15:24:53 +02:00
Gerhard 3e06d94115 If getimagesize fails for some reason, ie plugin using offsite images, just return the original image sizes. 2019-01-15 15:22:12 +02:00
Gerhard f11613c5e9 Set order vat exempt status to that of customer on checkout. 2019-01-15 13:20:07 +02:00
Claudio Sanches fbcbd55bf7 [REST API] Removed extra inherited filters from product endpoint
Closes #21700
2019-01-14 17:15:23 -02:00
Rodrigo Primo 507f67cb38
Merge pull request #22029 from woocommerce/fix/21429
FIx:  Delete wc_layered_nav_counts_* transients whenever a product is updated
2019-01-14 15:26:15 -02:00
Mike Jolley 696d042c0e
Merge pull request #22255 from aelia-co/Tweak-wc_get_min_max_price_meta_query-filter
Added new filter "woocommerce_get_min_max_price_meta_query"
2019-01-14 17:04:59 +00:00
Mike Jolley 4dbee72c65
Merge pull request #22165 from woocommerce/fix/22089
Add new pre query filter to WC_Product_Data_Store_CPT::search_products()
2019-01-14 17:02:51 +00:00
Mike Jolley 1f63d59244
Merge pull request #22257 from manchumahara/patch-1
Add $orderby and $order params to filter woocommerce_get_catalog_ordering_args
2019-01-14 17:00:37 +00:00
Mike Jolley 4f4d7e6c9c API - Rather than error, add users to blog like the checkout does 2019-01-14 16:31:52 +00:00
Mike Jolley 668c078bcf This check is not needed - super admin should see it only 2019-01-14 16:31:05 +00:00
Mike Jolley 1b337dea64 Load customer data regardless of current blog 2019-01-14 16:30:47 +00:00
Mike Jolley bd611172c2 Hide 0 costs for local pickup 2019-01-14 15:14:44 +00:00
Mike Jolley 47bd97862a Change priority of notices on the account page so they appear above forms/content 2019-01-14 15:09:07 +00:00
Mike Jolley 9799301b0a Add script dep 2019-01-14 14:43:53 +00:00
Mike Jolley 1e563aea29 Use wp_get_attachment_image if we have an attachment based placeholder 2019-01-14 13:55:12 +00:00
Mike Jolley 198fdce1bf Larger placeholder to allow more resizing 2019-01-14 13:54:01 +00:00
Mike Jolley 549a0f01c0 Placeholders need srcset and sizes 2019-01-14 12:54:54 +00:00
Mike Jolley 510ed70d1e Fix check during install to create placeholder image. 2019-01-14 11:32:57 +00:00
Gerhard dc0f8fb696 PHPCS fixes 2019-01-14 09:41:24 +02:00
Gerhard 9d3053ce9a Check if WooCommerce is active on blog before running WooCommerce queries for the MS widget. 2019-01-14 09:40:04 +02:00
Gerhard 6220399163 Switch to use v3 of the API for network orders. 2019-01-14 09:15:20 +02:00
Jesús Ramirez 88335691cd
Updating Venezuelan Currency
The new Venezuelan currency is Bs S
2019-01-13 10:01:37 -04:00
Kathy Daring 1e51bf3e69 switch ordered_again hook to ref_array 2019-01-11 12:14:29 -05:00
Ron Rennick 6b1341138f phpcs sniff fixes for class-wc-ajax.php 2019-01-11 12:57:33 -04:00
Mike Jolley 5016e4c858 Removed unused query 2019-01-11 16:56:51 +00:00
Mike Jolley 938992cbae Exit early, add back fallback code 2019-01-11 16:52:57 +00:00
Ron Rennick 641884b71b return coupon error messages as text message for alert() 2019-01-11 12:50:44 -04:00