Commit Graph

60 Commits

Author SHA1 Message Date
Nestor Soriano 5a11d9e064
Refactor the settings pages, and add unit tests for them.
This commit fixes some inconsistencies in the settings pages, and
makes all the existing pages extensible by adding new sections
(that was possible in some pages, but not in others). Main changes:

1. Modify the 'get_sections' method so that it invokes a new protected
   'get_own_sections' method and then triggers the
   'woocommerce_get_sections_' . id filter.

This way the filter is triggered only in the base class
and not in each of the derived classes too.

2. Change the get_settings() method so that it has its signature
   changed to get_settings( $current_section = '' )
   in the base class and in all the derived class.

Some derived classes were already using this signature, but others
(those not having multiple sections natively) weren't, making then
effectively impossible to define multiple sections for these pages
via filters.

With this change all the section pages act consistently and allow
both adding new settings to the default "General" section
and creating new sections via filters.

3. Change the implementation of 'get_settings' in the base class
   so that it searches for a 'get_settings_for_{section_id}_section'
   method in the class and executes it, otherwise it executes the new
   protected method get_settings_for_section( $current_section ); then
   it triggers the 'woocommerce_get_settings_' . id filter.

This makes it easier to separate the code that returns the list
of filters in multiple methods, one per section, instead of using
one big if-else-else... block.

So now instead of overriding get_settings($current_section='') derived
classes need to implement get_settings_for_{$current_section}_section
for each section, or override get_settings_for_section($current_section)
or both. 'get_settings_for_section' returns an empty array by default.

Also, 'woocommerce_get_settings_' . id is triggered in one single
place too.

Other improvements:

* Remove duplicated code from 'output' in 'WC_Settings_Page' children.

Some classes inherited from 'WC_Settings_Page' override the 'output'
method with custom code, which in all cases ended up repeating the code
of the original method as a fallback. These repetitions have been
replaced with 'parent::output()'.

* Fix inconsistencies for 'save' and 'output' in WC_Settings_Tax/Emails

The 'WC_Settings_Tax' and 'WC_Settings_Emails' classes had some
inconsistencies in their 'save' and 'output' methods that prevented the
proper creation new sections and the addition of new settings via the
'woocommerce_get_sections_' and 'woocommerce_get_settings_' filters.
Now they work as expected.

* Deduplicate parts of 'save' in 'WC_Settings_Page' and children.

Two methods have been added to 'WC_Settings_Page' class:
'save_settings_for_current_section' and 'do_update_options_action'.
These are intended to be invoked by derived classes in their 'save'
methods, in order to remove code repetition.

* Add some helper methods to WC_Unit_Test_Case.

Methods added:
- assertOutputsHTML
- assertEqualsHTML
- normalize_html
- capture_output_from
2021-04-12 12:42:26 +02:00
Claudio Sanches d48f1d4e2e Fixed package tag usage 2020-08-05 13:36:24 -03:00
Claudio Sanches 10cdbf88be Use shop base address as default customer location 2020-01-14 16:29:48 -03:00
Claudio Sanches cfeb07eaf7 Removed legacy code 2020-01-10 13:18:25 -03:00
Gerhard 8716c7451c PHPCS fixes 2019-04-10 14:29:40 +02:00
Mike Jolley deaaa5d1d8 Remove two old moved-feature notices 2019-04-10 11:23:35 +01:00
Mike Jolley 1b34cd4745 Moved settings tabs around to allow for privacy page. 2018-04-12 16:59:42 +01:00
Mike Jolley 7080989081 Move coupon settings to general settings 2018-04-12 11:13:15 +01:00
Mike Jolley 01be034279 Disable geolocation if using legacy php #19548 2018-03-29 17:04:31 +01:00
Rodrigo Primo 23b69eba53 Use phpcbf to fix coding standard violations in includes/admin
After using phpcbf to fix the coding standard violations, I did some manual adjustments to the changes, especially in poorly indented files.
2018-03-05 16:21:35 -03:00
Mike Jolley 9ff0a9717f Adjust query arg 2018-02-06 11:10:28 +00:00
Mike Jolley 0ad37a6426 Use add query arg in customizer links 2018-02-05 17:10:39 +00:00
Caleb Burks 9d062f8d82 Add notice for moved store notice setting 2018-02-02 14:32:37 -05:00
Mike Jolley 7a7995f697 Revert price formatting changes which break in RTL 2018-01-12 14:16:18 +00:00
Mike Jolley bc16a85d22 Cropping settings 2017-11-14 16:01:36 +00:00
Mike Jolley 43ba326ed9 Fix currency position with rtl symbols 2017-10-31 12:22:18 +00:00
Jeroen Sormani 607cd878e0 Settings parent construct (#16412)
* Miscellaneous cleanup of typos + change some return types for IDE helpers

* Call/use parent::__construct() to add filters for settings output, saving
2017-08-11 21:36:35 -03:00
Mike Jolley d6131f3a74 Field styling 2017-06-30 14:59:45 +01:00
Allen Snook 61a8d858b5 Update address labels in settings to better match customer address labelling 2017-06-19 11:28:42 -07:00
Allen Snook 21d2bee658 Add store street, city and postcode fields to settings > general 2017-06-15 09:56:52 -07:00
Mike Jolley bbf8e750ce Tidy up includes 2017-02-16 11:46:01 +00:00
Mike Jolley 2e77e38d33 colour -> color
#12627
2016-12-19 11:41:48 +00:00
Claudio Sanches 657c312cae Fix strings case (#12069)
* Fixed case for all _e, esc_attr_e and esc_html_e strings

* Fixed case for all _n_noop strings

* Fixed case for all _x strings

* Fixed case for all __, esc_html__ and esc_attr__ strings

* Fixed a few more strings

* Fixed strings in unit tests

* Fix PayPal Standard case.

* Save Order text
2016-10-12 11:16:30 +01:00
Aristeides Stathopoulos fde1037757 fix failing tests. 2016-09-01 23:50:14 +03:00
Aristeides Stathopoulos 72696901f3 WordPress.WhiteSpace.OperatorSpacing.SpacingAfter 2016-08-27 09:14:06 +03:00
Aristeides Stathopoulos f2730eea02 WordPress.WhiteSpace.ControlStructureSpacing.BlankLineAfterEnd 2016-08-27 08:57:05 +03:00
Aristeides Stathopoulos 58b9df6564 WordPress.Arrays.ArrayDeclaration.NoSpaceAfterOpenParenthesis 2016-08-27 05:23:54 +03:00
Aristeides Stathopoulos ec8a0b288b PHPCS: WordPress.Arrays.ArrayDeclaration.NoCommaAfterLast 2016-08-27 05:08:49 +03:00
Aristeides Stathopoulos b063bcfe4c last item in a multiline-array should end in a comma 2016-08-27 04:46:45 +03:00
Mike Jolley a0faffec85 Lang tweak 2016-05-03 12:01:03 +01:00
Matheus Lopes f0c26b7439 Refatoring main code 2016-04-28 13:37:30 -03:00
Matheus Lopes 71a46df6b0 Editing titles 2016-04-25 13:51:40 -03:00
Matheus Lopes 2c191f5bb7 Enable countries exceptions to Billing and Shipping 2016-04-20 14:55:05 -03:00
Mike Jolley 97d47fb576 Move zones to main settings 2016-01-05 11:23:15 +00:00
Claudio Sanches 5893875b0c Removed period for file headers 2015-11-03 11:53:50 -02:00
Claudio Sanches ee30b5b308 Fixed php docs standards 2015-11-03 11:31:20 -02:00
Claudio Sanches b85ae9056c Rename wc_add_help_tip() function to wc_help_tip() 2015-10-23 13:09:08 -02:00
Claudio Sanches 2e95a68357 Use new "question" mark icon font
Created wc_add_help_tip() function to generate the icons
Replaced all .help_tip elements and [?]

We'll keep the old image and styles in order to maintain backwards
compatibility

Closes #9381
2015-10-23 01:40:52 -02:00
Mike Jolley 5e984faebc Allow HTML in store notice. 2015-08-24 16:15:16 +01:00
Mike Jolley 14c88b49bc Tweak option labelling 2015-06-23 12:20:13 +01:00
Mike Jolley 4a9c2aece9 Update option wording 2015-06-17 14:27:42 +01:00
Mike Jolley 33c298fea7 Experiment with appending geolocation to query string to prevent caching 2015-06-17 12:12:49 +01:00
Claudio Sanches 7b8a24924a Moved api settings to API tab 2015-05-15 16:35:50 -03:00
Mike Jolley af2407a089 Move default customer location to general settings tab. 2015-03-06 14:45:04 +00:00
Mike Jolley f18b2c6c93 Added and enqueued select2 to admin 2015-01-09 16:39:10 +00:00
Mike Jolley 83fb26e30d Dump chosen select option. Closes #6593 2014-11-11 12:12:28 +00:00
claudiosmweb 861a34c348 Removed the frontend styles setting #6589 2014-10-21 20:12:39 -02:00
claudiosmweb 2a255de172 changed the LESS compiler to SCSS compiler #5606 2014-09-22 15:30:07 -03:00
Mike Jolley aee2b62c85 Added woocommerce_get_settings_ID filters.
Closes #6231
2014-09-12 12:20:06 +01:00
Mike Jolley c4ef86d44e scrutinizer patches 2014-09-08 00:37:55 +01:00