Gan Eng Chin
6246cf6ff2
Marketing: Add "Sales" column in Campaigns card ( #43284 )
...
* Add sales property to MarketingCampaign class.
* Return campaign sales data in API.
* Display Sales in Campaigns card.
* Fix test for useCampaigns.
* Display a "-" when there are no cost or sales value in Campaigns card.
* Add changelog.
* Fix test for useCampaigns hook.
* Fix PHP lint issue.
2024-01-19 01:42:35 +08:00
Eason
d57b9e1d05
Make the `useCampaigns` hook support being used with multiple instances ( #41211 )
...
* Add tests for the `useCampaigns` hook in the woocommerce-admin marketing.
* Add `channels` to the deps of `useSelect` in the `useCampaigns` hook to avoid outdated hook states.
* Make the `useCampaigns` hook support being used with multiple instances.
- Include the `perPage` in the page key of campaigns in the multichannel's data store.
- Move the processing of querying the campaigns paging to the selector of the multichannel's data store.
- Move `total` in each campaign's paging of the multichannel's data store.
- Remove unused properties and their types: `state.campaigns.perPage` and `state.campaigns.total`
* Add changelog
* Multichannel data store - Move the `total` from `campaigns.pages[*]` to `campaigns.meta` to have only one total value.
Related to:
- https://github.com/woocommerce/woocommerce/pull/41211#discussion_r1409634640
- https://github.com/woocommerce/woocommerce/pull/41211#discussion_r1409590559
* Multichannel data store - Return the pagination meta of campaigns along with the `getCampaigns` selector.
Address: https://github.com/woocommerce/woocommerce/pull/41211#discussion_r1412266127
2023-12-05 11:20:05 +08:00
Gan Eng Chin
cb135df890
Null check on campaign.cost.
2023-11-02 22:19:03 +08:00
Bartosz Budzanowski
6e0e224196
Allow null in multichannel campaign.
2023-11-02 09:28:39 +01:00
RJ
0190f4adea
fix: applied lint autofixes ( #39942 )
...
* woocommerce-admin lint fixes
* @woocommerce/* lint fixes
* Add changefile(s) from automation for the following project(s): @woocommerce/date, @woocommerce/data, @woocommerce/components, @woocommerce/admin-layout, woocommerce
* lints
---------
Co-authored-by: github-actions <github-actions@github.com>
2023-08-30 06:40:45 +08:00
Gan Eng Chin
76379770a1
Fix hook file name with correct casing.
2023-03-22 16:51:25 +08:00
Gan Eng Chin
1f7a8120a3
Temporary rename file to fix casing issue.
2023-03-22 16:50:27 +08:00
Gan Eng Chin
3189f2b7f5
Reorganize code.
2023-03-22 16:44:44 +08:00
Gan Eng Chin
7395d6939c
Fix file name for useInstalledPluginsWithoutChannels.
2023-03-22 15:59:37 +08:00
Gan Eng Chin
e281c09bc6
Merge branch 'trunk' into feature/34907-marketing-exclude-channels
...
Conflicts:
plugins/woocommerce-admin/client/marketing/hooks/index.ts
2023-03-21 23:33:41 +08:00
Gan Eng Chin
637fca8df5
Rename file UseInstalledPlugins to UseInstalledPluginsWithoutChannels.
2023-03-21 23:23:39 +08:00
Gan Eng Chin
648eab74eb
Change namings in useInstalledExtensions to useInstalledPluginsWithoutChannels.
2023-03-21 23:22:39 +08:00
Gan Eng Chin
fe4e28d511
Rename UseInstalledPlugins to UseInstalledExtensions.
...
Also change related names from "plugin" to "extension".
2023-03-21 19:08:13 +08:00
Gan Eng Chin
50c391cee0
Use fallback value instead of default value in useInstalledPlugins.
2023-03-21 18:35:38 +08:00
Gan Eng Chin
79023a4a10
Fix incorrect data while loading in useInstalledPlugins.
2023-03-21 18:33:57 +08:00
Gan Eng Chin
11683be1a8
Set default parameter values for useCampaigns.
2023-03-19 23:17:22 +08:00
Gan Eng Chin
458c16bad9
Move useCampaigns to shared hooks directory.
2023-03-19 22:54:55 +08:00
Gan Eng Chin
1b65be0a53
Fix useSelect dependency in useIntroductionBanner.
2023-03-19 20:50:37 +08:00
Gan Eng Chin
99c6ebff15
Remove the use of isOptionsUpdating in useIntroductionBanner.
...
isOptionsUpdating will return true for any option update, not just our option here. This causes issue as shown in demo video in https://github.com/woocommerce/woocommerce/pull/37110#discussion_r1130531104 .
We can just depend on getOption. When we update an option, it will be updated immediately in wp.data store before making API request to update the option in database (see c5564a15c1/packages/js/data/src/options/actions.ts (L44)
).
2023-03-19 20:38:20 +08:00
Gan Eng Chin
162d790a7a
Update option name and value to make it more indicative.
2023-03-19 20:16:04 +08:00
Gan Eng Chin
49253425b2
Specify dependency for useSelect in useIntroductionBanner.
...
Co-authored-by: Eason <eason.su.tw@gmail.com>
2023-03-19 20:12:09 +08:00
Gan Eng Chin
8c151984ad
Filter installed plugins against marketing channels in useInstalledPlugins.
2023-03-19 18:06:34 +08:00
Gan Eng Chin
f769a8c6f5
Merge branch 'trunk' into feature/34904-marketing-introduction-banner
...
Conflicts:
plugins/woocommerce-admin/client/marketing/overview-multichannel/MarketingOverviewMultichannel.tsx
2023-03-17 01:21:13 +08:00
Gan Eng Chin
0316fbb265
Specify empty array as hasFinishedResolution args.
...
This is to make things consistent with invalidateResolution to make things work with WP 5.9.
2023-03-14 03:35:20 +08:00
Gan Eng Chin
5a58784a62
Specify empty array as invalidateResolution and hasFinishedResolution args.
...
This is to make things work with WP 5.9.
2023-03-14 03:32:54 +08:00
Gan Eng Chin
baf9408f69
Merge branch 'feature/34909-marketing-create-campaign-modal' into feature/34904-marketing-introduction-banner
...
Conflicts:
plugins/woocommerce-admin/client/marketing/overview-multichannel/Campaigns/Campaigns.test.tsx
plugins/woocommerce-admin/client/marketing/overview-multichannel/Campaigns/Campaigns.tsx
plugins/woocommerce-admin/client/marketing/overview-multichannel/MarketingOverviewMultichannel.tsx
2023-03-13 01:02:12 +08:00
Gan Eng Chin
c6e6f8774d
Specify empty array dependency in useCampaignTypes.
...
This is to make it work with WP 5.9. See https://github.com/woocommerce/woocommerce/pull/37044#discussion_r1132062493 .
2023-03-11 00:42:09 +08:00
Gan Eng Chin
8b6aad4138
Refetch campaign types after installing a channel in CreateNewCampaignModal.
2023-03-09 22:51:12 +08:00
Gan Eng Chin
f19969dacb
Change NewCampaignTypes to CampaignTypes.
2023-03-09 21:52:11 +08:00
Gan Eng Chin
39ce470fe8
Specify dependency for useSelect in useNewCampaignTypes.
2023-03-09 21:43:54 +08:00
Gan Eng Chin
3ba492f32b
Move convert function out of useSelect in useNewCampaignTypes.
...
This is so that it doesn't become dependency in useSelect.
2023-03-09 21:42:59 +08:00
Gan Eng Chin
8fe3781266
Use ref instead of location hash to scroll to add channels section.
2023-03-08 02:06:06 +08:00
Gan Eng Chin
7c9eedbbb4
Merge branch 'feature/34909-marketing-create-campaign-modal' into feature/34904-marketing-introduction-banner
...
Conflicts:
plugins/woocommerce-admin/client/marketing/hooks/index.ts
plugins/woocommerce-admin/client/marketing/overview-multichannel/Channels/RecommendedChannels.tsx
plugins/woocommerce-admin/client/marketing/overview-multichannel/MarketingOverviewMultichannel.tsx
2023-03-07 00:46:38 +08:00
Gan Eng Chin
e13112875b
Move useNewCampaignTypes to shared hooks directory.
2023-03-03 01:05:14 +08:00
Gan Eng Chin
46adb0dc25
Rename Channels to RegisteredChannels.
2023-02-01 02:58:49 +08:00
Gan Eng Chin
f050bb79b5
Rename Channel to RegisteredChannel.
...
This is for better clarity and consistency.
2023-02-01 00:52:35 +08:00
Gan Eng Chin
49032b98db
Make data undefined on first load in useRecommendedChannels.
2023-01-27 21:38:38 +08:00
Gan Eng Chin
ef669d8ca2
Rename InstalledChannel to RegisteredChannel.
2023-01-21 02:36:39 +08:00
Gan Eng Chin
8754003fb0
Add mapping for sync-failed product listings status.
2023-01-21 02:26:19 +08:00
Gan Eng Chin
2a15f09514
Remove TODO comments.
2023-01-21 02:22:30 +08:00
Gan Eng Chin
3cc568b4ed
Remove duplicated RecommendedChannel type.
2023-01-21 02:20:06 +08:00
Gan Eng Chin
0b1ab21836
Rename types.
2023-01-21 02:14:36 +08:00
Gan Eng Chin
cd0402a10c
Refetch registered channels after install and activate recommended channels.
2023-01-20 01:02:41 +08:00
Gan Eng Chin
223ea4d712
Filter recommended channels to get "not installed" or "not activated" channels.
2023-01-19 22:23:00 +08:00
Gan Eng Chin
cf4c62e707
Fix loading bug in useRecommendedChannels.
2023-01-19 19:50:56 +08:00
Gan Eng Chin
b708cc18ff
Get recommended channels from API.
2023-01-19 19:33:51 +08:00
Gan Eng Chin
2d7c8db2e5
Map product_listings_status to syncStatus.
2023-01-19 01:32:38 +08:00
Gan Eng Chin
0a36d7a4fe
Map errors_count to issueType and issueText.
2023-01-19 01:12:50 +08:00
Gan Eng Chin
f616d688d8
Call marketing channels API with wp.data.
2023-01-18 02:04:42 +08:00
Gan Eng Chin
f92f4d3dee
Code refactor with useIsLocationHashAddChannels.
2022-12-28 01:09:37 +08:00