3c8f4861e4
[wccom-17942] Only showing feedback snackbar when content of in-app marketplace has finished loading. Making sure snackbar is fixed position, so it's visible wherever you are on the page.
...
- `ProductListContextProvider` provides `setIsLoading` function as well as `isLoading`.
- `Discover` uses these values from context, instead of keeping a loading state in itself.
- `FeedbackModal` calls `maybSetTimeout` when `isLoading` changes. If `isLoading` isn't truthy, and snackbar hasn't already rendered, it sets a timeout of 5 seconds to show it.
- Removed wrapping <WooFooterItem> from around Footer component, so it's no longer a child of the WooCommerce Admin `.woocommerce-layout__footer` footer.
- Removed the `position: relative` from `.woocommerce-layout__footer`. It needs to be `position: fixed`.
- Added FooterContent component to Footer, to allow the layout we want.
- Changed use of context. This now only has states for the selected tab and loading state.
- We use this context in `Tabs` and `Content` to keep track of which tab is selected, and set the selected tab.
- We also use it in `Discover` and `Extensions`, which both report loading state to the context. This allows us to use it to only render the snackbar when loading is complete.
- Extensions: moved `productList` and `setProductList` and logic for getting product list from the context provider to a state in this component. We don't need to share the list of products in the context.
- Renamed `ProductListContext`, `ProductListContextProvider` and `productListContextValue` to more generic `MarketplaceContext`, `MarketplaceContextProvider` and `marketplaceContextValue`.
- Renamed a constant and created constants for API paths.
- Only shows snackbar after content has loaded, and after a timeout. We set a date `marketplace_redesign_2023_last_shown_date` in local storage to ensure we only show one snackbar.
2023-08-26 12:47:23 +01:00
0d2e2b6c06
Squashed commit of the following:
...
commit d7c6924301976338100aad564e4f9d2b8ef40bb3
Author: And Finally <andfinally@users.noreply.github.com>
Date: Thu Aug 10 11:52:46 2023 +0100
Addressing feedback.
Removed unneeded internal dependencies comment.
commit 216e3061787923e070878c1491098fb984f53f47
Author: And Finally <andfinally@users.noreply.github.com>
Date: Thu Aug 10 11:51:45 2023 +0100
Addressing feedback.
Sanitizing `comments` input before we send it to Tracks.
Whitespace.
commit 817bcb78a47e9cb5c60167d979dca404d581cc9c
Author: Dan Q <danq@automattic.com>
Date: Wed Aug 9 16:37:04 2023 +0100
Made selected-item style more like existing ones (background color)
commit 57af273b02dfd3039f3db48b620c5842cf7eab3c
Author: Dan Q <danq@automattic.com>
Date: Wed Aug 9 16:25:14 2023 +0100
Namespaced more translatable strings
commit ef293ad45db9511199a61bda9cf1f94709558dd1
Author: Dan Q <danq@automattic.com>
Date: Wed Aug 9 16:21:35 2023 +0100
Moved <TextareaControl> out of <p> (prevents DOM "<div> in <p>" warning)
commit efc4a5993358726e89e1728b29245340b62dab9c
Author: Dan Q <danq@automattic.com>
Date: Wed Aug 9 16:18:57 2023 +0100
Linter appeasement
commit c7efaf798e49ddfe3fd3deab8f07da083c4c236f
Merge: 8b3ff1c86b 2a8d47cd6ahttps://github.com/woocommerce/woocommerce into add/wccom-17602-marketplace-feedback-component
commit 19e3aa13249a885f563ee3265fe6b4f224201f4e
Author: Dan Q <danq@automattic.com>
Date: Wed Aug 9 15:18:58 2023 +0100
Remove unused TextControl
commit 789fdf36a06f8244cc293bbbb4fbd5cb0d6c7eb4
Author: Dan Q <dan@danq.me>
Date: Wed Aug 9 15:16:09 2023 +0100
Update plugins/woocommerce-admin/client/marketplace/components/likert-scale/likert-scale.tsx
Co-authored-by: And Finally <andfinally@users.noreply.github.com>
commit d8db9a460f4626b316fad2a60dc947d3c232205d
Author: Dan Q <dan@danq.me>
Date: Wed Aug 9 15:15:25 2023 +0100
Update plugins/woocommerce-admin/client/marketplace/components/feedback-modal/feedback-modal.tsx
Co-authored-by: And Finally <andfinally@users.noreply.github.com>
commit 6f0ab9a65c6ec4c13b2af3530393f793952fa93e
Author: Dan Q <danq@automattic.com>
Date: Wed Aug 9 15:08:10 2023 +0100
Switched pencil icon
commit 5bea666730f1bb5cd9479affad5701b68007ea9f
Author: Dan Q <danq@automattic.com>
Date: Wed Aug 9 14:36:32 2023 +0100
Ensured snackbar appears at bottom (thanks @andfinally for the analysis!)
commit b49a19f08d9db4eed592c54ddf79fcf9b9e35d13
Merge: 0076c28677 172234b5a9a80704020862a4bfa0ec👌 Use admin theme color for select2
commit 26811772c9#39256 )
* Add support for variable products
* Add 'hello world' block to variations tab
* Add product-section block to template
* Add AttributeControl component to screen
* Add changelog
* Change labels
* Make a copy of AttributeControl to VariationOptionsControl to allow the fields to evolve separately in future
* Fix tests
* Add changelog to woocommerce
* Fix alert error
* Remove copied control and start adapting attribute control to handle both scenarios
* Add -field to block name
* Revert "Add -field to block name"
This reverts commit 50e1ee66e27ffb2df22ea7f6a4f78d1577a273f5.
* Revert "Revert "Add -field to block name""
This reverts commit eee0441c6532f9fa8cf8383d9699fd503dd054ae.
* Extract more labels
* Hide drag handle in variation options
commit 575bbae7b9#39464 )
* Add post password to API
* Add changelog
* Fix phpcs issue
* Remove post_password from tests
* Add additional property to test
* Increment number of properties in product schema
* Update the post when post_password changes
* Start adding password block
* Add css and import it
* Refactor attributes and erase password when checkbox is unchecked
* Add changelogs
* Remove unused imports
* Rename 'fields' to 'field'
* Refactor CSS
* Remove example object
commit bb390b12d087ae3d1d7d9c7c58cb0bd4893c4706#39467 )
* when checking out remote branch, ensure git history is there to find common ancestor for git diff
* remove unshallow
commit 144e873393#39363 )
commit fccc62d91a#39438 )
* Add post password to API
* Add changelog
* Fix phpcs issue
* Remove post_password from tests
* Add additional property to test
* Increment number of properties in product schema
* Update the post when post_password changes
commit cb787aba19#39362 )
commit d7e5703b078cf45dc8c1527701f53d35c1592d8bbf95490adeeb7b83b496378d005230603cbd3f5d3c9e4606cd8f4003806a016ae26651df07d17e2b30f43803d25497cefced57d4f685fdea19b23e54dbffd6b5c968a83a0d46366ee82397f62221c0da4bd8f6b874e6370355746a76fd79541b67a7fe7c3b69ad144db9cd91c20c5c1dfade0520d9981b7116d295d3035c0d161d8728e4ce95ef#38849 a change was made that allowed the class mocking necessary
for this test to happen in a way that wouldn't interfere with other
unit tests.
Fixes #38720
commit f479625708#39357 )
Fix a bug where passing full file urls made ids unstable.
commit ce79211c93#39396 )
* Support inserting NULL values for strict DB mode
* Set default date for placeholder order to support strict MySQL.
* Add unit test to verify strict mode also works.
* Make HPOS behavior of modified date consistent with WP_Post.
In HPOS we were leaving modified date to be empty, while WP_Post set it to the created date if modified date is null.
commit b1cb905464#39352 )
commit ddf9a7741a#39243 )
commit 91a0fbafa9#39388 )
Delete changelog files for 39327
Co-authored-by: WooCommerce Bot <no-reply@woocommerce.com>
commit 8ae03a55de#39327 )
* Fix grammar in data-sharing agreement copy
* Add changelog
* Put ,
* Add brackets
* Move learn more link inside the bracket
* Update test snapshot
* Fix grammar
* Update test snapshot
commit 41d052b9e5#39046 )
* dev: core profiler pages storybook
* changed css path to pre-build zip path
commit c119d8f7e3598adeb93e8f14d89310b7913a71654c3ef8e623c3e76523ec149c969ba8be992dca0200f55c3a13b128f07af2#39244 )
* WIP extend support for frontmatter in manifests.
* Change some of the prop names in the frontmatter support, add tests.
* WIP support new frontmatter in plugin.
* Improve category processing.
* restructure the docs to have a nested category with no index.
* Add WP test stubs to dev.
* Add tests for the ManifestProcessor.
* Add param docs to function
* Store post meta on posts when they are updated or created. Add supporting tests.
* WIP supporting more core block types.
* Fix bugs in conversion.
* Adjust conversion for issues with tables, blockquotes, code.
* Resolve pnpm lock conflicts
* Return manifest to state in trunk.
* Return pnpm lock to trunk state.
* Update fixture for new md content.
commit 0243bfdc4219ba93ca5234e490f267#39145 )
commit 34e490f267https://github.com/woocommerce/woocommerce/pull/39145 . Copied changes from `add/wccom-17419-marketplace-top-admin-bar`.
Deleting unused import.
Addressing CSS linter errors.
commit 19ba93ca5230e23d22d528cb1008eb#39382 )
commit 28cb1008eb30e23d22d5a2b878e8e7https://github.com/woocommerce/woocommerce/pull/38885 .
Addressing linter errors.
2023-08-10 14:53:46 +01:00
rjchow
And Finally