WordPress Coding Standard 2.0 removed the sniff
WordPress.Security.NonceVerification.NoNonceVerification:
```
The WordPress.Security.NonceVerification sniff used the same error code for both an error as well as a warning.
The old error code NoNonceVerification is no longer used.
The error now uses the Missing error code, while the warning now uses the Recommended error code.
```
(from
d45f5e5cf3/CHANGELOG.md (200-rc1---2018-12-31))
This commit updates WooCommerce code and replaces all instances where WordPress.Security.NonceVerification.NoNonceVerification verification was used with either WordPress.Security.NonceVerification.Missing or
WordPress.Security.NonceVerification.Recommended. In a few cases WordPress.Security.NonceVerification.NoNonceVerification was used but was not needed, so instead of replacing the sniff, the line was removed. In two other cases, I removed other unrelated sniffs that were not needed.
While debugging the admin dashboard I found out that some transients where updated up to 5 times during the page load, reading is fast but writting is costy, so the query where adding a total of 200ms to the page load (because they are also huge transients)
I've rewritten the transient storage procedure so that per class a transient is only written once at the end of the request
I also found that a continue was changed for a break line 139 for php7.3 and the new warning it incurs, the problem is it was changed the wrong way, it should have been a "continue 2" to continue the foreach and not a break.
That makes me wonder if some others like this may have slipped in the code.
This commit replaces all the instances where the WPCS rule `WordPress.VIP.SlowDBQuery` was used with `WordPress.DB.SlowDBQuery`. `WordPress.VIP.SlowDBQuery` was deprecated in WPCS 2.0 and `WordPress.DB.SlowDBQuery` was added as a replacement (see 5f27d8e3a4/CHANGELOG.md (L130)).
* Add full refund support to the taxes by code report.
* Some PHPCS fixes
* Do not include refund in initial tax lookup for report.
* Correct logic which loops orders
* match date report
Rodrigo Primo
aslamshekh
Mike Jolley
Adrien Foulon
Ron Rennick
Gerhard
Claudio Sanches