Commit Graph

499 Commits

Author SHA1 Message Date
Mike Jolley a17945d9a8
Merge pull request #20574 from woocommerce/fix/20551
Fix: set order status to refunded when a PayPal transaction is refunded
2018-06-20 14:56:25 +01:00
Rodrigo Primo 5b5256370a Ignore a single PHPCS rule instead of ignoring all rules
Replace the usage of `// @codingStandardsIgnoreStart` and `// @codingStandardsIgnoreEnd` with `// phpcs:ignore WordPress.NamingConventions.ValidHookName.UseUnderscores` on WC_Gateway_Paypal_IPN_Handler::check_response(). Ignoring a single PHPCS rule is better than ignoring everything to protect the line against potential violations of the other rules.
2018-06-19 10:44:45 -03:00
Rodrigo Primo 9263a0b169 Fix: set order status to refunded when a PayPal transaction is refunded
Commit c7a3fd2 changed the logic to check if the refund is a full refund to use the strict equal operator (`===`) in the following line:

25be9fc13c/includes/gateways/paypal/includes/class-wc-gateway-paypal-ipn-handler.php (L295)

This change broke the comparison as `$order->get_total()` will return the value respecting the number of decimals after the decimal point set in the option `woocommerce_price_num_decimals` and `wc_format_decimal()`, when called without a second parameter, will not format the received value to use the same number of decimals set in `woocommerce_price_num_decimals`. To fix this issue, this commit passes `wc_get_price_decimals()` as the second parameter to `wc_format_decimal()`. This way both values will always have the same number of decimals and the comparison should work when handling a full refund.

Fixes #20551
2018-06-19 10:42:27 -03:00
Mike Jolley 5e6405b650 Merge branch 'master' into update/13359 2018-06-15 15:12:12 +01:00
Khan M Rashedun-Naby 8d7ae8b413 Remove unused variable and unnecesary else if 2018-06-09 23:24:08 +06:00
Mike Jolley 2cad2414b3 Remove manual wc_reduce_stock_levels calls 2018-06-07 18:01:38 +01:00
Mike Jolley ad10e846ea get_canonical_package_rate_ids should check it has an array 2018-05-25 12:54:58 +01:00
Mike Jolley cf9fa5b3ff Updates table styling and columns 2018-05-04 18:48:41 +01:00
Mike Jolley 57ae8285b6 Mask logged PayPal data. 2018-04-30 18:17:12 +01:00
Mike Jolley aef46ce8d3 Clear paypal logs when debug mode is turned off. 2018-04-30 18:04:52 +01:00
Mike Jolley 610e9b0989 Add disclaimer to debug logging setting 2018-04-30 17:30:55 +01:00
Mike Jolley d14e59cdb0 Remove some PII from paypal logs and avoid storing custom meta from responses 2018-04-30 17:30:39 +01:00
Claudio Sanches 781d38dc51 Removed undefined wp_json_decode() function from PayPal response
Closes #19807
2018-04-20 13:26:05 -03:00
Mike Jolley 1b34cd4745 Moved settings tabs around to allow for privacy page. 2018-04-12 16:59:42 +01:00
Claudio Sanches 900c8fc33f
Merge pull request #19380 from woocommerce/update/19302
Override supports for PayPal to see if credentials exist
2018-04-06 15:44:42 -03:00
Peter Fabian 80dc183880 Use nbsp to separate * denoting required fields. 2018-04-04 16:45:40 +02:00
Mike Jolley 5ac7aac369 Improve can_refund_order and add unit tests 2018-04-03 17:09:09 +01:00
Mike Jolley d02106f697 Merge branch 'master' into pr/18596 2018-04-03 16:24:19 +01:00
Mike Jolley 7b45e90357 Merge branch 'master' into update/19302 2018-04-03 14:57:24 +01:00
Mike Jolley 51252915e1
Merge pull request #19493 from woocommerce/fix/19404
Removed line item limit and made sure the URL is shorter than 2083 ch…
2018-03-28 13:56:57 +01:00
Peter Fabian 3809ab3f4c Fixed shipping tax logic to behave the same as originally 2018-03-28 13:08:05 +02:00
Peter Fabian 59c47c4407 Refactored line item logic
- prepare_line_items is not used as a test anymore, it only updates line items
- add_line_item is not used as a test anymore, only adds line items
- added method line_items_valid to test for valid line items
- shipping tax inclusion test moved to get_shipping_cost_line_item to encapsulate shipping tax-related logic
2018-03-28 11:04:34 +02:00
Peter Fabian f39e8e3900 Removed incorrect comment 2018-03-27 16:28:25 +02:00
Peter Fabian 5eda49f98a Line item logic refactored
Renamed function get_non_line_item_args
Documentation updates
...all part of code review fixes
2018-03-27 15:55:03 +02:00
Peter Fabian 88588eccbc Code duplication removed
Added test for non line item agrument presence
Fixed incorrect comment
2018-03-26 13:05:55 +02:00
Peter Fabian e19d64e51e Fixed PHPCS violations 2018-03-26 11:00:28 +02:00
Peter Fabian 26144afbc6 Test request length after applying filter
- added default value to get_line_item_args to not break interface
- smaller code review updates
2018-03-23 17:22:09 +01:00
Mike Jolley 0573232c62 Call empty cart when completing payment in PayPal 2018-03-23 12:54:03 +00:00
Peter Fabian 59af63e642 Merge branch 'master' into fix/19404 2018-03-23 09:36:15 +01:00
Peter Fabian 27a309d2df Removed line item limit and make sure the URL is shorter than 2083 characters
- removed limit to 9 line items per Paypal order
- if the request URL with all line items will be longer than 2083 characters, send it as one line item
- fix the character limit function to account for URL encoding happening in http_build_query
2018-03-22 15:39:30 +01:00
Claudio Sanches 0660a50e07 Removed obvious boolean results 2018-03-21 19:57:10 -03:00
Mike Jolley 291de9c1fb Override supports for PayPal to see if credentials exist 2018-03-13 11:35:20 +00:00
Claudio Sanches 54a0e01b8a
Merge branch 'master' into patch-2 2018-03-12 16:28:00 -03:00
Rodrigo Primo 4e3ba1b73b phpcs fixes in includes/gateways/paypal/includes/class-wc-gateway-paypal-response.php 2018-03-09 15:45:47 -03:00
Rodrigo Primo cf5ce33e29 phpcs fixes in includes/gateways/paypal/includes/class-wc-gateway-paypal-request.php 2018-03-09 15:45:35 -03:00
Rodrigo Primo 128c4398a5 phpcs fixes in includes/gateways/paypal/includes/class-wc-gateway-paypal-pdt-handler.php 2018-03-09 15:45:22 -03:00
Rodrigo Primo 06af993595 phpcs fixes in includes/gateways/paypal/includes/class-wc-gateway-paypal-api-handler.php 2018-03-09 15:45:13 -03:00
Rodrigo Primo 93a50caa42 phpcs fixes in includes/gateways/paypal/class-wc-gateway-paypal.php 2018-03-09 15:45:00 -03:00
Rodrigo Primo cdf8b483a1 phpcs fixes in includes/gateways/cod/class-wc-gateway-cod.php 2018-03-09 15:44:48 -03:00
Rodrigo Primo 4989e0ff2b phpcs fixes in includes/gateways/class-wc-payment-gateway-echeck.php 2018-03-09 15:44:37 -03:00
Rodrigo Primo 609bc3bf71 phpcs fixes in includes/gateways/class-wc-payment-gateway-cc.php 2018-03-09 15:44:24 -03:00
Rodrigo Primo 3451dae895 phpcs fixes in includes/gateways/cheque/class-wc-gateway-cheque.php 2018-03-09 15:44:14 -03:00
Rodrigo Primo 701320ad32 phpcs fixes in includes/gateways/bacs/class-wc-gateway-bacs.php 2018-03-09 15:43:56 -03:00
Rodrigo Primo df249d3b76 Rename class WC_Payment_Gateway_eCheck to WC_Payment_Gateway_ECheck
To match WP coding standards.
2018-03-09 09:57:59 -03:00
Rodrigo Primo 8678ed8685 Fix phpcs violations using phpcbf 2018-03-09 09:53:10 -03:00
mweimerskirch 28df2ce3e0
Added a filter allowing to change the order status to the BACS gateway
The structure is the same as for the COD gateway (there, the filter is called "woocommerce_cod_process_payment_order_status").
2018-03-08 16:11:54 +01:00
Mike Jolley 85450f60ec Merge branch 'master' into pr/18596 2018-03-02 19:31:37 +00:00
danielshields e2da7fd277
Fix the PayPal API URL
Assuming they changed the section title, as the permalink is now "create" vs "creating"
2018-03-01 12:30:38 -05:00
Mike Jolley 341dfe1e7b Fix table styling in mobile 2018-01-30 13:24:59 +00:00
Mike Jolley 46f9e00497 Tweak paypal seller protection text
Closes #18632
2018-01-29 14:43:25 +00:00