Commit Graph

14460 Commits

Author SHA1 Message Date
Mike Jolley f56e40363b If using get_catalog_ordering_args. remove the args when finsihed 2018-02-08 13:59:03 +00:00
Gerhard Potgieter 2280cabb94 Change on-the-fly image regenration to use same process as backrgound resizing, ensures CDN images are updated and show. 2018-02-08 15:36:50 +02:00
Mike Jolley 7dd9c7fb0e Added ability to search for all post statuses 2018-02-08 12:53:39 +00:00
Mike Jolley b95812d563 Handle quick edit 2018-02-08 12:35:57 +00:00
Rodrigo Primo 3290094ca0 Merge branch 'master' into update/avoid-extra-unneeded-query 2018-02-08 10:00:32 -02:00
Rodrigo Primo b4f6dc45e6 Update option instead of adding it
Doing this since on commit 57ae11c4c6, we stopped deleting the option and thus adding it won't do anything as it will be already present.
2018-02-08 09:54:39 -02:00
Caleb Burks bee4a57403 Fix array to string conversion error 2018-02-07 20:30:37 -05:00
Caleb Burks 4ca94e8f21 Add tooltip for default category 2018-02-07 19:24:43 -05:00
Caleb Burks c8a888acba Add note underneath product categories in admin 2018-02-07 18:12:31 -05:00
Caleb Burks c21cc2e8fe Replace “Cheatin’ uh?” with friendlier messages 2018-02-07 17:01:12 -05:00
Claudiu Lodromanean d6262e0b0e
Merge pull request #18849 from woocommerce/fix/wp-option-updates-spike
Fix spike in update queries on the wp_options table
2018-02-07 13:09:55 -08:00
Claudio Sanches 94318762cc
Merge pull request #18855 from woocommerce/fix/at
Only do unsupported template rendering in the loop
2018-02-07 18:18:46 -02:00
Mike Jolley 35265cdf08 Prevent warning when height is empty 2018-02-07 12:14:07 -08:00
claudiulodro e67634c45f Only do unsupported template rendering in the loop 2018-02-07 11:56:41 -08:00
Rodrigo Primo 57ae11c4c6 Avoid unneeded query to wp_options on every request
This commit changes the value of the option 'woocommerce_queue_flush_rewrite_rules' to 'no' instead of deleting it when rewrite rules are flushed. This way this option is autoloaded and the `get_option()` call below doesn't trigger a select query to the database on every request.

61f037060b/includes/class-wc-post-types.php (L514)
2018-02-07 10:59:06 -02:00
Rodrigo Primo 61f037060b Use 'yes' instead of 'true' as the value of the option woocommerce_queue_flush_rewrite_rules
WC seems to use 'yes' and 'no' instead of 'true' and 'false' as the values of boolean options, so this commit changes the value of the option woocommerce_queue_flush_rewrite_rules to follow this pattern. Also, the string 'false' can induce bugs as it is truthy.
2018-02-07 10:54:01 -02:00
Gerhard Potgieter 8ae28cfe63 Add extra checks before processing on-the-fly regenration images to catch remote files. 2018-02-07 14:52:23 +02:00
Rodrigo Primo f2e7eb98df Fix spike in update queries on the wp_options table
Since WC 3.3.1, the following query is executed on every page load:

```
UPDATE `wp_options` SET `option_value` = '1' WHERE `option_name` = 'current_theme_supports_woocommerce'
```

This is happening because of the following call to `update_option()`:

```
update_option( 'current_theme_supports_woocommerce', current_theme_supports( 'woocommerce' ) ? 1 : 0 )
```

(02cac7d637/includes/class-wc-post-types.php (L268))

`update_option()` shouldn't update the option when the value hasn't changed, but in this case it is updating on every request because, when the current theme supports WC, `1` (integer) is passed to `update_option()` and this function internally compares it against the old value stored in the database which is `"1"` (string). A strict comparison (`===`) is used (f3eaddd2dc/wp-includes/option.php (L343)), so the function assumes that the value changed and proceeds with the update.

This PR fixes this problem by using the values `"yes"` and `"no"` instead of `1` and `0`.
2018-02-07 10:20:33 -02:00
Gerhard Potgieter df0970dd07 Add search label when searching via product crud helper. 2018-02-07 11:02:50 +02:00
Gerhard Potgieter f4acfc9999 Unset the s param when doing a datastore search as it will cause a double search. 2018-02-07 10:44:49 +02:00
Claudiu Lodromanean bc5faec5c0
Merge pull request #18829 from woocommerce/fix/18819
Fix partial refund handling in taxes by date report
2018-02-06 06:30:05 -08:00
Mike Jolley 8fb8039b23
Merge pull request #18818 from woocommerce/fix/prevent-unsupported-downgrade
Don't call WC_Install::install() on downgrades
2018-02-06 12:46:42 +00:00
Mike Jolley a0252af0af
Merge pull request #18511 from woocommerce/update/make-image-gallary-save-crud
Image Gallery missing CRUD calls
2018-02-06 11:38:38 +00:00
Mike Jolley bd72bf89f2 Fix partial refund handling in taxes by date report 2018-02-06 11:31:40 +00:00
Mike Jolley 815e0d14fd
Merge pull request #18816 from woocommerce/fix/18815
Use add query arg in customizer links
2018-02-06 11:10:53 +00:00
Mike Jolley 9ff0a9717f Adjust query arg 2018-02-06 11:10:28 +00:00
Mike Jolley efc698ece1
Merge pull request #18823 from nishitlangaliya/Issue-18785
rephrasing create a first product to as per suggestion ref #18785
2018-02-06 11:05:26 +00:00
Mike Jolley 0282b9a30b
Merge pull request #18825 from hoangkianh/patch-1
Catalog rows: cast min, max, and value to int
2018-02-06 11:03:00 +00:00
Anh Hoang Nguyen 0ec546427e
Catalog rows: cast min, max, and value to int 2018-02-06 14:50:23 +07:00
nishitlangaliya 70ea46d573 rephrasing create a first product to as per suggestion ref #18785 2018-02-06 06:35:15 +05:30
claudiulodro 0c98f5d874 Remove extra ?> 2018-02-05 13:10:50 -08:00
Mike Jolley 0ad37a6426 Use add query arg in customizer links 2018-02-05 17:10:39 +00:00
Rodrigo Primo 13f703fd32 Don't call WC_Install::install() on downgrades
WC doesn't support downgrades but the if condition that decides whether or not to call WC_Install::install() and apply database schema changes was checking if the WC version stored in the database is equal to the WC version in the code. This commit changes the check performed inside the if condition to verify if the WC version stored in the database is smaller than the version in the code. This way `dbDelta()` won't be called automatically by WC and revert database schema changes. This is particulary important for clustered providers where the version of the WC code running in one of the containers could be outdated and trigger a database downgrade.
2018-02-05 14:40:51 -02:00
Rodrigo Primo 13351b3d75 phpcs fixes
Removed the print_r() call as phpcs was complaining about it and there is no need to output the version values as phpunit will do that if the test fails.
2018-02-05 14:40:36 -02:00
Claudio Sanches 67e56a7243
Merge pull request #18813 from woocommerce/fix/18796-textdomains
Fix esc_attr/esc_html usage
2018-02-05 13:18:00 -02:00
Claudio Sanches f0b99b3f0d
Merge pull request #18812 from woocommerce/update/18802
Tweak customer text
2018-02-05 13:14:16 -02:00
Mike Jolley e36c05b1d5 Fix esc_attr/esc_html usage 2018-02-05 14:54:18 +00:00
Mike Jolley 00c43e76c1 Tweak customer text 2018-02-05 14:47:12 +00:00
Mike Jolley d674aa71aa Fix import placeholder lookup 2018-02-05 14:33:34 +00:00
Mike Jolley b46ce1c366
Merge pull request #18796 from woocommerce/fix/18795-coupon-editing
Allow removing coupons on editable orders only
2018-02-05 11:23:03 +00:00
Mike Jolley eb7f1f1daf
Merge pull request #18794 from woocommerce/fix/18791-store-notice-alert
Add notice for moved store notice setting
2018-02-05 11:18:02 +00:00
Caleb Burks 9c3611624c Remove extra CSS padding 2018-02-02 22:19:07 -05:00
Caleb Burks 02952bd0a3 Allow removing coupons on editable orders only 2018-02-02 21:59:09 -05:00
claudiulodro 56230e9189 Refactor to handle percents with comma separators 2018-02-02 11:45:23 -08:00
Caleb Burks 9d062f8d82 Add notice for moved store notice setting 2018-02-02 14:32:37 -05:00
claudiulodro 680b8b6b01 Fix bulk sale/regular price percentage handling 2018-02-02 10:52:24 -08:00
Claudiu Lodromanean 8579c1fecc
Merge pull request #18782 from woocommerce/update/18757
Use CRUD search helper in admin products table
2018-02-02 09:59:49 -08:00
Claudio Sanches 6fc707bacc Merge branch 'cmmarslender-feature/network-order-widget' 2018-02-02 14:47:16 -02:00
Claudio Sanches 9c39dd34cc Merge branch 'feature/network-order-widget' of https://github.com/cmmarslender/woocommerce into cmmarslender-feature/network-order-widget 2018-02-02 14:46:51 -02:00
Claudio Sanches 9c6141b6f6
Merge pull request #18066 from woocommerce/fix/legacy-api-notice
Updated API settings making clear that is from our legacy REST API
2018-02-02 14:42:32 -02:00
Claudio Sanches 2321e8bdc1 Properly deprecated WC_Admin_List_Table_Products->sku_search() 2018-02-02 14:24:18 -02:00
Claudiu Lodromanean ea11ed8b10
Merge pull request #18767 from woocommerce/fix/18738
Make "ID: " translatable
2018-02-02 08:20:10 -08:00
Claudio Sanches 0755038e8d
Merge pull request #18505 from liquidweb/feature/post-system-status-tool-hook
Add a hook after executing a REST system status tool
2018-02-02 14:19:03 -02:00
Claudio Sanches fceca66770 Fixed coding standards 2018-02-02 14:09:47 -02:00
Claudio Sanches bb8f4f0139 Fixed translators notation 2018-02-02 14:05:49 -02:00
Mike Jolley 59d38b5a85 Handle no results 2018-02-02 15:13:37 +00:00
Mike Jolley 6047322c52 Rather than query products by a SKU, use the CRUD search helper. 2018-02-02 15:11:23 +00:00
Gerhard Potgieter 94640ef5af Add back wc_get_product 2018-02-02 12:58:05 +02:00
Gerhard Potgieter fa7fd2228c Add check that product is not false before calling methods in if. 2018-02-02 12:56:24 +02:00
Claudio Sanches 36963afe99 Make "ID: " translatable
Ref #18738
2018-02-01 19:09:04 -02:00
Mike Jolley 98b24fdc31 Include parent ID when searching for SKUs 2018-02-01 17:31:40 +00:00
Mike Jolley 997e8aefde Typecast sizes to int and avoid 9999999999 2018-02-01 17:13:05 +00:00
Mike Jolley 40098feb3c Prevent regen if not cropping and height mismatches 2018-02-01 17:13:05 +00:00
Mike Jolley c9789a4743 Default should be 1:1 2018-02-01 17:13:05 +00:00
Mike Jolley db54911443
Merge pull request #18752 from woocommerce/refactor/background-processing
Introduced new WC_Background_Process abstract class
2018-02-01 16:18:56 +00:00
Claudio Sanches c4da47f8ad Fixed coding standards 2018-02-01 13:53:29 -02:00
Claudio Sanches 1dc56f5ef9 Fixed missing default value #18753 2018-02-01 13:52:05 -02:00
Claudio Sanches 9a202f93c1
Merge pull request #18756 from Drivingralle/patch-5
Pass on default single_select_page setting field value into output
2018-02-01 13:51:13 -02:00
Ralf Wiechers f098f4edb8
Pass on default single_select_page setting field value into output
Addition to #18753
2018-02-01 15:52:32 +01:00
Ralf Wiechers c6839e7962
Default value for single_select_country and multi_select_countries settings field not passed into output
Fix #18753
2018-02-01 15:45:38 +01:00
Mike Jolley 974ff71129
Merge pull request #18747 from woocommerce/fix/woocommerce_content
Was missing  wc_get_loop_prop check like the main archive
2018-02-01 14:34:25 +00:00
Mike Jolley add3ca3bea This removes pagination and products from display for themes not using wc_get_loop_prop in their product loops. 2018-02-01 14:31:00 +00:00
Mike Jolley 8bd5d908b0
Merge pull request #18744 from woocommerce/fix/18733
Show category description on supported theme archives.
2018-02-01 14:17:20 +00:00
Claudio Sanches 6ce1bb36b0 Applied new kill_process() method into WC_Regenerate_Images 2018-02-01 12:03:28 -02:00
Claudio Sanches 7615783980 Introduced new methods into WC_Background_Process to complete clean process 2018-02-01 12:02:03 -02:00
Claudio Sanches d74d664f79 Fixed includes 2018-02-01 11:52:14 -02:00
Claudio Sanches b811dbbaec Applied new WC_Background_Process class 2018-02-01 11:42:34 -02:00
Claudio Sanches 37d25dfaec Introduced new WC_Background_Process abstract class 2018-02-01 11:42:13 -02:00
Claudio Sanches e57e38508b Restored background processing library classes 2018-02-01 11:34:03 -02:00
Mike Jolley 00d16dce0e Was missing wc_get_loop_prop check like the main archive 2018-02-01 13:22:50 +00:00
Mike Jolley 5bea7de93c
Merge pull request #18743 from woocommerce/fix/unsupported-theme-homepage-pagination
Fix shop on homepage with unsupported themes
2018-02-01 12:45:17 +00:00
Mike Jolley b499148a35
Merge pull request #18729 from woocommerce/fix/customizerrows
Dont show row settings if something is managing products per page
2018-02-01 12:42:14 +00:00
Mike Jolley e787a0bf99 Show category description on supported theme archives. 2018-02-01 11:49:19 +00:00
Mike Jolley 2ed9691c14 Fix shop on homepage with unsupported themes 2018-02-01 11:15:46 +00:00
Caleb Burks 9aa4d81084 Add product ID to row actions 2018-02-01 01:01:49 -05:00
claudiulodro 14fa87ab1f Dont show row settings if something is managing the number of products per page 2018-01-31 15:50:48 -08:00
Mike Jolley 9b22357d26 Prevent regular pagination showing on archives for unsupported themes. 2018-01-31 23:42:08 +00:00
Mike Jolley 2d8d5f3fdb
Merge pull request #18726 from woocommerce/fix/theme-compat
Theme compat updates
2018-01-31 22:29:08 +00:00
Mike Jolley b9b07faa77
Merge pull request #18724 from woocommerce/fix/18722
Move filter for image resize to allow preventing regeneration better
2018-01-31 22:04:37 +00:00
Mike Jolley 5d11f660fe Fire hooks for pagination etc only when pagination is enabled 2018-01-31 21:46:52 +00:00
Mike Jolley fc3bf3edf2 Moved this below query to prevent subcategories display mode also showing products. 2018-01-31 21:24:14 +00:00
Mike Jolley 02cac7d637 If theme support changes, we may need to flush permalinks since some are changed based on this flag. 2018-01-31 21:23:32 +00:00
claudiulodro 67a8113f59 Move filter for image resize to allow preventing regeneration betterr 2018-01-31 13:10:56 -08:00
Mike Jolley ca4f0cf0c8 Merge branch 'master' into update/uncategorized-improvements 2018-01-31 20:28:37 +00:00
Mike Jolley 29fda455aa Remove exclude code - show it, now it's sortable 2018-01-31 20:27:15 +00:00
Mike Jolley 832d767a83 Full support for sorting 2018-01-31 20:17:06 +00:00
Claudiu Lodromanean fa7fb6061f
Merge pull request #18720 from woocommerce/fix/18683
Protect against theme support being defined too late
2018-01-31 11:33:33 -08:00
claudiulodro cbaa8831d5 Merge master and resolve conflicts 2018-01-31 11:24:21 -08:00
Mike Jolley 9648a72c1b Protect against theme support being defined too late 2018-01-31 19:09:26 +00:00
Claudiu Lodromanean 062bc4b1b5
Merge pull request #18701 from woocommerce/fix/18680
Revert default columns to 4
2018-01-31 11:01:22 -08:00