Commit Graph

2622 Commits

Author SHA1 Message Date
roykho beebbb8e25
Switch to general panel when virtual is enabled and on shipping tab closes #28267 2020-11-25 10:12:24 -08:00
Rodrigo Primo 1fca8bb1b1 Replaces a few more instances of jQuery.fn.click() event shorthand
This commit replaces a few more instances of jQuery.fn.click() event shorthand that were missed in the previous commit. For more information see the commit message for 8ebead165e.
2020-11-18 16:31:17 -03:00
Rodrigo Primo 8ebead165e Replace usages of depracted jQuery.fn.click() event shorthand
This commit replaces all instances in WooCommerce codebase (except included third-party libraries) where jQuery.fn.click( handler ) event shorthand was used. This shorthand was deprecated in jQuery 3.3 (see https://github.com/jquery/jquery/issues/3214). The jQuery documentation was not updated yet (see https://github.com/jquery/jquery-migrate/issues/288 and https://github.com/jquery/api.jquery.com/issues/972).

jQuery.click() was not deprecated and so it was not replaced.
2020-11-18 15:27:46 -03:00
Rodrigo Primo 5c8491c862 Remove jQuery code that does nothing
This commit replaces a block of jQuery code that I believe does nothing. I found it while starting the work to make our JS code compatible with jQuery 3 as it uses jQuery.fn.keyup() which has been deprecated.

As far as I can understand, this block of code is supposed to change the focus to the coupon description when the user hits the tab key while the focus is on the title field. It doesn't work because the keyup event is not fired for the tab key. The current behavior is that when the user hits the tab key, the focus changes to the "Generate coupon code" button, and if the tab key is pressed another time, the focus changes to the description text field. Which seems fine to me and that is why I'm suggesting we remove this code instead of fixing it.

I believe it was added in this c15b8e817c commit six years ago and unfortunatelly the commit doesn't provide much information on why it was added.
2020-11-17 14:39:55 -03:00
Christopher Allford ea888a4a21
Revert "Added support for file in checkout ajax." 2020-11-16 09:04:15 -08:00
Rodrigo Primo 7659b984dc
Merge pull request #28058 from woocommerce/fix/27937
Replaces some jQuery deprecated code
2020-11-12 14:00:39 -03:00
Dominic Vermeulen-Smith 2c17454956 Merge remote-tracking branch 'upstream/master' into add-data-to-checkout_error 2020-10-29 13:39:40 +00:00
Dominic Vermeulen-Smith d2696e395b add error messages to checkout_error event 2020-10-26 18:03:06 +00:00
Rodrigo Primo 3d965f06e0
Merge pull request #25988 from yash-webkul/patch-1
Added support for file in checkout ajax.
2020-10-24 11:11:21 -03:00
Rodrigo Primo 291884e154 Replace all occurrences of jQuery.parseJSON()
jQuery.parseJSON() is deprecated (https://api.jquery.com/jquery.parsejson/). This commit replaces all of its occurrences with JSON.parse().
2020-10-22 10:11:27 -03:00
Jory Hogeveen 34eb09dfa1
Use `on` instead of `bind`
Bind will be deprecated
2020-10-20 15:56:43 +02:00
Jory Hogeveen 269ca73aa8
Allow re-init of price slider
Use case for when the widget is reloaded using AJAX
2020-10-20 15:56:02 +02:00
Claudio Sanches ef956e64e7 Update minified jQuery TipTip file 2020-10-19 21:18:20 -03:00
Ron Rennick 43051a0950 update deprecation versions to 4.6.0 2020-09-18 13:16:46 -03:00
Ron Rennick 9915a5b142 merge master 2020-09-18 12:53:28 -03:00
John Greys cbcb07be02
Coding standards fixes
Co-authored-by: Claudio Sanches <contato@claudiosanches.com>
2020-09-05 08:26:48 +09:00
John Greys 8d63457a60
Coding standards fixes
Co-authored-by: Claudio Sanches <contato@claudiosanches.com>
2020-09-05 08:26:36 +09:00
Claudio Sanches 09630202e7
Merge pull request #27459 from jgreys/fix/27360
Fix white space character #27360
2020-08-28 17:23:12 -03:00
Ron Rennick 8fe3bcb90e rebase to current master 2020-08-28 10:59:43 -03:00
GREYS dd10ad5637 Fix white space character #27360 2020-08-24 11:40:43 +09:00
GREYS 55cf3e2508 Update checkout.js 2020-08-23 14:50:02 +09:00
GREYS 2a5bb98f0b Merge branch 'master' into fix/27021 2020-08-23 10:22:45 +09:00
Hayden Whiteman 3fca3caf1d Fix #27413 2020-08-22 19:35:13 +12:00
vedanshujain f74d2241f5 Additional protection for fieldlocale 2020-08-19 20:41:11 +05:30
Ron Rennick 72df8aecfa updated deprecated version to 4.5.0 2020-08-13 14:46:12 -03:00
Ron Rennick f0ad8a01be merge current master 2020-08-13 14:33:07 -03:00
GREYS 82d2124a74 Fix for issue #27021 2020-08-06 16:07:39 +09:00
Claudio Sanches 94f8d2d576 Fixed jQuery selector 2020-07-29 19:21:24 -03:00
Claudio Sanches 97c7937fd9 Fixed "Product type" dropdown on WP 5.5
WP 5.5 doesn't introduce a <span> tag inside metaboxes headings
2020-07-29 19:12:02 -03:00
Claudio Sanches db82c98801
Merge pull request #26945 from woocommerce/fix/25233
Photoswipe: Populate alt attribute for photoswipe galleries
2020-07-27 11:35:13 -03:00
Claudio Sanches 7bd34e3545
Merge branch 'master' into fix/25843 2020-07-24 17:04:28 -03:00
Christopher Allford b21c3fb55a Updated minified files 2020-07-16 21:44:49 -07:00
Claudio Sanches e340a20312
Merge pull request #26880 from wpdesk/bugfix/settings-changes-warning
Changed settings warning when leaving page
2020-07-14 13:40:05 -03:00
Nestor Soriano d2787818e3 Rename `quick-edit-warning` style with `wc-` prefix, and add styling. 2020-07-14 16:02:59 +02:00
Nestor Soriano a33bcaf532 Remove unnecessary phpcs disabler in quick-edit.js 2020-07-14 11:42:22 +02:00
Nestor Soriano fd34cf76b2 Fix stock status setting for variable products on bulk & quick edits.
For bulk edit: even if stock status was left as "No change", the
status of all variations was being changed to whatever the status
of the product was before it was converted to variable. Now
no change is performed when "No change" is selected, and all
variations change to whatever is selected otherwise.

For quick edit: a new "No change" option is added that will be
preselected when the product is variable. Previously, whatever
status the product had before being converted to variable was being
shown, and that's the status that would be set when saving.
Also, a "This will change the stock status of all variations"
message is displayed before the selector.
2020-07-14 11:42:21 +02:00
Nestor Soriano 39e5a1bfb1 Fix code sniffer errors on quick-edit.js 2020-07-14 11:42:21 +02:00
Jonathan Sadowski 3b9ac931b6 Include alt in the items passed to initialize photoswipe 2020-07-02 13:17:34 -05:00
Jonathan Sadowski c0fe1e25de Update jquery zoom to grab alt from source image 2020-07-02 13:17:34 -05:00
Jonathan Sadowski c9e327809a Update photoswipe to display alt attribute on preload 2020-07-02 13:17:34 -05:00
Claudio Sanches ef6b369726
Merge pull request #26536 from catchmareck/master
Trigger removed_coupon_in_checkout event after coupon removal on checkout
2020-07-01 14:13:49 -03:00
Claudio Sanches dec50429b4
Merge pull request #25240 from shamalisulakhe/issue-24266-solution
Issue 24266 solution - with rerf of
2020-07-01 13:00:58 -03:00
Claudio Sanches 61caec9a24
Fixed coding standards 2020-07-01 13:00:25 -03:00
Claudio Sanches 9ac5bcb586
Merge pull request #26697 from passatgt/master
Fixes for Hungarian address format and name order
2020-07-01 12:55:50 -03:00
Claudio Sanches d74b73f014
Merge pull request #26558 from woocommerce/fix/26555
Fix tooltip flashing
2020-07-01 12:47:14 -03:00
Claudio Sanches 4450d2239f
Merge pull request #26660 from woocommerce/add/status-tools-prompt
Adds a prompt to confirm if should run tools in the Status page.
2020-07-01 12:39:54 -03:00
Claudio Sanches 683296f2dc
Merge pull request #26805 from franticpsyx/issue-26799
Preserve qty input val when changing variations
2020-07-01 12:37:55 -03:00
Grzegorz Rola 598100eeb0 Settings lost warning should be shown always. 2020-06-26 10:52:28 +02:00
Claudio Sanches f4d11c89f3
Merge branch 'master' into issue-24266-solution 2020-06-23 16:47:30 -03:00
Claudio Sanches a008e8a9ac
Fixed coding standards 2020-06-23 16:40:53 -03:00
Ron Rennick aaae319a65 deprecate wc-setup 2020-06-23 15:29:58 -03:00
Claudio Sanches ca9a76c462
Fixed coding standards 2020-06-23 10:46:26 -03:00
Peter Fabian 56d343e26a Added minified files. 2020-06-23 13:12:10 +02:00
Peter Fabian 3b0dd45fcf Put back the remove element for multiselects. 2020-06-23 12:38:43 +02:00
Manos Psychogyiopoulos 06a7847f73 Preserve qty input val whan changing variations 2020-06-18 07:42:25 +03:00
Peter Fabian 40f7c2d474 Update min files and selectWoo, coding standards. 2020-06-16 17:22:10 +02:00
Peter Fabian 14a26aca2c Update min files and selectWoo 2020-06-16 17:15:12 +02:00
jonathansadowski 68a5d88dd8
Merge pull request #26726 from woocommerce/fix/26298
Accessibility: Add aria-disabled to update cart button
2020-06-12 10:37:46 -05:00
Ron Rennick e80e9a35a7
Merge branch 'master' into fix/26271 2020-06-12 10:48:39 -03:00
Ron Rennick 14ddcbc8eb
Merge pull request #26250 from mi5t4n/fix/26234
Hide only the tab content under the tab wrapper
2020-06-12 10:18:41 -03:00
Ron Rennick d4f2fd0044
Merge pull request #26525 from helgatheviking/feature/find-variations-with-custom-attributes
Allow onFindVariation to accept custom attributes
2020-06-10 14:04:31 -03:00
Jonathan Sadowski e13f763587 a11y: Add aria-disabled to update cart button 2020-06-08 15:05:27 -05:00
Viszt Péter 1724507a0e Fixes for Hungarian address format and name order
Missing address-field class for Japan's postcode and state field
Checkout layout fixes on country change
2020-06-04 19:21:41 +02:00
Claudio Sanches b4ab40ae34 Adds a prompt to confirm if should run tools in the Status page. 2020-06-01 18:56:38 -03:00
David Stone 4486f06cda Use keepAlive for better user experience
keepAlive lets the user hover over the tooltip without closing it.
closes # 26555
2020-05-19 14:40:56 -06:00
David Stone 030c90e069 tweak keepAlive for better user experience
keepAlive will now close when leaving target element or tooltip box
2020-05-19 14:39:44 -06:00
Pan Seba d5952d3b00 Trigger removed_coupon_in_checkout event after coupon removal on checkout 2020-05-18 13:16:30 +02:00
Kathy Daring cecfee4f57 to account for <select> fields not being present, make sure ajax doesn't fire if there are no found attributes 2020-05-14 22:28:39 -06:00
Kathy Daring d1672ff42e optionally accept a custom array of chosen attributes. This will make it easier for "Swatches" and "Radio" input plugins to interact with the variations script without replacing the entire thing. 2020-05-14 22:27:40 -06:00
Kathy Daring b93b9092ca Give plugins an entry point into the VariationForm object 2020-05-14 22:26:13 -06:00
Christopher Allford 5b427c1155
Merge pull request #25654 from miguelfspinto/patch-2
Add option to override element tag container in checkout forms
2020-05-11 20:03:22 -07:00
Christopher Allford b4f6564cdd
Merge pull request #26132 from BrandynL/show-password
bugfix for show password icon and password hint
2020-05-11 19:54:39 -07:00
Christopher Allford 7206365250
Merge pull request #25760 from helgatheviking/issues/25759-conditionally-disable-ajax-add-to-cart
Conditionally disable ajax add to cart
2020-05-11 19:46:50 -07:00
Claudio Sanches 3ce6d4f04a
Fixed coding standards 2020-05-11 20:00:23 -03:00
Christopher Allford 0d6675b490 Corrected ESLint violations in JS files 2020-05-04 20:49:29 -07:00
Sagar Tamang ab8ee194c8 Fix: Show password toggle not working in checkout page 2020-04-25 23:37:43 +05:45
Sagar Tamang fbdbecbcf6 Hide only the tab content under the tab wrapper 2020-04-23 01:20:21 +05:45
BrandynL b234964a1c changed append show-password-span to prepend to fix bug with password strength hint 2020-04-08 14:21:00 -04:00
Vedanshu Jain e9bb84e18f
Merge pull request #25627 from bartech/master
Fix password visibility toggle (#25624)
2020-04-06 18:22:07 +05:30
Vedanshu Jain 395ceb7c9d
Merge pull request #25903 from woocommerce/fix-qty-update
Trigger change and set val to qty so that it properly updates event h…
2020-04-06 18:07:05 +05:30
Yash Kapoor 872b4c135c
Added support for file in checkout ajax. 2020-03-21 12:27:37 +05:30
Christopher Allford 1358cca6d1
Revert "Improved performance when saving variations" 2020-03-17 08:55:09 -07:00
Kathy Daring 319395b0fa update the add to cart button if ajax request not sent 2020-03-13 18:27:45 -06:00
Kathy Daring 4ed91d9482 quit early if should_send_ajax_request.adding_to_cart triggerHandler is false and trigger a custom event instead 2020-03-13 18:26:37 -06:00
Kathy Daring 6937baccce Revert "Set adding_to_cart trigger to variable. If false, do not fire ajax. Closes #25759."
This reverts commit 38e081e590.
2020-03-13 18:25:25 -06:00
Boro Sitnikovski 15641bf08f Trigger change and set val to qty so that it properly updates event handlers 2020-03-12 16:01:30 +01:00
Kathy Daring 38e081e590 Set adding_to_cart trigger to variable. If false, do not fire ajax. Closes #25759. 2020-02-25 13:12:27 -07:00
vedanshujain d904786d7d Support both `.data()` and `.datasore` to have better compatibility
PR #24818 replaces data with datastore, however both of them have nothing to do with each other. `.data()` is jQuery specific memory datastore per element, whereas datastore is relatively newer way to store data associated with elements using `data-*` attributes.
There is no reason to not support both.
2020-02-21 15:47:31 +05:30
Miguel Pinto 8ff17ddbd2
Add option to override element tag container in checkout forms 2020-02-13 03:11:44 +00:00
Bartosz Drewniak 84e958dbde Fix password visibility toggle (#25624) 2020-02-10 20:30:39 +01:00
Christopher Allford 6ca7b9fa4a
Merge pull request #25382 from smachi/master
Improved performance when saving variations
2020-02-05 13:14:13 -08:00
Claudio Sanches 9e1738be70
Revert "Eliminate update order AJAX request on checkout page load" 2020-02-04 14:19:52 -03:00
Claudio Sanches 7fe05d46e4
Revert "Remove code that ignored the woocommerce_ship_to_destination option" 2020-02-04 14:18:48 -03:00
Vedanshu Jain a85dc86978
Merge pull request #25540 from woocommerce/fix/25358
Find the correct form element to update.
2020-02-04 12:38:03 +05:30
Peter Fabian b85d314d5d Find the correct form element to update.
Previously it just found the first one, which made the second checkbox buggy.
2020-01-31 12:45:08 +01:00
Salva Machí c4a7e19534 Refactory: code style 2020-01-31 09:23:28 +01:00
Claudio Sanches f4263d8c11 Remove code that ignored the woocommerce_ship_to_destination option 2020-01-29 12:18:14 -03:00
Rodrigo Primo 2e61321e2a
Merge pull request #25289 from rafdizzle86/feature/add-checkout-place-order-success-triggerhandler
Add a triggerHandler called "checkout_place_order_success" so plugin developers can hook into AJAX order success event.
2020-01-20 15:25:46 -03:00
Salva Machí d1dc5f8c20 Bypass inputs without name 2020-01-13 11:31:20 +01:00
Salva Machí 2ca6c12089 Bypass unchecked radio buttons, unchecked checkboxes and disabled inputs 2020-01-13 10:24:12 +01:00