793dba81f1
This commit fixes the unit test WC_Tests_API_Functions::test_wc_rest_upload_image_from_url_should_return_error_when_invalid_image_is_passed() which was failing due to a change in a WordPress core message with the following error: ``` 2) WC_Tests_API_Functions::test_wc_rest_upload_image_from_url_should_return_error_when_invalid_image_is_passed Failed asserting that two strings are equal. --- Expected +++ Actual @@ @@ -'Invalid image: File is empty. Please upload something more substantial. This error could also be caused by uploads being disabled in your php.ini or by post_max_size being defined as smaller than upload_max_filesize in php.ini.' +'Invalid image: File is empty. Please upload something more substantial. This error could also be caused by uploads being disabled in your php.ini file or by post_max_size being defined as smaller than upload_max_filesize in php.ini.' /home/travis/build/woocommerce/woocommerce/tests/unit-tests/util/api-functions.php:89 ``` (https://travis-ci.org/woocommerce/woocommerce/jobs/637353161#L402) This test only fails when using WordPress nightly build (the yet to be released WP 5.4). To fix this problem, this commit adds an if statement to check for different error messages depending on the WordPress version that is being used to run the tests. In the future, we might want to refactor this test to remove its dependency to a WordPress error message to make it more robust and stable. |
||
|---|---|---|
| .. | ||
| api-functions.php | ||
| class-wc-rate-limiter.php | ||
| class-wc-tests-core-functions.php | ||
| class-wc-tests-user-functions.php | ||
| class-wc-tests-wc-query.php | ||
| conditional-functions.php | ||
| deprecated-hooks.php | ||
| dummy-wc-logger.php | ||
| install.php | ||
| notice-functions.php | ||
| plugin-updates.php | ||
| validation.php | ||