woocommerce/plugins/woocommerce-blocks/assets/js/blocks/product-collection/edit
Manish Menaria 861bc091d4
Product Collection - Add Editor UI for missing product reference (#51114)
* Initial implementation of the missing product state

- Changed `getProductCollectionUIStateInEditor` to a hook `useProductCollectionUIState`.
	- As we added logic to check if selected product reference is deleted which require making an API call. Therefore, I decided to use a hook.
- While making an API call to check if product reference is deleted, I decided to show spinner in the block.
- Introduced new UI state `DELETED_PRODUCT_REFERENCE` to handle the missing product state.
- Updated existing `ProductPicker` component to handle the new UI state.
	- It's better to use existing component for the missing product state, as it already has all the required UI.

* Add changefile(s) from automation for the following project(s): woocommerce-blocks

* Use getEntityRecord to check if product exists and other improvements

* Remove console log

* Add E2E tests for deleted product reference in Product Collection block

This commit introduces new E2E tests to verify the behavior of the Product
Collection block when dealing with deleted product references. The changes
include:

1. New test suite in register-product-collection-tester.block_theme.spec.ts
2. Modification to product-collection.page.ts to support custom product selection
3. Minor update to utils.tsx to handle trashed products

These tests ensure that the Product Collection block correctly handles
scenarios where referenced products are deleted, trashed, or restored,
improving the overall reliability of the feature.

* Simplify product creation in Product Collection block test

* Refactor E2E test for delete product reference picker

1. Removing the unnecessary `test.describe` block for "Deleted product reference"
2. Eliminating the `beforeEach` hook that was creating a test product
3. Integrating the test product creation directly into the main test

This change simplifies the test structure and improves readability while
maintaining the same test coverage for the Product Collection block's
behavior when dealing with deleted or unavailable products.

* Simplify logic for product collection UI state

This commit simplifies the handling of the `usesReference` prop in the
Product Collection block:

1. In `edit/index.tsx`, directly pass `usesReference` to
   `useProductCollectionUIState` hook without conditional spreading.

2. In `utils.tsx`, update the type definition of `usesReference` in the
   `useProductCollectionUIState` hook to explicitly include `undefined`.

* Refactor Product Collection block to improve prop passing

- Introduce ProductCollectionContentProps type for better prop management
- Refactor Edit component to use a renderComponent function
- Update component prop types to use more specific props
- Remove unnecessary props from ProductCollectionEditComponentProps
- Simplify component rendering logic in Edit component
- Adjust ProductPicker to receive only required props
- Update imports and prop types in various files to use new types

This refactoring improves code organization and reduces prop drilling by
only passing necessary props to each component. It enhances maintainability
and readability of the Product Collection block and related components.

* Refactor Product Collection block editor UI state handling

This commit simplifies the rendering logic in the Product Collection block's
Edit component. It removes a redundant case for the VALID state, as both
VALID and VALID_WITH_PREVIEW states now render the same ProductCollectionContent
component. This change improves code maintainability and reduces duplication.

* Fix: isDeletedProductReference is not set correctly

* Use "page.reload" instead of "admin.page.reload"

* Separate PRODUCT_REFERENCE_PICKER and DELETED_PRODUCT_REFERENCE cases

This improves readability and maintainability of the switch statement.

---------

Co-authored-by: github-actions <github-actions@github.com>
2024-09-17 14:08:24 +05:30
..
inspector-advanced-controls Product Collection - Add Editor UI for missing product reference (#51114) 2024-09-17 14:08:24 +05:30
inspector-controls Product Collection - Add Editor UI for missing product reference (#51114) 2024-09-17 14:08:24 +05:30
toolbar-controls Product Collection - Add Editor UI for missing product reference (#51114) 2024-09-17 14:08:24 +05:30
ProductPicker.tsx Product Collection - Add Editor UI for missing product reference (#51114) 2024-09-17 14:08:24 +05:30
collection-chooser.tsx Product Collection: Redesigned Collection Insertion Selection (#48911) 2024-07-09 13:53:48 +02:00
collection-selection-modal.tsx Product Collection: Redesigned Collection Insertion Selection (#48911) 2024-07-09 13:53:48 +02:00
editor.scss Product Collection - Add Editor UI for missing product reference (#51114) 2024-09-17 14:08:24 +05:30
index.tsx Product Collection - Add Editor UI for missing product reference (#51114) 2024-09-17 14:08:24 +05:30
product-collection-content.tsx Product Collection - Add Editor UI for missing product reference (#51114) 2024-09-17 14:08:24 +05:30
product-collection-placeholder.tsx Product Collection: Redesigned Collection Insertion Selection (#48911) 2024-07-09 13:53:48 +02:00