af308da6b9
The WC_Product::set_default_attributes function uses an array_filter (using the default callback for filtration) to remove null and false values from the defaults array for a given product. The issue here is that, in the above use case, the array_filter will evaluate '0' as 0 and therefore as false. Ultimately, array_filter then prevents the value from being recorded, moving forward. I've added a new filter callback to includes/wc-attribute-functions which will disregard all FALSE PHP equivalents except for '0' (as a a string). Also, I've updated the filter_array call in WC_Product::set_default_attributes so that it uses this new callback, instead of the PHP default. Finally, I've added a phpunit test to assert that, when storing default variations / attributes on a product, the false/true PHP synonyms are evaluating and storing like one would normally expect, with the exception that (string) '0' evaluates as true in this special case. This solution could potentially be broadened to facililate similar rules elsewhere, but the need raised in the bug is specific and this is a specific solution. |
||
|---|---|---|
| .. | ||
| data-store.php | ||
| data.php | ||
| factory.php | ||
| functions.php | ||
| product-simple.php | ||
| product-variation.php | ||