steve/just-the-docs
1
0
Fork 0
mirror of https://github.com/snachodog/just-the-docs.git synced 2025-09-13 05:13:33 -06:00
Code Issues Packages Projects Releases Wiki Activity

sass: remove all uses of / as SASS division (#1074)

Browse Source 
@pdmosses noticed that we have deprecation warnings on some of our SASS code. After testing locally, all of them have to do with using `/` as division in SASS, which is [deprecated](https://sass-lang.com/documentation/breaking-changes/slash-div) (since there's some lexical ambiguity). 

SASS has a nifty [migrator tool](https://github.com/sass/migrator). I used the migrator piecewise on each deprecation warning (since the global usage fails on some liquid code). Upon manual inspection, I think there are no false positives. Running `bundle exec jekyll serve` after a fresh install and `bundle update` no longer emits any warnings.

Closes #1073; blocked by #1072 (CI failure).
This commit is contained in:
Matt Wang
2022-12-21 13:53:02 -08:00
committed by GitHub
parent e26bdd366b
commit 12ea042bf2
3 changed files with 16 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
_sass/support/_functions.scss
View File

@@ -1,5 +1,7 @@
@use "sass:math";
@function rem($size, $unit: "") {
$rem-size: $size / $root-font-size;
$rem-size: math.div($size, $root-font-size);
@if $unit == false {
@return #{$rem-size};