steve/just-the-docs
1
0
Fork 0
mirror of https://github.com/snachodog/just-the-docs.git synced 2025-04-18 17:12:23 -06:00
Code Issues Packages Projects Releases Wiki Activity

Fix JS error for pages excluded from navigation (#1332)

Browse Source 
Fix #1331

Pages excluded from the navigation do not have a second (page-specific) stylesheet in the head. When JS is enabled, an error arises when such a page is loaded, due to `initNav()` trying to disable a non-existent stylesheet.

This PR stops JS trying to disable the second stylesheet when it doesn't exist.

Note that issue #1331 was reported in connection with optimising the build of the endoflife.date site by following [my suggestion](https://github.com/just-the-docs/just-the-docs/pull/1244#issuecomment-1660246728) in #1244, but the bug also appears on the theme website at https://just-the-docs.com/404.html.
This commit is contained in:
Peter Mosses 2023-08-26 19:30:53 +02:00 committed by GitHub
parent 8d8b444b46
commit 6041c7cd8e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
assets/js/just-the-docs.js
View File

@ -76,7 +76,9 @@ function initNav() {
// The page-specific stylesheet is assumed to have index 1 in the list of stylesheets. // The page-specific stylesheet is assumed to have index 1 in the list of stylesheets.
function disableHeadStyleSheet() { function disableHeadStyleSheet() {
if (document.styleSheets[1]) {
document.styleSheets[1].disabled = true; document.styleSheets[1].disabled = true;
}
} }
{%- if site.search_enabled != false %} {%- if site.search_enabled != false %}