mirror of
https://github.com/snachodog/just-the-docs.git
synced 2025-04-18 17:12:23 -06:00
4d95f9937a
The scope of this PR has changed slightly - it now removes all styling of `::selection`, which reverts selected-element highlighting to browser defaults (typically a blue highlight with no text colour changes). It still inadvertently closes #1201. I've included the original PR body below: --- This resolves an issue on Firefox where selecting a code block produces white text on a white background, which is not legible. To test: visit https://deploy-preview-1208--just-the-docs.netlify.app/docs/index-test/, and highlight various code blocks in light/dark mode. I did a bit more digging, and realized a handful of things: - when I added the new `OneLightJekyll` theme, I inadvertently bundled in a `::selection` class; I've removed it. - I'm not really sure why this is a part of the theme in the first place! - this is technically the minimum change required to have no more issues - however, at this point, Firefox now correctly uses the global `::selection`, which is white-on-purple; this is *different* from Chrome, which somehow overrides this for `pre` or `code`; I also (subjectively) think this is harder to read. - the vast majority of websites default to the browser/user agent stylesheet for code highlighting; for example, [react.dev](https://react.dev) - so, I've elected to instead default to the browser/user agent stylesheet; this has the nice side effect of making Chrome and Firefox consistent again Questions for reviewers/community members: - does this fix the problem for you? what about other browsers? - do we like having the browser default for code selection, or should we stick to white-on-purple? Closes #1201.
110 lines
1.5 KiB
SCSS
110 lines
1.5 KiB
SCSS
// Base element style overrides
|
|
// stylelint-disable selector-no-type, selector-max-type, selector-max-specificity, selector-max-id
|
|
|
|
* {
|
|
box-sizing: border-box;
|
|
}
|
|
|
|
html {
|
|
@include fs-4;
|
|
|
|
scroll-behavior: smooth;
|
|
}
|
|
|
|
body {
|
|
font-family: $body-font-family;
|
|
font-size: inherit;
|
|
line-height: $body-line-height;
|
|
color: $body-text-color;
|
|
background-color: $body-background-color;
|
|
overflow-wrap: break-word;
|
|
}
|
|
|
|
ol,
|
|
ul,
|
|
dl,
|
|
pre,
|
|
address,
|
|
blockquote,
|
|
table,
|
|
div,
|
|
hr,
|
|
form,
|
|
fieldset,
|
|
noscript .table-wrapper {
|
|
margin-top: 0;
|
|
}
|
|
|
|
h1,
|
|
h2,
|
|
h3,
|
|
h4,
|
|
h5,
|
|
h6,
|
|
#toctitle {
|
|
margin-top: 0;
|
|
margin-bottom: 1em;
|
|
font-weight: 500;
|
|
line-height: $body-heading-line-height;
|
|
color: $body-heading-color;
|
|
}
|
|
|
|
p {
|
|
margin-top: 1em;
|
|
margin-bottom: 1em;
|
|
}
|
|
|
|
a {
|
|
color: $link-color;
|
|
text-decoration: none;
|
|
}
|
|
|
|
a:not([class]) {
|
|
text-decoration: underline;
|
|
text-decoration-color: $border-color;
|
|
text-underline-offset: 2px;
|
|
|
|
&:hover {
|
|
text-decoration-color: rgba($link-color, 0.45);
|
|
}
|
|
}
|
|
|
|
code {
|
|
font-family: $mono-font-family;
|
|
font-size: 0.75em;
|
|
line-height: $body-line-height;
|
|
}
|
|
|
|
figure,
|
|
pre {
|
|
margin: 0;
|
|
}
|
|
|
|
li {
|
|
margin: 0.25em 0;
|
|
}
|
|
|
|
img {
|
|
max-width: 100%;
|
|
height: auto;
|
|
}
|
|
|
|
hr {
|
|
height: 1px;
|
|
padding: 0;
|
|
margin: $sp-6 0;
|
|
background-color: $border-color;
|
|
border: 0;
|
|
}
|
|
|
|
// adds a GitHub-style sidebar to blockquotes
|
|
blockquote {
|
|
margin: 10px 0;
|
|
|
|
// resets user-agent stylesheets for blockquotes
|
|
margin-block-start: 0;
|
|
margin-inline-start: 0;
|
|
padding-left: 15px;
|
|
border-left: 3px solid $border-color;
|
|
}
|