From ce805f501bf1faf478747bdbb5c06760283e216e Mon Sep 17 00:00:00 2001
From: "Christopher C. Wells" <git@chris-wells.net>
Date: Fri, 27 Aug 2021 20:06:18 -0700
Subject: [PATCH] Ensure lists are initialized for sleep pattern graph days

Fixed #293
---
 reports/graphs/sleep_pattern.py | 44 ++++++++++++++++++++++++---------
 1 file changed, 32 insertions(+), 12 deletions(-)

diff --git a/reports/graphs/sleep_pattern.py b/reports/graphs/sleep_pattern.py
index 98c6671c..823f3dce 100644
--- a/reports/graphs/sleep_pattern.py
+++ b/reports/graphs/sleep_pattern.py
@@ -26,27 +26,23 @@ def sleep_pattern(instances):
         start_time = timezone.localtime(instance.start)
         end_time = timezone.localtime(instance.end)
         start_date = start_time.date().isoformat()
+        end_date = end_time.date().isoformat()
         duration = instance.duration
 
+        # Ensure that lists are initialized for the start and end date (as they
+        # may be different dates).
         if start_date not in times:
             times[start_date] = []
         if start_date not in labels:
             labels[start_date] = []
+        if end_date not in times:
+            times[end_date] = []
+        if end_date not in labels:
+            labels[end_date] = []
 
         # Check if the previous entry crossed midnight (see below).
         if adjustment:
-            # Fake (0) entry to keep the color switching logic working.
-            times[adjustment['column']].append(0)
-            labels[adjustment['column']].append(0)
-
-            # Real adjustment entry.
-            times[adjustment['column']].append(
-                adjustment['duration'].seconds/60)
-            labels[adjustment['column']].append(_format_label(
-                adjustment['duration'],
-                adjustment['start_time'],
-                adjustment['end_time']))
-
+            _add_adjustment(adjustment, times, labels)
             last_end_time = timezone.localtime(adjustment['end_time'])
             adjustment = None
 
@@ -91,6 +87,10 @@ def sleep_pattern(instances):
 
         last_end_time = end_time
 
+    # Handle any left over adjustment (if the last entry crossed midnight).
+    if adjustment:
+        _add_adjustment(adjustment, times, labels)
+
     dates = list(times.keys())
     traces = []
     color = 'rgba(255, 255, 255, 0)'
@@ -159,6 +159,26 @@ def sleep_pattern(instances):
     return utils.split_graph_output(output)
 
 
+def _add_adjustment(adjustment, times, labels):
+    """
+    Adds "adjustment" data for entries that cross midnight.
+    :param adjustment: Column, start time, end time, and duration of entry.
+    :param times: Graph times data.
+    :param labels: Graph labels data.
+    """
+    # Fake (0) entry to keep the color switching logic working.
+    times[adjustment['column']].append(0)
+    labels[adjustment['column']].append(0)
+
+    # Real adjustment entry.
+    times[adjustment['column']].append(
+        adjustment['duration'].seconds / 60)
+    labels[adjustment['column']].append(_format_label(
+        adjustment['duration'],
+        adjustment['start_time'],
+        adjustment['end_time']))
+
+
 def _format_label(duration, start_time, end_time):
     """
     Formats a time block label.